| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The earlier fix changes the behaviour of the find bar text field such that
whenever the textfield is focused, all of the text inside it is selected. This
was done to fix a regression where the text was not getting selected when
switching tabs (read description on that issue for more info). However, this
new behaviour could be undesirable as we may not need to select the whole text
everytime find bar gains focus. Hence, in this fix, we undo the changes from
the earlier fix and add the selectall behaviour at the right place (when the
tab is switched).
BUG=none
TEST=Test added in the earlier CL still passes.
Review URL: http://codereview.chromium.org/6188005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/6173008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/5986020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=yurys
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
reading of 3rd party cookies
BUG=69066
TEST=net_unittests
Review URL: http://codereview.chromium.org/6207005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
webkit rool 75540:75584.
TEST=none
BUG=69349
TBR=jschuh
Review URL: http://codereview.chromium.org/6139008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=69324
TEST=manual
Review URL: http://codereview.chromium.org/6151008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Using the debugger, I can verify that previously we were redrawing the entire list once per row (e.g. 10 times if you delete a row in a list that has 10 rows). Now it only redraws once for the delete.
BUG=69086
TEST=see above
Review URL: http://codereview.chromium.org/6099016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows for:
- adding UI that will distinguish the keyboard from the client view
- controlling focus behaviour of the keyboard: it is made unfocusable
here as well
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6020013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- webcam (as in youtube.com\my_webcam)
- gtalk
BUG=64356
TEST=see bug
Review URL: http://codereview.chromium.org/6139006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
method.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6203004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
blacklist matches.
BUG=69172
Review URL: http://codereview.chromium.org/6111005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also removed console spam while I'm here.
BUG=63842
TEST=none
Review URL: http://codereview.chromium.org/6155008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=69292
TEST=http://www.ninepointfive.org/
Review URL: http://codereview.chromium.org/6099015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Validation feedback still needs polish, but this is completely functional, so I'll leave that for a follow-up.
This introduces a new shared class for editable lists; we should migrate the existing editable lists to it, expanding as necessary, but I didn't want to make this patch too unwieldly.
BUG=63825,61742
TEST=Search engines should be editable and addable inline in DOMUI prefs.
Review URL: http://codereview.chromium.org/6151004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
crashing. I can only see this crash happening if the opener ends up
equal to contents, but that doesn't seem possible in code.
BUG=34135
TEST=none
Review URL: http://codereview.chromium.org/6124009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
If PulseAudio is running, everything should behave as before, otherwise use ALSA API for adjusting volume. The previous PulseAudioMixer was split into AudioMixerBase and audioMixerPusle, then AudioMixerAlsa was added.
BUG=chromium-os:10470
TEST=Volume keys should work even if pulseaudio disabled
Review URL: http://codereview.chromium.org/5859003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently we get memory information for about:memory using /bin/ps. Unfortuantely ps doesn't give us information about shared and private memory. Also, it's total virtual memory value doesn't match Activity Monitor's.
This change adds code to get memory information using /usr/bin/top. The new code falls back to ps if there's a parsing error.
Once about:memory displays all the information we need there are still a couple of things left to do:
- refactor ProcessInfoSnapshot to use ProcessMetrics where possible
- do a better job of detecting shared objects between our child processes and show it some how
BUG=25454
TEST=Opened about:memory and verified that the values matched those in Activity Monitor. Tested on both 10.6 and 10.5.
Review URL: http://codereview.chromium.org/6052005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24672
TEST=trybots
Review URL: http://codereview.chromium.org/6152003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6216003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Change the lead selection in DOMUI pref lists; there should be a top and bottom border.
Review URL: http://codereview.chromium.org/6198005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Change hide message from 'Hide this message' to 'No thanks, hide this'.
2. Hide promo text when a default app is launched (this was already happening on uninstall).
3. Uninstall default apps when promo expires or is purposefully hidden.
4. Collapse apps section when promo expires or is purposefully hidden.
BUG=67292,69268
TEST=none
Review URL: http://codereview.chromium.org/6162006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Another CL will remove the old MIME type (x-ppapi-nacl-srpc) after the NaCl tree has been updated, to avoid a window where NaCl is broken.
BUG=none
TESTS=manual
Review URL: http://codereview.chromium.org/6117005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It should now match the mocks modulo the adobe flash settings link (not sure why the mocks show it as a checkbox; AFAIK making it a checkbox is outside our ability to do).
also make it work (the time period select dropdown was broken).
BUG=69163,63843
TEST=manual
Review URL: http://codereview.chromium.org/6110006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change localizes the Autofill heuristics regular expressions pertaining to credit card information.
BUG=55787
TEST=FormStructureBrowserTest.HTMLFiles
Review URL: http://codereview.chromium.org/6113005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/6142012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of 32/64 bits, as they have been causing out of memory errors even on
64-bit builders.:
chrome_frame_tests
chrome_frame_perftests
chrome_dll_nacl_win64
browser_tests
nacl_ui_tests
nacl_sandbox_tests
sync_integration_tests
interactive_ui_tests
BUG=none
TEST=it builds
Review URL: http://codereview.chromium.org/6113006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6233001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=thakis
Review URL: http://codereview.chromium.org/6132008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chromium repository to break circular dependencies on Chromium's
OpenGL bindings in app/gfx/gl.
The minimal changes to the code were made in order to break
dependencies on WebCore types and to make the code fit the Google C++
style guide as closely as possible. There are many references to
undesirable types like "long" in the WebGraphicsContext3D interface,
which are the source of the majority of lint errors and which will be
fixed in follow-on work.
The upstream WebGraphicsContext3DDefaultImpl will be deleted after
this lands.
Tested:
- Various WebGL demos in Chrome
- Built and ran WebGL layout tests in DRT
BUG=none
TEST=none (see above)
Review URL: http://codereview.chromium.org/6100009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=joi@chromium.org
BUG=68516
TEST=none
Review URL: http://codereview.chromium.org/6109008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Calls ChromeURLRequest::IsExternal() inside ResourceDispatcherHost to see if the URLRequestContext was a valid ChromeURLRequestContext at the point when it was set.
BUG=68766
Review URL: http://codereview.chromium.org/6094017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
otherwise causes subtle problems with extensions and breaks the
invariant that the tab id is unique.
BUG=68508
TEST=none
Review URL: http://codereview.chromium.org/6155003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
custom directory for generated images.
BUG=59131
TEST=none
Review URL: http://codereview.chromium.org/6173007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
scrolling, adding and removing bookmarks and during drag and drop operations. Make a subfolder menu appear as much on screen as possible.
Changed to the BookmarkBarFolderWindow.xib: Added view (visibleView_) between the window's content view and the rest of the content. Added scroll-up arrow and scroll-down arrow views. Added connections to controller of all views within the window.
BUG=54701
TEST=Test submenu appearance by creating a folder menu with lots of items with the bottom-most item being a sub-folder with several bookmark items of its own. Place the browser window such that the bookmark button for the sub-folder will appear near the bottom of the screen. Pop up the folder menu then pop up the sub-menu and verify that the sub-menu is shown on screen and does not require scrolling.
In all following cases of adding or removing bookmarks, either by using the contextual menus (cut/copy/paste/delete) or by dragging and dropping, verify that the top of the folder menu and the menu items (bookmark buttons) above the location of the addition/removal remain in the same position vertically on the screen; menu items below the affected bookmark should move upward (for a removal) or downward (for an addition) and the scroll-up arrow (the one at the bottom of the menu) should hide or show as appropriate.
Verify that dragging or pasting a wide menu item into a narrow folder menu causes the menu to widen. Verify that cutting or deleting a wide menu item from a folder menu will cause the menu to narrow.
Perform the listed tests for each of the folder menu arrangements.
Folder menu arrangements
------------------------
1. Folder with no items (one showing 'empty')
2. Folder with just a few items and neither the scroll-up or scroll-down arrow showing.
3. Folder with enough items such that adding one more should cause the scroll-up arrow to show.
4. Folder with enough items and the scroll-up arrow showing such that removing one item should cause the scroll-up arrow to hide.
5. Folder with enough items that the scroll-up arrow shows but after fully scrolling the menu fits completely on screen without any scrolling arrows showing.
6. Folder with enough items that the scroll-up arrow shows and can be scrolled up such that both scroll-up and scroll-down arrows can show with plenty of extra items.
Tests
-----
1. Cut a bookmark menu item.
2. Paste an item.
3. Paste another item.
4. Drag an item to a different place within the same folder menu.
5. Drag an item to a different folder menu (one each of those listed above).
6. Cut the first item.
7. Cut the last item.
8. Paste to the last item.
For scrollable arrangements #5 and #6:
9. Scroll up only a little (such that the scroll-down arrow does not appear) and cut an item.
10. Scroll up only a little (such that the scroll-down arrow does not appear) and paste an item.
For scrollable arrangement #6:
11. Scroll up so that both the scroll-up and scroll-down arrows appear and cut an item.
12. Scroll up so that both the scroll-up and scroll-down arrows appear and paste an item.
Review URL: http://codereview.chromium.org/5694001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The sync integration tests were using a timeout of 30 seconds for live
operations. Some of the sync stress tests are timing out because it
takes longer for a full sync cycle to complete.
This patch increases the timeout to 45 seconds in
profile_sync_service_harness.cc, and is expected to eliminate the
occasional failures on the builders.
TBR=tim@chromium.org
BUG=68207
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/6125006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=joi
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TableModelArrayController is a subclass of NSArrayController that adapts a TableModel (including groups) for use with Cocoa bindings.
Original CL: http://codereview.chromium.org/3327016
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5831001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=68516
TEST=none
Review URL: http://codereview.chromium.org/6111008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6060008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix problem with uninstallation of multi-install products.
We would incorrectly uninstall both installed products when we should only uninstall one.
BUG=68876
TEST=See bug description.
Review URL: http://codereview.chromium.org/6186006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:9296
TEST=manual
Review URL: http://codereview.chromium.org/5966008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
inspector protocol."
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
RenderView load them directly, in response to the
LoadBlockedPlugins IPC message.
BUG=none
TEST=NPAPIVisiblePluginTester.ClickToPlay (pre-existing)
Review URL: http://codereview.chromium.org/6209004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
As per http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=ui_tests&tests=ViewSourceTest.ViewSourceInMenuDisabledWhileViewingSource
BUG=69249
TEST=none
Review URL: http://codereview.chromium.org/6133008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=yurys
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=68877
TEST=Installing Chrome with --multi and then Chrome Frame with --multi works.
Review URL: http://codereview.chromium.org/6109006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
inspector protocol."
TBR=yurys
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71040 0039d316-1c4b-4281-b951-d872f2087c98
|