| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Will it fix some flakiness problems? Who knows. But at least NoInfobarForDeniedOrigin
should stop failing on XP (it's calling Initialize twice).
TBR=bulach, joth
BUG=49680, 52518
Review URL: http://codereview.chromium.org/3127018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
popup before showing a new one.
This causes it to flash every time the user type a new key (as we get new suggestions for each key stroke).
It is safe to hide the autofill only when there are no suggestions.
If there are suggestions, the WebKit side takes care of resizing and potentially hiding the popup if necessary.
BUG=49980
TEST=Trigger the AutoFill/Autocomplete popup. As you type characters in the text input, the popup should not flash. Test that it does not flash either when you press backspace.
Review URL: http://codereview.chromium.org/3158017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The original bug report was that on windows, in the newly added directory.py
file (for autogenerating samples) the 'import hashlib' line was failing because
that library isn't present in python 2.4.
To fix this, I've replaced the build.bat script with build.sh, which finds the
depot_tools path and uses the python from there. This means you can just run
this from inside a cygwin bash shell instead of needing to run in a windows
cmd.exe.
Also fix an error message in build.py about missing os.EX_OK (it isn't
guaranteed to be available on non-windows platforms).
BUG=52463
TEST=Running the new build.sh script should work on windows
Review URL: http://codereview.chromium.org/3157020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebKit doesn't work correctly if it is shut down and re-initialized. browser_tests
runs each test in its own process, which avoids this problem.
TEST=passes
BUG=none
Review URL: http://codereview.chromium.org/3184002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50537
TEST=In the bug: unit test should work on any brand.
Review URL: http://codereview.chromium.org/3160022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* With the new shorter toolbar, the attached bar overlapped the omnibox drop shadow.
* The animation wasn't completely smooth and the contents would "bounce up" 1 px at the end of the "slide down" animation.
BUG=none
TEST=Attached bookmark bar doesn't overlap omnibox drop shadow
Review URL: http://codereview.chromium.org/3136015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
AdjustStringForLocaleDirection() having stupid behavior.
BUG=none
TEST=Crashing in LTR mode produces a dialog box that isn't empty
Review URL: http://codereview.chromium.org/3195002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=pinkerton, shess, mark
BUG=51643
TEST=Open Wrench menu in sticky and non-sticky mode. Hover over buttons and they highlight.
Review URL: http://codereview.chromium.org/3137013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=52518
TEST=no
Review URL: http://codereview.chromium.org/3155027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=ProfileSyncServiceSessionTest
BUG=30519
Original patch by jerrica@chromium.org
Original review: http://codereview.chromium.org/3168009
Review URL: http://codereview.chromium.org/3184004
TBR=tim@chromium.org
Review URL: http://codereview.chromium.org/3127017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=27797
TEST=none
Review URL: http://codereview.chromium.org/3140008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=ProfileSyncServiceSessionTest
BUG=30519
Original patch by jerrica@chromium.org
Original review: http://codereview.chromium.org/3168009
Review URL: http://codereview.chromium.org/3184004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds a change to serve the stable channel by default (used to be beta).
Adds a license header to the python file.
Increments the version number for a new deployment.
BUG=52070
TEST=http://code.google.com/chrome/extensions/docs.html serves stable docs.
Review URL: http://codereview.chromium.org/3179015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=brettw, eroman
BUG=49680
Review URL: http://codereview.chromium.org/3151021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TabContents is destroyed, when RenderViewIsGone and when the tab becomes responsive again. If we happen to press the button just after this happens, we'll get a crash.
BUG=http://crbug.com/52293
TEST=None
Review URL: http://codereview.chromium.org/3165022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
fetching the product name from resource bundle, which is not available for child processes that do not need it.
Review URL: http://codereview.chromium.org/3176008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes it consistent across other platforms, such that chrome::DIR_CRASH_DUMPS on Mac actually points to the right dir.
Crash dumps used to go in ~/Library/Breakpad/Chrome_Mac
They'll now go in: ~/Library/Application Support/Google/Chrome/Crash Reports
BUG=52365
TEST=Mac breakpad continues to work
Review URL: http://codereview.chromium.org/3152021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=6854
TEST=none
Review URL: http://codereview.chromium.org/3119007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=eroman
BUG=49680
Review URL: http://codereview.chromium.org/3175019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=ui_tests, chrome_frame_tests
BUG=52097
Review URL: http://codereview.chromium.org/3186004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Removing google maps urls since their ajax loads from live web and delays the
tests, and there isn't much text in there anyway.
Review URL: http://codereview.chromium.org/3194001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49094
TEST=none
Review URL: http://codereview.chromium.org/3119020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3187002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- reduce the number of different classes
- clean up the internal code
- modify the interface to expose less internal details
(this will allow more flexibility with port numbers)
TEST=many
BUG=49680
Review URL: http://codereview.chromium.org/3080029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The constructor of syncable::ScopedDirLookup takes the username of the
account being synced. There are times when the username is blank,
resulting in a DCHECK being fired for the value of good() within the method
SyncManager::SyncInternal::InitialSyncEndedForAllEnabledTypes().
This patch makes sure that a ScopedDirLookup with a blank username is
never created by adding a check in the method
SyncManager::SyncInternal::HandleDirectoryManagerEvent().
BUG=51820
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/3184009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46374
TEST=opengl demos work on Pepper2
Review URL: http://codereview.chromium.org/3020049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=manual
BUG=none
Review URL: http://codereview.chromium.org/3131018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
.cc file.
Cleanup in base. This moves the implementation (and a bunch of header file
dependencies) from the multiprocess test and the test_suite headers to .cc
files. Moves multiprocess_test to the test directory, and all of this stuff to
the existing base_test_support project. I also used the base namespace.
Previously other projects included this functionality just by #include because
it was all inline, so I had to add dependencies on base_test_support in a few
places.
Moves and renames the command line switch this was using to base_switches. Move
the base switch for process type to chrome switches.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3026055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Use ScopedTempDir, and don't CHECK in tests.
BUG=none
TEST=waterfall.
Review URL: http://codereview.chromium.org/3127007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=28294
Review URL: http://codereview.chromium.org/3145014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on failure within
Chromium. It is a network level implementation and should constitute a good
enough bottleneck to manage every outgoing http request.
Committing for malavv@google.com.
Original review: http://codereview.chromium.org/2487001/show
R=phajdan-jr
BUG=none
TEST=unit tests
Review URL: http://codereview.chromium.org/3005049
TBR=joi@chromium.org
Review URL: http://codereview.chromium.org/3165029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
That patch wasn't what caused the regression in the page cycler.
BUG=51411,52103
TEST=still compiles
Review URL: http://codereview.chromium.org/3106018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50699
TEST=First three (or two in Vietnam and Iran) search engine logos always available on import in --organic Chrome (not Chromium).
Review URL: http://codereview.chromium.org/3189004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For each resolution request this checks to see if this 'host' is a literal ip address. If so, it synthesises a struct addrinfo and returns it without adding it to the cache.
BUG=39830
TEST=unit tests, new and old
Review URL: http://codereview.chromium.org/3023048
TBR=vandebo@chromium.org
Review URL: http://codereview.chromium.org/3115014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
For each resolution request this checks to see if this 'host' is a literal ip address. If so, it synthesises a struct addrinfo and returns it without adding it to the cache.
BUG=39830
TEST=unit tests, new and old
Review URL: http://codereview.chromium.org/3023048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
not look broken.
TBR=ben
BUG=none
TEST=Run in Aero with --lang=he, hit ctrl-shift-n, Incognito image should not be broken in two
Review URL: http://codereview.chromium.org/3117016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TabStrip::SetBackgroundOffset() into a single call in a different place.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3107012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chromium. It is a network level implementation and should constitute a good
enough bottleneck to manage every outgoing http request.
Committing for malavv@google.com.
Original review: http://codereview.chromium.org/2487001/show
BUG=none
TEST=unit tests
Review URL: http://codereview.chromium.org/3005049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
a bug in tabapplescript. Added more examples.
patch from (v.a.shreyas@gmail.com)
BUG=none
TEST=run tests included in CL.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Thumbnails file is renamed to Favicons.
The new "Top Sites" DB file is added.
TEST=about:histograms
BUG=none
Review URL: http://codereview.chromium.org/3113002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(http://code.google.com/p/chromium-os/issues/detail?id=4448)
Moved PopupNonClientFrameView to its own file and moved FrameView initialization logic to BrowserFrameChromeos::Init.
TEST=See issue. Additionally, ensure that non-chromeos Chrome popup window behavior is unaffected, and that the address bar is still visible for popup windows not generated by apps (e.g popped out google chat windows), on chromeos and non-chromeos.
Review URL: http://codereview.chromium.org/3133001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Apply 10% white to selected menu button;
- Remove the menu offset so that the menu is top aligned with toolbar;
- Make all status area buttons derive from StatusAreaButton;
- Move ClockMenuButton's text size logic into StatusAreaButton to share the
logic with LanguageMenuButton;
- Strip unused space from LanguageMenuButton so that it looks good with 10%
white highlight;
- Make LanguageMenuButton and ClockMenuButton center aligned;
- Add 1-pixel padding at top when the vertical space is odd number so that text
looks properly aligned with the icons;
BUG=chromium-os:5517
TEST=Verify fix for chromium-os:5517.
Review URL: http://codereview.chromium.org/3141019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
translate" infobar when in Incognito mode.
BUG=52305
TEST=See bug.
Review URL: http://codereview.chromium.org/3164016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3109025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This happens mainly in chrome frame where password manager
or the web data service could be invalid due to failed sqllite
initialization. The failure is due to chrome.exe running in low
integrity mode while deleting browser history. This a temporary
fix to avoid crash the right fix is to run chrome.exe at medium
integrity and that involves some investigation.
Now why chrome.exe runs in the low integrity mode is a long
story. Chrome Frame implements IDeleteBrowsingHistory to
participate in history/user data deletion. IE8 tries to be
smart and invokes IDeleteBrowsingHistory methods in by
launching a separate process, rundll32.exe. However, when
npchrome_frame.dll's implementation is invoked the container
rundll32.exe is in low integrity. IE's elevation policy does
not work for us to elevate chrome_launcher.exe to medium in
this case (since this is not IE). so we end up launching
chrome.exe in low integrity.
BUG=51949
TEST=load gcf:about:version in Chrome Frame with IE8 on Win7
and delete browsing history.
Review URL: http://codereview.chromium.org/3133019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
some logics are moved into system memory path only. ( such as allocation of output buffer, and usage of FTBDoneACK messages.
Review URL: http://codereview.chromium.org/3141014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Part of http://codereview.chromium.org/3191002 missed during checkin.
BUG=49091
TEST=None
Review URL: http://codereview.chromium.org/3149018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
on NDEBUG builds too.
TBR: zelidrag
BUG=48920
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Spotted in previous review.
BUG=23581
Review URL: http://codereview.chromium.org/3152019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56352 0039d316-1c4b-4281-b951-d872f2087c98
|