summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* This is almost a complete rewrite of DidNavigate and the associated ↵brettw@google.com2008-09-1424-990/+1304
| | | | | | | | | | NavigationController logic. The approach is that the NavigationController should be responsible for the logic and memory management of navigation. Previously, half the logic and memory management lived in WebContents which made it very hard to figure out what was going on. I split out the various navigation types into separate functions, which then copy and update any existing NavigationEntry as necessary. Previously, WebContents would make a new one which would be manually populated with random fields (I think some were forgotten, too), and then the NavigationController may or may not commit it. Review URL: http://codereview.chromium.org/479 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2201 0039d316-1c4b-4281-b951-d872f2087c98
* Roll back frames now test run is complete.beng@google.com2008-09-142-3/+0
| | | | | | | B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2188 0039d316-1c4b-4281-b951-d872f2087c98
* Test new frames on buildbots again.beng@google.com2008-09-142-0/+3
| | | | | | B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2183 0039d316-1c4b-4281-b951-d872f2087c98
* Fix interactive UI tests...beng@google.com2008-09-143-8/+15
| | | | | | | | | | - in the UI tests, SimulateOSClick was taking screen coordinates and the browser automation provider was treating them as client. For a click, screen coordinates seems better and is what most users were sending. This was causing the focus tests to fail since tabs weren't getting clicked on. Not sure why this wasn't affecting non-new-frames! - a math error in BrowserView2 was leading to incorrect window sizing in constrained window tests. - new frames mean layout is slightly different, and a constant in the constrained window test needed to be adjusted. Review URL: http://codereview.chromium.org/2828 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2180 0039d316-1c4b-4281-b951-d872f2087c98
* Get the new frames to pass the accessibility UI tests.beng@google.com2008-09-144-8/+90
| | | | | | | | B=2235 Review URL: http://codereview.chromium.org/3039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2177 0039d316-1c4b-4281-b951-d872f2087c98
* Fix an include path.paulg@google.com2008-09-141-1/+1
| | | | | | Review URL: http://codereview.chromium.org/3041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2176 0039d316-1c4b-4281-b951-d872f2087c98
* Move the Save Page code to the browser/download/ directory.paulg@google.com2008-09-1422-92/+96
| | | | | | Review URL: http://codereview.chromium.org/3040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2174 0039d316-1c4b-4281-b951-d872f2087c98
* fix build bustagebeng@google.com2008-09-131-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2172 0039d316-1c4b-4281-b951-d872f2087c98
* fix build bustagebeng@google.com2008-09-131-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2171 0039d316-1c4b-4281-b951-d872f2087c98
* fix build bustagebeng@google.com2008-09-132-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2170 0039d316-1c4b-4281-b951-d872f2087c98
* Move more UI stuff into browser/viewsbeng@google.com2008-09-1353-109/+109
| | | | | | | B=2205 Review URL: http://codereview.chromium.org/2825 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2169 0039d316-1c4b-4281-b951-d872f2087c98
* turn off new frames again.beng@google.com2008-09-131-1/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2168 0039d316-1c4b-4281-b951-d872f2087c98
* testing new frames on one cycle of buildbotsbeng@google.com2008-09-131-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2167 0039d316-1c4b-4281-b951-d872f2087c98
* Move the download code to new directories:paulg@google.com2008-09-1335-94/+96
| | | | | | | | | browser/download/ browser/views/ Review URL: http://codereview.chromium.org/2826 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2166 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the TODO to remove --start-maximized. It seems this switch ispjohnson@google.com2008-09-131-3/+0
| | | | | | | actually useful for users, so I see no problem in keeping it. Review URL: http://codereview.chromium.org/3038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2165 0039d316-1c4b-4281-b951-d872f2087c98
* forgot to modify this filebeng@google.com2008-09-131-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2163 0039d316-1c4b-4281-b951-d872f2087c98
* Back r2151 since it causes ui tests failures.maruel@google.com2008-09-135-550/+181
| | | | | | Review URL: http://codereview.chromium.org/3037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2161 0039d316-1c4b-4281-b951-d872f2087c98
* Move XPFrame, VistaFrame to views/old_framesbeng@google.com2008-09-1319-328/+87
| | | | | | | | | | | | Also remove WindowClippingInfo, since it's not used by anyone. And fix a couple of header include issues. B=2205 Review URL: http://codereview.chromium.org/2820 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2158 0039d316-1c4b-4281-b951-d872f2087c98
* Forgot to commit these two files.beng@google.com2008-09-132-2/+2
| | | | | | | B=2205 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2157 0039d316-1c4b-4281-b951-d872f2087c98
* Move importer files into an importer subdirectory.beng@google.com2008-09-1326-326/+115
| | | | | | | | | Also delete title chomper no one uses it. B=2205 Review URL: http://codereview.chromium.org/3035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2154 0039d316-1c4b-4281-b951-d872f2087c98
* Added routines to MetricsService to parse the server response and respond to ↵petersont@google.com2008-09-135-181/+550
| | | | | | | | the request to cease uploading with some probability. Review URL: http://codereview.chromium.org/1633 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2151 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some files and directories we no longer use (We can resurrect them ↵beng@google.com2008-09-124-782/+6
| | | | | | | | | | from svn history later) B=2205 Review URL: http://codereview.chromium.org/2817 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2150 0039d316-1c4b-4281-b951-d872f2087c98
* Fix black flash when detaching tabs.beng@google.com2008-09-121-3/+3
| | | | | | | | B=2199 Review URL: http://codereview.chromium.org/3028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2145 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where history view was not showing star state correctly.sky@google.com2008-09-121-3/+5
| | | | | | | | | BUG=2117 TEST=See bug Review URL: http://codereview.chromium.org/3027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2144 0039d316-1c4b-4281-b951-d872f2087c98
* Revert the change that fixed the encoding when viewing source in subframes.brettw@google.com2008-09-1232-240/+138
| | | | | | | | | This makes view source for some pages (for example Google Reader) not work properly. I speculate that telling WebKit to change the encoding (which causes a reload) right after starting the real load makes it confused. Review URL: http://codereview.chromium.org/3022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2143 0039d316-1c4b-4281-b951-d872f2087c98
* forgot these files, fixing clobber buildbeng@google.com2008-09-1210-10/+10
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2142 0039d316-1c4b-4281-b951-d872f2087c98
* Move View components of the Browser's tab strip into the browser_views ↵beng@google.com2008-09-1216-86/+90
| | | | | | | | | project, and into the views/ subdirectory on disk. B=2198 Review URL: http://codereview.chromium.org/3020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2140 0039d316-1c4b-4281-b951-d872f2087c98
* Removing static initializers.jcampan@chromium.org2008-09-124-113/+103
| | | | | | | | BUG=None TEST=Make sure download bar is still working fine. Review URL: http://codereview.chromium.org/2431 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2137 0039d316-1c4b-4281-b951-d872f2087c98
* Update chrome strings.tc@google.com2008-09-122-2/+2
| | | | | | | TBR=mal Review URL: http://codereview.chromium.org/2807 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2120 0039d316-1c4b-4281-b951-d872f2087c98
* Allows OSDD files to contain https.sky@google.com2008-09-123-13/+15
| | | | | | | | | BUG=2153 TEST=covered by unit tests Review URL: http://codereview.chromium.org/2454 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2119 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent constrained popup windows from trying to become realerg@google.com2008-09-121-2/+8
| | | | | | | | | windows by using alert(). B=1372216 Review URL: http://codereview.chromium.org/1970 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2116 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent window caption flashing in the magic frames by handling undocumented ↵beng@google.com2008-09-123-0/+45
| | | | | | | | | | windows messages that get sent to caption'ed windows. B=1031854 Review URL: http://codereview.chromium.org/1965 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2105 0039d316-1c4b-4281-b951-d872f2087c98
* Actually fix the javascript alert crasher in a way thaterg@google.com2008-09-122-1/+16
| | | | | | | | | doesn't introduce new crashes. B=1368898 Review URL: http://codereview.chromium.org/1966 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2104 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing bug 1951: Browser crash on View-Source of an https page.finnur@google.com2008-09-111-4/+5
| | | | | | | | | | | | | | | | http://code.google.com/p/chromium/issues/detail?id=1951 We load the page in view-source mode, then request the favicon to show in the tab. The SSLManager gets notified about OnRequestStarted for both the page and the favicon, but the favicon request gets redirected from: https://www.solomobile.ca/favicon.ico ... to ... http://www.solomobile.ca/Error.aspx?aspxerrorpath=/Page-Not-Found.aspx The SSLManager sees this as mixed content and while handling that it writes a debug message to the console, but in the process of writing the debug message we crash when GetTabContents(TAB_CONTENTS_WEB) returns NULL (since the current tab is TAB_CONTENTS_VIEW_SOURCE). Given that this is a debug message we are trying to write with a function that is only implemented on WebContents we should just NULL check the GetTabContents(TAB_CONTENTS_WEB) return value (and not log the debug message). Review URL: http://codereview.chromium.org/2445 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2090 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting constrained window change. Seems to break tests on TOT.erg@google.com2008-09-112-13/+1
| | | | | | Review URL: http://codereview.chromium.org/2447 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2088 0039d316-1c4b-4281-b951-d872f2087c98
* As described in bug 2136, this test is flaky.jcampan@chromium.org2008-09-111-1/+2
| | | | | | | Temporarily disabling it. Review URL: http://codereview.chromium.org/1955 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2087 0039d316-1c4b-4281-b951-d872f2087c98
* Two minor fixes. Fix the hard coded desired dpi and remove an unneeded include.maruel@google.com2008-09-112-2/+3
| | | | | | Review URL: http://codereview.chromium.org/1954 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2084 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid starting the pause timer if it is already started.darin@chromium.org2008-09-111-2/+3
| | | | | | | | R=sky Review URL: http://codereview.chromium.org/2443 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2083 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in IconManager where it was possible for callback to besky@google.com2008-09-111-3/+4
| | | | | | | | | | | | | invoked with a deleted pointer. We never hit this as none of the callers use the SkBitmap supplied to the callback. I was tempted to nuke the SkBitmap from the callback, but seems useful. BUG=1372146 TEST=none Review URL: http://codereview.chromium.org/2438 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2081 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crasher and possible security vulnerability in popuperg@google.com2008-09-112-1/+13
| | | | | | | | | handling. B=1368898 Review URL: http://codereview.chromium.org/2437 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2079 0039d316-1c4b-4281-b951-d872f2087c98
* Update URL for dictionary download.sidchat@google.com2008-09-111-1/+1
| | | | | | Review URL: http://codereview.chromium.org/1401 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2071 0039d316-1c4b-4281-b951-d872f2087c98
* Changes session service to not persist NavigationEntries that havesky@google.com2008-09-116-40/+93
| | | | | | | | | | | POST data. This is a security problem as POST data can contain passwords in plain text. BUG=1361980 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2063 0039d316-1c4b-4281-b951-d872f2087c98
* Return the exit code from setup.exe instead of returning a generic return code.kuchhal@chromium.org2008-09-111-2/+2
| | | | | | Review URL: http://codereview.chromium.org/1918 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2059 0039d316-1c4b-4281-b951-d872f2087c98
* Closing a tab with a constrained pop-up showing an SSL interstitial would ↵jcampan@chromium.org2008-09-113-3/+40
| | | | | | | | | | crash the browser. BUG=1966 TEST=Open a page that opens a popup which is served over bad SSL. Close the tab. Review URL: http://codereview.chromium.org/1898 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2058 0039d316-1c4b-4281-b951-d872f2087c98
* Renames BoomarkBarModel to BookmarkModel.sky@google.com2008-09-1150-837/+790
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1912 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2057 0039d316-1c4b-4281-b951-d872f2087c98
* Tuck the ram/num_processes map into a function, and remove a static initializer.deanm@chromium.org2008-09-111-12/+11
| | | | | | Review URL: http://codereview.chromium.org/1936 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2053 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the tabstrip doesn't have the chin above it in maximized view in aero.beng@google.com2008-09-111-1/+2
| | | | | | | B=1031854 Review URL: http://codereview.chromium.org/2414 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2051 0039d316-1c4b-4281-b951-d872f2087c98
* Set an upper limit to the number of characters that can appear in a tooltip ↵beng@google.com2008-09-112-0/+19
| | | | | | | | | | string. B=1368905 Review URL: http://codereview.chromium.org/2409 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2042 0039d316-1c4b-4281-b951-d872f2087c98
* Double clicking on an item in the task manager should bring the relevant tab ↵petersont@google.com2008-09-107-10/+101
| | | | | | | | forward. Review URL: http://codereview.chromium.org/1822 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2026 0039d316-1c4b-4281-b951-d872f2087c98
* Google Update gave us a new IDL and asked us to change the CLSID const we ↵finnur@google.com2008-09-101-1/+1
| | | | | | | | use. Effectively there should be no change here. This is not required for the beta branch. Review URL: http://codereview.chromium.org/1901 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2008 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-31 00:56:02 +0000