summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Tab strip model: Fix an off by one error where we do not check the first tab.thestig@chromium.org2010-02-051-15/+10
| | | | | | | | BUG=33323 TEST=see bug Review URL: http://codereview.chromium.org/561066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38234 0039d316-1c4b-4281-b951-d872f2087c98
* Don't need ipc_message.h any morecmasone@google.com2010-02-052-16/+0
| | | | | | Review URL: http://codereview.chromium.org/577025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38229 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds support for displaying Chrome InfoBars in pages rendered via ↵ananta@chromium.org2010-02-056-26/+88
| | | | | | | | | | | | | | | | | | ChromeFrame. To achieve this the ExternalTabContainer now creates a view which comprises of the InfoBarContainer and the TabContentsContainer view. It uses the GridLayout manager to layout this view. The InfoBarContainer no longer depends on the BrowserView. It now passes notifications to the InfoBarContainerDelegate interface which is implemented by the BrowserView and the ExternalTabContainer. Fixes bug http://code.google.com/p/chromium/issues/detail?id=24051 Bug=24051 Review URL: http://codereview.chromium.org/573022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38228 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crasher in LocationBarView when browser is closed with page action ↵mirandac@chromium.org2010-02-054-19/+31
| | | | | | | | | | install bubble showing. BUG= 34282 TEST= in release version, create a page action. close browser window while page action install bubble is showing. no crash, ever. Review URL: http://codereview.chromium.org/561028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38225 0039d316-1c4b-4281-b951-d872f2087c98
* Show the filebrowse ui rather than the download shelf in chromeos.xiyuan@chromium.org2010-02-058-26/+95
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This cl displays the filebrowse ui rather than download shelf for downloads in chrom(e|ium) os. It conditionally replaces (with preprocessor macros) the Browser::OnStartDownload method to do this. The cl adds a static FileBrowseUI::OpenPopup(profile, hashArgument), which opens the file browse ui and passes it the provided hash argument. This is invoked directly from Browser::OnStartDownload. The USBMountObserver code was changed to call this static method, rather than open the popup by hand as it had been doing. I'm not sure about ownership of the Browser* returned by OpenPopup, but based on other code in the tree I assume chrome will deal with freeing it when appropriate. Before this change, USBMountObserver would add the window to registrar_ *before* showing it. Now that FileBrowseUI::OpenPopup returns a which which is already visible, this is no longer the case. I assume this won't be a problem. Commit this for rginda. Original review: http://codereview.chromium.org/555167 BUG=none TEST=none Review URL: http://codereview.chromium.org/564022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38222 0039d316-1c4b-4281-b951-d872f2087c98
* Prepare for running nacl_ui_test on Mac and Linux.gregoryd@google.com2010-02-051-0/+6
| | | | | | | | This is the NaCl-Chrome integration test that runs in Chrome waterfall, currently on Windows only. I am working on starting new bots that will run it on Mac and Linux. Review URL: http://codereview.chromium.org/563021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38218 0039d316-1c4b-4281-b951-d872f2087c98
* Makes example.com resolve to localhost for test.sky@chromium.org2010-02-051-0/+2
| | | | | | | | | | BUG=32845 TEST=none TBR=erikkay Review URL: http://codereview.chromium.org/573029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38215 0039d316-1c4b-4281-b951-d872f2087c98
* Split out of reverted change ↵joth@chromium.org2010-02-053-13/+23
| | | | | | | | | | | | | http://src.chromium.org/viewvc/chrome?view=rev&revision=38207 Commit fixes to code under test, whilst tests themselves are still pending. BUG=http://crbug.com/11246 TEST=see http://codereview.chromium.org/578006 Review URL: http://codereview.chromium.org/571014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38213 0039d316-1c4b-4281-b951-d872f2087c98
* Wires TabContents to app extensions.sky@chromium.org2010-02-0511-58/+174
| | | | | | | | | BUG=32845 TEST=none Review URL: http://codereview.chromium.org/566032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38212 0039d316-1c4b-4281-b951-d872f2087c98
* Add bugs, update, and remove TODOs that are no longer validpinkerton@chromium.org2010-02-0517-77/+20
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/577021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38211 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid out-of-bounds array access.cevans@chromium.org2010-02-051-1/+2
| | | | | | | | | TEST=NONE BUG=34710 Review URL: http://codereview.chromium.org/572031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38209 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 38207 - bah. still can't work out why this passes fine on local ↵joth@chromium.org2010-02-055-416/+13
| | | | | | | | | | | | | | | | | | | | | machine & try bots. Reattempt at http://src.chromium.org/viewvc/chrome?view=rev&revision=37989 (asserts tidy up slit out into its own change http://codereview.chromium.org/578013/show) Add tests for the geolocation network provider. Also some small tidy up a few other files. BUG=http://crbug.com/11246 TEST=unit_tests.exe gtest_filter=NetworkLocationProvider* gtest_break_on_failure Review URL: http://codereview.chromium.org/578006 TBR=joth@chromium.org Review URL: http://codereview.chromium.org/575021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38208 0039d316-1c4b-4281-b951-d872f2087c98
* Re-attempt at http://src.chromium.org/viewvc/chrome?view=rev&revision=37989 joth@chromium.org2010-02-055-13/+416
| | | | | | | | | | | | | | | (asserts tidy up slit out into its own change http://codereview.chromium.org/578013/show) Add tests for the geolocation network provider. Also some small tidy up a few other files. BUG=http://crbug.com/11246 TEST=unit_tests.exe --gtest_filter=NetworkLocationProvider* --gtest_break_on_failure Review URL: http://codereview.chromium.org/578006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38207 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit side is in https://bugs.webkit.org/show_bug.cgi?id=34524jeremy@chromium.org2010-02-054-1/+92
| | | | | | | | | BUG=NONE TEST=Right clicking on a text input field in Web content on OS X should now show a Writing Direction submenu. Clicking on "Left To Right" should align the input to the left, and "Right To Left" should do the opposit. The "Default" menu item should always be disabled. Review URL: http://codereview.chromium.org/566031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38204 0039d316-1c4b-4281-b951-d872f2087c98
* Split out of reverted change ↵joth@chromium.org2010-02-055-9/+10
| | | | | | | | | | | | | | http://src.chromium.org/viewvc/chrome?view=rev&revision=37989 Tidy up assertions to use CHECKs (Already reviewed as part of above change) BUG=none TEST=none Review URL: http://codereview.chromium.org/578013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38203 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 318.0 to 319.0chrome-release@google.com2010-02-051-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38202 0039d316-1c4b-4281-b951-d872f2087c98
* Remove context accessor crash from known crashes after pushing V8ager@chromium.org2010-02-051-3/+0
| | | | | | | fix to chromium. Review URL: http://codereview.chromium.org/578012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38201 0039d316-1c4b-4281-b951-d872f2087c98
* Remove size_t from audio IPC code.jam@chromium.org2010-02-0514-162/+157
| | | | | | | The change got to this size because I had to modify the surrounding code (I didn't want to just cast at the last minute). Review URL: http://codereview.chromium.org/577006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38192 0039d316-1c4b-4281-b951-d872f2087c98
* Support app menu and double-click close on upper left corner of window, part ↵pkasting@chromium.org2010-02-059-64/+6
| | | | | | | | | | | | one. This makes things work right for windows that have an icon. The behavior of the main window is unchanged because right now it never returns HTSYSMENU anywhere. Part two of this change will be figuring out how to return that at the right place, which will make things Just Work. BUG=6961 TEST=Open an app or popup window. Single click the icon. The app menu should appear. Close it, then click-and-drag into the app menu. The item you release on should execute. Double-click the icon. The window should close. Review URL: http://codereview.chromium.org/577018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38187 0039d316-1c4b-4281-b951-d872f2087c98
* Implement launch disposition for extension-apps.rafaelw@chromium.org2010-02-0513-19/+150
| | | | | | | | | | | | This change adds an --app-id command switch that signifies that the extension-app with the given id should be launched according to its configuration. It also adds parsing for app.window_type in the manifest and the behavior that when installed and a desktop shortcut is created, the --app-id switch is used rather than the --app switch. BUG=32361 Review URL: http://codereview.chromium.org/573016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38184 0039d316-1c4b-4281-b951-d872f2087c98
* Implement backend support for forcing cookies to be saved asdarin@chromium.org2010-02-051-2/+7
| | | | | | | | | | | | | | session cookies. Introduces a new CookiePolicy result code OK_FOR_SESSION_ONLY. R=eroman BUG=34571 TEST=none Review URL: http://codereview.chromium.org/577013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38179 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash when extensions try to set cookies. It is valid fordarin@chromium.org2010-02-051-15/+21
| | | | | | | | | | | | | the cookie policy to be NULL, in which case we should default to allowing cookies to be set. R=eroman BUG=34649 TEST=Try to install extension AniWeather from official gallery site Review URL: http://codereview.chromium.org/578007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38178 0039d316-1c4b-4281-b951-d872f2087c98
* More work on diagnostics modecpu@chromium.org2010-02-054-43/+106
| | | | | | | | | | | | | | | | - Clean up a bit, reduce windows specific code - Add disk space test - Add Chrome version test - Make OS version readable, cross platform mostly This concludes the minimal sanity tests. BUG=27885 TEST= run chrome with --diagnostics , no test should fail. Review URL: http://codereview.chromium.org/561078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38176 0039d316-1c4b-4281-b951-d872f2087c98
* Now showing the browser action image (including badge) when dragging andfinnur@chromium.org2010-02-053-9/+36
| | | | | | | | | | | | showing the badge in the overflow menu. BUG=26990 TEST=Browser actions in container/overflow should show image and badge and also while dragging back and forth. Review URL: http://codereview.chromium.org/575016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38174 0039d316-1c4b-4281-b951-d872f2087c98
* System toast was trying to launch the per-user chromecpu@chromium.org2010-02-056-7/+11
| | | | | | | | | | | | | - forgot to pass along the system_install flag. BUG=32474 TEST=see bug for instructions, you need to simulate a system level install. TBR=huanr Review URL: http://codereview.chromium.org/561080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38172 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 38166 - Added Star button to compact navigation mode.pkasting@chromium.org2010-02-0511-220/+240
| | | | | | | | | | | | | BUG=32326 TEST=Switch Chrome to compact mode by pressing CtrlShiftC. Test that Star icon works. Review URL: http://codereview.chromium.org/543215 TBR=avayvod@chromium.org Review URL: http://codereview.chromium.org/561081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38171 0039d316-1c4b-4281-b951-d872f2087c98
* linux: Use gtk-cursor-blink from GtkSettings to set the caret blink intervaljoel@chromium.org2010-02-054-1/+31
| | | | | | | | | BUG=20772 TEST=Open gnome-keyboard-properties. Un-set the "Cursor Blinking" checkbox. Open a new tab in chromium and the cursor should not blink. Do the same with the slider, and the rate of blinking should vary. Review URL: http://codereview.chromium.org/398003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38168 0039d316-1c4b-4281-b951-d872f2087c98
* Added Star button to compact navigation mode.avayvod@chromium.org2010-02-0511-240/+220
| | | | | | | | | | BUG=32326 TEST=Switch Chrome to compact mode by pressing Ctrl-Shift-C. Test that Star icon works. Review URL: http://codereview.chromium.org/543215 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38166 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 33130 by checking whether the tab is closed whenhuanr@chromium.org2010-02-051-2/+3
| | | | | | | | | | | closing login propmt BUG=33130 TEST=existing test passes Review URL: http://codereview.chromium.org/576010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38165 0039d316-1c4b-4281-b951-d872f2087c98
* Bug 34167: GPU plugins' output initially placed incorrectly on pagekbr@google.com2010-02-054-0/+40
| | | | | | | | | | | | | | | | Added call to RenderView::DidMovePlugin upon creating the command buffer so the nested delegate is initially placed properly on the page; thanks to jam for this suggestion. Added necessary accessor to fetch the plugin window handle from the nested delegate, which is the "fake" GPU plugin window handle on Mac OS X. Verified that Pepper 3D test plugin initially shows up in the correct place. BUG=34167 TEST=none (ran Pepper test plugin on Mac and Linux) Review URL: http://codereview.chromium.org/561068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38164 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Set fixed maximum line height in Omnibox.viettrungluu@chromium.org2010-02-052-1/+22
| | | | | | | | | | | (Otherwise, e.g., Arabic text can make the line shift downwards.) BUG=31115 TEST=Make sure Omnibox works/looks/feels normal (and that normal text is displayed in it correctly). Then paste in something containing appropriate Arabic characters (see bug report for some samples); make sure text doesn't shift down. Review URL: http://codereview.chromium.org/573002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38163 0039d316-1c4b-4281-b951-d872f2087c98
* Implement RemoveChars, a function to remove a list of characters from a ↵jhawkins@chromium.org2010-02-051-1/+1
| | | | | | | | | | string, and use it in PhoneNumber to remove extra phone number characters. BUG=none TEST=StringUtilTest.RemoveChars Review URL: http://codereview.chromium.org/572015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38162 0039d316-1c4b-4281-b951-d872f2087c98
* Make the side tabstrip participate in the layout of the BrowserView.ben@chromium.org2010-02-058-48/+69
| | | | | | | | | | | | Turn on the side tabstrip by default when --enable-vertical-tabs is specified, for ease of testing/debugging. Adjust glass rendering in this mode. http://crbug.com/34509 TEST=none Review URL: http://codereview.chromium.org/570029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38160 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some goofiness when arrowing around the popup with control down by ↵pkasting@chromium.org2010-02-051-1/+18
| | | | | | | | | | canceling control-enter once the user starts moving around the popup. BUG=32547 TEST=Type something in the omnibox, hold control, arrow down to a different entry, release control, press enter. You should visit the entry that's selected, not something else. Review URL: http://codereview.chromium.org/577008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38159 0039d316-1c4b-4281-b951-d872f2087c98
* Additional Chromium icon resolutions for better Linux desktop integration.mmoss@google.com2010-02-056-0/+4
| | | | | | | | BUG=34320 Review URL: http://codereview.chromium.org/575013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38158 0039d316-1c4b-4281-b951-d872f2087c98
* Implement FormManager, a class that manages forms in a RenderView.jhawkins@chromium.org2010-02-055-0/+617
| | | | | | | | BUG=18201 TEST=FormManagerTest Review URL: http://codereview.chromium.org/577009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38157 0039d316-1c4b-4281-b951-d872f2087c98
* Fix StringPrintf that is now brokencpu@chromium.org2010-02-051-2/+2
| | | | | | | | | | | | | | - command line for chrome is not working BUG=none TEST=now toast test with --inactive-user-toast=0 should work TBR=huanr Review URL: http://codereview.chromium.org/570037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38156 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: unbreak right click on bookmark bar folders.estade@chromium.org2010-02-042-3/+7
| | | | | | | | | BUG=34416 TEST=right, middle, and left click on bookmark bar folder all do what they should Review URL: http://codereview.chromium.org/576008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38151 0039d316-1c4b-4281-b951-d872f2087c98
* Fix description of onImportBegan to ensure people use it safely.feldstein@chromium.org2010-02-041-1/+1
| | | | | | | | When observers listen to onImportBegan, they can only safely ignore handleCreated. handleDeleted, handleMoved, etc must still be handled immediately to avoid holding on to stale pointers. Review URL: http://codereview.chromium.org/570017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38149 0039d316-1c4b-4281-b951-d872f2087c98
* Adds link to flash settings on clear browser data panel.sky@chromium.org2010-02-042-1/+45
| | | | | | | | | | BUG=none TEST=bring up clear browsing data dialog and make sure it has a link to flash storage settings. Review URL: http://codereview.chromium.org/570030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38148 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up third_party/cld.jshin@chromium.org2010-02-046-15/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | 1. Remove files we don't use that come from toolbar 2. Simplify the directory structure by removing the redundant intermediary directories bar/toolbar/cld/i18n This will bring CLD a step closer to where it can be open-sourced separately (or along with CED for encoding detection.). It's not there yet. In addition to the clean-up, change |LanguageCode*| return 'nb', 'he', 'fil' instead of 'no', 'iw', and 'tl'. Also, use LanguageCodeWithDialects instead of LanguageCode to get 'zh-CN' instead of 'zh'. This is to simplify the 3-way mapping between Chrome's UI locale code, CLD's language code and what's accepted by Google Translate. It's also another preparation for open-sourcing because we'd better use the standard code rather than the obsolete code like 'iw' when open-sourcing. BUG=32759, 33613 TEST=third_party/cld builds on all platforms and pass the following tests: - unit_tests: Extension*.DetectTabLanguage and CompactLangDetTest.* - browser_tests: ExtensionBrowserTest.Toolstrip git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38146 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for the IE File->Save As command. This eventually ends up in ↵ananta@chromium.org2010-02-046-3/+22
| | | | | | | | | | | | | | | | Chrome via the new automation message AutomationMsg_SaveAsAsync. Rest of the changes are to plumb this message across from IE to Chrome. Fixes bug http://code.google.com/p/chromium/issues/detail?id=24039 Bug=24039 Test=Launch IE with OptinUrls set to *. Navigate to google.com and select File->Save As. The dialog should popup. Review URL: http://codereview.chromium.org/563025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38145 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed some of UI issues with AutofillSettings dialog: separators, preview ↵georgey@chromium.org2010-02-041-16/+37
| | | | | | | | | | | and indents should be correct. Sizes and alignments should be mostly correct. Known issue is large size of the month field in credit view. TEST=general autofill test, all functionality is there BUG=33026 Review URL: http://codereview.chromium.org/567038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38142 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: fix crash deleting bookmark while bookmark editor is open.snej@chromium.org2010-02-046-6/+197
| | | | | | | | | | (xib change: enable 'preserve selection' in NSOutlineView.) BUG=33333 TEST=BookmarkEditorBaseControllerTest.SelectedFolderDeleted et al Review URL: http://codereview.chromium.org/566005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38139 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing paint issue with browser actions not being updated in one window when ↵finnur@chromium.org2010-02-041-0/+1
| | | | | | | | | | | dragged around in another. BUG=34506 TEST=See bug (make sure you specify a zip code for the weather extension when testing). Review URL: http://codereview.chromium.org/570028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38137 0039d316-1c4b-4281-b951-d872f2087c98
* Adding drag-drop support in and out of the Browser Action overflow menu.finnur@chromium.org2010-02-045-29/+267
| | | | | | | | | BUG=26990 TEST=Drag icons into and out of (and within) both the Browser Action container and its overflow menu. Review URL: http://codereview.chromium.org/570014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38135 0039d316-1c4b-4281-b951-d872f2087c98
* Browser action for compact loc bar, plus several visual fixes.oshima@chromium.org2010-02-045-23/+58
| | | | | | | | | | | | | - added browser action container to compact location bar - use toolbar background to match with bookmark bar (when visible) - use given bounds to compute window edge BUG=32327 TEST=none Review URL: http://codereview.chromium.org/573017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38133 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor chromeos login files into subdir 'login'chocobo@chromium.org2010-02-049-32/+33
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/577007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38130 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor chromeos cros files into subdir 'cros'chocobo@chromium.org2010-02-0429-78/+78
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/572012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38128 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor chromeos status area files into subdirectory statuschocobo@chromium.org2010-02-0425-75/+75
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/561077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38127 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 00:01:35 +0000