| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
of extensions into crx files.
BUG=20578
TEST=Create a sample extension, pack it, then try to install it.
Review URL: http://codereview.chromium.org/181020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
'beaker'. It isn't clear how LGPL applies to images, so
to avoid hassle, replaced the old icon with something else.
TBR=erikkay@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
centers the text for us already. This change also removes a hack that modified the clipping rect unnecessarily.
BUG=20401,20610
TEST=none
Review URL: http://codereview.chromium.org/179037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/packaging.html is what should be used to pack extensions.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/173624
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=20577
TBR=rafaelw@chromium.org
Review URL: http://codereview.chromium.org/177032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is what it looks like with this change:
http://dl.getdropbox.com/u/124107/cap.png
Note that this removes the information about content scripts.
I would actually like to expand that information to show all
the components of the extension eventually, but with just
content scripts, it didn't seem super useful.
TBR=rafaelw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=erikkay
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/173623
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the New Tab page.
BUG=http://crbug.com/20415
TEST=With the extension toolstrip visible, go to the New Tab page and press Ctrl + Alt + B. Watch the toolstrip merge into the New Tab page and back again into a separate toolstrip (when you press Ctrl + Alt + B again). Also, when you do this on a regular webpage (as opposed to NTP) this should toggle the toolstrip visiblity.
Review URL: http://codereview.chromium.org/175017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
selecting a new tab.
BUG=20583
TEST=Open a browser with two tabs. Select the unselected tab. The now-unselected tab should be rendered as unselected.
Review URL: http://codereview.chromium.org/182025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
weren't hitting the codepath that initializes this variable, leading to a UMR that caused glitchy rendering.
BUG=20157
TEST=Drag a tab. The rendering should not be glitchy.
Review URL: http://codereview.chromium.org/176035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
other paths in the browser, like navigating away from Interstitial pages, etc. We end up crashing the browser because of dereferencing a NULL reply_message pointer.
Added a check for the same.
This fixes http://b/issue?id=2057296
Bug=2057296
Review URL: http://codereview.chromium.org/179024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR: finnur
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- The failure was happening because of my change to use api_test.js in the test. Because of that, there were now two calls to chrome.test.pass(), and I was asserting that there had been only one. This was only failing under Release, presumably because it wound up getting both pass events in the single event loop (a timing issue).
BUG=none
TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.Overrides
Review URL: http://codereview.chromium.org/181012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ui_tests needs to be considered as a "large module" now otherwise linking failure may happen.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/182016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
download shelf.
BUG=20343
TEST=Look at it.
Review URL: http://codereview.chromium.org/173621
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This caused the possible url dialog in the options menu to never load favicons, and instead DCHECK (crashing debug builds).
Review URL: http://codereview.chromium.org/179034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=20236
TBR=aa
Review URL: http://codereview.chromium.org/178028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=20573
TEST=Install sample extensions without modifying command line flags. They should install (and run on next startup).
Review URL: http://codereview.chromium.org/179032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were already doing this, this change modifies the
mechanism. Before we were relying on the presence of the
--enable-extensions flag, but as we are getting ready to
remove that on dev, we needed something else.
This forces local storage and database to be enabled on
chrome-extension:// pages.
Also, change the way database enabling works in general to
be more like the way local storage works, just for
consistency. Will remove old, unnecessary WebKit API in an
upstream change.
erikkay: extensions stuff
dumi: database stuff
jorlow: local storage stuff
BUG=19511
Review URL: http://codereview.chromium.org/173306
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/182019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=aa, rafaelw
Review URL: http://codereview.chromium.org/183009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
http://crbug.com/17251
Review URL: http://codereview.chromium.org/179008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=17363, 20407
TEST=none
Review URL: http://codereview.chromium.org/174327
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
whose images have failed to process correctly, drop back to the default theme.
BUG= http://crbug.com/20263
TEST= Use a preferences file from an older version of Chrome that has a theme installed, and open Chrome. Observe that Chrome opens using the default theme.
Review URL: http://codereview.chromium.org/175013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Factor out common window rounding code from two places where it was used,
generalize it, and use it to round the "Search site for:" hint in the location
bar. Theoretically, people should be able to use this anywhere they need a
window to have rounded corners.
http://crbug.com/18310
Review URL: http://codereview.chromium.org/179026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit e6ab23c81e56c6b9fbb062bbb090a648e6ebef12.
TBR=beng
Review URL: http://codereview.chromium.org/183006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor so that the dialog is shown by calling BrowserWindow::ShowRepostFormWarningDialog
BUG=19761
TEST=see bug
Review URL: http://codereview.chromium.org/174294
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://crbug.com/20506
TEST= Install any theme. Observe that tips are legible.
Review URL: http://codereview.chromium.org/182012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Left a TODO to rename the class to something more general but
it is preferable to do a rename separate from code changes, it
will make things easier to sync and be quicker since that change
is relatively trivial.
The exact look may be changed later but I'll attach screenshots
to this issue to show the initial implementation.
Also left as future enhancement is the possibility of limiting
the size of the notification list in cases where a lot of hosts
are affected. The most extreme example I found was some Gizmodo
page with 36 domains using cookies.
BUG=16932
TEST=none
Review URL: http://codereview.chromium.org/179013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The combobox still isn't implemented, but this makes TextBox work, and also
does some changes around the info_bubble to make sure it get created properly.
TEST=none
BUG=none.
Review URL: http://codereview.chromium.org/177026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Turns out there's a way to allow sending signals to yourself that works on both 10.5 & 10.6 so use that...
Remove temporary hack to only enable syntax on Leopard.
BUG=20370
TEST=On both 10.5 & 10.6 - Follow repro steps for crash in 20366, browser process should show sad tabs rather than crash.
Review URL: http://codereview.chromium.org/180028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the user hits shift-delete (that's forward delete),
attempt to delete the item highlighted from the list. This only seems
to work for history items.
http://crbug.com/20281
TEST=No idea. I've managed to delete an item, but most items seem
immune to deletion, this code is calling the right place, but the
match itself checks !deletable. Sometimes I have luck going to a
site, then typing part of the URL and using shift-del on it.
Review URL: http://codereview.chromium.org/176022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for dev:
* Enforce permissions on cross-origin XHR
* Enforce module-level permissions
* Decided not to completely remove chrome.self since it is so widely used, but removed all references to it from samples and docs.
BUG=16356,12129,12140
TEST=Sample extensions on http://dev.chromium.org/developers/design-documents/extensions/samples should still work
Review URL: http://codereview.chromium.org/179027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24816 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=20254
Review URL: http://codereview.chromium.org/179012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Minor rendering fix (could fail if XHR fired two callbacks).
TBR=aa
Review URL: http://codereview.chromium.org/179029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174232
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original issue: http://codereview.chromium.org/115212/show
The favicons service is the entry point to getting favicons.
Make the DOMUIFactory handle the favicons of DOMUI pages so since DOMUI pages
are never added to the history.
BUG=5840
TEST=Open a new window and open history and downloads (Ctrl+H and Ctrl+J) in
this window. Then close the window and open the NTP. The recently closed
windows/tabs should show the favicons for the hsitroy and downloads page.
Review URL: http://codereview.chromium.org/178001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR: tony
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=rafaelw
Review URL: http://codereview.chromium.org/182017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit r24792.
TBR=estade
Review URL: http://codereview.chromium.org/179028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=estade
Review URL: http://codereview.chromium.org/175014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Middle click should open the item clicked in a background tab.
http://crbug.com/20282
TEST=Start typing in omnibox. Middle click an item. The item should
open in a different tab without affecting the current omnibox state.
Review URL: http://codereview.chromium.org/179009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Most of these are classes with virtual methods lacking virtual destructors
or NULL used in non-pointer context.
BUG=none
TEST=app_unittests && base_unittests
--gtest_filter=-ConditionVariableTest.LargeFastTaskTest
patch by Jacob Mandelson <jlmjlm [at] gmail>
http://codereview.chromium.org/171028/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Overrides are declared in an extension's manifest. The last one installed
wins. However, we keep a list of those installed per page so that priority
is preserved and so that uninstall will revert to a previous state.
Review URL: http://codereview.chromium.org/174277
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
dev tools window.
It makes app mode windows feel a lot more native.
BUG=16474
Review URL: http://codereview.chromium.org/183002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The signal-self syntax needed to fix bug 20370 doesn't work on Leopard and
causes the Sandbox to barf so renderers don't star tup.
We introduce a ;10.5_ONLY keyword to the sandbox that is substituted at runtime (the line with the rule is effectively uncommented). This allows us to use leopard or snow-leapard-only sandbox syntax
BUG=20516
TEST=Chrome should no longer crash on launch under SL.
Review URL: http://codereview.chromium.org/183003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
extensions that increase privilges.
BUG=20461
Review URL: http://codereview.chromium.org/174637
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
DISALLOW_EVIL_CONSTRUCTORS in a bunch of files.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/173538
Patch from Thiago Farina <thiago.farina@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=20288
Review URL: http://codereview.chromium.org/180016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Also distinguish dump files by architecture, so they don't clobber each other when archived.
Review URL: http://codereview.chromium.org/177025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24769 0039d316-1c4b-4281-b951-d872f2087c98
|