summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Turn BrowserView::GetBrowserViewForNativeView() into ↵davemoore@chromium.org2009-05-286-18/+24
| | | | | | | | | | | GetBrowserViewForNativeWindow() This simplifies things on linux where the native window is not the same type as the native view. Review URL: http://codereview.chromium.org/115830 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17043 0039d316-1c4b-4281-b951-d872f2087c98
* Shift maximized mode tabstrip up by 1 px to avoid empty pixel at screen top.pkasting@chromium.org2009-05-282-11/+15
| | | | | | | BUG=12042 Review URL: http://codereview.chromium.org/115838 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17042 0039d316-1c4b-4281-b951-d872f2087c98
* Dangerous download dialog for linux.estade@chromium.org2009-05-2710-38/+228
| | | | | | | | | BUG=11780 TEST=go to cygwin.com, click "install or update now". The download shelf should appear with a dangerous download dialog, which should animate properly and without undue jank. Clicking "cancel" should delete the item and hide the shelf (since it's the only thing in the shelf). Clicking "save" should make it become a normal download item. Review URL: http://codereview.chromium.org/113920 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17041 0039d316-1c4b-4281-b951-d872f2087c98
* Fix erroneous sign when drawing path for right endcap of tabs, causing them ↵pkasting@chromium.org2009-05-271-1/+1
| | | | | | | | to not be selectable for much of the right endcap. Review URL: http://codereview.chromium.org/115836 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17038 0039d316-1c4b-4281-b951-d872f2087c98
* With the recent change to the ExternalTabContainer to have it subclass ↵ananta@chromium.org2009-05-273-4/+4
| | | | | | | | | | | | WidgetWin rather than Widget and the associated ATL classes, the class name based comparison for a window to check if it is an external tab container window is no longer valid. We now check if a window is an external tab window by looking for the existence of the kWindowObjectKey window property, which is only set on external tab container windows. Review URL: http://codereview.chromium.org/115833 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17034 0039d316-1c4b-4281-b951-d872f2087c98
* Update (add back) a few known crash to list.huanr@chromium.org2009-05-271-1/+7
| | | | | | Review URL: http://codereview.chromium.org/115834 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17033 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 12729: Find box doesn't unregister Esc accelerator.finnur@chromium.org2009-05-272-5/+42
| | | | | | | | | | | | | | | | | | | | | | | | | This regressed recently during porting. When comparing to see who is registered we need to be comparing against a class that implements FocusChangeListener (and registers as such with AddFocusChangeListener). In this case, host_ does not implement that interface and doesn't register as a listener, so it will never be registered. We should be comparing using 'this', not 'host_'. I've fixed this and added a browser_test to catch this in the future. BUG=12729 TEST=Open Find, press Esc, press Esc again and the Find box should not briefly appear and hide again. Also, make sure Esc works to cancel navigations. Review URL: http://codereview.chromium.org/115832 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17032 0039d316-1c4b-4281-b951-d872f2087c98
* Converts a bunch things from NativeWindow to NativeView to make itsky@chromium.org2009-05-2717-50/+40
| | | | | | | | | | | | | | easier for callers. Also gets bookmark menu button to compile. I'm also removing a function I just added to gtk_util as it's not needed. GTK offers gtk_widget_get_toplevel which does what I need. BUG=none TEST=none Review URL: http://codereview.chromium.org/115831 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17029 0039d316-1c4b-4281-b951-d872f2087c98
* Add an unused interface for storing thumbnails. This is to replace the historybrettw@chromium.org2009-05-271-0/+52
| | | | | | system's thumbnail storage. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17028 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure that we're restoring focus to a valid subview. (with Rohit)avi@chromium.org2009-05-271-1/+5
| | | | | | | | | | BUG=http://crbug.com/12725 TEST=repro test mentioned in http://code.google.com/p/chromium/issues/detail?id=12725#c4 Review URL: http://codereview.chromium.org/113922 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17027 0039d316-1c4b-4281-b951-d872f2087c98
* Commit on behalf of Yusuke:glen@chromium.org2009-05-271-3/+8
| | | | | | | | | | | | | | | | | """ Fixed StatusBubbleViews::AvoidMouse() to support the mirrored UI (RTL) mode. BUG=12148 TEST=Start chromium with --lang=he. Hover a mouse cursor on a link in the bottom right corner, verify that the status bubble appears to the left. Verify that the status bubble appears in a normal (right) position for all other links. """ Original review URL: http://codereview.chromium.org/115461 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17026 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes the problem of the status bubble obscuring the download shelf.mirandac@chromium.org2009-05-2710-3/+41
| | | | | | | | | | | | | BUG= http://crbug.com/6590 TEST=Cause the download shelf to appear by initiating a download. Hover over a link in the extreme lower left corner of the browser window. The status bubble should avoid your mouse by moving to the right, instead of moving down and obscuring the download shelf. Review URL: http://codereview.chromium.org/113671 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17025 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an errant line from DownloadItemGtk that was causing a crash.estade@chromium.org2009-05-271-2/+0
| | | | | | | | BUG=12653 Review URL: http://codereview.chromium.org/115829 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17024 0039d316-1c4b-4281-b951-d872f2087c98
* Add .dll (and a .exe) files to the gyp build:sgk@google.com2009-05-271-2/+166
| | | | | | | | | | | | | | | | * activex_test_control.dll * browser_tests.dll * browser_tests.exe * memory_watcher.dll * rlz.dll * security_tests.dll * test_chrome_plugin.dll * themes/default.dll BUG=none TEST=none Review URL: http://codereview.chromium.org/113915 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17023 0039d316-1c4b-4281-b951-d872f2087c98
* gyp file for pdfsqueezethomasvl@chromium.org2009-05-271-11/+34
| | | | | | | | | | | make chrome app depend on pdfsqueeze add a rule to run pdfs through pdfsqueeze BUG=7654 TEST=pdf files in resources should be smaller now. Review URL: http://codereview.chromium.org/113911 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17022 0039d316-1c4b-4281-b951-d872f2087c98
* Some ui tests would crash when the browser was closed.jcampan@chromium.org2009-05-271-6/+10
| | | | | | | | | | | | | The problem was related to an infobar (the default browser one) showing. When the tab is closed, InfoBarClosed is called on the infobar delegates, triggering a delete of the delegate. Then a notification that the tab is destroyed is sent, causing the tab contents to layout its infobars accessing the deleted delegates. BUG=12668 TEST=All UI tests should pass (especially the LoginPromptTest ones). Make IE your default browser, start Chrome. The default browser infobar should show. Close the tab. Review URL: http://codereview.chromium.org/113906 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17021 0039d316-1c4b-4281-b951-d872f2087c98
* Adds gtk_util::ParentWindow to find the parent window of a GtkWidget.sky@chromium.org2009-05-272-0/+13
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/113919 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17019 0039d316-1c4b-4281-b951-d872f2087c98
* Add a preference to enable/disable ID persistence in bookmark model andmunjal@chromium.org2009-05-273-5/+53
| | | | | | | | add methods in bookmark model to get/set this preference. Review URL: http://codereview.chromium.org/113882 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17017 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome renderer support for YV16.fbarchard@chromium.org2009-05-271-11/+17
| | | | | | Review URL: http://codereview.chromium.org/113890 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17016 0039d316-1c4b-4281-b951-d872f2087c98
* Initial stab at dialog for "clear browsing data". Needs some UI love from ↵pinkerton@chromium.org2009-05-271-0/+597
| | | | | | | | | Cole. TBR=jnj BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17015 0039d316-1c4b-4281-b951-d872f2087c98
* Move text_field.cc and rename the class to Textfield in preparation for porting.ben@chromium.org2009-05-2733-194/+191
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/115825 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17014 0039d316-1c4b-4281-b951-d872f2087c98
* Open a new tab page rather than the homepage if startup is set to "open the ↵pkasting@chromium.org2009-05-271-2/+8
| | | | | | | | following" with a blank list. Patch by Yuzo Fujishima (see http://codereview.chromium.org/113444 ), r=beng. BUG=6901 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17013 0039d316-1c4b-4281-b951-d872f2087c98
* Don't lose omnibox edits when dragging tabs out. Patch by Yuzo Fujishima ↵pkasting@chromium.org2009-05-271-0/+3
| | | | | | | | (see http://codereview.chromium.org/115558 ), r=beng. BUG=10632 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17012 0039d316-1c4b-4281-b951-d872f2087c98
* Fix breakpad-related Linux official build breakage.mmoss@chromium.org2009-05-271-21/+11
| | | | | | | | | | | | | | Move the "breakpad_linux*" files to the "browser" target rather than "app", since they're needed by "render_crash_handler_host_linux*" which is in "browser". This fixes link errors in unit_tests, which incorporates "browser" but wasn't getting the definitions in these files. This is a revised version of r16954 which avoids the scons "multiple inclusion" errors in the non-official build. Review URL: http://codereview.chromium.org/115823 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17011 0039d316-1c4b-4281-b951-d872f2087c98
* Add stubs for a variety of dialogs under GTK-Views.brettw@chromium.org2009-05-273-0/+85
| | | | | | Review URL: http://codereview.chromium.org/115824 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17010 0039d316-1c4b-4281-b951-d872f2087c98
* Adds comments to BrowserList::GetLastActive that it might return NULLsky@chromium.org2009-05-271-0/+5
| | | | | | | | | | | when there are browsers. BUG=none TEST=none Review URL: http://codereview.chromium.org/113912 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17009 0039d316-1c4b-4281-b951-d872f2087c98
* Binary files for themes+extensions change - these are in a separate change ↵glen@chromium.org2009-05-273-0/+0
| | | | | | | | | | | | so they can be committed ahead of the other CL so that the try server can work. The modified file removes one item from the manifest that wasn't being used. TBR=aa,erikkay Review URL: http://codereview.chromium.org/113918 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17008 0039d316-1c4b-4281-b951-d872f2087c98
* When writing to a closed pipe on OSX errno is set to EPERM.jeremy@chromium.org2009-05-271-0/+7
| | | | | | | | | | | We specifically detect this case, close the channel and return an error. This CL also silences error messages that where previously printed to the console in this situation. BUG=12734 Review URL: http://codereview.chromium.org/113913 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17004 0039d316-1c4b-4281-b951-d872f2087c98
* *_views.cc files were not getting re-included in the gyp Windows build.sgk@google.com2009-05-271-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/115821 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17003 0039d316-1c4b-4281-b951-d872f2087c98
* Add BrowserView to the Linux build, it now compiles. This also includes a smallbrettw@chromium.org2009-05-273-0/+7
| | | | | | | | namespace change to window_sizer_mac which I noticed when doing a previous change. Review URL: http://codereview.chromium.org/113910 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17002 0039d316-1c4b-4281-b951-d872f2087c98
* Fix font sizes in locales other than en-US, da, he, and zh-TW.tc@google.com2009-05-2746-0/+368
| | | | | | | | | | | Add app_locale_settings and app_strings to all the locale dlls. BUG=12309 Review URL: http://codereview.chromium.org/115820 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16998 0039d316-1c4b-4281-b951-d872f2087c98
* Make toolbar compile on linux.ben@chromium.org2009-05-272-12/+35
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/115813 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16997 0039d316-1c4b-4281-b951-d872f2087c98
* ExternalTabContainer should subclass WidgetWin rather than Widget and ATL ↵ben@chromium.org2009-05-273-246/+122
| | | | | | | | | | | | CWindowImpl. This makes it much easier to extend the API of Widget. Cleans up ExternalTabContainer to better match chrome style. BUG=none TEST=run ui tests, verify ExternalTabContainer tests pass. Review URL: http://codereview.chromium.org/113892 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16996 0039d316-1c4b-4281-b951-d872f2087c98
* revert 12598 now that text-overflow:ellipsis has been fixed in WebKit.jeremy@chromium.org2009-05-271-22/+0
| | | | | | | | | BUG=7697 TEST=Open RTL Chrome (--lang=he), load ynet.co.il, load mako.co.il, open new tab page. Observe that ellipsis is placed correctly at the end of the page titles for aforementioned sites and that the underline is under the whole title and not just under the ellipsis. Review URL: http://codereview.chromium.org/112025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16995 0039d316-1c4b-4281-b951-d872f2087c98
* Hides the "Remove thumbnails" link when the most visited intro is shown.arv@google.com2009-05-271-6/+8
| | | | | | | | | | | | | BUG=None TEST=With an empty history, open a new tab. The NTP should not show the link to "Remove thumbnails". Browse 3 different sites and open a new tab again. The link "Remove thumbnails" should now be visible. Review URL: http://codereview.chromium.org/115787 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16994 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes multiple definitions for DragDownload.sky@chromium.org2009-05-273-1/+5
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/115811 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16992 0039d316-1c4b-4281-b951-d872f2087c98
* Use correct branding on the "make default browser" button. Create a new ↵pinkerton@chromium.org2009-05-274-11/+111
| | | | | | | | | | localizer subclass for the prefs window. BUG=12534 TEST=make sure branding is correct on default browser button. Review URL: http://codereview.chromium.org/115817 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16991 0039d316-1c4b-4281-b951-d872f2087c98
* Add shift-zoom to maximize.pinkerton@chromium.org2009-05-271-0/+7
| | | | | | | | BUG=none TEST=shift-zoom maximizes window, zoom sizes to intrinsic size. Review URL: http://codereview.chromium.org/115818 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16989 0039d316-1c4b-4281-b951-d872f2087c98
* Fix errant comments on parameters.pinkerton@chromium.org2009-05-271-2/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/112062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16988 0039d316-1c4b-4281-b951-d872f2087c98
* Relands cl 16982 as it wasn't the cause of the build breakage. Here'ssky@chromium.org2009-05-272-0/+15
| | | | | | | | | | | | | | the description for that cl: Lands http://codereview.chromium.org/115505 for bug http://crbug.com/4030 for tyoshino. BUG=http://crbug.com/4030 TEST=make sure control-w dismisses bookmark manager. Review URL: http://codereview.chromium.org/113902 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16987 0039d316-1c4b-4281-b951-d872f2087c98
* Make the import feature a little more complete:kuchhal@chromium.org2009-05-2712-60/+456
| | | | | | | | | | | | | - Now we show import progress of individual items - In case Firefox is running we display a warning and allow user to close it before proceeding - Delete the Firefox lock when import finishes BUG=11191 Review URL: http://codereview.chromium.org/114047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16986 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 16982.maruel@chromium.org2009-05-272-15/+0
| | | | | | | Broke Modules Mac Review URL: http://codereview.chromium.org/113901 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16985 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Add 'Enable Developer Tools' option into the Advanced tab. Hide ↵pfeldman@chromium.org2009-05-275-6/+101
| | | | | | | | developer tools by default. Review URL: http://codereview.chromium.org/117003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16984 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/115505 for bugsky@chromium.org2009-05-272-0/+15
| | | | | | | | | | | http://crbug.com/4030 for tyoshino. BUG=http://crbug.com/4030 TEST=make sure control-w dismisses bookmark manager. Review URL: http://codereview.chromium.org/113887 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16982 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue where cmd-w was hard-coded to closing a browser tab regardless of ↵pinkerton@chromium.org2009-05-277-47/+182
| | | | | | | | | | the frontmost window type. Have cmd-key equiv correctly set depending on the window type and the number of tabs in the window. Broadcast notification when the number of tabs changes in the model. Disable "close tab" item when there's only 1 tab in the browser window. BUG=10047 TEST=cmd-w correctly closes the expected thing (frontmost window, or tab in the frontmost window). close tab should be disabled when the frontmost tab is not a browser or if there is only 1 tab in the window. Review URL: http://codereview.chromium.org/115789 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16981 0039d316-1c4b-4281-b951-d872f2087c98
* Added support for constructor calls in the NPAPI.sgjesse@chromium.org2009-05-275-3/+99
| | | | | | | | | | | | | | | | | The LiveConnect test cases at http://java.sun.com/javase/6/webnotes/6u10/plugin2/liveconnect/LiveConnectTests/ now pass for Chromium. Parts of this change is rather mechanical, and leaves room for some refactoring afterwards. Merged the implementation of testConstruct and the "objectPointer" property from WebKit\WebKitTools\DumpRenderTree\TestNetscapePlugIn.subproj\TestObject.cpp to the Chromium TestObject.cpp for the layout test LayoutTests\plugins\netscape-construct.html pass. BUG=http://crbug.com/3285 BUG=http://crbug.com/10354 TEST=http://java.sun.com/javase/6/webnotes/6u10/plugin2/liveconnect/LiveConnectTests/ TEST=LayoutTests\plugins\netscape-construct.html Review URL: http://codereview.chromium.org/113823 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16979 0039d316-1c4b-4281-b951-d872f2087c98
* Create OpenClose browser test for TaskManager with necessary refactoring.phajdan.jr@chromium.org2009-05-275-8/+31
| | | | | | | | http://crbug.com/12320 Review URL: http://codereview.chromium.org/113636 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16978 0039d316-1c4b-4281-b951-d872f2087c98
* Do not monitor system power state during unit tests.phajdan.jr@chromium.org2009-05-271-0/+5
| | | | | | | | | | | | | The observer requires that message loop stays up and same through its lifetime. This is not true during testing. TEST=none http://crbug.com/12187 Review URL: http://codereview.chromium.org/113824 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16976 0039d316-1c4b-4281-b951-d872f2087c98
* Show Unicode IDNs for "On startup" setting and "Add page" dialog for it.jungshik@google.com2009-05-272-3/+12
| | | | | | | | | | | | | | | | | TEST=visit an IDN URL, and open the "Basics" tab of the "Options" dialog, select "Open the following pages", press "Add..." button, select the IDN URL, and confirm that the URL field is shown in Unicode, or paste a Punycode URL to the URL field of the "Add page" dialog, press "Add" button, and confirm that the "Open the followig pages" list shows the Unicode URL. http://crbug.com/3991 Patch by tkent Original review: http://codereview.chromium.org/115759 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16974 0039d316-1c4b-4281-b951-d872f2087c98
* For "Copy link address" context menu, copy the URL with Unicode host namejungshik@google.com2009-05-271-27/+27
| | | | | | | | | | | | | | instead of Punycode host name. http://crbug.com/4008 TEST="Copy link address" copies Unicode host name for both of <a href="punycode URL"> and <a href="Unicode URL"> if Accept-Language preference is matched. Patch by tkent Original review: http://codereview.chromium.org/115752 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16973 0039d316-1c4b-4281-b951-d872f2087c98