| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Also add a unit test to make sure the change processor does not explode when it sees updates from the cloud to a preference it does not know about.
BUG=44714
TEST=unit
Review URL: http://codereview.chromium.org/2805077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
A new ClipboardDispatcher interface has been added to handle the IPC calls. The new methods don't really belong on the existing Clipboard class, since that class deals with only copy and paste. On Windows and Mac, ClipboardDispatcher will share logic for copy/paste and drag/drop. GTK will have to use two separate code paths.
BUG=31037
TEST=none
Review URL: http://codereview.chromium.org/2842016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45811
TEST=(This is adding a test to browser_tests)
Review URL: http://codereview.chromium.org/2841037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51788 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Hold the reload button state change from stop to reload until the
mouse exits. Also short-circuit the stop message when the real state
should be reload. Also prevent multi-clicks from sending multiple
actions.
Toolbar.xib: reload button made kind of ReloadButton.
BUG=47184
TEST=Browse to a slow page, mouse over stop button. Should not go to reload button when throbber (in tab) stops.
TEST=After page loaded, click stop. Should not crash.
TEST=Hover over reload button. Command-r should start a reload and change the button to stop button.
Review URL: http://codereview.chromium.org/2847051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Non-blocking version of init is now being called, and asynchronous set/get of mute and volume is implmenented at PulseAudioMixer level.
The logic has been updated in SystemKeyEventListener so that the audio key behavior follows the latest doc 'Chrome OS Audio Scenarios':
Increase volume key: unmutes aduio if muted, otherwise increases volume.
Decrease volume key: do nothing if muted, otherwise decrease volume.
Mute volume key: always mutes volume.
UI is displayed after any volume key press.
Currently only the init is being called asynchronously, but the next step will be to add a call allowing asynchronous operation of the volume adjust/unmute sequence from SystemKeyEventListener, and move the ShowVolumeBubble() calls into AudioHandler so that the volume bubble will update once the calls complete on their own thread.
Patch by davej@chromium.org:
http://codereview.chromium.org/2769008/show
BUG=2910
Test=Play video or audio in ChromeOS, and press the system volume up, down, and mute keys to see they follow the above behavior. Alternating Mute and Increment Volume presses should always bring the volume back to the same level and not creep it upwards.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Handles to the sync socket should be released. The leak of 4 bytes apprantly
is the leaked SyncSocket object.
BUG=51743
TBR=cbentzel
Review URL: http://codereview.chromium.org/2818047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also, do not attempt to collect any stability metrics on Mac -- they are not used.
Review URL: http://codereview.chromium.org/2842046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Right now the accessibility tree is shipped over at page load, so this doesn't account for any changes to the html, or scrolling/resizing.
BUG=27112
TEST=Use accessibility inspector to inspect various elements of the webpage.
Review URL: http://codereview.chromium.org/2642001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
suppressions for supposedly-fixed bugs.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2825040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
After fixing the contextmenu event in WebKit we can no longer rely on the bug/hack/feature that screenX was 0 when the event was generated using the keyboard. We now keep track of keydown and keyup and if the right key was down then we know it was a context menu generated by the keyboard.
BUG= 40073
TEST=Select an bookmark item (or a folder in the bookmark tree). Press Shift+F10. The context menu should be positioned relative to the selected item.
Review URL: http://codereview.chromium.org/2845042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Verify chrome:options loads when using --enable-tabbed-options.
Review URL: http://codereview.chromium.org/2888007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. borders of buttons were drawn incorrectly.
. I was repainting the correct bounds, resulting in mouse hover
effects not showing up correctly.
BUG=48012
TEST=see bug
Review URL: http://codereview.chromium.org/2845040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Otherwise it may access a freed URLRequest.
R=agl
BUG=48210
TEST=close tab while certificate selection dialog is open, then submit
Review URL: http://codereview.chromium.org/2858047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
now missing chrome_frame.release, it should be looking for chrome.release. This fixes a breakage introduced with r51729.
BUG=46818
TEST=none
TBR=pkasting
Review URL: http://codereview.chromium.org/2877013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51771 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- All checkboxes are functional, partial functionality for buttons.
- Download path controls TBD.
- Security SSL checkboxes on non-Mac platform TBD.
- Added placeholder files for Browser and Personal option panels.
- Moved placeholder CSS into a new options_page.css file.
- Unit testing TBD.
BUG=48482
TEST=Launch browser with --enable-tabbed-options and bring up options window.
Review URL: http://codereview.chromium.org/2830036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cookies related to URL (found by inspection.) Also changed name
and semantics to more closely reflect usage of primary caller (extension
data deleter), and added test for that set of semantics.
BUG=none
TEST=Linux CookieMonsterTest.*:ParsedCookieTest.* (especially new CookieMonsterTest.DeleteAllHost)
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51544
Review URL: http://codereview.chromium.org/2857029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none (or is there?)
TEST=trybots and tests
Review URL: http://codereview.chromium.org/2234006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
when using the History menu, rather than always (mistakenly) restoring the first one.
BUG=47779
TEST=Open a new window, navigate three tabs. Close the window. Select History-->3 Tabs and then choose the middle tab. It is restored properly.
Review URL: http://codereview.chromium.org/2802029
TBR=rsesek@chromium.org
Review URL: http://codereview.chromium.org/2806051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=cbentzel
BUG=48483
TEST=none
Review URL: http://codereview.chromium.org/2857038
TBR=tonyg@chromium.org
Review URL: http://codereview.chromium.org/2803039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
redirects to "chrome-extension://" pages) and mine to make it work in M6 (which
fires an update event when "chrome.tabs.create" is called).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2800034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=cbentzel
BUG=48483
TEST=none
Review URL: http://codereview.chromium.org/2857038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
History menu, rather than always (mistakenly) restoring the first one.
BUG=47779
TEST=Open a new window, navigate three tabs. Close the window. Select History-->3 Tabs and then choose the middle tab. It is restored properly.
Review URL: http://codereview.chromium.org/2802029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
proxy should keep retrying and shall not proceed further.
BUG=none
TEST=Check that proxy does not re-register printers if server request to get printers list times out.
Review URL: http://codereview.chromium.org/2858045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crosbug.com/2951
TEST=The name of the UK keyboard layout should be "English (UK) keyboard layout"
Review URL: http://codereview.chromium.org/2810049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change will move all the audio device methods calls to
AudioController so we can move all the audio related methods calls off the IO
thread. This change will let AudioRendererHost to use the AudioController API.
This involves rewriting the whole AudioRendererHost.
After this patch we can implement proper pause operations that is only possible
if they are hosted on a separated thread due to their blocking nature.
Normal latency mode is fully covered by unit tests, including audio control
operations and data conversation.
Low latency mode using SyncSocket is tested only for stream creation and still
need to handle cases during shutdown when we want SyncSocket to return
immediately.
TEST=unit_tests --gtest_filter=AudioRendererTest.*
BUG=39885
Review URL: http://codereview.chromium.org/2850016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=tonyg
BUG=48475
TEST=none
Review URL: http://codereview.chromium.org/2850047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This logs to both LOG(INFO), and also to the NetLog (about:net-internals).
BUG=46822
Review URL: http://codereview.chromium.org/2815046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=48093
TEST=tested that plugin doesn't load w/o --enable-chromoting.
Review URL: http://codereview.chromium.org/2818043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
correct icon (http://cl.ly/97c1b5e22eb32075d497).
Still to be done:
o there should be a much smaller overlap of app tabs with other tabs.
o The toolbar should hide when necessary.
o The context menu for the tab should have the option of hiding/showing the toolbar on a per-app basis.
TEST=none
BUG=45539
Review URL: http://codereview.chromium.org/2847052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
These changes merge popup menu suggestions for Autocomplete and AutoFill. Suggestions are collected from both sources and returned to the renderer as a single list. This combined list is given to WebKit to display in the suggestions popup. When the user selects an item in the popup the appropriate result gets filled in the fields.
BUG=41328
TEST=AutoFillManagerTest.*
Review URL: http://codereview.chromium.org/2878020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2800035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
PanelController::TitleMousePressed.
http://code.google.com/p/chromium-os/issues/detail?id=4255
BUG=chromium-os:4255
TEST=See Issue for repro
Review URL: http://codereview.chromium.org/2834037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=44602
Based on a patch from Giuseppe Iuculano <giuseppe@iuculano.it>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
be registered (and thus used) if the installer is run with the --chrome-frame flag.
Remove a bunch of CF-specific code in the process.
BUG=46818
TEST=Can use the same mini_installer.exe to install either Chrome or Chrome Frame.
Review URL: http://codereview.chromium.org/2839009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=open New Tab page, see thumbnails. Same with chrome --top-sites.
Review URL: http://codereview.chromium.org/2815045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=48227
TEST=none
Review URL: http://codereview.chromium.org/2888005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
perfect yet).
Trigger OnBackendInitialized when the syncable::Directory is opened, and cue the DataTypeManager when that happens.
Fix a bug where entering the wrong password on re-login UI results in inability to log in to sync forever, as the UI gets stuck in the "Authenticating...' state.
Overhaul the tests to
1) actually use the abstract superclass and not copy/paste the same code (and redefine the same variables, shadowing protected ones in the super!),
2) to not use two SyncBackendHost objects, which makes it really confusing to follow what's happening,
3) not rely on anonymous OnStateChanged() notifications to perform crucial init tasks (which was also really confusing and brittle) by either a) removing the need to listen altogether, or b) listen for specific notifications.
4) unify root node creation, and
5) kill verbose and self proclaimed "uninteresting" gmock output.
BUG=47957
TEST=unit_tests (ProfileSync*)
Review URL: http://codereview.chromium.org/2834032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tab is already closing it's possible for the tab to no longer contain
the coordinates of the release event. I've changed it so that if the
tab is closing and the tab doesn't contain the mouse on the release
event we see if another tab does and if so close it.
BUG=48209
TEST=none
Review URL: http://codereview.chromium.org/2841038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
nested tasks as in some situations the menu may be shown when the
message loop is processing a task. If the message loop is processing a
taskand we don't set nested tasks allowed to true then none of the
tasks scheduled by the menu (paints, delays...) are processed and the
menu appears totally broken.
BUG=48102
TEST=give focus to the page, press alt-f, press arrow keys and make
sure the menu updates appropriately.
Review URL: http://codereview.chromium.org/2836044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2813045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
of a setting.
BUG=none
TEST=none.
Review URL: http://codereview.chromium.org/2858048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45230
TEST=none
Review URL: http://codereview.chromium.org/2818046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, re-enable DefaultPluginUITest.DefaultPluginLoadTest.
BUG=48388,46662
TEST=DefaultPluginUITest.DefaultPluginLoadTest
Review URL: http://codereview.chromium.org/2854041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in order to fully support Windows screenreaders.
Note: it makes sense to check these files into third_party
directly (rather than pull from Mozilla's repository) because
(1) they're very small (under 500 lines total), and
(2) they're stable and unlikely to change frequently.
BUG=48185
TEST=none
Review URL: http://codereview.chromium.org/2802031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=39813
TEST=translate infobars should have a very light gray gradient background.
Review URL: http://codereview.chromium.org/2814049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
function.
BUG=chromium-os:4575
TEST=see the bug
Review URL: http://codereview.chromium.org/2884017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Obviously we don't have to write an error log when |type| is kKeyboardLayoutsOnly.
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/2871037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:4570
TEST=started ibus-chewing, toggled properties, then verified there were no errors in /home/chronos/chrome_log.
Review URL: http://codereview.chromium.org/2836049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2805074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51696 0039d316-1c4b-4281-b951-d872f2087c98
|