summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Refactors code for showing bookmarks menus into a standalone classsky@google.com2009-03-129-384/+570
| | | | | | | | | | | | | | | that isn't tied to the bookmark bar. Removes some dead code from the bookmark bar, and fixes a UMR in chrome_menu that I found when running under purify. There isn't any behavior change in this patch. BUG=none TEST=this is a large refactoring of how bookmark menus are shown. Please thoroughly test menus on the bookmark bar to make sure I didn't screw anything up. Review URL: http://codereview.chromium.org/42128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11558 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome-side changes to use registerURLSchemeNoAccess.darin@chromium.org2009-03-121-1/+7
| | | | | | | | R=dglazkov Review URL: http://codereview.chromium.org/42125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11555 0039d316-1c4b-4281-b951-d872f2087c98
* Make toggling fullscreen mode on/off significantly less janky-looking by ↵pkasting@chromium.org2009-03-125-16/+69
| | | | | | | | means of various crazy hacks. Review URL: http://codereview.chromium.org/42106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11550 0039d316-1c4b-4281-b951-d872f2087c98
* fix gyp file, quote mismatch.tc@google.com2009-03-121-3/+3
| | | | | | | | | TBR=nsylvain Review URL: http://codereview.chromium.org/42135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11547 0039d316-1c4b-4281-b951-d872f2087c98
* fix linux build. we need to include basictypes.h to gettc@google.com2009-03-121-0/+1
| | | | | | | | | | | DISALLOW_COPY_AND_ASSIGN TBR=finnur Review URL: http://codereview.chromium.org/43140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11545 0039d316-1c4b-4281-b951-d872f2087c98
* Some work in refactoring FindBarWin/FindBarView sotc@google.com2009-03-1215-216/+470
| | | | | | | | | | | we can share code across platforms. See http://code.google.com/p/chromium/wiki/FindBarRefactoring for more information about the design. Review URL: http://codereview.chromium.org/42057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11544 0039d316-1c4b-4281-b951-d872f2087c98
* Add a TabController class to manage a TabView (with corresponding xib). ↵pinkerton@chromium.org2009-03-129-45/+653
| | | | | | | | Rewrite strip controller to create and manage TabControllers instead of NSButtons. Review URL: http://codereview.chromium.org/43137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11541 0039d316-1c4b-4281-b951-d872f2087c98
* Update known crashes.patrick@chromium.org2009-03-121-2/+14
| | | | | | Review URL: http://codereview.chromium.org/42124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11540 0039d316-1c4b-4281-b951-d872f2087c98
* Redisable the java test. Even though the machine wasnsylvain@chromium.org2009-03-121-1/+2
| | | | | | | | | trying to autoupdate, it looks like this was not the cause of the failure. Review URL: http://codereview.chromium.org/42126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11538 0039d316-1c4b-4281-b951-d872f2087c98
* Have RenderWidgetHostViewGtk take ownership of its widget.deanm@chromium.org2009-03-121-0/+5
| | | | | | | | | | | We previously left the widget floating, the reference would be sunk by the first container it was added to, if removed from this container it would be destroyed. This was happening in WebContentsViewGtk, and then we were double-destroying the widget in RenderWidgetHostViewGtk::Destroy(). BUG=8707 Review URL: http://codereview.chromium.org/42119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11530 0039d316-1c4b-4281-b951-d872f2087c98
* Hookup the escape key on Linux Omnibox to revert to the permanent text (like ↵deanm@chromium.org2009-03-121-2/+7
| | | | | | | | | | | Windows). BUG=8236 Review URL: http://codereview.chromium.org/42074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11529 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a Linux Omnibox bug where a widget was used after it was destroyed.deanm@chromium.org2009-03-121-0/+4
| | | | | | | Review URL: http://codereview.chromium.org/42073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11528 0039d316-1c4b-4281-b951-d872f2087c98
* Better keyboard and mouse handling in Omnibox:deanm@chromium.org2009-03-122-33/+64
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Grab enter key events before they get to GtkTextView. We need to do this, otherwise enter when text is selected will replace the text, and we won't get a chance to catch that happening. This might have problems with IME, but it should be straightforward to fix anything IME related. - Don't deselect when we lose focus. This sometimes looks a bit strange, but it's the GTK thing to do. This also unbreaks copy and paste via the context menu, since popping up the context menu makes the GtkTextView lose focus. - Rewrite the inefficent newline eater. This should now only be needed for newlines that didn't come from the keyboard (like when you paste text). Use the builtin iter support for finding line boundaries, hopefully more efficient than checking the characters one by one. Still might have some bad behavior when pasting a ton of newline characters, but that can be improved later. This fixes inline autocomplete, you can now hit the enter key on an inline autocompleted suggestion, and you will get the intented navigation, instead of the navigation with the selected completion removed. This also adds support for alt-enter in Omnibox to navigate in a new tab. BUG=8236 Review URL: http://codereview.chromium.org/43072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11527 0039d316-1c4b-4281-b951-d872f2087c98
* Add a GDK_COLOR_RGB macro for constructing GdkColors.deanm@chromium.org2009-03-123-7/+10
| | | | | | | | | This does the simple math of * 257 to map from a 1 byte component to the gint16 GdkColor values, and initializes the pixel field to 0. Review URL: http://codereview.chromium.org/43077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11526 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that a listener's OnChannelConnected is called before OnMessageReceived.jam@chromium.org2009-03-123-22/+20
| | | | | | | | | | | | A race condition existed since the listener thread could dispatch messages in two ways: a task being posted to it, or because the dispatch messages event is set. The latter is needed to avoid deadlock when multiple SyncChannels are used on the same listener thread. If the latter method was used to dispatch a message, it might occur before the task that calls OnChannelConnected gets run. The fix is to call OnChannelConnected manually if we notice a message is being dispatched before it's called. Note: I couldn't think of a way to test this since it depends on a race condition in the listener message looop (whether the task or objectwatcher gets run first). Review URL: http://codereview.chromium.org/42113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11522 0039d316-1c4b-4281-b951-d872f2087c98
* Pointing slns at generated vcprojs from base.bradnelson@google.com2009-03-121-1291/+2002
| | | | | | Review URL: http://codereview.chromium.org/42047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11520 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable java plugin test (reverting 11510)jar@chromium.org2009-03-121-2/+1
| | | | | | | | | | | The bot was trying to auto-update... and no one was clicking "yes." bug=8690 tbr=brettw Review URL: http://codereview.chromium.org/42112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11517 0039d316-1c4b-4281-b951-d872f2087c98
* Add more info to a dcheck to see why DuplicateHandle is failing on the buildbot.jam@chromium.org2009-03-121-1/+2
| | | | | | Review URL: http://codereview.chromium.org/42109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11514 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug were sorting bookmarks wouldn't trigger a save.sky@google.com2009-03-121-0/+3
| | | | | | | | | BUG=8655 TEST=see bug Review URL: http://codereview.chromium.org/42103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11513 0039d316-1c4b-4281-b951-d872f2087c98
* Restore bretts change (reverting 11506) and disabling java testjar@chromium.org2009-03-121-1/+2
| | | | | | | tbr=brettw Review URL: http://codereview.chromium.org/43118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11510 0039d316-1c4b-4281-b951-d872f2087c98
* Stop having renderers use both pids and a monotonically increasing ↵jam@chromium.org2009-03-1230-227/+212
| | | | | | | | "host_id". This allows ResourceDispatcher to be used by child processes other than renderers. I've done minor related cleanup on the way to make the code simpler. Review URL: http://codereview.chromium.org/42054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11509 0039d316-1c4b-4281-b951-d872f2087c98
* Rollback 11498jar@chromium.org2009-03-121-2/+1
| | | | | | | | | | | It may be nicer to just have teh java test failing than all the tests. Perhaps teh memory ordering is causing this... as the new (large set of) failing test run before the disabled java test. tbr=brettw Review URL: http://codereview.chromium.org/43117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11506 0039d316-1c4b-4281-b951-d872f2087c98
* - Add UI test for DOM checker.patrick@chromium.org2009-03-129-58/+316
| | | | | | | | | | | | - Modify DOM checker to work with the UI test framework. - Add expected failure list for DOM checker. Note that this only runs the tests over HTTP, not file:///. BUG=6274 Review URL: http://codereview.chromium.org/43029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11505 0039d316-1c4b-4281-b951-d872f2087c98
* Make fullscreen exit bubble link work by preventing the bubble from ever ↵pkasting@chromium.org2009-03-122-5/+25
| | | | | | | | | being activated. Not sure why this worked in the first place and then regressed. BUG=8318 Review URL: http://codereview.chromium.org/43107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11503 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unneeded includes of googleurl/src/url_parse.h and url_canon.h.thestig@chromium.org2009-03-123-3/+3
| | | | | | Review URL: http://codereview.chromium.org/42102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11502 0039d316-1c4b-4281-b951-d872f2087c98
* Moving the storing/restoring of the focus from TabContents to ↵jcampan@chromium.org2009-03-1219-149/+186
| | | | | | | | | | | | WebContentsView. This makes TabContents less dependent on views. This requires few contortions with DOMUIs (NTP, history and downloads tab) as they still need to set the initial focus specifically. BUG=None TEST=Run the interactive tests. Review URL: http://codereview.chromium.org/39269 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11501 0039d316-1c4b-4281-b951-d872f2087c98
* Diable a failing test. This seems to be related to the WebKit merge 41559:41588brettw@chromium.org2009-03-121-1/+2
| | | | | | Review URL: http://codereview.chromium.org/43111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11498 0039d316-1c4b-4281-b951-d872f2087c98
* Allow passing in package version info, since it's already calculated by themmoss@chromium.org2009-03-112-72/+56
| | | | | | | | | buildbot scripts. Review URL: http://codereview.chromium.org/42095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11489 0039d316-1c4b-4281-b951-d872f2087c98
* Bring over more code from cole to improve the appearance of tabs. Start ↵pinkerton@chromium.org2009-03-112-107/+145
| | | | | | | | building parts of GTM that are needed for theming. Review URL: http://codereview.chromium.org/42081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11482 0039d316-1c4b-4281-b951-d872f2087c98
* My change to widen the About box got reverted for the Hebrew locale. Readding.finnur@chromium.org2009-03-111-1/+1
| | | | | | | | | BUG=8676 TEST=Open About box in Hebrew and make sure it is not truncating the text. Review URL: http://codereview.chromium.org/43099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11478 0039d316-1c4b-4281-b951-d872f2087c98
* Enable building of browser/debugger/debugger_{contents,shell}.cc on Linux.sgk@google.com2009-03-113-20/+26
| | | | | | | | | This required getting rid of the stubs in common/temp_scaffolding_stubs.cc to avoid duplicate symbols, in favor of moving the stubs into a separate module for use when porting to new platforms. Review URL: http://codereview.chromium.org/43089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11477 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 11467.mpcomplete@google.com2009-03-113-12/+1
| | | | | | Review URL: http://codereview.chromium.org/43093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11471 0039d316-1c4b-4281-b951-d872f2087c98
* Inform google_update that the user has acepted the EULAcpu@google.com2009-03-115-9/+33
| | | | | | | | | | - reg key lives in hklm but we can write it BUG=b/1594565 Review URL: http://codereview.chromium.org/43061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11469 0039d316-1c4b-4281-b951-d872f2087c98
* Getting rid of dead code.pinkerton@chromium.org2009-03-111-12/+2
| | | | | | Review URL: http://codereview.chromium.org/43090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11468 0039d316-1c4b-4281-b951-d872f2087c98
* Try to make ExtensionViewTest less flaky by running it in single-process mode.mpcomplete@google.com2009-03-113-1/+12
| | | | | | Review URL: http://codereview.chromium.org/42055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11467 0039d316-1c4b-4281-b951-d872f2087c98
* Change to make the 'save as...' dialog choose the default download path you ↵maruel@chromium.org2009-03-111-3/+12
| | | | | | | | | | | | | have selected in your prefs instead of always choosing the chrome::DIR_DEFAULT_DOWNLOADS path. This will only affect you if you have not used 'save as...' before and do not have a SaveFileDefaultDirectory set. Patch contributed by Paul Robinson <paulRobinson85@googlemail.com> BUG=8049 Review URL: http://codereview.chromium.org/43016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11465 0039d316-1c4b-4281-b951-d872f2087c98
* Add new browser/gtk/find_bar_gtk.{cc,h} files to gyp build.sgk@google.com2009-03-111-0/+2
| | | | | | Review URL: http://codereview.chromium.org/42079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11464 0039d316-1c4b-4281-b951-d872f2087c98
* Add hanging test to Purify gtest filter file. Report location of filter filepam@chromium.org2009-03-111-0/+2
| | | | | | | | | | in Purify script, for convenience. BUG=7810 TEST=covered by buildbot Review URL: http://codereview.chromium.org/42082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11463 0039d316-1c4b-4281-b951-d872f2087c98
* Fix directory listings in mac and linux by making sure the codetc@google.com2009-03-112-5/+4
| | | | | | | | | for loading the template is enabled and the resource exists. Review URL: http://codereview.chromium.org/42053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11462 0039d316-1c4b-4281-b951-d872f2087c98
* Hopefully make DownloadTest.UnknownSize not-flaky.phajdan.jr@chromium.org2009-03-112-6/+5
| | | | | | | | http://crbug.com/7191 Review URL: http://codereview.chromium.org/43046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11459 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r11445, _wtoi does not exist outside of Windows / MSVC.deanm@chromium.org2009-03-111-13/+4
| | | | | | | Review URL: http://codereview.chromium.org/42072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11448 0039d316-1c4b-4281-b951-d872f2087c98
* Add a couple more unit tests to the Mac buildpinkerton@chromium.org2009-03-113-7/+3
| | | | | | Review URL: http://codereview.chromium.org/43076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11446 0039d316-1c4b-4281-b951-d872f2087c98
* I was a moron and did http://codereview.chromium.org/40012/ against a read ↵davemoore@chromium.org2009-03-111-4/+13
| | | | | | | | | only repository. TBR: jrg Review URL: http://codereview.chromium.org/42071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11445 0039d316-1c4b-4281-b951-d872f2087c98
* Initial pass at copy/paste. Menu items are always enabled. This matches ↵avi@chromium.org2009-03-113-9/+37
| | | | | | | | Windows; we'll do better soon. Review URL: http://codereview.chromium.org/42018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11444 0039d316-1c4b-4281-b951-d872f2087c98
* Reenable incremental linking for most projects except the largest ones. Will ↵maruel@chromium.org2009-03-114-1/+4
| | | | | | | | fix later. Review URL: http://codereview.chromium.org/42016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11440 0039d316-1c4b-4281-b951-d872f2087c98
* net_resources unforkthomasvl@chromium.org2009-03-111-7/+5
| | | | | | | | | | | | - bring the rules for grit all in align for common style/dir names. - make the mac build net:net_resource (was win/linux only) - ripple the mac dep upstream - merge net_resource into the chrome repack more work is needed on the mac side, we aren't really using the new resources yet, but this is a clean landing point. Review URL: http://codereview.chromium.org/45001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11438 0039d316-1c4b-4281-b951-d872f2087c98
* Remove TabContents from scaffolding. Yay!pinkerton@chromium.org2009-03-1115-172/+33
| | | | | | Review URL: http://codereview.chromium.org/43039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11435 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some empty source files from the tree.deanm@chromium.org2009-03-117-2/+0
| | | | | | | | | It looks like these were originally meant to be deleted, but instead all of their lines were removed and the empty file was left behind. Review URL: http://codereview.chromium.org/43021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11434 0039d316-1c4b-4281-b951-d872f2087c98
* The video renderer actually color converts. This is the last change that ↵ralphl@chromium.org2009-03-111-4/+17
| | | | | | | | should be required to actually get the renderer to display frames. Review URL: http://codereview.chromium.org/43051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11428 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the distributor logo placement on the glass frame.ben@chromium.org2009-03-114-6/+37
| | | | | | | | | | The window's control bounds can change independently of window sizing messages (WM_SIZE), and so we need to make sure that we always call Layout on the frame view and the client view, even if the bounds of the window don't change so that we are more likely to update the layout of the distributor logo. http://crbug.com/8511 Review URL: http://codereview.chromium.org/42061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11424 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-11 13:56:16 +0000