| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
BUG=25354
Review URL: http://codereview.chromium.org/345023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Surprisingly, this is not a tab-modal sheet on linux and windows, so it's window-modal on os x as well for now.
BUG=23526
TEST=Go to http://www.cs.unc.edu/~jbs/resources/perl/perl-cgi/programs/form1-POST.html , click "Do it!", hit reload. Window sheet should come up. Hitting cancel should cancel the navigation (and hitting reload again should bring up sheet again). Hitting "Resend" should trigger reload.
Review URL: http://codereview.chromium.org/327009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
chromium_strings rather than google_chrome_strings, although I doubt it would matter.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/343050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is an experiment to see the current status of
the test.
BUG=13921
TEST=warm perf load test is greenish
Review URL: http://codereview.chromium.org/342045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=19980
TEST=See the steps in the bug description.
Patch by Randy Posynick<randy.posynick@gmail.com>
http://codereview.chromium.org/287008
Review URL: http://codereview.chromium.org/339075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/341044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=19852
TEST=See repro steps of the bug
Patch by Bruno Calvignac <BrunoCalvignac@gmail.com>
Original CL http://codereview.chromium.org/282004
Review URL: http://codereview.chromium.org/342046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=23865
Review URL: http://codereview.chromium.org/341025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Since bug 24721 is fixed, these might work again. They don't show up on the flakiness dashboard, suggesting that they behaved for a while.
BUG=24632,24889
TEST=Tests not super flaky
Review URL: http://codereview.chromium.org/345024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We now always walk the last active list backwards rather than consulting the last active then walking the registered browser list forwards.
This ensures that when the last active browser is a popup or app frame the last active TYPE_NORMAL browser is located when opening a new tab.
http://crbug.com/17498
TEST=Open an app frame. Open a browser window (Ctrl+N) and load a page. Minimize it. Open another browser window and minimize it. Activate the app frame. Press Ctrl+T. The second browser window should be restored and have a new tab added to it rather than the first.
Review URL: http://codereview.chromium.org/330013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Always intialize the css cache. Previously we were only
initializing if not in incognito mode. If the first NTP was an
incognito page, it wouldn't be styled.
2) Small optimization in generating the HTML to avoid calling
ReplaceFirstSubstringAfterOffset which would need to move the
bytes after the placeholder.
3) Only generate the css for the incognito or normal mode. Since
the NTP only needs one, we only need to generate one.
BUG=26228
Review URL: http://codereview.chromium.org/344027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/346015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/337010/show/.
BUG=25099
TEST=See 337010.
Review URL: http://codereview.chromium.org/343042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=26239
TEST=launch browser, look at border under toolbar, open findbar
Review URL: http://codereview.chromium.org/339074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- Fix extension_service_unittest to actually load extensions from prefs.
BUG=19733
TEST=Remove extension manifest from Preferences file. Extension shouldn't load even if the necessary files are present.
Review URL: http://codereview.chromium.org/339058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30521 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Thiago Farina (see http://codereview.chromium.org/347020 ), r=me, tweaked.
BUG=21317
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Minor position changes to the CSS to make the page
match the other pages better when flipping
betwen the downloads, history and extensions page.
BUG=http://crbug.com/26120
TEST=Flip between History and Downloads page and
the icon and the header section should line up
and be the same size on all three pages.
Review URL: http://codereview.chromium.org/339073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30518 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/342041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
using WebCore internals in glue anyway.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/342032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=26173
Review URL: http://codereview.chromium.org/345022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
user's list too if they haven't edited it or made it default.
BUG=none
TEST=Covered by unittest
Review URL: http://codereview.chromium.org/339071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Remove Browser::find_bar(), make everyone use either Browser::GetFindBarController() which creates the FindBarController on demand, or a new method HasFindBarController(), which can be used to check for its existence (so as to avoid creating it unnecessarily).
http://crbug.com/26231
TEST=interactive ui tests, standard find tests
Review URL: http://codereview.chromium.org/348015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Patch from Kelly Norton <knorton@google.com>
TBR=mpcomplete@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=24430
TEST=Right click a mailto:foo@bar.com link on a page, select Copy email
address. Make sure the clipboard contains foo@bar.com and no mailto:
prefix.
Review URL: http://codereview.chromium.org/342031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes us fire both the old deprecated style of pageActions click handler and the new pageAction style.
BUG=25833
TEST=none
Review URL: http://codereview.chromium.org/346006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
itself as incorrect ClearType edges.
The problem was that we were taking into account the translation from the page
coordinate system when blitting the background, but this had already been
accounted for in the transformation matrix, resulting in duplicate
transformations.
The fix simplifies the code by not tranlating into the page coordinate system
until later, staying in the plugin coordinate system which is more convenient.
This means that the background (which is the same size as the buffer) can just
be painted at (0,0) with no fuss and no muss. We don't even need to worry about
how much we paint since the clip was already installed.
This also corrects some indenting in browser.cc that I noticed.
TEST="Attach a file" text in Gmail compose looks weird (sometimes requires
selecting it to make this happen).
BUG=26080
Review URL: http://codereview.chromium.org/343040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/340004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change adds 2 new menu items to the option menu.
There is pref migration code to make tips and sync visible by default.
BUG=24319
TEST=Hide and show the different sections and reload to make sure it
is persisted across instances of NTP.
Review URL: http://codereview.chromium.org/337011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
hardware acceleration on the Mac.
BUG=25406, 25092
TEST=Flash should no longer crash immediately after loading on
sites with complex Flash applications.
Review URL: http://codereview.chromium.org/339068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
time_posix.cc has the actual code and compiles on Linux
already. Including both files causes linker errors for
the shared build.
BUG=none
TEST=compiles on trybots
Review URL: http://codereview.chromium.org/341035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
StringPiece as the format string instead. This allows us to save
a string copy in the new tab page.
Also clean up some code in the extensions process binding that
was doing excess string conversions.
BUG=26228
Review URL: http://codereview.chromium.org/347019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
comparing signed and unsigned values.
BUG=tree break
TEST=none
Review URL: http://codereview.chromium.org/339070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
cross-platform.
BUG= none
TEST= bug reporting should work the same on Windows.
Review URL: http://codereview.chromium.org/339051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
it may not be what we think it is.
BUG=23157
TEST=context menus in the web content area, esp rapid right-click and dragging.
Review URL: http://codereview.chromium.org/344024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23978
TEST=Added unit test
Review URL: http://codereview.chromium.org/343041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=26025
Review URL: http://codereview.chromium.org/343028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=26024
Review URL: http://codereview.chromium.org/347015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The bubble was showing at the same time as the installation confirmation dialog for non-theme extensions.
BUG=26130
Review URL: http://codereview.chromium.org/339055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=26231
TEST=Interactive Tests bot green-ness
Review URL: http://codereview.chromium.org/342038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
left out for try-server incompatibility with binary files.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/348013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
broadly usable. Patch by Thiago Farina (see http://codereview.chromium.org/328031 ), r=me.
BUG=21317
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=24679
TEST=Mouse down on a tab, then press ctrl+w. This should not result in a dangling pointer in the MessagePump's ObserverList.
Review URL: http://codereview.chromium.org/340028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to display toasts on the screen, and manager for controlling the layout of the balloons.
BUG=none
TEST=none yet (part of larger patch)
Review URL: http://codereview.chromium.org/338051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/345009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=26213
Review URL: http://codereview.chromium.org/346014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30468 0039d316-1c4b-4281-b951-d872f2087c98
|