| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
startup without doing the cocoa locale force (since it isn't valid there).
BUG=none
TEST=ntp tips, history times stamps, etc. all still in the right locale
Review URL: http://codereview.chromium.org/449076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
bindings patch has been landed that should take care of this one.
BUG=29041
TEST=none
Review URL: http://codereview.chromium.org/459014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
than Chromium specific, and clean up a few headers.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/449048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=thestig
Review URL: http://codereview.chromium.org/459013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=sky
Review URL: http://codereview.chromium.org/463003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=sky
Review URL: http://codereview.chromium.org/459012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/457025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=gregoryd
Review URL: http://codereview.chromium.org/459011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=gregoryd
Review URL: http://codereview.chromium.org/455028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of resource loading from WebKit into the network stack.
In order to fully make these work, webkit changes are needed
as well.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/452033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
declaration order.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/460008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=trybots
Review URL: http://codereview.chromium.org/462001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of storing pointers into a vector, store offsets. That
way, if the vector resizes, we should still be OK.
Also, add a DCHECK that we only enter this method once, which
is my current assumption.
Review URL: http://codereview.chromium.org/457028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=trybots
Review URL: http://codereview.chromium.org/460006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG= 28196
TEST= "make this my home page" should show up as a tip.
Review URL: http://codereview.chromium.org/449073
TBR=mirandac@chromium.org
Review URL: http://codereview.chromium.org/460007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=29149
Review URL: http://codereview.chromium.org/460005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33537 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28276
TEST=dump_syms works with ToT Chrome.
Review URL: http://codereview.chromium.org/414049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
changes for a child window of the popup, as it is the case
with select popups.
BUG=28110
TEST=Make sure extension popups are still working as expected.
Open an extension popup with a select popup (combo box)
in it. Click on the select to bring up its popup, the
extension popup should stay opened.
Review URL: http://codereview.chromium.org/459005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
collection.
BUG=28884
Review URL: http://codereview.chromium.org/455026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were accidentally setting the opacity to 1/255.
This bug was introduced in r32643. Fix the unittest too.
BUG=29107
Review URL: http://codereview.chromium.org/461003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
accidentally
setting the opacity to 1/255.
This bug was introduced in r32643.
BUG=29107
Review URL: http://codereview.chromium.org/452040
TBR=tony@chromium.org
Review URL: http://codereview.chromium.org/460004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= 28196
TEST= "make this my home page" should show up as a tip.
Review URL: http://codereview.chromium.org/449073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
setting the opacity to 1/255.
This bug was introduced in r32643.
BUG=29107
Review URL: http://codereview.chromium.org/452040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://code.google.com/p/chromium/issues/detail?id=29025
The crash occurs while dereferencing the automation channel to send out the SetCookie IPC message on the
automation channel to the host browser. Based on what I could see from the crash dump and the code
it seems like there could be a scenario where the AutomationResourceContext object could be destroyed
while the AutomationCookieStore object is still around and thus ends up with a stale pointer which crashes
when dereferenced.
Fix is to ensure that all related code paths hold on to a refcounted AutomationResourceContext instance.
I will look into whether it is possible to come up with a unit test for this.
Bug=29025
Review URL: http://codereview.chromium.org/450020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=29096
Review URL: http://codereview.chromium.org/450043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
bookmark manager and bookmark bar.
BUG=29029
TEST=drag a bookmark into an <input> field
Review URL: http://codereview.chromium.org/449067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(We have a fixed profile per browser.) The Mac code never had this SetProfile().
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/450038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Local State when writing to disk.
BUG=28836
Review URL: http://codereview.chromium.org/449074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33518 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change is to help diagnose bug 29038.
BUG=29038
Review URL: http://codereview.chromium.org/455025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
before the old CJK Win fonts (available on Win XP, Vista / 7).
Vista fonts are better looking that the old CJK fonts.
Also, list Arial at the beginning so that Arial is used for the 'ASCII portion' than not-so-nice glyphs for the ASCII portion in CJK fonts.
BUG=NONE
TEST=1. On Win Vista/7, run Chrome with '--lang=zh-CN' (zh-TW, ja and ko). The font in DOM UI (history, download, new tab) look nicer than on WIn XP. 2. Even on XP, the ASCII portion (Latin letters and numbers) in CJK Chrome looks nicer than before in DOM UI pages.
Review URL: http://codereview.chromium.org/437071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=29113
Review URL: http://codereview.chromium.org/458003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
SessionRestoreUITest.RestoreAfterClosingTabbedBrowserWithAppAndLaunching as flaky.
BUG=29110
Review URL: http://codereview.chromium.org/450044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also adds the npapi headers to the npapi.gyp file since I got tired of
Visual Studio not finding the files.
This removes the "open file in sandbox" feature which it doesn't look like we
will use.
One more significant change is that I changed to including pepper.h in all
cases, even when pepper is disabled. We used to have a forward declare in
npapi.h for the structs in question, but we'll be adding a lot more structs for
the different contexts and I don't think this will scale. I think its OK fo
rthe pepper API declarations to be available when Pepper isn't enabled.
BUT=none
TEST=none
Review URL: http://codereview.chromium.org/453015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=20915
Review URL: http://codereview.chromium.org/458002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=aa
Review URL: http://codereview.chromium.org/449072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
particular case was harmless with no underlying bugs.
BUG=29085
Review URL: http://codereview.chromium.org/449068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a case where my extension used the network; but because extensions are
initialized earlier than WinSock init, the extension failed when
trying to do a dns lookup. This only fails because it was in conjunction
with the --single-process flag, so it is unlikely to effect others.
Nonetheless, there is really no harm in moving winsock initialization
to be very early.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/454021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(It's still a bit odd that some of these windows (e.g., Developer Tools) display
a location bar. The displayed bar is also a strange size and not properly
framed. These are separate bugs.)
BUG=29070
TEST=Open a normal web page and then also a Developer Tools window (Cmd-Opt-I). Focus the window (and tab) with the normal web page. Press Shift-Cmd-B a few times. Make sure no animation occurs in the Developer Tools window. Also make sure the bookmark bar animations occur normally in normal browser windows.
Review URL: http://codereview.chromium.org/453020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the gallery.
TBR=rafaelw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Update copyrights.
* Remove unnecessary headers.
* Remove useless functions.
* Make declaration and definition order match (in at least the _database_bloom.* files).
* Eliminate database_perftest.cc, since it seems to have been disabled entirely since before the public launch, and looks like it's perhaps irrelevant to the current code design.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/457019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TODO #1: dragging of folder buttons.
TODO #2: perhaps holding Option while dragging on the bookmark bar should force
the bookmark to be copied instead of moved.
BUG=17608, 28842
TEST=Make a bunch of (non-folder) bookmarks on the bookmark bar; try dragging these bookmark bar buttons to the desktop, to the web content area, to text boxes, to other browsers -- these should all do sensible things; make sure that dragging them around on the bookmark bar still rearranges them.
Review URL: http://codereview.chromium.org/434095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
no longer needed and prompts the scary warning on the install dialog.
BUG=None
TEST=I ran the browser tests that test the feed parsing and tested the
extension on a news site with a feed. No issues found.
Review URL: http://codereview.chromium.org/453018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
don't persist them permanently.
BUG=none
TEST=use notifications in incognito
Review URL: http://codereview.chromium.org/455004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
WebDataService.
This is so I can start adding change notification to the autofill methods, which is need to sync this data type.
Review URL: http://codereview.chromium.org/435030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
* Scale back poll rate.
* Focus existing gmail tab instead of creating a new one.
* Prefer https over http
Review URL: http://codereview.chromium.org/449049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This does not reject links with targets but it does reset the target to the
current page.
BUG=29084
TEST=With tips turned on and the web inspector shown. You should no longer
see any warnings about a[target]
Review URL: http://codereview.chromium.org/452029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33470 0039d316-1c4b-4281-b951-d872f2087c98
|