| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also includes a change to not have third_party/WebKit/WebKit/chromium/public
in the global include path. Most of the code changes pertain to this.
I also took this opportunity to do some renaming:
browser/cache_manager_host -> browser/renderer_host/web_cache_manager
R=brettw
Review URL: http://codereview.chromium.org/42194
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=wtc
BUG=8860
Review URL: http://codereview.chromium.org/42384
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
(found by Coverity)
Review URL: http://codereview.chromium.org/48161
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- rolling back http://codereview.chromium.org/48120/
- it turns out the launch behaviour is now specified in the tag
Review URL: http://codereview.chromium.org/42381
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Added missing delayload entries to chrome/app/chrome.dll.deps.
TBR=maruel
Review URL: http://codereview.chromium.org/48172
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Have chrome/renderer to use FFmpeg
- Added using_media.vsprops to all affected projects that depends
on chrome/renderer.
- Added lib path "$(OutDir)\lib" to essential.vsprops
Review URL: http://codereview.chromium.org/48118
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
setIsWebWorkersEnabled to follow isFoo/setIsFoo pattern.
Also pull DEPS to bring in the WebKit/chromium/src part.
Review URL: http://codereview.chromium.org/48157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
ViewAccessibilityWrapper).
Review URL: http://codereview.chromium.org/48170
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42376
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- that outta reduce the fat that setup.exe gained
- this is the chrome side of the fix
BUG=8894
Review URL: http://codereview.chromium.org/48114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
was that the wrong pid was being sent to RDH from RMF. It needs to be the fake pid for the in-process renderer.
BUG=8890
Review URL: http://codereview.chromium.org/42366
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42311
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
(found by Coverity)
Review URL: http://codereview.chromium.org/42370
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
minimized
browser window.
BUG=4557 ( http://crbug.com/4557 )
Original patch by Mohamed Mansour <m0.interactive@gmail.com> in
http://codereview.chromium.org/42208/show
Review URL: http://codereview.chromium.org/48167
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
There are cases where the renderer asks for the root rectangle of its
window before we have a window for it. Since we still have the
NativeViewId hack in place, this previously caused a crash.
Review URL: http://codereview.chromium.org/42356
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
(found by Coverity)
Review URL: http://codereview.chromium.org/42369
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
new_name_count_ is unsigned, so checking for >= 0 is useless.
(Found by Coverity)
Review URL: http://codereview.chromium.org/48152
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
(found by Coverity)
Review URL: http://codereview.chromium.org/42367
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
(Coverity discovered it.)
Review URL: http://codereview.chromium.org/49002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
is not updated when |request_context| is added to
ViewHostMsg_Resource_Request.
In r11816 CreateResourceRequest() is used to prepare
ViewHostMsg_Resource_Request with |request_context| uninitialized,
giving the purify bot red. Initializing the variable should fix the
UMR error.
Review URL: http://codereview.chromium.org/42360
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(tab) to change Search Engine. Not a good first impression.
BUG=4688
TEST=Open Chrome using --first-run, press Cancel on the
import dialog and watch the First Run bubble come up. Use Tab
and then Enter and the Change Search Engine should appear.
Then try it again, but this time click outside the bubble to
dismiss it (corner case that could lead to a crash).
Review URL: http://codereview.chromium.org/48138
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I had assuming that we always scroll the whole window; I was wrong.
This patch fixes issues with 'ghost' scrollbars appearing when the
window looses focus and with huge misrendering when scrolling iframes.
Review URL: http://codereview.chromium.org/42357
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for DownloadDatabase, InMemoryDatabase, and RedirectUiTest. Except for in those
files, we now only use std::wstring for text strings.
This CL also enables two more unittests on Mac.
patch by Rohit Rao.
http://codereview.chromium.org/48018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://dev.chromium.org/developers/design-documents/native-controls
Review URL: http://codereview.chromium.org/48094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42338
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also ensure that Chromium.app quits properly between the tests.
http://crbug.com/8391
Review URL: http://codereview.chromium.org/42306
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
These are used for <select> html items, for example.
Review URL: http://codereview.chromium.org/48054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
tbr=avi
Review URL: http://codereview.chromium.org/48139
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
whitespaces before checking.
Review URL: http://codereview.chromium.org/42316
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
loop if we were ever to get a "chrome_config" node back in metrics response data.
Review URL: http://codereview.chromium.org/42335
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This belongs as a private method of BrowserView. Neither mac nor linux uses it.
Review URL: http://codereview.chromium.org/42298
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/48136
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Fixes http://crbug.com/8829 .
Review URL: http://codereview.chromium.org/42336
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/48106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/48105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A change in 9953 made a tab of a single chrome-window with a single tab part of the
client area so that double-clicks on it are not treated as non-client double-clicks
and that the tab context-menu appears instead of the system context menu (see issue
3787). That change also solved issue 2827 (which is not restructed to the close
button of the right-most tab).
Change 10929 reverted 9953 partially, keeping the sinle-tab of a single-window as
part of the client area but removed the double-click swallowing code that was needed
to fix 2827. In doing so, dragging a single-tabbed single chrome window by the tab
(not the tabstrip) no longer worked. This small changes only fixes that behavior. It
turns out that there was a use case where some users want double-clicks to be considered
as two single-clicks (see issue 8287) and swallowing the double-click breaks this.
Review URL: http://codereview.chromium.org/46033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- Fix indentation.
- Reorder typedefs according to style guide.
- Add DISALLOW_COPY_AND_ASSIGN.
Review URL: http://codereview.chromium.org/42322
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
some cases and doesn't represent an actual problem.
Review URL: http://codereview.chromium.org/48134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
find_bar_controller.cc:
Unused local variable created.
hwnd_view.cc:
The local definition of parent overshadows param passed in.
google_update.cc:
Uninitialized member variable.
webframe_impl.cc:
The if was overly constrained. At the top of the function there is an if (reset) { ... return; } so we don't need to check for !reset in the next if statement. This functionality is covered by a ui_test, which passes with this change.
Review URL: http://codereview.chromium.org/42321
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Switch from wstring to string where needed.
Review URL: http://codereview.chromium.org/42303
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
sandbox project wasn't copying wow_helper.exe anymore, causing a build
breakage on x64 platforms only.
TBR=bnelson
Review URL: http://codereview.chromium.org/42328
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/48121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change is a very tricky fix for Issue 1845 in chromium: cant alignt text to the right using right shift and right ctrl.This change consists of two parts listed below.
1. Emulating the implementation of Safari that changes the text-direction of an input element.
Safari uses context menus to change the text direction. This change adds an IPC message 'ViewMsg_SetTextDirection', which notifies the new text direction. Also, it adds two functions: RenderWidgetHost::UpdateTextDirection() and RenderWidgetHost::NotifyTextDirection(). They encapsulate the new IPC message so that we can use them both when we presses a set of keys and when we add context-menu items which change the text direction.
2. Calling the above interface when pressing right-shift and right-control keys, or when left-shift and left-control keys.
This modifies the RenderWidgetHostViewWin::OnKeyEvent() function and call the above text-direction interfaces when a user finishes pressing the keys. As you can imagine, if we send an IPC message every time when we receive a WM_KEYDOWN event, we continue sending IPC messages while a user is pressing the keys.
BUG=1845
Review URL: http://codereview.chromium.org/39252
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- According to docs we should not be writing InstallerSuccessLaunchCmdLine
- Might affect gcapi
BUG=1719600
Review URL: http://codereview.chromium.org/48120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
(Also fixing missing property on sdch.)
Review URL: http://codereview.chromium.org/42317
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cookie values to get results back to the test executable. This fixes an issue
where the test could not be automated to run from local disk - that required
file cookies, which causes the DOM checker test to fail. This is also a
cleaner approach.
- Add test to run DOM checker automation from local disk.
- Add code to optionally disable file cookies in UI tests. Disable them in the
DOM checker tests.
- Add a function to the UITest class that allows a test to wait for a JavaScript
condition in the test page.
BUG=6274
Review URL: http://codereview.chromium.org/48055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/48119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11944 0039d316-1c4b-4281-b951-d872f2087c98
|