summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Linux: fix a couple of libc calls in a compromised context.agl@chromium.org2010-04-061-8/+17
| | | | | | | | | | | We shouldn't call memset nor socketpair once we have crashed. BUG=39292 TEST=none http://codereview.chromium.org/1210006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43717 0039d316-1c4b-4281-b951-d872f2087c98
* Make Mac plugin window interposing more conservative about activating pluginstuartmorgan@chromium.org2010-04-061-2/+23
| | | | | | | | | | | Don't switch to the plugin process for offscreen windows (like the one opened by Unity). BUG=38996 TEST=Open a Unity sample. It shouldn't lose focus on every mouse event (although it will still lose focus once). Review URL: http://codereview.chromium.org/1626002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43716 0039d316-1c4b-4281-b951-d872f2087c98
* detect preferences errorserikkay@chromium.org2010-04-0636-80/+274
| | | | | | | | | BUG=38352 TEST=none Review URL: http://codereview.chromium.org/1120006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43715 0039d316-1c4b-4281-b951-d872f2087c98
* Enable WorkerTest.WorkerScriptError which now have same results on win, ↵yurys@chromium.org2010-04-061-2/+1
| | | | | | | | | | linux and mac after http://trac.webkit.org/changeset/57147 is rolled. BUG=38918 Review URL: http://codereview.chromium.org/1596011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43712 0039d316-1c4b-4281-b951-d872f2087c98
* Abstracted language switch logic to its model class.glotov@google.com2010-04-068-109/+176
| | | | | | | | | BUG=37070 TEST=none Review URL: http://codereview.chromium.org/1596007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43711 0039d316-1c4b-4281-b951-d872f2087c98
* Fix docking behaviour for devtools windows that don't have an associated ↵mnissler@chromium.org2010-04-069-26/+38
| | | | | | | | | | | browser window BUG=40090 TEST=none Review URL: http://codereview.chromium.org/1567014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43709 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Get theme providers from a window's delegate, not its window ↵rohitrao@chromium.org2010-04-062-6/+6
| | | | | | | | | | controller. These are actually the same object, but they are set at different times during the switch to fullscreen. BUG=39323 TEST=Go fullscreen with the Android Robot theme installed. Tab text for unselected tabs should be grey, not black. Review URL: http://codereview.chromium.org/1576019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43708 0039d316-1c4b-4281-b951-d872f2087c98
* Add menu and menu item events to the accessibility extension api, anddmazzoni@chromium.org2010-04-0614-85/+325
| | | | | | | | | | | | | | generate menu item notifications for gtk menus. The code to generate menu open and close events is a little more complicated and will come in a future patch. BUG=none TEST=navigated menus with keyboard, watched notifications fire Review URL: http://codereview.chromium.org/1585011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43707 0039d316-1c4b-4281-b951-d872f2087c98
* Make DidProcessCrash a bit more solid and accurate on Windowsphajdan.jr@chromium.org2010-04-062-6/+2
| | | | | | | | | | | | | I hit the NOTREACHED() inside it while debugging an unrelated problem. Also, now there is one less special case in this function's contract. TEST=none BUG=38048 Review URL: http://codereview.chromium.org/1315009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43706 0039d316-1c4b-4281-b951-d872f2087c98
* Add NormalizeLanguageCode() to normalize language codes.satorux@chromium.org2010-04-063-9/+50
| | | | | | | | | | | | | | The normalization is needed to avoid duplicates in the language table in the language config diloag, as well as the combobox in the "add language" dialog, when engines return "jpn" and "ja" as language codes. Along the way, fixed typos in function names. TEST=added unit tests, and manually Review URL: http://codereview.chromium.org/1512022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43705 0039d316-1c4b-4281-b951-d872f2087c98
* Enable interactive_ui_testsoshima@chromium.org2010-04-067-67/+140
| | | | | | | | | | | | | | | | | | | | | | | * changed DCHECK in tree_node_model to make it easy to find how it failed. * Fixed compilation error in find_bar_host_interactive_uitest.cc on linux/views. * Disabled BrowserKeyEventsTest.AccessKeys for Chromeos Added/Changed ui_test_utils::RunAllPendingInMessageLoop where necessary. * Disabled tab_dragging_tests. I included the source so that we can catch compilation error even if tests do not run. Changed the comment from // -> /* as GCC complains the use of "\" (and potentially dangerous) * Added SleepInMessageLoop to allow event loop to execute the tasks/events while waiting. * For RunAllPendingInMessageLoop change, please see http://codereview.chromium.org/1591004 BUG=39736 TEST=interactive_ui_tests should pass with following cls http://codereview.chromium.org/1594003 http://codereview.chromium.org/1545011. Review URL: http://codereview.chromium.org/1576008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43701 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding:oshima@chromium.org2010-04-063-23/+125
| | | | | | | | | | | | | | | | | BookmarkBarView tests fixes * Add BOOKMARK_CONTEXT_MENU_SHOWN notification. On Linux, event handling is asynchronous, but the showing context menu is blocking, so we can't use RunAllPending(). * Convert gtk keycode to Win when checking accelerator. BUG=39736 TEST=none (interactive_ui_tests should pass once enabled it'll be enabled by http://codereview.chromium.org/1576008 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43699 Review URL: http://codereview.chromium.org/1545011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43700 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Make content bubbles wider in languages that have long translations of ↵thakis@chromium.org2010-04-068-53/+215
| | | | | | | | | | | | | "Manage" and "Done. xib changes: Anchor bubble view on right side, make it autoresize horizontally. Same for divider line, radio groups, and title. Make widthbased tweakers at bottom horizontally autoresize. Hook up manage and done buttons to controller. BUG=39393 TEST=See bug. Review URL: http://codereview.chromium.org/1527012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43698 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 43692 - Adds some debugging info in hopes of tracking leak insky@chromium.org2010-04-061-16/+0
| | | | | | | | | | | | | | | bounds_animator/tab_strip. BUG=40475 TEST=none TBR=jcivelli@chromium.org Review URL: http://codereview.chromium.org/1609008 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/1512021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43696 0039d316-1c4b-4281-b951-d872f2087c98
* Improve the underlying escaping function JsonDoubleQuoteT to escape < and > ↵inferno@chromium.org2010-04-061-2/+2
| | | | | | | | | | characters BY DEFAULT to prevent script execution. BUG=40147 TEST=StringEscapeTest.* Review URL: http://codereview.chromium.org/1512013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43695 0039d316-1c4b-4281-b951-d872f2087c98
* Change how the calculation is performed for determining the location of the ↵mrossetti@chromium.org2010-04-066-16/+28
| | | | | | | | | | | arrow tip in a bubble window. BUG=40406 TEST=1) Not in full-screen and with language set to English, press Cmd-D and verify bubble is properly positioned with arrow tip pointing to star. Change language to Espanol and repeat test. 2) Now in full-screen, repeat the tests. Review URL: http://codereview.chromium.org/1623002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43694 0039d316-1c4b-4281-b951-d872f2087c98
* Adds some debugging info in hopes of tracking leak insky@chromium.org2010-04-061-0/+16
| | | | | | | | | | | | bounds_animator/tab_strip. BUG=40475 TEST=none TBR=jcivelli@chromium.org Review URL: http://codereview.chromium.org/1609008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43692 0039d316-1c4b-4281-b951-d872f2087c98
* Move more extensions hard coded error messages to .grd file. finnur@chromium.org2010-04-062-28/+82
| | | | | | | | | | | Patch from Thiago Farina. Previously reviewed here: http://codereview.chromium.org/931001 BUG=23086 TEST=Chrome should work as before (no visible change). git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43691 0039d316-1c4b-4281-b951-d872f2087c98
* Make an error message verbose to investigate a un-reproducible bug.tkent@chromium.org2010-04-061-2/+7
| | | | | | | | BUG=35198 TEST=none Review URL: http://codereview.chromium.org/1528018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43686 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Don't show toolbar border without the toolbar.estade@chromium.org2010-04-061-5/+8
| | | | | | | | | BUG=39172 TEST=visual Review URL: http://codereview.chromium.org/1549021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43685 0039d316-1c4b-4281-b951-d872f2087c98
* Localize CSS files in content scripts (but don't localize JS files).cira@chromium.org2010-04-068-25/+266
| | | | | | | | | | | Add UserScriptSlave unittest. BUG=39899 TEST=List css file in content_scripts section of the manifest. Refer to an image using url(chrome-extension://__MSG_@@extension_id_/image.png); within that css. @@extension_id message should be replaced with actual id of the extension. Review URL: http://codereview.chromium.org/1585013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43684 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark manager: Fix tree indentationarv@chromium.org2010-04-062-30/+53
| | | | | | | | | BUG=39228 TEST=Create lots of nested folders (more than 10 levels deep). Review URL: http://codereview.chromium.org/1539023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43683 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Mac build, part 2.pkasting@chromium.org2010-04-061-2/+0
| | | | | | | | BUG=27570 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43680 0039d316-1c4b-4281-b951-d872f2087c98
* GTK plumbing for dragend.dcheng@chromium.org2010-04-053-29/+10
| | | | | | | | | | | This plumbs the actual dropEffect that occurred back into WebKit so that dragend is dispatched with the correct dropEffect. BUG=39399 TEST=Manual testing using the attached test case on the bug. Review URL: http://codereview.chromium.org/1589015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43679 0039d316-1c4b-4281-b951-d872f2087c98
* Add a scoped notifier for pref dictionaries / lists.chron@chromium.org2010-04-057-7/+55
| | | | | | | | | | | | | Other options included subclassing the pref value types, making the firenotifications public, or just friend classing. Since values can contain other values, such as dictionary within dictionary, it didn't seem like a good idea to subclass. We might want to consider combining the scoped lookup with the GetMutableList call at some point, but some callers keep a long reference so that might be a bad idea. BUG=38557 TEST=manual Review URL: http://codereview.chromium.org/1549020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43678 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Mac build failure.pkasting@chromium.org2010-04-051-1/+1
| | | | | | | | BUG=27570 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43677 0039d316-1c4b-4281-b951-d872f2087c98
* Replace omnibox icons with new set that are all the same size (19x19).pkasting@chromium.org2010-04-0554-3315/+67
| | | | | | | | | TBR=jnj BUG=27570 TEST=Type "paypal.com", watch as it loads, ensure address doesn't shift sideways when the lock appears. Review URL: http://codereview.chromium.org/1560015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43676 0039d316-1c4b-4281-b951-d872f2087c98
* sync: Specify linking dependencies correctly. The browser library contains ↵thestig@chromium.org2010-04-052-7/+2
| | | | | | | | | | | lots of files in chrome/browser/sync. They need to depend on the syncapi library and not just sync_proto. BUG=none TEST=Random CLs don't trigger linking errors. TBR=nick Review URL: http://codereview.chromium.org/1564010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43675 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "BookmarkBarView tests fixes"oshima@chromium.org2010-04-053-116/+21
| | | | | | | | | | I don't understand why this is still causing the problem, but reverting this for now. This reverts commit 6bb4f22703226e093644c28afe34d975cc7d549d. Review URL: http://codereview.chromium.org/1612005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43674 0039d316-1c4b-4281-b951-d872f2087c98
* Don't compare wchar_t *szork@chromium.org2010-04-051-1/+1
| | | | | | | | | BUG=38559 TEST=Manual test. Review URL: http://codereview.chromium.org/1562011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43673 0039d316-1c4b-4281-b951-d872f2087c98
* Delete bookmarks with backspace on macfeldstein@chromium.org2010-04-051-1/+2
| | | | | | | | | | | | Safari deletes bookmarks using the backspace key, so we should too. BUG=39211 TEST=Highlight a bookmark and press the backspace key, the delete key, or meta+backspace. All should delete the bookmark. Review URL: http://codereview.chromium.org/1513017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43671 0039d316-1c4b-4281-b951-d872f2087c98
* Geolocation exceptions window, Windows.pkasting@chromium.org2010-04-0510-110/+484
| | | | | | | | | | This also makes some correctness/consistency fixes to the model that affect other OSes, e.g. we now allow "remove" on the selected exception set iff all selected exceptions are removable. BUG=39817 TEST=Geolocation exceptions window exists on windows, allows sorting by either column Review URL: http://codereview.chromium.org/1539021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43669 0039d316-1c4b-4281-b951-d872f2087c98
* Implement LoginDatabase on all platforms.albertb@chromium.org2010-04-0511-70/+108
| | | | | | | | | BUG=35038 TEST=LoginDatabaseTest Review URL: http://codereview.chromium.org/1567022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43667 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "No longer accept 'null' as signifying unset optional object property ↵rafaelw@chromium.org2010-04-052-11/+11
| | | | | | | | | | in extension calls." This reverts commit 02bd0a11dd8cee6e19c201e30b3984b638b2ddd1. Review URL: http://codereview.chromium.org/1512019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43666 0039d316-1c4b-4281-b951-d872f2087c98
* Revert the unnecessary change. I forgot to remove this test code when I ↵oshima@chromium.org2010-04-051-10/+2
| | | | | | | | | | | | created the cl. BUG=39736 TEST=interactive_ui_tests shoudl cycle green TBR=sky@chromium.org Review URL: http://codereview.chromium.org/1602009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43658 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Implement WebFormElementToFormData and use this to send form data tojhawkins@chromium.org2010-04-054-11/+126
| | | | | | | | | | | | the AutoFillManager. Don't check field labels for equality until we parse labels again. BUG=40297 TEST=FormManagerTest.WebFormElementToFormData Review URL: http://codereview.chromium.org/1609007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43657 0039d316-1c4b-4281-b951-d872f2087c98
* No longer accept 'null' as signifying unset optional object property in ↵rafaelw@chromium.org2010-04-052-11/+11
| | | | | | | | | | | | | extension calls. This changes the json schema validation to treat a object property set to null as significant, rather than meaning the property is not specified. BUG=39465 TEST=all tests should pass Review URL: http://codereview.chromium.org/1558021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43655 0039d316-1c4b-4281-b951-d872f2087c98
* Browser action icons not displayed in detached browser windowctguil@chromium.org2010-04-051-2/+2
| | | | | | | | | | | | Regression from this revision http://src.chromium.org/viewvc/chrome?view=rev&revision=43044 BUG=40272 TEST=Verify installed browser actions are visible in browser window created by detaching a tab. Review URL: http://codereview.chromium.org/1530019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43652 0039d316-1c4b-4281-b951-d872f2087c98
* Fix perf regression (again)jrg@chromium.org2010-04-051-0/+4
| | | | | | Review URL: http://codereview.chromium.org/1602008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43651 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill credit card field filling, with nameoncard field.dhollowa@chromium.org2010-04-052-7/+86
| | | | | | | | | | | | | | | | | | | | Enables credit card filling when "Name on Card" field is present. This adds to existing method of clicking on card number to fill. Note: this fixes up unit test changes with recent migration to FormData from FormFieldValues. BUG=38320 TEST=CreditCardFieldTest, FormStructureTest, manual testing with cc.html (attached). Related to: http://codereview.chromium.org/1518017 http://codereview.chromium.org/1605011 Review URL: http://codereview.chromium.org/1512018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43649 0039d316-1c4b-4281-b951-d872f2087c98
* Add F2 shortcut to rename folder and edit bookmark.arv@chromium.org2010-04-051-0/+4
| | | | | | | | | BUG=20992 TEST=Press F2 to rename folder or edit a bookmark. Review URL: http://codereview.chromium.org/1612003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43645 0039d316-1c4b-4281-b951-d872f2087c98
* Update Flash EULA positioning code to use new view_text_utils instead of old ↵mirandac@chromium.org2010-04-051-6/+7
| | | | | | | | | | | local method. TBR=finnur BUG= none TEST= chrome for chromeos about box looks fine. Review URL: http://codereview.chromium.org/1615004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43643 0039d316-1c4b-4281-b951-d872f2087c98
* Fix pyauto test on ChromeOS withOUT introducing a perf regression on XP.jrg@chromium.org2010-04-052-2/+13
| | | | | | | | | BUG=http://crbug.com/39559 BUG=http://crbug.com/40225 Review URL: http://codereview.chromium.org/1540015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43638 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the toast experiment omaha groupscpu@chromium.org2010-04-051-11/+5
| | | | | | | | | | | | | | - Reusing the first and second bit for 41 and 42 no bueno - Removing the condition that if the user is in some experiment it will not be drafted again BUG=none TEST=none Review URL: http://codereview.chromium.org/1570011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43637 0039d316-1c4b-4281-b951-d872f2087c98
* Add the proxy information to the new net internals page.eroman@chromium.org2010-04-057-44/+404
| | | | | | | | BUG=37421 Review URL: http://codereview.chromium.org/1607004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43636 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression for browser action container width on Toolkitfinnur@chromium.org2010-04-052-6/+19
| | | | | | | | | | | | | | | | | | | | Views. Once we introduced the model for keeping track of the number of visible icons, there was a race that was introduced where the toolbar could get constructed before the model knew about any icons, so on startup the width of the container was 0. This CL hooks up the newly added ModelLoaded notification and sets the width on receiving that notification, if the width hasn't been set already. BUG=40329 TEST=None Review URL: http://codereview.chromium.org/1547021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43635 0039d316-1c4b-4281-b951-d872f2087c98
* Move utility method for embedding links in texts from about_chrome_view to a ↵mirandac@chromium.org2010-04-052-197/+16
| | | | | | | | | | | generic class, for future use in other classes. BUG= none TEST= chrome "about" dialog still works the same, in ltr and rtl languages. Review URL: http://codereview.chromium.org/1508018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43634 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix about:memory for epiphany and add iceweasel.craig.schlenter@chromium.org2010-04-051-2/+3
| | | | | | | | | BUG=40370 TEST=Run epiphany and iceweasel and check that they appear in about:memory. Review URL: http://codereview.chromium.org/1611007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43633 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug numbers for disabled tests.rohitrao@chromium.org2010-04-051-1/+2
| | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/1594006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43632 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Make image dragging 162.4% more awesome.thakis@chromium.org2010-04-054-17/+41
| | | | | | | | | | | | | | | | | | | Also needs a webkit patch to do anything ( https://bugs.webkit.org/show_bug.cgi?id=37069 ), but can be landed independently. BUG=11457,18992 TEST=(all require the webkit patch, so this won't work yet) http://html5demos.com/drag and http://ljouanneau.com/lab/html5/demodragdrop.html Dragging should show image http://www.google.com/ Dragging google image should show image http://www.travelvivi.com/wp-content/uploads/2009/09/Eiffel_Tower.jpg Dragging image should work, drag image should be smaller than image itself Random website Mark some text, drag it. Should show drag cursor and no image Review URL: http://codereview.chromium.org/1539018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43631 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 22:27:28 +0000