| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
#ifdef out windows-specific portion of chrome/common/l10n_util.h,
which allows me to port some other files.
I also extracted parts of chrome/views/tree_view.h to tree_model.h,
so that ATL/WTL-specific parts stay in tree_view.h, but tree_model.h
is platform-independent and can be included in files using it as base class.
Review URL: http://codereview.chromium.org/8618
Patch from Paweł Hajdan jr.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10903
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add 'gdm_fp' to the $LIBS setting in base\using_base.scons
(to be removed when that library moves into base\third_party).
* Have the grit Scanner search the Repository() copy of the source
file (necessary now that $TARGET_ROOT has changed).
* Change all the SConscript files underneath chrome\test and
chrome\tools to *.scons files, including updating their
contents with the current patterns.
* Add dependencies of the local_settings_*.res files on
the corresponding google_chrome_string_*.rc files, so they
get generated properly.
* Add generation of the chrome_exe.res resource file.
* Comment out some unnecessary .lib settings in the base
construction environment.
Review URL: http://codereview.chromium.org/10745
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Make relative paths better so that other solutions
can include these and build.
Review URL: http://codereview.chromium.org/10934
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This doesn't generate locale dlls yet, we need to make the vcproj
files for that.
Review URL: http://codereview.chromium.org/10909
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10738
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
avoid some more Windows specific code.
Move Process and SharedMemory into the base namespace (most changes).
Review URL: http://codereview.chromium.org/10895
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
correct style. I was debugging in here and this was annoying me, since there is no reason for these functions to be virtual.
Review URL: http://codereview.chromium.org/10638
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10916
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
bounds.
TBR=erg
Review URL: http://codereview.chromium.org/10724
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- Apparently blank tabs must have NewTabUIURL as their URL.
- flag wasn't initialized.
Review URL: http://codereview.chromium.org/10721
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10712
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Remove a duplicate entry for safe_browsing\safe_browsing_service.cc.
Review URL: http://codereview.chromium.org/10904
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove the path from WinMain to the Browser object passing the show_command. For the Browser object, this is a problem since this value isn't portable. For the code in general it involves a lot of ugly wiring. It's completely unnecessary since the value is obtainable via GetStartupInfo.
- Remove show_command plumbing from all over the place (session restore, web app launcher, etc)
Change the way browser windows are constructed:
- The browser constructor now takes just a type and a profile, and simply initializes the object.
- Some configuration that used to be part of the constructor that was only used in one or two use cases (initial bounds, maximized state, web app name) are split into separate setters.
- Window creation is split out into a separate step to be called post configuration.
- Assorted static helper functions added to Browser to make construction of common types easy.
- Remove Browser::Show in favor of BrowserWindow::Show
- Adjust all callers to use the new helpers.
Change the way ChromeViews restores window placement:
- Split restored size determination from restored maximized determination. They are needed by the code at different times. Size restoration happens when the window is constructed and Window::SetInitialBounds is called. Maximized state restoration happens when the window is shown for the first time and SW_SHOWMAXIMIZED or SW_SHOWNORMAL is needed. Thus, replace WindowDelegate::RestoreWindowPosition with WindowDelegate::RestoreWindowBounds and WindowDelegate::RestoreMaximizedState.
- Window::SetInitialBounds calls WindowDelegate::RestoreWindowBounds
- Window::Show calls WindowDelegate::RestoreMaximizedState
- Adjusts all WindowDelegate implementations that override RestoreWindowPosition to implement these new methods instead.
- Move "playback/record" mode window size setting from browser_init to Browser::RestoreWindowBounds.
- Provide a virtual function on Window called GetShowState that determines the default show state to be used when Window::Show is called. For most windows and dialogs this is SW_SHOWNORMAL. AeroGlassFrame/OpaqueFrame (the browser window frames) override this since they're the app's main windows to return the value provided by GetStartupInfo which gives the value from the app shortcut.
http://crbug.com/3557
Review URL: http://codereview.chromium.org/10896
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
was on top of Chrome's topmost brower window when attempting to dock a
dragged tab.
BUG=1094303
TEST=see bug
Review URL: http://codereview.chromium.org/10715
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=4365
Review URL: http://codereview.chromium.org/10688
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10857
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
modified date, which meant newly added groups wouldn't show up in the
combobox of the bookmark bubble.
BUG=766
TEST=see bug
Review URL: http://codereview.chromium.org/10709
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. If a context menu was shown from a menu, then hidden we did not keep
mouse capture and bad things happened (menu wouldn't go away when
clicking else where, crash ...).
. We only update menu sizes on first show of a menu. That way if a
context menu doesn't have icons things don't shift around.
. If nothing was selected in the menu pressing the context menu
showed the context menu for the root. It doesn't make sense for the
root menu to have a context menu.
BUG=4364
TEST=see bug
Review URL: http://codereview.chromium.org/10706
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10704
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
libraries)."
This reverts commit fdeb8575309055ad23803b376659c236099348ac.
Review URL: http://codereview.chromium.org/10908
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Added a dummy media.cc file in order to produce media.lib so there are no
linker errors when building media_unittests.exe. Currently chrome_dll
does NOT depend on media so it will not be linked in, which is OK for now :)
Review URL: http://codereview.chromium.org/10683
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
database closed when not processing updates.
Review URL: http://codereview.chromium.org/10643
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
* removed a few unneeded headers from MIMETypeRegistry
* removed all uses of IMLangFontLang2
Review URL: http://codereview.chromium.org/10661
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
added an option such that menus can be rendered in two ways, chubby or
skinny. The only places that uses the taller menus is the bookmark
bar.
I also made the menus use the right font.
BUG=1074332
TEST=none
Review URL: http://codereview.chromium.org/10865
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
to malfunction.
Review URL: http://codereview.chromium.org/10862
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=cpu
Review URL: http://codereview.chromium.org/10686
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
making ui test more consistent. I suspect I could get the same effect
by changing the last sleep to kMaxTestExecutionTime, but seems best to
use the sync function here.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/10692
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- make the window update locking use window visibility instead of WM_SETREDRAW. I believe WM_SETREDRAW is causing the window to become visible during tests.
- potential crashes caused by NULL TabcontentsDelegates.
TBR=sky
Review URL: http://codereview.chromium.org/10674
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
work on the buildbots. I need to find a better way to get the WindowProxy for
the alert dialog.
TBR=jam
Review URL: http://codereview.chromium.org/10667
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
AutocompleteMatch types, and pass a type to the AutocompleteMatch constructor. The added detail in the new types is not used for anything functional; its sole purpose is for metric logging. Someday we could probably update other bits of the code to make use of this, though (e.g. the paste-and-search vs. paste-and-go determinant code).
These are separable changes, but doing either one without the other would have required an annoying number of fragile temporary changes.
Review URL: http://codereview.chromium.org/10855
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
necessary since the text can be sized using the desktop DC, which should be faster. I made this function static, and moved the functions it used into file-local functions since they didn't depend on the class either.
This is trying to fix bug 49. This code is very close to the crash, and a 0x0 canvas seems like it might cause problems. However, it is unclear whether this will have any effect (other than performance).
Review URL: http://codereview.chromium.org/10409
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a variable called SYSTEM_LIBS, consisting of a comma-separated
list of system libraries. So far, bzip2, libpng, libjpeg,
libxml, libxslt, lzma_sdk, zlib, hunspell, sqlite, libevent are recognized.
BUG=4321
Review URL: http://codereview.chromium.org/10626
Patch from Fabien Tassin <fta@sofaraway.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=3675
Patch from Paweł Hajdan jr <phajdan.jr@gmail.com>
original issue: http://codereview.chromium.org/9509
Review URL: http://codereview.chromium.org/11002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
how Windows looks. This also changes SetEnabled not to adjust
read_only_ state. That SetEnabled invoked SetReadOnly is just wrong,
the two don't have to be the same.
BUG=1218491
TEST=bring up the keyword editor and double click on one of the
default search engines, make sure the background of the text field
looks disabled.
Review URL: http://codereview.chromium.org/10662
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=1463346
Review URL: http://codereview.chromium.org/10805
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5313 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
entries made between two given times. BrowserDataRemover::Remove now clears autofill data.
BUG=3870
Review URL: http://codereview.chromium.org/9775
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=4270
Review URL: http://codereview.chromium.org/10620
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
One of these is unused for the moment.
Review URL: http://codereview.chromium.org/10657
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=4287
TEST=see bug
Review URL: http://codereview.chromium.org/10621
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
initialization path than the bookmarks bubble.
http://crbug.com/4344
Review URL: http://codereview.chromium.org/10849
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
we weren't resetting state before showing the context menu it was
possible for the button to stay in a HOT state even though it isn't.
BUG=2620
TEST=see bug
Review URL: http://codereview.chromium.org/10835
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5300 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. Pressing shift-F10 would make context menu appear then immediately
disappear. This is because MenuController was hiding on a
WM_SYSKEYUP. I've changed MenuController to do nothing on
WM_SYSKEYUP. If a sys key is pressed again, we'll get a
WM_SYSKEYDOWN and hide there.
. MenuController needed to handle WM_CONTEXTMENU and not dispatch it,
otheriwse we could end up with stacked menus.
BUG=3685
TEST=bring up bookmark manager, select a row in the table on the
right. Press shift-F10 and make sure the context menu appears and
stays up.
Review URL: http://codereview.chromium.org/10635
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
trunk is usable again.
TBR=sky
Review URL: http://codereview.chromium.org/10655
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
functions.
Review URL: http://codereview.chromium.org/10823
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
renamed libv8.a to libv8_g.a
Review URL: http://codereview.chromium.org/10845
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
this function. This is defensive coding being added in
part to see if it doesn't reveal anything interesting
for bug 1231568
Review URL: http://codereview.chromium.org/11003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
AutocompleteMatchData to correspond to the order in AutocompleteMatch.
I am unconvinced this struct is useful or necessary. It seems like we should simply serialize AutocompleteMatch if that's what we want; this is already doing most of that. But whatever.
Review URL: http://codereview.chromium.org/10841
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=4316
Review URL: http://codereview.chromium.org/10820
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5281 0039d316-1c4b-4281-b951-d872f2087c98
|