summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Clang: enable -Wbool-conversions and -Wunused-variables on Linux.hans@chromium.org2011-01-148-8/+8
| | | | | | | | | | | | | | | -Wbool-conversion warns about EXPECT_EQ(false, blah), so replace that with EXPECT_FALSE(blah). Do the same with EXPECT_EQ(true, blah) for good measure (even though that doesn't generate warnings). Also remove the one instance of an unused variable. BUG=69421 TEST=buildbots all compile and all tests pass Review URL: http://codereview.chromium.org/6300001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71431 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up threading model of external extension providersgfeher@chromium.org2011-01-1425-673/+898
| | | | | | | | | | | Move blocking IO of loading the lists of external extensions from the UI thread to the FILE thread. Remove the ExternalPolicyExtensionProvider-specific parts from ExtensionsService. Side-effects: reduce the number of PostTask operations from 9 to 4. Trigger uninstall of external extensions immediately after they are removed from a policy. BUG=65107,63667 TEST=ExtensionManagementTest.ExternalPolicyRefresh for the new functionality, lot of other extension tests are updated Review URL: http://codereview.chromium.org/5742008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71427 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 639.0 to 640.0chrome-release@google.com2011-01-141-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71425 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ChromeFrame net tests which have broken since revision 70089 which added ↵ananta@chromium.org2011-01-141-2/+1
| | | | | | | | | | | | | | | | | | a named testing interface to the automation provider. The testing automation provider was incorrectly assuming that the tab handle would be a parameter in the TabLoaded message. This changed with jam's change to clean up the automation messages used by chrome frame. The other bug was with the AutomationMsg_Hello message which was passing an incorrect protocol version to chrome frame. BUG=none TEST=ChromeFrame net tests should run. TBR=amit Review URL: http://codereview.chromium.org/6324002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71422 0039d316-1c4b-4281-b951-d872f2087c98
* Integrate user strings into the JSON policy template filegfeher@chromium.org2011-01-142-1039/+743
| | | | | | | | | | | The new concept is the following: policy_templates.json contains all the data necessary to generate templates: policy names, English captions, descriptions, etc. This gets translated the following GRIT gatherer: policy_json.py. The text of the translated JSON file is then picked up, parsed, and passed to the writers by template_formatter.py. BUG=64898 TEST=PolicyJsonUnittest.* Review URL: http://codereview.chromium.org/6134006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71421 0039d316-1c4b-4281-b951-d872f2087c98
* Disable CrashRecoveryBrowserTest.Reload, flakily times outphajdan.jr@chromium.org2011-01-141-9/+2
| | | | | | | | | | TBR=creis BUG=69637 TEST=browser_tests Review URL: http://codereview.chromium.org/6290003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71420 0039d316-1c4b-4281-b951-d872f2087c98
* Add multi-process notification class.dmaclach@chromium.org2011-01-148-0/+1170
| | | | | | | | | | | | | | This is a platform abstraction for a notification that can be sent between processes. Currently only implemented on Mac. Windows and Linux will be done in a future CL. BUG=NONE TEST=BUILD Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70629 Review URL: http://codereview.chromium.org/5970015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71418 0039d316-1c4b-4281-b951-d872f2087c98
* WebDragSource: Added a guard for null [contentView_ window]morrita@chromium.org2011-01-141-2/+6
| | | | | | | | | BUG=69095 TEST=manual Review URL: http://codereview.chromium.org/6203005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71416 0039d316-1c4b-4281-b951-d872f2087c98
* Show remoting host status on the advanced options page.sergeyu@chromium.org2011-01-1410-5/+159
| | | | | | | | | BUG=67218 TEST=Remoting status is shown on the advanced options page. Review URL: http://codereview.chromium.org/6214003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71410 0039d316-1c4b-4281-b951-d872f2087c98
* We forgot to call Associate in case of local changes for autofill.lipalani@chromium.org2011-01-142-4/+5
| | | | | | | | | | When a local profile is created we create the corresponding sync node and we need to associate the sync node with profile. We forgot to make the call and that is fixed in this cl. BUG=68912, 69173 TEST= sync_integration_tests Review URL: http://codereview.chromium.org/6323001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71409 0039d316-1c4b-4281-b951-d872f2087c98
* Add option for url_fetch_test to wait for a JS expressiontfarina@chromium.org2011-01-141-3/+45
| | | | | | | | | | | | | | | | | | | | | | This option extends url_fetch_test to support waiting for a JavaScript expression to evaluate to true. This is used in the Chrome OS desktopui_GmailLatency test. The browser goes to the test URL and then runs the test to completion. BUG=chromium-os:10869 TEST=test on my workstation on Ubuntu, x86-mario, qemu using a web page which sets a JS value after a period. Original Review URL: http://codereview.chromium.org/6249003/ Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-by: Anton Sargent <asargent@chromium.org> Reviewed-by: William Chan <willchan@chromium.org> Reviewed-by: Thiago Farina <tfarina@chromium.org> Review URL: http://codereview.chromium.org/6288003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71408 0039d316-1c4b-4281-b951-d872f2087c98
* Add two new autofill browser tests.isherman@chromium.org2011-01-141-67/+136
| | | | | | | | | | | | * Test that autofill can be initiated by pressing the down arrow in a fillable field. * Test that autofill works after reloading the page. BUG=69219 TEST=interactive_ui_test --gtest_filter=AutoFillTest.* Review URL: http://codereview.chromium.org/6316001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71406 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling sync stress tests since they occasionally time outrsimha@chromium.org2011-01-143-8/+6
| | | | | | | | | | | | | | | | The sync stress tests (that use 10 sync clients) occasionally time out on the sync builders. The cause is not fully apparent at this time, and it doesn't make sense to arbitrarily increase the test timeout. Disabling tests until a long term fix is found. TBR=tim@chromium.org BUG=69604 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/6265003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71403 0039d316-1c4b-4281-b951-d872f2087c98
* Followup to http://codereview.chromium.org/5967003/dtu@chromium.org2011-01-143-9/+9
| | | | | | | | | | | UITestBase now creates its ProxyLauncher instance in SetUp() rather than its constructor. LaunchState no longer contains references. BUG=none TEST=none Review URL: http://codereview.chromium.org/6111011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71398 0039d316-1c4b-4281-b951-d872f2087c98
* Move chrome/browser/gtk/ to chrome/browser/ui/gtk/msw@chromium.org2011-01-14383-13021/+14433
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (moved *.cc using 'svn mv' to preserve history) (copied *.h using 'svn cp' to preserve history and stub out originals) Stubbed out original headers in chrome/browser/gtk/ Update header guards & copyright dates in chrome/browser/ui/gtk/ Update .gypi files Remove chrome/chrome_browser.gypi:4228 reference to nonexistant: ['include', '^browser/gtk/pk11_password_dialog.h'], Remove stray header guard in: chrome/browser/ui/gtk/bookmark_bar_instructions_gtk.cc Add #pragma once to the following files: chrome/browser/ui/gtk/instant_confirm_dialog_gtk.h chrome/browser/ui/gtk/infobar_arrow_model.h Ran the following to appease presubmit: 'svn pset svn:eol-style LF \ chrome/browser/ui/gtk/info_bubble_accelerators_gtk.cc \ chrome/browser/ui/gtk/gtk_custom_menu.cc \ chrome/browser/ui/gtk/info_bubble_accelerators_gtk.h \ chrome/browser/ui/gtk/gtk_custom_menu.h \ chrome/browser/ui/gtk/options/managed_prefs_banner_gtk.h \ chrome/browser/ui/gtk/chrome_gtk_frame.h \ chrome/browser/ui/gtk/chrome_gtk_frame.cc \ chrome/browser/ui/gtk/gtk_custom_menu_item.h \ chrome/browser/gtk/info_bubble_accelerators_gtk.h \ chrome/browser/gtk/gtk_custom_menu.h \ chrome/browser/gtk/options/managed_prefs_banner_gtk.h \ chrome/browser/gtk/chrome_gtk_frame.h \ chrome/browser/gtk/gtk_custom_menu_item.h' BUG=69289 TEST=Compile&Trybots Review URL: http://codereview.chromium.org/6251001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71397 0039d316-1c4b-4281-b951-d872f2087c98
* Fix passphrase unit test.johnnyg@chromium.org2011-01-141-1/+2
| | | | | | | | | | BUG=62103 TEST=none TBR=tim Review URL: http://codereview.chromium.org/6341001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71396 0039d316-1c4b-4281-b951-d872f2087c98
* Fix touch compile.sadrul@chromium.org2011-01-141-1/+1
| | | | | | TBR=gspencer@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71394 0039d316-1c4b-4281-b951-d872f2087c98
* Sync: Clean up fake URLFetcher factory prior to browser shut downrsimha@chromium.org2011-01-141-4/+4
| | | | | | | | | | | | | | | | | | | Revision 71253 introduced a fake URLFetcher factory to the sync tests. The clean up step of reverting to the default URLFetcher was added to LiveSyncTest::TearDown(), which is run after browser shut down. The correct place to add the clean up step is the method LiveSyncTest::TearDownInProcessBrowserTestFixture(), which is run prior to browser shut down. This patch merely moves the clean up step to the right spot. TBR=akalin@chromium.org BUG=69184, 56729, 53931 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/6251004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71392 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at fixing crash in ProcessPendingTabs. This differs from thesky@chromium.org2011-01-133-18/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | one you reviewed in that I changed a DCHECK in ProcessPendingTabs to an if. See the comments there for details (this was triggering a failure on chromeos). Description from last attempt: With the current code, during closing a window with unload handlers if a tab is disconnected then we delay cleanup by way of PostTask with the tab being disconnected. During the time between when the disconnect happens and the task is run the unloader handler sets still maintain a reference to the tab. If ProcessPendingTabs is invoked during this window and the tab is deleted, then we can crash. I'm fixing it by making disconnect remove from the sets immediately, but delay the call to ProcessPendingTabs. I'm also doing a similar thing in TabDetachedAt. BUG=15620 TEST=none Review URL: http://codereview.chromium.org/6321001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71388 0039d316-1c4b-4281-b951-d872f2087c98
* Fix chromeOs build after 71381.johnnyg@chromium.org2011-01-132-2/+4
| | | | | | | | | | TBR=tim BUG=62103 TEST=none Review URL: http://codereview.chromium.org/6266004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71387 0039d316-1c4b-4281-b951-d872f2087c98
* [gtk] shenanigans to get the confirm infobar's text to shrink/hide before ↵estade@chromium.org2011-01-131-7/+15
| | | | | | | | | | | the buttons do. BUG=68782 TEST=manual Review URL: http://codereview.chromium.org/6334001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71385 0039d316-1c4b-4281-b951-d872f2087c98
* Add a unique ID for each URL in the malware details protocol buffer. This ↵panayiotis@google.com2011-01-134-92/+130
| | | | | | | | | | allows us to save some space in the protocol buffer by not repeating the urls of parents and children. Also, change some string fields to bytes to avoid the implicit utf-8 conversion when not applicable. BUG=60831 TEST=relevant unit_tests, browser_tests Review URL: http://codereview.chromium.org/6208003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71384 0039d316-1c4b-4281-b951-d872f2087c98
* Password Autofill disables auto-completed textfielddhollowa@chromium.org2011-01-132-7/+16
| | | | | | | | | | | This change fixes an issue where the password completion, when the tab key is used to cycle focus, was causing focus to get lost. BUG=67888 TEST=PasswordAutocompleteManagerTest.*, and manual tests according to bug. Review URL: http://codereview.chromium.org/6280003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71383 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the security model for "chrome" URLsabarth@chromium.org2011-01-134-4/+13
| | | | | | | | | | | | | | | | | | This patch changes the security model for "chrome" URLs to make implementing some features in DOMUI easier. Instead of registering "chrome" as a NoAccess and a Local scheme, we register it as a DisplayIsolated scheme. That should have the effects outlined in this email: http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/863700bf99b3f3ed See also https://bugs.webkit.org/show_bug.cgi?id=50182 which introduces the necessary API into WebKit. BUG=69140 Review URL: http://codereview.chromium.org/5268006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71382 0039d316-1c4b-4281-b951-d872f2087c98
* Further tweaks to the passphrase UI to deal with passphrase entry.johnnyg@chromium.org2011-01-1310-56/+124
| | | | | | | | | BUG=62103 TEST=none Review URL: http://codereview.chromium.org/6309002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71381 0039d316-1c4b-4281-b951-d872f2087c98
* Add support to sha256 hash the downloaded file.lzheng@chromium.org2011-01-139-27/+139
| | | | | | | | | BUG=60822 TEST=base_file_unittest.cc Review URL: http://codereview.chromium.org/6023006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71379 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the nord flag to the instant url so that if igoogle is yoursky@chromium.org2011-01-131-2/+2
| | | | | | | | | | | Google home page instant works correctly. BUG=none TEST=none Review URL: http://codereview.chromium.org/6331001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71372 0039d316-1c4b-4281-b951-d872f2087c98
* Make the Linux build not fail because of an unhandled enum.jam@chromium.org2011-01-131-0/+2
| | | | | | Review URL: http://codereview.chromium.org/6258002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71369 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded chrome/browser/ui/browser.h usage.thestig@chromium.org2011-01-1365-71/+44
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6260001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71368 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed bug 64847: Graphics2D paints outside plugin boundaries. Also removed ↵ddorwin@chromium.org2011-01-131-1/+0
| | | | | | | | | | | unused |origin| variables. BUG=64847 TEST=Modify the first condition in example.cc::MyInstance::DidChangeView() to use "<=" instead of "==". On the example page, use the Toggle Size button to make the plugin larger then smaller. The plugin should not paint outside its boundary. Review URL: http://codereview.chromium.org/6207002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71365 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Run beforeunload handlers when closing panels.derat@chromium.org2011-01-136-2/+19
| | | | | | | | | | | | | | | | | | | | | | | When a panel content window has a beforeunload handler, we'd previously close its titlebar (which would cause the window manager to also hide the content window in anticipation of it being closed too), but then leave the content window mapped and open a modal dialog (which would be kept invisible by the window manager). This would effectively freeze the UI unless the user happened to press the Escape key, which would still leave us in a state where we'd end up restoring the panel again the next time the session was restored. This change makes us instead call BrowserView::CanClose() first and avoid closing the panel if we're not supposed to. BUG=chromium-os:10910 TEST=went to air1.com/listen and checked that i get an alert when closing the panel with "leave this page" and "stay on this page" buttons that function as expected Review URL: http://codereview.chromium.org/6247002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71363 0039d316-1c4b-4281-b951-d872f2087c98
* sync: annotate call to join SyncCoreThread to keep ThreadRestrictions happy.tim@chromium.org2011-01-131-4/+9
| | | | | | | | | | | | Bug 19757 discusses how we block the UI thread on the core thread when shutting down sync. Until that is fixed, we have to fess up to the Thread police. BUG=69570,19757 TEST=Start syncing in debug build. Stop sync. Don't crash. Review URL: http://codereview.chromium.org/6328001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71361 0039d316-1c4b-4281-b951-d872f2087c98
* This adds a "killed tab" page to be displayed in the case where a tab is ↵gspencer@chromium.org2011-01-1331-48/+179
| | | | | | | | | | | | | | | killed instead of crashing. It also adds "about:kill" to simulate kills. On ChromeOS killed tabs will be reloaded as soon as the user clicks on them unless they are the only tab, or the currently focused tab is killed. BUG=http://crosbug.com/10043, http://crosbug.com/10711 TEST=Built linux and ChromeOS Chrome and killed a tab, and then did about:crash and made sure that the "Aw, Snap!" page was displayed. Did about:kill and made sure kill page was displayed. Review URL: http://codereview.chromium.org/6053012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71360 0039d316-1c4b-4281-b951-d872f2087c98
* GPU service now runs on new thread in browser process when --single-process ↵apatrick@chromium.org2011-01-139-55/+126
| | | | | | | | | | | is specified. TEST=try BUG=none Review URL: http://codereview.chromium.org/6189008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71359 0039d316-1c4b-4281-b951-d872f2087c98
* Fix touch compile.sadrul@chromium.org2011-01-132-2/+2
| | | | | | | | | | BUG=touchbot fails (http://build.chromium.org/p/chromium.fyi/waterfall?branch=&builder=Chromium+Linux+Touch&builder=Chromium+Linux+Touch+%28dbg%29) TEST=touchbot works Review URL: http://codereview.chromium.org/6317002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71358 0039d316-1c4b-4281-b951-d872f2087c98
* The sync server supports a new "progress token" scheme that allows data ↵nick@chromium.org2011-01-1336-595/+787
| | | | | | | | | | | | | | | | types to be requested with a different timestamp per datatype. The benefits of this approach are: - timestamps become opaque to the client, which makes - the client no longer has to rely on timestamps converging for all datatypes. - the server will send fewer redundant updates after enabling a new datatype. - the flexibility of the opaque field allows the server to implement other optimizations which will increase scalability & performance BUG=58217 TEST=manual test of sync (old profile+new profile), unit tests, integ tests Review URL: http://codereview.chromium.org/6104003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71357 0039d316-1c4b-4281-b951-d872f2087c98
* Tag a couple of functions with OVERRIDEagl@chromium.org2011-01-131-2/+3
| | | | | | | | | | | | | I'm going to be updating the underlying class (in WebKit) and don't want these functions to be siliently disconnected in the event that the WebKit merge doesn't work exactly as planned. BUG=none TEST=compile http://codereview.chromium.org/6320001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71352 0039d316-1c4b-4281-b951-d872f2087c98
* NSS: don't set environment variables when multi-threaded.agl@chromium.org2011-01-131-0/+5
| | | | | | | | | | | | | We can't alter the envionment once we have gone multithreaded because glibc's getenv doesn't take the environment lock. Thus we add an EarlyNSSInit() function which can do so, early in startup. BUG=66835 TEST=ThreadSanitizer http://codereview.chromium.org/6185005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71351 0039d316-1c4b-4281-b951-d872f2087c98
* touch: Set the timestamp for the touchevent.sadrul@chromium.org2011-01-131-0/+1
| | | | | | | | | BUG=touchy clicks don't work TEST=touchy clicks work Review URL: http://codereview.chromium.org/6175006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71348 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI: Fix error dialog in certificate manager missing ok button. Fix leak.mattm@chromium.org2011-01-131-4/+5
| | | | | | | | | BUG=none TEST=open cert manager, try to import non-existent file / etc Review URL: http://codereview.chromium.org/6277001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71346 0039d316-1c4b-4281-b951-d872f2087c98
* NamedInterfaceTest.BasicNamedInterface flakiness was fixed in this change:dtu@chromium.org2011-01-131-9/+1
| | | | | | | | | | | | | | http://codereview.chromium.org/5967003/ and is no longer flaky as of Friday, Jan 7. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=NamedInterfaceTest&testType=ui_tests BUG=66414 TEST=none Review URL: http://codereview.chromium.org/6224004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71345 0039d316-1c4b-4281-b951-d872f2087c98
* Convert comments to CurrentlyOn checks.estade@chromium.org2011-01-131-24/+24
| | | | | | | | | BUG=none TEST=trybots Review URL: http://codereview.chromium.org/6254001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71341 0039d316-1c4b-4281-b951-d872f2087c98
* New art for the wrench menu BG page badge.atwilson@chromium.org2011-01-132-0/+0
| | | | | | | | | BUG=none TEST=run chrome, install app with background page, see new art on wrench menu Review URL: http://codereview.chromium.org/6252002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71339 0039d316-1c4b-4281-b951-d872f2087c98
* Disable background network access in sync integration testsrsimha@chromium.org2011-01-133-25/+24
| | | | | | | | | | | | | | | | Now that the sync integration tests are designed to be self-contained and not rely on external network resources like GAIA, we need to ensure that background network access for things like auto update is disabled. This patch adds the --disable-background-networking command line switch to the sync integration test framework. BUG=69469, 53931 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/6282001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71338 0039d316-1c4b-4281-b951-d872f2087c98
* sync: avoid creating a HistoryModelWorker unless it is needed.tim@chromium.org2011-01-133-10/+12
| | | | | | | | | | | | We typically add all known workers when Initializing the SyncBackendHost, but this one is causing crashes and isn't used by default. BUG=53916,69561 TEST=none Review URL: http://codereview.chromium.org/6111012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71337 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 71327 - Attempt at fixing crash in ProcessPendingTabs. With the ↵sky@chromium.org2011-01-133-30/+17
| | | | | | | | | | | | | | | | | | | | | | | | | current code, during closing a window with unload handlers if a tab is disconnected then we delay cleanup by way of PostTask with the tab being disconnected. During the time between when the disconnect happens and the task is run the unloader handler sets still maintain a reference to the tab. If ProcessPendingTabs is invoked during this window and the tab is deleted, then we can crash. I'm fixing it by making disconnect remove from the sets immediately, but delay the call to ProcessPendingTabs. I'm also doing a similar thing in TabDetachedAt. BUG=15620 TEST=none Review URL: http://codereview.chromium.org/6203006 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/6318001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71336 0039d316-1c4b-4281-b951-d872f2087c98
* Move app/key* to ui/base/keycodes/*ben@chromium.org2011-01-1380-657/+632
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6246001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71330 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt at fixing crash in ProcessPendingTabs. With the current code,sky@chromium.org2011-01-133-17/+30
| | | | | | | | | | | | | | | | | | | | during closing a window with unload handlers if a tab is disconnected then we delay cleanup by way of PostTask with the tab being disconnected. During the time between when the disconnect happens and the task is run the unloader handler sets still maintain a reference to the tab. If ProcessPendingTabs is invoked during this window and the tab is deleted, then we can crash. I'm fixing it by making disconnect remove from the sets immediately, but delay the call to ProcessPendingTabs. I'm also doing a similar thing in TabDetachedAt. BUG=15620 TEST=none Review URL: http://codereview.chromium.org/6203006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71327 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix a bunch of NULL vs. 0 issues spotted by gcc 4.5.craig.schlenter@chromium.org2011-01-1310-16/+16
| | | | | | | | | | | | There are more gcc 4.5 issues to be solved so GYP_DEFINES=='werror=' is still required to build with 4.5 even with these changes. BUG=66652 TEST=compiles with gcc 4.5 and trybots Review URL: http://codereview.chromium.org/6186008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71325 0039d316-1c4b-4281-b951-d872f2087c98
* In ExtensionHostMac::~ExtensionHostMac, only close visible popups.rsesek@chromium.org2011-01-131-2/+3
| | | | | | | | | BUG=56340 TEST=Click on a browser action to open it. Click on the button again to close it. Click on it a third time to open, and it should open as expected. Review URL: http://codereview.chromium.org/6195004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71324 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-19 13:56:10 +0000