summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Update some comments/nits following r7486.ericroman@google.com2009-01-052-4/+5
| | | | | | Review URL: http://codereview.chromium.org/17047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7547 0039d316-1c4b-4281-b951-d872f2087c98
* Windows SCons build fixes.phajdan.jr@chromium.org2009-01-052-1/+6
| | | | | | Review URL: http://codereview.chromium.org/17054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7546 0039d316-1c4b-4281-b951-d872f2087c98
* Fix part of linking problems in Windows SCons build.phajdan.jr@chromium.org2009-01-031-0/+4
| | | | | | Review URL: http://codereview.chromium.org/17049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7540 0039d316-1c4b-4281-b951-d872f2087c98
* g++ 4.3.x doesn't seem to like forward declarationsphajdan.jr@chromium.org2009-01-031-1/+3
| | | | | | | | | | with namespace::classname so declare the forward declaration inside the appropriate namespace. Review URL: http://codereview.chromium.org/16508 Patch from Craig Schlenter. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7539 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a leak in unzip code. I was calling the wrong close function.erikkay@google.com2008-12-311-1/+1
| | | | | | | | TBR=aa Review URL: http://codereview.chromium.org/17039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7531 0039d316-1c4b-4281-b951-d872f2087c98
* Add generic unzip support. This is to be used by extensions.erikkay@google.com2008-12-3113-9/+384
| | | | | | | depends on http://codereview.chromium.org/16605 Review URL: http://codereview.chromium.org/16487 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7530 0039d316-1c4b-4281-b951-d872f2087c98
* Porting in chrome/phajdan.jr@chromium.org2008-12-319-22/+20
| | | | | | Review URL: http://codereview.chromium.org/17016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7529 0039d316-1c4b-4281-b951-d872f2087c98
* Bug fix issue 4669 (http://code.google.com/p/chromium/issues/detail?id=4669)hclam@chromium.org2008-12-311-1/+2
| | | | | | | | | When doing a view source action and then go to other address and back to view source page. Forward addresses become backward addresses. The reason is that every view source page is treated as a standard load because content_state() is always empty. The content state should be filled in SetContentStateIfEmpty() Review URL: http://codereview.chromium.org/16221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7524 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 7508.7509 and 7510nsylvain@chromium.org2008-12-3019-375/+222
| | | | | | Review URL: http://codereview.chromium.org/17030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7514 0039d316-1c4b-4281-b951-d872f2087c98
* Add FTP unit test in preparation for portable FTP implementation.erikkay@google.com2008-12-3019-222/+375
| | | | | | | | | | | Clean up test server code. Originally from issue 12939, written by Ibrar Ahmed (ibrar.ahmed@gmail.com) Review URL: http://codereview.chromium.org/16490 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7508 0039d316-1c4b-4281-b951-d872f2087c98
* Adjusting the name of a function to make it more descriptive.avi@google.com2008-12-302-2/+2
| | | | | | Review URL: http://codereview.chromium.org/16489 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7504 0039d316-1c4b-4281-b951-d872f2087c98
* Provide and use auto startup/teardown for tracked objectsjar@google.com2008-12-301-21/+9
| | | | | | | | | | Avoid races with message loop teardown r=nsylvain Review URL: http://codereview.chromium.org/17023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7503 0039d316-1c4b-4281-b951-d872f2087c98
* Revert sdk 6.1 upgrade changes.jungshik@google.com2008-12-301-32/+31
| | | | | | | | TBR=nsylvain Review URL: http://codereview.chromium.org/17021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7501 0039d316-1c4b-4281-b951-d872f2087c98
* Change build-related files to use Windows SDK 6.1 instead of Windows SDK 6.0.jungshik@google.com2008-12-301-0/+1
| | | | | | | | | | | SDK upgrade is necessary to support dynamic/webfont because SDK 6.0 does not have t2embapi.h and t2embed.lib. SDK 6.1 is compatible with WIn XP and VS 2005 or later. FYI: http://codereview.chromium.org/14084/show is the CL for adding web/dynamic font support. Review URL: http://codereview.chromium.org/14908 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7500 0039d316-1c4b-4281-b951-d872f2087c98
* Remove compatibility #defines in string_util.hphajdan.jr@chromium.org2008-12-302-5/+8
| | | | | | Review URL: http://codereview.chromium.org/17014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7499 0039d316-1c4b-4281-b951-d872f2087c98
* Enable Hebrew spell checker after Jeremy fixed the underlying Webkit bug.xji@chromium.org2008-12-301-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | Related bug: http://code.google.com/p/chromium/issues/detail?id=2779 Related Webkit fix: http://trac.webkit.org/changeset/36874 Test: Steps to repro: 1) open chrome, Hebrew UI 2) make sure the spell checker is on, and is set to Hebrew 3) type some Hebrew text in a RTL box (like RTL plain text finto), and use a Hebrew word that the speller does not know. 4) type some more Without the underlying Webkit fix: the highlight marker is in a wrong location, and keeps moving while typing more words after the unrecognized one. With the underlying Webkit fix: the highlight marker is in a correct and fixed location. Review URL: http://codereview.chromium.org/16606 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7496 0039d316-1c4b-4281-b951-d872f2087c98
* Part 1 of 'Add common words for each language, and remove forbidden words'.sidchat@google.com2008-12-292-27/+59
| | | | | | | | | | | Updated the Dic Reader to read additional words from additional-words dictionary file, created as a text file with UTF-8 encoding, with extension dic_delta. Test: Tested with all the 21 languages that are currently supported by the spell checker and for which common/additional words have been obtained. Resulting bdic files generated have those additional words. Issue=2837. Review URL: http://codereview.chromium.org/14856 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7492 0039d316-1c4b-4281-b951-d872f2087c98
* Change the signature of JSONReader::Read() and relatedaa@chromium.org2008-12-2917-149/+121
| | | | | | | | | methods to be more friendly to use with scoped_ptr. Change all the callsites. Review URL: http://codereview.chromium.org/16270 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7486 0039d316-1c4b-4281-b951-d872f2087c98
* * Bring up render_mesages.cc on POSIX.jeremy@chromium.org2008-12-293-2/+24
| | | | | | | | | * Add Pickle::Read/WriteUint32 & ParamTraits<uint32>. * Removed NSEvent from WebInputEvent since it appears not to be needed anymore. Review URL: http://codereview.chromium.org/16479 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7484 0039d316-1c4b-4281-b951-d872f2087c98
* * Update xcode project to add files compiled on Linux but not on OS X in ↵jeremy@chromium.org2008-12-293-30/+44
| | | | | | | | | chrome/common. * Update chrome/common/common.scons for OS X. * bring up property_bag_unittest.cc on Linux & OS X. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7482 0039d316-1c4b-4281-b951-d872f2087c98
* Blind attempt at a fix for the Windows SCons build.evanm@google.com2008-12-261-1/+0
| | | | | | | | I didn't break it, but it'd be useful for verifying my other changes didn't break things if the Windows SCons build were green. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7480 0039d316-1c4b-4281-b951-d872f2087c98
* Mass convert ChromeStaticLibrary -> ChromeLibrary, including pulling the ↵evanm@google.com2008-12-2610-10/+10
| | | | | | | | | | | updated ICU dep that uses it as well. Add a SHARED scons command-line flag to build shared libraries. Review URL: http://codereview.chromium.org/16477 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7479 0039d316-1c4b-4281-b951-d872f2087c98
* Initial subset of .vcproj file generation, covering generation of:sgk@google.com2008-12-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | base\build\base.vcproj base\build\base_gfx.vcproj base\build\base_unittests.vcproj base\build\debug_message.vcproj skia\skia.vcproj testing\gtest.vcproj third_party\icu38\icu.vcproj third_party\icu38\icudt.vcproj third_party\libpng\libpng.vcproj third_party\zlib\zlib.vcproj Supporting work in *.scons files: * Adds .h files to the input_files lists in the various *.scons files. * Add arguments to ChromeMSVSProject() to actually generate the .vcproj files. * Add MSVS.AddConfig() calls to the *.scons files to preserve the .vsprops inclusion in the generated .vcproj files. (These will go away eventually as we migrate away from .vsprops in favor of using the settings from the SCons configuration.) * Add MSVS.AddConfig() calls to preserve the .vsprops inclusion. * Move the special generation of dmg_fp/*.cc files ahead of the input file list so we can list the generated object files. * Change the 'solutions' Alias to 'msvs' so we don't mislead about what will actually be generated. Updates to the new _Node_MSVS.py module with latest from upstream prototype development: * Support configurability of: * buildtarget (used to generat project name) * RootNamespace * relative_path_prefix (to prepend './') * tools (to avoid repetition in the project configs) * Track the Visual Studio hierarchy in SCons Nodes, not DOM, so we can delay evaluation until after the complete configuration has been specified. * Add a FileList base class for the things that need, with a subclass hierarchy for the different concrete things in our tree, and a FileListWalk() function for traversing hierarchies. * Centralize turning strings into Nodes in the args2nodes() method and have AddFiles() just use it. Updates to chromium_builders.py to support all this * Add knowledge about stripping out noncompilable files (.h files) from input_files lists. * Return a Null() class if we're not generating MSVS files so we don't have to hide the other calls in if:-blocks. * Add custom ChromeFileList subclass of MSVS.FileList as a container for the file list manipulation we need to do. * Move the Chrome*() function definitions out to global space, and just use the generate() function for adding them to the passed-in environment as class methods. * Make a change to SCons (in Node/FS.py) to handle polymorphism in the new MSVS Node hierarchy. Review URL: http://codereview.chromium.org/16447 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7467 0039d316-1c4b-4281-b951-d872f2087c98
* Implement extension:// protocol.aa@chromium.org2008-12-2419-44/+265
| | | | | | Review URL: http://codereview.chromium.org/15010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7462 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes NPAPITester ui tests. I was trying to diagnose failing ui testssky@google.com2008-12-231-3/+29
| | | | | | | | | | | | | | and with page heap enabled these tests consistenly crashed on me. I've no idea about this code, but this change fixed it. As far as I can tell in some cases Send deletes the NPObjectProxy, so that any code that attempts to access the proxy after the Send may crash. BUG=none TEST=none Review URL: http://codereview.chromium.org/16418 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7452 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the two URLRequestContext subclasses in profile.cc into a new sharedaa@chromium.org2008-12-235-279/+267
| | | | | | | | | | | | | | | | | ChromeRequestContext class. This will allow us to put browser-specific request context here rather than in URLRequestContext and eliminates a lot of duplicate code. I looked at having two different classes using either inheritance (as proposed by the existing TODO) or composition, but it seems like there isn't enough difference between these two classes to justify it. Removed is_off_the_record() because it wasn't being used anywhere and did a few other minor code cleanup things. Review URL: http://codereview.chromium.org/16408 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7448 0039d316-1c4b-4281-b951-d872f2087c98
* Add a dummy PostThreadMessage and PeekMessage call to help inform Windows ↵darin@chromium.org2008-12-231-9/+19
| | | | | | | | | | | that our subprocesses have started up. This causes Windows to promptly stop showing the IDC_APPSTARTING cursor when opening a new tab or navigating to a new domain via the location bar. BUG=4805 R=ananta Review URL: http://codereview.chromium.org/16464 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7447 0039d316-1c4b-4281-b951-d872f2087c98
* Add some ui_tests to the Purify skip filter until we can fix them.paulg@google.com2008-12-231-0/+5
| | | | | | | | TBR=erikkay Review URL: http://codereview.chromium.org/16245 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7435 0039d316-1c4b-4281-b951-d872f2087c98
* * Bring up GreaseMonkeySlave unittest on OS X.jeremy@chromium.org2008-12-233-4/+29
| | | | | | | | * Fix missing Autoreleasepool warning in SafeBrowsing Unittest. Review URL: http://codereview.chromium.org/16243 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7432 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting my landing (of a patch by external contributer).finnur@google.com2008-12-231-4/+1
| | | | | | | | | | I jumped the gun, Peter raised additional issues after we both LGTM'ed (and I didn't notice those emails). TBR=pkasting Review URL: http://codereview.chromium.org/16234 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7412 0039d316-1c4b-4281-b951-d872f2087c98
* Landing a patch for m0interactive (already in the AUTHORS list):finnur@google.com2008-12-231-1/+4
| | | | | | | | | | | | | | | | Ctrl+U should show up view-source on Application shortcuts. According to pkasting in dev mailing list: "Ctrl-U for an application should do what the context menu option does: open a source tab in some normal window." Hence, made it a NEW_FOREGROUND_TAB for disposition TBR=pkasting BUG=http://crbug.com/5115 Review URL: http://codereview.chromium.org/16233 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7408 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 4830: We navigate back after closing the Save As dialog.finnur@google.com2008-12-231-2/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | If you use Alt-Shift-T and the arrow keys to go to the Page menu and then launch the Save Page As dialog, we would navigate back after saving the page. This is because once we close the Save As dialog with Enter, focus goes to the Back button (which arguable is also wrong, see issue 5750) and it receives a KeyRelease(Enter), which causes us to navigate back right after saving the page. In Windows, pressing Enter while a button has focus clicks the button on KeyPressed, whereas we currently click the button on KeyRelease. This patch makes Chrome mimic native Windows behavior. We retain the current behavior for Space, however, which clicks on KeyReleased in both Chrome and Windows. BUG=4830 TEST=Native Chrome buttons should click buttons on KeyPress when using Enter and on KeyRelease when using Space. Review URL: http://codereview.chromium.org/16202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7406 0039d316-1c4b-4281-b951-d872f2087c98
* New attempt at landing the resource_dispatcher_host.cc splitting (broke the ↵jcampan@chromium.org2008-12-2341-2635/+3137
| | | | | | | | | build on Friday). TBR=darin Review URL: http://codereview.chromium.org/15801 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7400 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Win/Release build bustage.jeremy@chromium.org2008-12-221-0/+2
| | | | | | Review URL: http://codereview.chromium.org/16435 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7393 0039d316-1c4b-4281-b951-d872f2087c98
* Make Maximized Mode Not Suck, part 1 (checkpoint).pkasting@chromium.org2008-12-221-170/+182
| | | | | | | | | | | | | | | | Pixel perfection (I think) on Normal and App windows, maximized and restored, on Windows XP Luna with default fonts and border widths. Among other things, fixes window control placement, tabstrip height, window icon/title placement, and client edge drawing (especially at the tops/bottoms of windows). Known to still be broken: Popup windows Untested: Vista non-Aero, Classic, non-default fonts/borders, non-main windows (Options, Task Manager, etc.) This change is pretty hacky in some places; once I get the behavior nailed perfectly I'll need to go back and try and cut down on the number of constants and use better logic instead. I do at least try to remove some of the current hacks or else document them. Eventually I'll need Ben's and Glen's eyeballs for things, as I've had to make judgment calls about the correct behaviors; some of these I copied our 1.0 behavior, and some I've tried to ape a native app more closely. Especially tricky are the positioning of window icons/titles, since our titlebar isn't quite like a native one. BUG=5054 Review URL: http://codereview.chromium.org/16219 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7391 0039d316-1c4b-4281-b951-d872f2087c98
* Bring up chrome/common/ipc_sync_message.cc on POSIX.jeremy@chromium.org2008-12-224-7/+24
| | | | | | Review URL: http://codereview.chromium.org/16428 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7390 0039d316-1c4b-4281-b951-d872f2087c98
* Bump build to 156: I branched 155 for a release build ChromeBot run.mal@chromium.org2008-12-221-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7386 0039d316-1c4b-4281-b951-d872f2087c98
* Bring up IPC::ChannelProxy on POSIX.jeremy@chromium.org2008-12-225-4/+68
| | | | | | Review URL: http://codereview.chromium.org/16426 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7385 0039d316-1c4b-4281-b951-d872f2087c98
* My Friday fix for some stack trashing introduced some heap trashing!jcampan@chromium.org2008-12-221-20/+37
| | | | | | | | | | | | | | | | | | The tests create PageInterstitial objects which are self-owned (they delete themselves when hidden). The tests test whether the PageInterstitial instance has been deleted by passing a local variable boolean to its constructor that the InterstitialPage sets to true when deleted. In the stack trashing case, in one of the test the interstitial was deleted from the TearDown() method, so outside of the scope of the test. The interstitial was still accessing the local variable from the test scope, trashing the stack. My previous fix introduced a state guard class allocated on the stack that would notify the InterstitialPage when deleted so it would clear any reference to the local vars, which fixed the stack trashing. But this created a new problem: when the interstitial is deleted in the scope of the unit tests, the state guard object still holds a reference to the now deleted interstitial and calls a method on it when itself deleted. This CL ensures the state guard class does not access any deleted interstitial. BUG=5789 Review URL: http://codereview.chromium.org/16423 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7384 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/16209jcampan@chromium.org2008-12-221-12/+19
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7355 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix Windows build.phajdan.jr@chromium.org2008-12-201-1/+1
| | | | | | Review URL: http://codereview.chromium.org/14920 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7345 0039d316-1c4b-4281-b951-d872f2087c98
* Platform cleanup in chrome/browser/net.phajdan.jr@chromium.org2008-12-205-29/+23
| | | | | | | | Preparing for more complex changes. Review URL: http://codereview.chromium.org/14919 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7344 0039d316-1c4b-4281-b951-d872f2087c98
* Changed DomAutomationController to use UTF-8 strings.scherkus@chromium.org2008-12-201-1/+1
| | | | | | Review URL: http://codereview.chromium.org/15071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7340 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting my CL to fix build bustage.jcampan@chromium.org2008-12-2040-3135/+2633
| | | | | | | TBR=maruel Review URL: http://codereview.chromium.org/15099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7338 0039d316-1c4b-4281-b951-d872f2087c98
* This CL moves the different resource handlers from ↵jcampan@chromium.org2008-12-2040-2633/+3135
| | | | | | | | | | | | | | | | resource_dispatcher_host.cc into their own files, into a new renderer_host directory. Their is no functionality change in this CL. The motivation for doing that was: - resource_dispatcher_host.cc has become very long and more than 1/3 of the code is for the resource handler. - having the resource handler in their own file allows having unit tests for them. BUG=none TEST=run all unit tests and UI tests. Review URL: http://codereview.chromium.org/14487 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7336 0039d316-1c4b-4281-b951-d872f2087c98
* The unit test WebContentsTest.ShowInterstitialProceedMultipleCommands was ↵jcampan@chromium.org2008-12-191-5/+49
| | | | | | | | | | | | crashing. This was caused by a class dereferencing a pointer to a local variable out of the scope of the local var, trashing the stack. BUG=5700 TEST=Run the unit tests. Review URL: http://codereview.chromium.org/14909 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7330 0039d316-1c4b-4281-b951-d872f2087c98
* After staring at this line of code I realized it was saying something much ↵pkasting@chromium.org2008-12-191-3/+1
| | | | | | | | simpler. Review URL: http://codereview.chromium.org/14904 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7322 0039d316-1c4b-4281-b951-d872f2087c98
* Implement command line switch to allow using a FIFO or a socketpair() for ↵jeremy@chromium.org2008-12-196-33/+169
| | | | | | | | IPC on POSIX. Review URL: http://codereview.chromium.org/14863 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7319 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 7304 to reapply 7296. It wasn't its fault.maruel@chromium.org2008-12-191-4/+4
| | | | | | Review URL: http://codereview.chromium.org/15083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7308 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 7306 to reapply 7296. It wasn't its fault.maruel@chromium.org2008-12-191-0/+1
| | | | | | Review URL: http://codereview.chromium.org/15603 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7307 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 05:21:39 +0000