| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
TBR=levin
Review URL: http://codereview.chromium.org/147131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/147121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/146127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
stuff going on here, I can't begin to unravel it on more than one platform at a time.
TBR=sky
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/146125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
view-source mode not to show error page in view-source mode. However, on
cancellation, it's not necessary and sometimes render non-error page with
view-source: prefix in non view-source mode by mistake.
In fixing this, I pushed down SetInViewSourceMode to RenderView from
WebFrameImpl. We can control view-source state more precisely by this way.
Patch by tyoshino@google.com
Original review: http://codereview.chromium.org/122026
BUG=4516
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
so that they can be built from scratch and complete.
Review URL: http://codereview.chromium.org/132056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Correct row index calculation in bookmark manager drag receive.
- Support multiple target dnd
also see http://crbug.com/15240
BUG=none
TEST=multi dragging in bookmark manager/bookmark bar. See cited bug for explanation of how to multi-drag.
Review URL: http://codereview.chromium.org/147107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
hidden.
Also, update the height of the lower section so that content does not
get clipped.
BUG=15234, 15106
TEST=Hide the thumbnails on the new new tab page. There should be no
way that clicking on some empty space would activate a hidden
.thumbnail For the second part of this bug close 5+ tabs and check that
the Recently closed section does not get clipped.
Review URL: http://codereview.chromium.org/146120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
accessed after the views have been removed.
This was causing a crasher in the browser tests (as a deleted object was accessed).
BUG=None
TEST=Run the browser tests.
Review URL: http://codereview.chromium.org/147110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(case-sensitive file system).
BUG=8647
TEST=Pass ui test on Linux
TBR=tony
Review URL: http://codereview.chromium.org/146117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
edit link.
BUG=14958, 15073
TEST=On the new new tab page. No "edit" link should show up after a
long hover of a thumbnail. The pin/unpin, remove, show/hide thumbnails,
show/hide list should all show tooltips.
Review URL: http://codereview.chromium.org/146108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
My last patch (http://src.chromium.org/viewvc/chrome?view=rev&revision=18584) should have been for chrome/browser/views/tab_contents/tab_contents_view_win.cc, not for chrome/browser/tab_contents/tab_contents_view_win.cc since the latter had been deleted (http://src.chromium.org/viewvc/chrome?view=rev&revision=18368).
I've confirmed that no patch other than mine is submitted to the old file:
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents_view_win.cc?view=log
BUG=12290
TEST=See http://codereview.chromium.org/125111
Review URL: http://codereview.chromium.org/147074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/15226
TEST=see bug
Review URL: http://codereview.chromium.org/147112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
not required, yet were creating compile errors when building unit_tests.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/132032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Added timer to clean unpopular thumbnails from the cache/disk every hour.
Still need to implement removal of blacklisted urls.
Review URL: http://codereview.chromium.org/126237
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
hadn't expired (5 seconds), even if there was no backing store. We now use the
stashed one no matter what if there is no backing store to create a new one.
Review URL: http://codereview.chromium.org/147087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
figure these perf regressions out.
TEST=graphs
BUG=15232
Review URL: http://codereview.chromium.org/147113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/146097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Change the locale param to be std::string because they're always ASCII and change call-sites accordingly.
2. Add GetStringFUTF16 to l10n_util. On Windows, they're inline helpers calling the correspondingGetStringF returning wstring while on Mac/Linux, they just return the result of |string16 GetStringF|without converting to wstring.
This is part 1 of the fix for issue 8647. Some of newly introduced conversions are temporary and will be removed later (e.g. ASCIIToWide applied to the result of GetApplicationLocale in a few places).
Note : this CL will be landed after http://codereview.chromium.org/147038 is landed.
BUG=8647 (http://crbug.com/8647)
TEST=Pass l10n_util_unittest and other unit tests
Review URL: http://codereview.chromium.org/126223
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
definitions file for installation.)
Review URL: http://codereview.chromium.org/146109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Add a unittest that pretends to be the UtilityProcessHost and launches a chrome utility process for unpacking a theme.
Review URL: http://codereview.chromium.org/147001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Open a browser window in a RTL language (--lang=he). The bookmark bar layout should correctly be in RTL layout.
Review URL: http://codereview.chromium.org/146105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For users with AFS home directories, we cannot create UNIX domain
sockets for ProcessSingleton. Before this patch we would spin because
the socket would be constantly 'readable' for accept.
http://codereview.chromium.org/139008
BUG=14237
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is a regression introduced by a recent change that fixed another bug.
The problem was that we were not dealing with the empty selection case in the password table.
BUG=http://crbug.com/15215
TEST=Open the "show saved password" dialog in the options. Move the selection around. Delete a password. Show a password, then move the selection, the password should not be shown anymore.
Review URL: http://codereview.chromium.org/147104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
r=erikkay,mark
Review URL: http://codereview.chromium.org/145026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
installation."
This reverts commit r19170.
Review URL: http://codereview.chromium.org/146106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=14201
Review URL: http://codereview.chromium.org/147092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/147105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
revision 18898 (when WebKit revision 44901 was merged in).
BUG=14491
TEST=That's what this is all about.
Review URL: http://codereview.chromium.org/146102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=15232
TEST=watch perf graphs
Review URL: http://codereview.chromium.org/147103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=14959
TEST=The option menu on the new new tab page should react to keyboard
and mouse events.
Review URL: http://codereview.chromium.org/147097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GtkFixeds do allocate their children. They give them an allocation that matches
their size request. Hence when you directly allocate the child, it gets two
allocates right in a row (one from you, one from the fixed). This was causing
flicker in slide animator gtk (most noticeable when opening a new browser window
and seeing the restore infobar, but also confirmed with debugging statements). The original reason for needing to use
size_allocate() instead of set_size_request() (which had to do with browser
window resizing) is now obsolete, so revert these back to size_request()s.
BUG=none
TEST=less flicker when an infobar is opening; border at bottom of toolbar/bookmark bar still looks the same
Review URL: http://codereview.chromium.org/147100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Open a browser window in a RTL language (--lang=he). The toolbar layout should correctly be in RTL layout.
Review URL: http://codereview.chromium.org/147102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
active browser. Not doing so was breaking code that opened a new window and
then immediatly opened aditional tabs in it.
http://crbug.com/14018
Review URL: http://codereview.chromium.org/147091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This also makes the findbar entry look the same on all system themes (dark themes no longer distinct).
BUG=none
TEST=when you fail to find something the background of the match count label turns orange, and when you succeed in finding something the background is white.
Review URL: http://codereview.chromium.org/147053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
fallback to the prefs object.
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/147095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
like A-B.jpg becoming B.jpg-A on download page and new-new-tab/download section.BUG=http://crbug.com/15094TEST=Start Chrome with --lang=he --new-new-tab options and check that filename with - in the name has the proper form (check bug on how to get the file). I've checked LTR language (sr) too and output remains correct.
Review URL: http://codereview.chromium.org/146064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=15078
TEST=prefs listed in bug. Not sure how to test nav errors or usage stats (since we don't really send them) or DNS pre-fetch.
Review URL: http://codereview.chromium.org/146088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- The analisis team needs a control group; these are users that qualify don't get the experiment.
- Select 50 % at random
BUG= b/1484308
TEST = see the bug
Review URL: http://codereview.chromium.org/147057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=If you use remote desktop you should not see any animations as you
hide/show the thumbnails on the new new tab page.
Review URL: http://codereview.chromium.org/147086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
button is clicked a second time.
BUG=14959, 15067
TEST=Tab to the options button. Try pressing the down arrow, up arrow
or enter. These should show the menu. Try pressing esc to hide the
menu. Try pressing enter to execute the item. Try opening the menu,
both using the mouse and keyboard and make sure that it is hidden as
expected.
Review URL: http://codereview.chromium.org/147071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
parent widgets' allocation should be taken into account when calculating the widget screen bounds.
BUG=none
TEST=Open a browser and set the frame to custom. Drag tabs around. They should not be offset vertically.
Review URL: http://codereview.chromium.org/147065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=13821
TEST=Verify that the home hover and pressed states look right
TBR=mirandac
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=15211 (http://crbug.com/15211 )
TEST=PerWindowShelf test does not show up as a failure on Linux bot
TBR=thakis
Review URL: http://codereview.chromium.org/146091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=15095
Review URL: http://codereview.chromium.org/146063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19133 0039d316-1c4b-4281-b951-d872f2087c98
|