summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Enable the RenderViewTest printing tests on the Mac.stuartmorgan@chromium.org2009-10-144-26/+35
| | | | | | | | | | | | | | | Migrates some test APIs from wstring path names to FilePath objects, and fixes some gcc compilation issues, to allow the tests to build on Mac. Moves rendering logic and some other pdf logic into PdfMetafile to avoid duplication with unit test code. Switches rendering from the deprecated CGContextDrawPDFDocument to the newer (but less convenient) CGContextDrawPDFPage. Added debugging helpers to PdfMetafile: SaveTo, matching the other platform metafiles, and context retain count checking to get early warning of issues that will cause printing failure. BUG=24750 TEST=N/A Review URL: http://codereview.chromium.org/274052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29003 0039d316-1c4b-4281-b951-d872f2087c98
* Unversion frameworksmark@chromium.org2009-10-144-68/+138
| | | | | | | | | | | | | | | BUG=24823 TEST= - GC.app/Contents/Versions/GCF.framework should not contain any symlinks. - GC.app/Contents/Versions/GCF.framework/Frameworks/KSR.framework shouldn't either. - There should only be three remaining symlinks in the entire GC.app package, in each of three different Resources directories. Each of the remaining symlinks should just be en.lproj -> en_US.lproj. - The app should still run. Keystone should still operate. (Make sure that Keystone does its up-to-date check in the About box.) Review URL: http://codereview.chromium.org/278007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28999 0039d316-1c4b-4281-b951-d872f2087c98
* Map ctrl+, to open options settings page for Chrome OS.chocobo@google.com2009-10-141-3/+2
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/267095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28998 0039d316-1c4b-4281-b951-d872f2087c98
* Originally in http://codereview.chromium.org/270096 but got lost somehow.jrg@chromium.org2009-10-141-1/+1
| | | | | | | | | BUG=http://crbug.com/24758 TBR=mrossetti Review URL: http://codereview.chromium.org/273054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28997 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: check return of SafeBrowsingProtocolParser::ParseGetHash.mattm@chromium.org2009-10-141-8/+8
| | | | | | | | | | CID=6428 TEST=none BUG=none Review URL: http://codereview.chromium.org/261034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28996 0039d316-1c4b-4281-b951-d872f2087c98
* Clear media cache when clearing browsing datahclam@chromium.org2009-10-141-2/+15
| | | | | | | | | | | | | | | BUG=24765 BUG=24813 TEST=run Chromium with --enable-byte-range-support, watch a movie, clear browsing data, Media Cache folder shouldn't have the cache files. Clear media cache when clearing browsing data. What's missing in this patch is that disk_cache in HttpCache is lazily initialized, so it has to be used at least once before we can clear it. Review URL: http://codereview.chromium.org/275013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28992 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that the correct URL and title is displayed in the host browser if ↵ananta@chromium.org2009-10-142-4/+20
| | | | | | | | | | | | | | | | | | | | | | the browser tab is attached to an existing external tab. This can happen if a script running in chrome invokes window.open which opens a popup window. To ensure that the title and URL display correctly we send over the navigation state changed IPC from Chrome when we receive an IPC from ChromeFrame indicating that it connected to the external tab. I also made a change to the function which sends over the navigation state to chrome to ensure that we set the title to the URL if it is empty. This mimics Chrome and the other browser's behavior. This should fix http://code.google.com/p/chromium/issues/detail?id=24024 Bug=24024 Review URL: http://codereview.chromium.org/274035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28991 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug to select initial wifi network when options page opens.chocobo@google.com2009-10-141-10/+27
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/276023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28989 0039d316-1c4b-4281-b951-d872f2087c98
* Readability fixes for server_connection_manager.nick@chromium.org2009-10-142-67/+93
| | | | | | Review URL: http://codereview.chromium.org/267029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28988 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression in menu button. I converted a call from GetWidget tosky@chromium.org2009-10-141-2/+2
| | | | | | | | | | | | | GetWindow, the problem is in certain scenarios GetWindow can return null. I've changed the code back to GetWidget and converted Screen from taking a NativeWindow to a NativeView. BUG=none TEST=none Review URL: http://codereview.chromium.org/269076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28986 0039d316-1c4b-4281-b951-d872f2087c98
* Disable parse feed test again.finnur@chromium.org2009-10-141-1/+1
| | | | | | | | | | TBR=jcampan BUG=None TEST=None Review URL: http://codereview.chromium.org/278003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28985 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the use of histogram in AudioMessageFilterhclam@chromium.org2009-10-141-32/+0
| | | | | | | | | | | | BUG=NONE TEST=NONE We don't need to measure latency in AudioMessageFilter any more, so removing the use of histogram in it. Review URL: http://codereview.chromium.org/274044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28984 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for memory leak in unit test. The test used to leak SiteInstance objectrogerta@chromium.org2009-10-141-22/+34
| | | | | | | | | | | returned from GetSiteInstanceForURL(). BUG=24769 TEST=None Review URL: http://codereview.chromium.org/271088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28982 0039d316-1c4b-4281-b951-d872f2087c98
* Move IDS_NOTIFICATION_PERMISSIONS to generated_resources.grd. This stringmark@chromium.org2009-10-142-16/+16
| | | | | | | | | | | | | | never belonged in chromium_strings.grd because it's not branding-dependent. Placing it in chromium_strings.grd but not google_chrome_strings.grd caused the two strings files to become out of sync, which is actually really really bad. BUG=24776 TEST=Application name shown in Mac menu bar should be Chrome, not Google Chrome Helper or anything else Review URL: http://codereview.chromium.org/277004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28980 0039d316-1c4b-4281-b951-d872f2087c98
* Fix line endings on merge_and_sync.html in repo, it is breaking svn.tim@chromium.org2009-10-141-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28977 0039d316-1c4b-4281-b951-d872f2087c98
* A patch from contributor Thiago Farina:finnur@chromium.org2009-10-141-1/+12
| | | | | | | | | | | | | | | | | [Windows] Improve the usage of "Open the following pages:" table. - Allow multiple selection. - Select the next row after the last row deleted or nothing when the row doesn't have any items. - Select the item in table when the user add an url. BUG=19150 TEST=add a bunch of urls, remove them, in different orders, should work fine. Review URL: http://codereview.chromium.org/267094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28976 0039d316-1c4b-4281-b951-d872f2087c98
* Updates for Under the Hood prefs from Cole:thomasvl@chromium.org2009-10-142-27/+32
| | | | | | | | | | | | - Make the scroller the width of the window. - Resize the content so any wrapping text fields have the full width. - Tweak the scroller so only bot bottom border shows. BUG=20538 TEST=Under the hood prefs scroller is the width of the window and goes to the bottom of the toolbar. Review URL: http://codereview.chromium.org/276019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28973 0039d316-1c4b-4281-b951-d872f2087c98
* More style nits.erg@google.com2009-10-1471-147/+163
| | | | | | | | (Working on cleaning chrome/ so hopefully we can lint it by default.) Review URL: http://codereview.chromium.org/274040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28971 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily re-enabling ParseFeed test.finnur@chromium.org2009-10-141-1/+1
| | | | | | | | | | TBR=jcampan BUG=23686 TEST=None Review URL: http://codereview.chromium.org/269077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28970 0039d316-1c4b-4281-b951-d872f2087c98
* The focus ring was not shown on Linux toolkit views.jcampan@chromium.org2009-10-141-1/+1
| | | | | | | | | | | | | | This is because on the renderer side the ring color was set to a value received from the browser, but on Linux toolkit view we are not initializing that value in the browser (just like we do on Windows, we keep the default WebKit value). So it would be 0, and the rings would not be shown. BUG=None TEST=Open www.google.com in Chrome toolkit views. Move the focus around with the tab key. A yellowish focus ring should show which node has focus. Review URL: http://codereview.chromium.org/270099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28968 0039d316-1c4b-4281-b951-d872f2087c98
* John, please review everything.ananta@chromium.org2009-10-141-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | agl, please review changes to the waitable_event_watcher code. Multiple sync channels if used in the same listener thread could result in calls completing in the wrong context at times. This happens if there are nested calls on these sync channels, i.e 1. Call from client 1 on channel 1 to server 1. Message pumping is enabled for the corresponding message 2. Call from client 2 on channel 2 to server 2, Message pumping is enabled for the corresponding message Now if a reply for 1 arrives, it should be queued until reply 2 arrives. This does not happen which causes 2 to terminate prematurely leading to crashes, 1 waiting indefinitely at times, etc. The fix for this issue is to maintain a local global stack for the send done event watcher object. The global object is in the form of a TLS. This ensures that we only watch for completed events on the outermost sync channel. The changes in the Waitable event watcher object are to return the current delegate which is needed to start watching the old send watcher once we are done and to ensure that the event member is set even if it was already signaled when StartWatching was called. I have added a unit test in ipc_tests for this case. I removed the old QueuedReply based unit tests as they did not test the actual nested call case. While debugging these issues I also found some issues in BrowserRenderProcessHost::OnChannelError where it would delete a sync channel while it was in use. Based on a discussion with jam we decided to DeleteSoon the sync channel pointer. However this broke some browser ui tests which relied on the timing of the OnChannelError notification. We decided to leave the existing code as is for now. I removed the DCHECK on channel as it would fire repeatedly if the channel died while multiple sync calls were waiting to complete leading to OnChannelError firing multiple times. Bug=24427 Review URL: http://codereview.chromium.org/271033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28967 0039d316-1c4b-4281-b951-d872f2087c98
* Don't animate first tab or new tab button when creating first tab (fix for ↵pinkerton@chromium.org2009-10-142-14/+29
| | | | | | | | | | startup regression), and don't animate NTB when the window isn't visible. BUG=24744 TEST=new tab and new tab button animation should still happen when creating and closing tabs, also test tab dragging animation. Review URL: http://codereview.chromium.org/271089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28966 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling ExtensionBrowserTest.BrowserAction since it crashes very ↵finnur@chromium.org2009-10-141-1/+2
| | | | | | | | | | | | frequently on Linux. TBR=nsylvain BUG=24802 TEST=None Review URL: http://codereview.chromium.org/274049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28965 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: temporarily disable completion test which fails on Linuxyurys@google.com2009-10-141-1/+1
| | | | | | | TBR=pfeldman Review URL: http://codereview.chromium.org/274048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28964 0039d316-1c4b-4281-b951-d872f2087c98
* Move the framework and helper application into a versioned directory in supportmark@chromium.org2009-10-1414-165/+453
| | | | | | | | | | | | | | | | | | | | | | of unbreaking auto-update. BUG=14610 TEST= - The following bundles should be gone: - Chromium.app/Contents/Frameworks/Chromium Framework.framework - Chromium.app/Contents/Resources/Chromium Helper.app They should be replaced by: - Chromium.app/Contents/Versions/*/Chromium Framework.framework - Chromium.app/Contents/Versions/*/Chromium Helper.app - The application should continue to function properly and all tests should still pass. - The signed application should have the inner framework and helper application signed, and the outer application signed. The outer seal should permit unknown versions to be present in the Versions directory, but should protect the active versioned directory. - Auto-updating to an official build with this change should still work. Review URL: http://codereview.chromium.org/261031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28963 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 222.8 to 222.9laforge@chromium.org2009-10-141-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28962 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: support autocompletion when script is pausedyurys@google.com2009-10-142-0/+41
| | | | | | Review URL: http://codereview.chromium.org/277001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28961 0039d316-1c4b-4281-b951-d872f2087c98
* Disable this test too in valgrind because it also leaksnsylvain@chromium.org2009-10-141-0/+2
| | | | | | | | | memory. BUG:24769 Review URL: http://codereview.chromium.org/278001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28959 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Omnibox popup should have Edit Search Engines when editable.shess@chromium.org2009-10-142-10/+15
| | | | | | | | | | | | | Was previously tied to whether you could paste-and-go. http://crbug.com/24741 http://crbug.com/22512 TEST=Copy " " to pasteboard. Right-click omnibox. Should see "Edit Search Engines". Review URL: http://codereview.chromium.org/271078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28958 0039d316-1c4b-4281-b951-d872f2087c98
* IOKit Framework is mac-only.nick@chromium.org2009-10-141-5/+7
| | | | | | | | | BUG=none TEST=eliminate a link warning on Windows. Review URL: http://codereview.chromium.org/267090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28951 0039d316-1c4b-4281-b951-d872f2087c98
* Make the acknowledgement message for querying form autofill data alwaysdarin@chromium.org2009-10-148-76/+72
| | | | | | | | | | | | | | | be sent. I plan to make use of this to have the RenderView hold onto a WebNode instead of a node_id in a future CL. R=jcampan BUG=24595 TEST=none Review URL: http://codereview.chromium.org/270082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28950 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a missing comma in the project file that was causing a bad project to be ↵dmaclach@chromium.org2009-10-141-1/+1
| | | | | | | | | | | created. BUG=none TEST=none Review URL: http://codereview.chromium.org/264056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28945 0039d316-1c4b-4281-b951-d872f2087c98
* Adding support for Native Client in Chrome's task manager and "stats for ↵gregoryd@google.com2009-10-144-0/+13
| | | | | | | | | | | | nerds" screen. TEST=none BUG=http://code.google.com/p/nativeclient/issues/detail?id=108 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28875 Review URL: http://codereview.chromium.org/267043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28944 0039d316-1c4b-4281-b951-d872f2087c98
* Adding in file I forgot to include in last commitasargent@chromium.org2009-10-141-0/+156
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28943 0039d316-1c4b-4281-b951-d872f2087c98
* Add UI test for Dromaeo benchmark.asargent@chromium.org2009-10-143-26/+70
| | | | | | | | | | | | | | That required minor modification of Dromaeo benchmark to enable automation. BUG=none TEST=none Committing for Anton Muhin (antonm@chromium.org). Review URL: http://codereview.chromium.org/274020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28942 0039d316-1c4b-4281-b951-d872f2087c98
* Port Browser Actions browsertest to linux.estade@chromium.org2009-10-146-14/+42
| | | | | | | | | BUG=23882 TEST=run it Review URL: http://codereview.chromium.org/274025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28941 0039d316-1c4b-4281-b951-d872f2087c98
* Remove hot tracked toolbar button when toolbar removes focus.mhm@chromium.org2009-10-141-0/+6
| | | | | | | | | | | WillLooseFocus needs to check if acc_focused_view is set, if it is, then it will properly remove it. BUG=3510 TEST=ALT+SHIFT+T all the way to the menu button, select options/about chromium menu option and hit enter to select one of them. The menu will be not hottracked. Review URL: http://codereview.chromium.org/270072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28938 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug that would cause spurious commits from the bookmark modelnick@chromium.org2009-10-141-4/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | under the following circumstances: (a) There were two or more bookmarks with the same title in a folder. (b) A change notification event occured for the bookmark (in my case it was a favicon loaded event; these would happen every startup, and maybe on every page visit too), but the bookmark properties didn't actually change. What was happening is that we were filtering out redundant property changes for the title, but only after we'd uniquified the name. This wasn't necessary, and for cases where there was a sibling with an identical name, the newly generated uniquified name would result in a false positive. The fix is to do the filtering on the non-unique name only. This is the only property visible to syncapi clients. BUG=24770 TEST=See bug. Review URL: http://codereview.chromium.org/271083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28937 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 222.7 to 222.8chrome-bot@google.com2009-10-141-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28935 0039d316-1c4b-4281-b951-d872f2087c98
* Implement shift+delete for removing omnibox entries on Linux.tony@chromium.org2009-10-142-3/+19
| | | | | | | | | | TEST=Select an item from the autocomplete popup and press shift+del. Clear the autocomplete and start typing again. Verify that the item doesn't re-appear. Review URL: http://codereview.chromium.org/271063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28933 0039d316-1c4b-4281-b951-d872f2087c98
* Have UI tests use a profile where the dates in the segment_usagetony@chromium.org2009-10-142-4/+33
| | | | | | | | | | | | | | | | | | | | | | table are current. By default, the NTP only uses data from the last 90 days, but the generated profile was created back in late 2008. Manually migrate the dates before launching chrome. This will probably impact the NTP perf tests, but it should give us a more realistic baseline. BUG=24369 TBR=brettw (Take 3 at landing this patch, this time with the proper fix for non-existent History files). Review URL: http://codereview.chromium.org/264053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28924 0039d316-1c4b-4281-b951-d872f2087c98
* Add a browser test for extensions autoupdate.asargent@chromium.org2009-10-1427-11/+340
| | | | | | | | | BUG=17826,19403 TEST=none Review URL: http://codereview.chromium.org/270019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28923 0039d316-1c4b-4281-b951-d872f2087c98
* Blind attempt at fixing the bookmark bar instructional text color for GTK.pkasting@chromium.org2009-10-142-8/+23
| | | | | | | | BUG=23536 TEST=Open Chrome Linux w/a theme and no bookmarks, verify instructional text in bookmarks bar has correct color. Review URL: http://codereview.chromium.org/274034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28922 0039d316-1c4b-4281-b951-d872f2087c98
* The SiteInstance unit tests are leaking memory. I disabled themnsylvain@chromium.org2009-10-141-0/+3
| | | | | | | | | until they are fixed. BUG:24769 Review URL: http://codereview.chromium.org/274037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28920 0039d316-1c4b-4281-b951-d872f2087c98
* Merging Native Client gyp files - get the changes from NaCl revision 852gregoryd@google.com2009-10-141-1/+1
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/271076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28919 0039d316-1c4b-4281-b951-d872f2087c98
* Make cros library thread-safe.chocobo@google.com2009-10-148-86/+196
| | | | | | | | | | Adds unmonitoring of network status changes. Fixed a few edge case bugs. BUG=23923 TEST=none Review URL: http://codereview.chromium.org/272019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28918 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a whole bunch of style nits.erg@google.com2009-10-1329-323/+318
| | | | | | | | (Long term intention is to add a subset of cpplint.py to the presubmit script.) Review URL: http://codereview.chromium.org/276008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28914 0039d316-1c4b-4281-b951-d872f2087c98
* Enables use-machine-stack.html worker test.hclam@chromium.org2009-10-131-4/+0
| | | | | | | | | | | | | | | | | TBR=domincc Original review: http://codereview.chromium.org/271069 Enables use-machine-stack.html worker test. As of WebKit revision 49427 Workers now set an appropriate stack limit on OS X, so this test can be enabled. Submitt this patch for Dominic Cooney <dominicc@google.com> Review URL: http://codereview.chromium.org/271082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28913 0039d316-1c4b-4281-b951-d872f2087c98
* Update page action manifest parsing to match the new format.mpcomplete@chromium.org2009-10-1315-141/+165
| | | | | | | | | | Preserves backwards compatability with the old manifest format. BUG=24635 Review URL: http://codereview.chromium.org/275007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28912 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 222.6 to 222.7chrome-bot@google.com2009-10-131-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28911 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-15 00:43:00 +0000