| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=10927
Review URL: http://codereview.chromium.org/93104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Make WaitForSingleProcess respect base::kNoTimeout (which is equivalent to INFINITE on windows).
Review URL: http://codereview.chromium.org/99008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
should be passed.
BUG=9191
patch by yusukes@google.com <http://codereview.chromium.org/97011>
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/92153
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/101002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Something else is trying to reap children in the ui_tests and causing
a mess. Reverting since it's a Friday night.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
(Seems that we still don't use GYP on Windows for a lot of things.)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Different header paths it seems, although the tryservers were ok with
it.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/99004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
be antisymmetric.
The old implementation was flawed because both of the following
comparisons were true: "{0, 1} < {1, 0}" and "{1, 0} < {0, 1}"
On Windows, std::map<> doesn't like that, and complains -- rightly so.
Review URL: http://codereview.chromium.org/93151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It also balances-out an OLE initialization performed by the CRichEditCTRL.
This is necessary for allowing to reload chrome.dll in a process, which is what the browser tests will do.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/93026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=Navigate to several different sites and check that no Chrome zombies are roaming around.
BUG=9401
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to this file from messing up the try server.
TBR=aa
Review URL: http://codereview.chromium.org/93156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This uses the trick described here:
http://blog.16software.com/dynamic-label-wrapping-in-gtk
Review URL: http://codereview.chromium.org/93153
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
cds->cbData is data length in bytes, and min_message_size is in characters. So it needs to be multiplied by sizeof(wchar_t)
Review URL: http://codereview.chromium.org/93078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is needed for PageActions that deal with IDs, so
that we can check if one PageAction is trying to change
another PageAction. This converts the object
ExtensionFunctionDispatcher in RenderViewHost from a
member to a scoped ptr so we can reset it on navigate.
BUG=None
TEST=Extensions should work as before (no visible
change).
Review URL: http://codereview.chromium.org/93125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 4a0189db765fe94f5df360c0907a585e26c9f681.
Revert "Fix build break."
This reverts commit eada493cf28975e56395aa3e2d3a0dc267a7f2c7.
Review URL: http://codereview.chromium.org/92162
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=1435533
Review URL: http://codereview.chromium.org/93154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
of the buildbots noticed that we weren't checking the results when
generating log output.
AGL gets the credit for tracking this down.
Review URL: http://codereview.chromium.org/93126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=1435533
Review URL: http://codereview.chromium.org/93109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=10950
Review URL: http://codereview.chromium.org/93140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=8389 (http://crbug.com/8389)
Review URL: http://codereview.chromium.org/57032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This is actually a very old bug that some of my recent changes exposed more widely. In PromoteOrCreateShorterSuggestion(), we could create a totally bogus search base, which, if added to the history matches, would then break. In the old code, we'd create this match, but usually not add it to the history match set because we'd already have a What You Typed match; in my new code that's frequently no longer the case.
BUG=10926
Review URL: http://codereview.chromium.org/92154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
if they're not actively being painted as focused, otherwise layout breaks badly.
http://crbug.com/10958
Review URL: http://codereview.chromium.org/93142
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
regression. Now we don't rely on the presence of a "what you typed" match in the result set; instead the AutocompleteResult determines the alternate nav URL directly.
To do this I refactored some of the code from the history URL provider over to AutocompleteInput.
BUG=10808
Review URL: http://codereview.chromium.org/92140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/93128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=10995
R=jam
Review URL: http://codereview.chromium.org/92144
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
by removing a no-longer-necessary std::ostream operator<< overload.
Review URL: http://codereview.chromium.org/92134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
GtkTextView requests enough space to fit all of the text. It turns out if you
weren't doing something to restrict the window size (like using a tiling
manager) long text in the edit would push the window to fit the text.
Review URL: http://codereview.chromium.org/93127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
specifically, when clicked on the button, not the label).
BUG=10834
TEST=Open the option dialog, click on the button (not the label) of a selected radio-button. The button should stay selected. Make sure checkboxes and radio buttons still behave as expected.
Review URL: http://codereview.chromium.org/97012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This creates a mapping for all the entries in the
theme_resources.grd file and adds a static method for querying
the mapping.
BUG=10639
Review URL: http://codereview.chromium.org/92085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=Ran Chromium, clicked around, found something in page. Nothing seems to
have broken.
Review URL: http://codereview.chromium.org/93124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now, we can copy the message by Ctrl-C.
BUG=5879
Patch by hamaji@google.com via
http://codereview.chromium.org/93112
Review URL: http://codereview.chromium.org/92133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(I screwed up. Thanks to Dean for noticing.)
TBR=tony
http://codereview.chromium.org/92132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I also broke glue/webplugininfo.h out of glue/webplugin.h as part of this
change. Eventually, glue/webplugin.h will go away and be moved into the WebKit
API, but the structures left in glue/webplugininfo.h need to remain since they
are used extensively throughout Chrome.
BUG=10922
R=dglazkov
Review URL: http://codereview.chromium.org/93116
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/88041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
property for the placeholder attribute.
BUG=10940
TEST=Make sure that the search boxes (not Search your history) on the new tab
page has place holder text.
Review URL: http://codereview.chromium.org/92107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
notifications to see if it can fix a crash.
Review URL: http://codereview.chromium.org/92129
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Turns out we can get 2 gtk leave events in a row on shutdown, if the cursor is already hovering over the go button.
BUG=10851
Review URL: http://codereview.chromium.org/93055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Please refer to this URL to have your mind blown:
http://aaronboodman.com/z_dropbox/whoa/
Review URL: http://codereview.chromium.org/92119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ben
BUG=10941
TEST=0
Review URL: http://codereview.chromium.org/93098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TEST=The new unittest passes.
BUG=10802
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
aren't broken.
Review URL: http://codereview.chromium.org/92084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=10895
TEST=Just re-enabling some tests that I had to disable earlier today.
Review URL: http://codereview.chromium.org/93115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
checkbox/radio-button was preventing focus to work as expected on these controls. It would leave the previous HWND focused, causing problems.
BUG=10856
TEST=Open the Option dialog. Click the "Show home button..." checkbox. The close button should lose focus, the checkbox should get focus. Press space, the checkbox state should change. Click on a radio-button, it should become selected and get focused. Press the up/down arrow. The next/previous radio-button should get selected and focused.
Review URL: http://codereview.chromium.org/93114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
remains as a shell so I don't have to change all the callers in this CL.
Review URL: http://codereview.chromium.org/92115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=abarth
http://codereview.chromium.org/93113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
updates the Dev tools manager to take a TabContents (a pointer was being
passed from the TabContents which made it break).
Review URL: http://codereview.chromium.org/92101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
DrawString/DrawStringFragment stuff from the old code. I am pretty sure the RTL stuff doesn't actually work, I just copied enough in to get things to compile/work.
Will sort out RTL later once LTR works.
Review URL: http://codereview.chromium.org/93092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Change Clear All to Clear all (Sentence case for all labels)
2. Remove 'uncompleted' from the downloads in progress confirm,
and change 'remove' to just 'cancel' in all cases.
R= glen
BUG= 10954
TEST= Ctrl+J and check that the label in the upper right is 'Clear all'
with a lower-case a.
TEST= Close the browser with a download in progress and verify that the prompt
is
"You have 1 download(s) in progress. If you close Google Chrome now, these
downloads will be canceled."
and the cancel button is
"Close and cancel downloads"
Review URL: http://codereview.chromium.org/92114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14410 0039d316-1c4b-4281-b951-d872f2087c98
|