summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Alphabetically sort font family names in the drop-down menu for the "Change ↵yusukes@google.com2010-11-301-6/+13
| | | | | | | | | | | font settings" screen. BUG=chromium-os:9048 TEST=manually done. Review URL: http://codereview.chromium.org/4664010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67637 0039d316-1c4b-4281-b951-d872f2087c98
* A browser test for safe_browsing_blocking_page. It tests some simple cases ↵panayiotis@google.com2010-11-3010-9/+337
| | | | | | | | | | for now, we can add more complex ones in the future. BUG=63778 TEST=browser_tests,unit_tests Review URL: http://codereview.chromium.org/5314001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67636 0039d316-1c4b-4281-b951-d872f2087c98
* Fix autofill detection of server data overriding heuristics.isherman@chromium.org2010-11-301-1/+2
| | | | | | | | | | | We should check whether the field's type changed, rather than looking at whether the server type matched the heuristic type, to handle the case of NO_SERVER_DATA. BUG=64176 TEST=none Review URL: http://codereview.chromium.org/5363004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67634 0039d316-1c4b-4281-b951-d872f2087c98
* UI Revamp + several fixes.rkc@chromium.org2010-11-305-316/+555
| | | | | | | | | | | | | | | | | .) UI matched to the Chrome settings DOM UI .) User-mail is now unchangeable .) Changed the screenshot input to a nicer toggle system .) Saved screenshots are only now loaded when the user choses to see them .) Check boxes for everything .) Privacy policy added .) Text changed around as per request by Chrome OS marketing BUG=chromium-os:8836,chromium:61847 TEST=Ran the new UI, checking and unchecking various boxes, trying different screenshots and submitting. More tests being done by the feedback team. Review URL: http://codereview.chromium.org/5271007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67633 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for "New blocked popup UI" on Windowsgeorgey@chromium.org2010-11-3014-24/+254
| | | | | | | | | | | | Changes: 1. new sets of strings indicating animation in chrome/browser/content_setting_image_model.cc - non-NULL id indicated that the situation is animated. 2. TabSpecificContentSettings has indicator that the new blockage occured, and was/was not messaged to the user. 3. ContentSettingImageView on Windows/ChromeOs is descended from LinearAnimation to allow animation of the popup indicator to the user. BUG=39260 TEST=Mocks Review URL: http://codereview.chromium.org/3120034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67630 0039d316-1c4b-4281-b951-d872f2087c98
* Added the extra iframe layer (central_roster_viewer.html) the enable the appscherkus@chromium.org2010-11-307-282/+388
| | | | | | | | | | | | | | | to run in the background. Moved JS code in separate scripts files. Implemented logic to restart the roster if the user reloads the panel. Patch by ivaylobakalov@chromium.org: http://codereview.chromium.org/5255009 BUG=chromium-os:9485 TEST=none Review URL: http://codereview.chromium.org/5314009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67629 0039d316-1c4b-4281-b951-d872f2087c98
* startup: factor out low-level startup/shutdownevan@chromium.org2010-11-301-82/+94
| | | | | | | | | Plan is to then move the body of LowLevelInit() into platform-specific files. Review URL: http://codereview.chromium.org/5360006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67627 0039d316-1c4b-4281-b951-d872f2087c98
* Send a DetectedPhishingSite IPC to the browser if a page is classified as ↵bryner@chromium.org2010-11-302-2/+106
| | | | | | | | | | | phishy. BUG=none TEST=PhishingClassifierDelegateTest.DetectedPhishingSite Review URL: http://codereview.chromium.org/5376002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67626 0039d316-1c4b-4281-b951-d872f2087c98
* Add command line flag to override gallery update urlsasargent@chromium.org2010-11-3013-48/+43
| | | | | | | | | | | | | | | | | | | | This will be helpful for testing installs via the web store pointing at a test server, and potentially for testing autoupdate as well. Also remove the kGalleryBrowsePrefix constant while I was in the neighborhood, since it turns out it's not used anywhere in our code anymore. BUG=63511 TEST=Run chrome with --app-gallery-update-url=<SOMEURL>. Go to the web store and try installing an app - the request to download the .crx file should go <SOMEURL> with some extra parameters tacked on including the extension id, etc. instead of http://clients2.google.com/service/update2/crx. Review URL: http://codereview.chromium.org/5119003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67625 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust the position of the Wrench menu badge.finnur@chromium.org2010-11-301-6/+3
| | | | | | | | | | | | It was two pixels to far to the left. TBR=glen BUG=51105 TEST=None Review URL: http://codereview.chromium.org/5348005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67624 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 67614 - Support predictive request for multiple preconnectionsjar@chromium.org2010-11-303-53/+66
| | | | | | | | | | | | | | | | Connected up to the API for requesting more than one preconnect at a time (that API also explicitly tags requsets as preconnects, so that they can be merged with actual navication requests). BUG=64246 r=willchan,mbelshe Review URL: http://codereview.chromium.org/5271002 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/5397003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67622 0039d316-1c4b-4281-b951-d872f2087c98
* Move audio output number limit to AudioManager.sergeyu@chromium.org2010-11-301-38/+0
| | | | | | | | | BUG=39825 TEST=None Review URL: http://codereview.chromium.org/5350003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67618 0039d316-1c4b-4281-b951-d872f2087c98
* Track permissions granted to extensions in prefsjstritar@chromium.org2010-11-3020-218/+968
| | | | | | | | | | | | | | | | | | Adds a section to the extension preferences to store the recognized permissions that the user has granted the extension. Ignores unknown permissions when installing extensions. Disables extension and prompts user to re-enable when unknown permissions become recognized (e.g., through browser upgrade). Allows extensions to remove a permission in one version, then add them back in the next without prompting the user. BUG=42742 TEST=ExtensionsServiceTest, ExtensionPrefsGrantedPermissions, ExtensionTest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67500 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67544 Review URL: http://codereview.chromium.org/4687005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67616 0039d316-1c4b-4281-b951-d872f2087c98
* Support predictive request for multiple preconnectionsjar@chromium.org2010-11-293-66/+53
| | | | | | | | | | | | | Connected up to the API for requesting more than one preconnect at a time (that API also explicitly tags requsets as preconnects, so that they can be merged with actual navication requests). BUG=64246 r=willchan,mbelshe Review URL: http://codereview.chromium.org/5271002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67614 0039d316-1c4b-4281-b951-d872f2087c98
* Don't show any autofill warnings for autocomplete=offisherman@chromium.org2010-11-291-30/+3
| | | | | | | | | | | Our logic for determining whether autocomplete=off is set at the form or at the field level is busted, and the fix is too fragile for this late in the game. Punting a better solution to M10. BUG=64286 TEST=manual Review URL: http://codereview.chromium.org/5382005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67613 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize DOMUI handlers if the DOM itself is re-usedstuartmorgan@chromium.org2010-11-295-0/+44
| | | | | | | | | | | | | Back/forward causes a page navigation, triggering a new DOMUI to be created. Since the page is the same, however, WebKit doesn't actually do a navigation, and the DOM remains intact, so the onload handler doesn't fire and cause the newly-created DOMUI to be initialized. This change notifies the DOMUI object when it has been bound to a RenderView that may have an existing DOM on the HTML/JS side, so that it can tell the page to re-trigger initialization if necessary. BUG=60768 TEST=Open DOMUI prefs, go to another pref section, press the Back button, then try to change the search engines. Review URL: http://codereview.chromium.org/5120005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67611 0039d316-1c4b-4281-b951-d872f2087c98
* Convert smart apostrophes to ascii apostrophes.tony@chromium.org2010-11-291-10/+10
| | | | | | | | TBR=kerz Review URL: http://codereview.chromium.org/5343006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67609 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a pair of overly aggressive DCHECKsjar@chromium.org2010-11-291-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Consistency checks (to detect memory corruption) were disabled for non-standard derived forms of histograms (some cache stats were using histograms a bit differently). When I added a virtual function to allow such derived classes to override the checking code, I forgot I had some inline DCHECKs as well. The method for getting the total_count was still DCHECKing the consistency, and there was another consistency assertion made when gathering data for upload to UMA. Both of these DCHECKs, which were not overridden, were removed. They were there to assure my code was working, and to detect memory smashers (or broken DRAM) more quickly... but are too hard to cleanly override (for the one histogram that does not support this facility). BUG=61281 BUG=64268 r=jam Review URL: http://codereview.chromium.org/5365004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67608 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for not instantiating a new page on singleton tabs when the tab is alreadyrkc@chromium.org2010-11-293-7/+42
| | | | | | | | | | | | | | | | | | | | | open and bug fix for when feedback tab is closed without hitting cancel (hitting cancel, cancels any pending system information requests, which was being skipped when the cancel button wasn't hit and the tab was directly closed) When Navigate is called for a Singleton tabs, regardless of whether or not the tab is already open, by default navigate creates tab_contents for the URL and then checks if the URL is already open on another tab - this can causes issues with DOM UI pages which expect to be open only at one time on one browser; in this case, the feedback DOM UI. BUG=chromium-os:8857 TEST=Ran multiple browsers and clicked on the feedback button while the feedback page was open - from the feedback page itself, and from other pages. Correct behavior was observed; we switched to the feedback page and no crashes. Review URL: http://codereview.chromium.org/4921001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67606 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Add unit test that makes sure clicking accelerated views focuses the ↵thakis@chromium.org2010-11-294-28/+125
| | | | | | | | | | | RWHVMac. BUG=60318 TEST=none Review URL: http://codereview.chromium.org/5365006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67605 0039d316-1c4b-4281-b951-d872f2087c98
* New Cloud Print Proxy setup UI.scottbyer@chromium.org2010-11-2926-29/+692
| | | | | | | | | | | | | | New UI to setup the proxy in Chrome. This UI passed review. New features include a friendlier layout, a Learn More link, and a Print Test Page button on the success page. This does not yet bring the UI out from behind a flag; that will be a separate CL. BUG=60092 TEST=CloudPrintURLTest.CheckDefaultURLs Review URL: http://codereview.chromium.org/5285001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67602 0039d316-1c4b-4281-b951-d872f2087c98
* Unmanaged devices should forget device id/tokendanno@chromium.org2010-11-292-0/+30
| | | | | | | | | | | Device token/id should be erased when device management sever reports "not managed" from policy request. BUG=64613 TEST=DeviceManagementPolicyProviderTest.DeviceNoLongerManaged Review URL: http://codereview.chromium.org/5346005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67600 0039d316-1c4b-4281-b951-d872f2087c98
* Once a form has been partially autofilled, autofill should only update ↵isherman@chromium.org2010-11-2927-1462/+1923
| | | | | | | | | | | fields one at a time. BUG=63437, 62638 TEST=unit_tests --gtest_filter=AutoFillManagerTest.* Review URL: http://codereview.chromium.org/5334005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67599 0039d316-1c4b-4281-b951-d872f2087c98
* EnumerateModules: Address UI review comments.finnur@chromium.org2010-11-295-95/+111
| | | | | | | | | | | | | | | | | | | | | | | | Make it a simple list with columns. Sort by status (conflicts at the top), then by location and module name. Also, convert the type of DLL to an enum so we can dedup the list (and for non-loaded DLLs show that they are not loaded yet, but are of type: Shell Extension / WinSock. Make sure lower bound version specified on the blacklist is inclusive (first version that broke) and the higher bound version is exclusive (first version that worked). This allows us to pointpoint exactly when the failure started and when the fix was introduced, instead of doing 0.9999 shenanigans. Specify an upper bound for the idmmbc.dll conflict, since Henry's outreach produced a fix in version 6.03 of the download manager. BUG=51105 TEST=Unit test Review URL: http://codereview.chromium.org/5278012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67598 0039d316-1c4b-4281-b951-d872f2087c98
* Roll initial policy template translations to trunkgfeher@chromium.org2010-11-2952-51/+508
| | | | | | | | | | | There are only a few strings translated, but having the .xtb files allows to uncomment references to them in the .grd file. That is also included in this CL. BUG=59276 TEST=none Review URL: http://codereview.chromium.org/5303008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67597 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Fix client certificate selection dialog handling of esc key.mattm@chromium.org2010-11-291-1/+11
| | | | | | | | | BUG=none TEST=open site requesting client certificate, hit esc Review URL: http://codereview.chromium.org/5288004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67596 0039d316-1c4b-4281-b951-d872f2087c98
* Adds another instant type that doesn't turn suggest text intosky@chromium.org2010-11-292-49/+108
| | | | | | | | | | | autocomplete text. BUG=none TEST=none Review URL: http://codereview.chromium.org/5281012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67593 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Align theme overlays correctly.erg@google.com2010-11-292-6/+13
| | | | | | | | | | | | | Make every calculation of the vertical offset go through the same function, and make sure that the overlay actually uses the offset instead of always being top aligned. BUG=63475 TEST=Install the GlossyBlue theme. Maximize the window. There shouldn't be any discontinuity in the curve (because the overlay is being rendered in the correct place.) Review URL: http://codereview.chromium.org/5379008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67591 0039d316-1c4b-4281-b951-d872f2087c98
* Finish the doc part of the de-experimentalization of the omnibox API. Please ↵kathyw@chromium.org2010-11-2965-579/+2022
| | | | | | | | | | | check the content changes to manifest.html and omnibar.html. BUG=63845 TEST=none Review URL: http://codereview.chromium.org/5326007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67590 0039d316-1c4b-4281-b951-d872f2087c98
* Nudge webkit so that it redraws network details overlay properly.xiyuan@chromium.org2010-11-291-0/+7
| | | | | | | | | BUG=chromium-os:9619 TEST=Verify fix for chromium-os:9619 Review URL: http://codereview.chromium.org/5337009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67588 0039d316-1c4b-4281-b951-d872f2087c98
* Load Get Started app from local directorydpolukhin@chromium.org2010-11-291-1/+7
| | | | | | | | | BUG=http://code.google.com/p/chromium-os/issues/detail?id=5914 TEST=manual Review URL: http://codereview.chromium.org/5256005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67585 0039d316-1c4b-4281-b951-d872f2087c98
* New images used by default as profile pictures. Order is gray, green, blue, ↵avayvod@chromium.org2010-11-298-3/+5
| | | | | | | | | | | yellow, red. BUG=chromium-os:9692 TEST=Login as new user several times and verify that order for default pictures is as described above. Review URL: http://codereview.chromium.org/5379006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67584 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where instant preview would not show in certainsky@chromium.org2010-11-291-24/+73
| | | | | | | | | | | | situations. This would happen if the RenderWidgetHost changed before the first paint. BUG=none TEST=none Review URL: http://codereview.chromium.org/5373003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67581 0039d316-1c4b-4281-b951-d872f2087c98
* Don't show autofill warning when interacting with field specifying ↵isherman@chromium.org2010-11-292-5/+8
| | | | | | | | | | | autocomplete=off BUG=64286 TEST=manual (see bug) Review URL: http://codereview.chromium.org/5322008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67579 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Fix regression where themed images and unthemed images went into the ↵erg@google.com2010-11-292-3/+11
| | | | | | | | | | | | | same map. This meant that whenever we requested an unthemed image (for example, the popup window background which should never be themed), we would often get a themed image back. BUG=63475 TEST=Open up a popup window when in chrome-theme mode with a theme installed. The default blue border should be used instead of a theme image. Review URL: http://codereview.chromium.org/5291008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67578 0039d316-1c4b-4281-b951-d872f2087c98
* Disable databases.DatabasesTest.testReloadActiveTab on winnirnimesh@chromium.org2010-11-291-0/+2
| | | | | | | | BUG=64664 Review URL: http://codereview.chromium.org/5295005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67577 0039d316-1c4b-4281-b951-d872f2087c98
* Remove chrome/browser/ui_thread_helpers.h because it's only used on Mac.rsesek@chromium.org2010-11-297-88/+50
| | | | | | | | | | | Move the Mac implementation to chrome/browser/cocoa/task_helpers.h. BUG=none TEST=no change Review URL: http://codereview.chromium.org/5360005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67576 0039d316-1c4b-4281-b951-d872f2087c98
* Always use settings UI for mobile network.xiyuan@chromium.org2010-11-291-5/+4
| | | | | | | | | | | | This is because native UI is not complete and only settings UI contains all the logic. BUG=chromium-os:9431 TEST=Verify only settings UI shows up for mobile network per chromium-os:9431. Review URL: http://codereview.chromium.org/5338007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67574 0039d316-1c4b-4281-b951-d872f2087c98
* Stop using the old layout test plugin.tony@chromium.org2010-11-292-2/+2
| | | | | | | | | | | | I haven't deleted it yet because it might be useful for debugging failures. I'll delete it in a separate change so it's easy for someone to cherry pick the change back. BUG=64260 Review URL: http://codereview.chromium.org/5301003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67571 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Disable UI elements in the content settings dialog if the controls are ↵thakis@chromium.org2010-11-295-27/+487
| | | | | | | | | | | | | | | | | managed. This disables the radio buttons and the exceptions button in the first 5 tabs (cookies, images, javascript, plugins, popups), and the "block 3rd party cookies" checkbox in the cookies tab. xib change: Hook up the "enabled" bindings of the buttons / radio buttons / checkbox to the new functions. (The cookie radio group's enabled state and exceptions button's enabled state is now bound to cookieSettingsManaged with a NSNegateBoolean value transformer. Likewise for images, javascript, plugins, popups.) BUG=63181 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67560 Review URL: http://codereview.chromium.org/5205008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67569 0039d316-1c4b-4281-b951-d872f2087c98
* Fix task manager context menu to not have any blank menu items.atwilson@chromium.org2010-11-291-1/+2
| | | | | | | | | | | | | Grab task manager context menu strings from resources, not from TableColumn structure, because some columns in the table may not have a header title but we still need an identifier in the context menu. BUG=64241 TEST=Bring up context menu, see no blank items Review URL: http://codereview.chromium.org/5303010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67568 0039d316-1c4b-4281-b951-d872f2087c98
* Fix example lists and untranslated text in generated policy documentationgfeher@chromium.org2010-11-291-0/+4
| | | | | | | | | | | | | Lists stored in Windows Registry should start numbering from 1 and not from 0. Strings displayed in the generated documentation should not be hard-coded, but come from the .grd file. BUG=64405,64213 TEST=python:DocWriterUnittest.* Review URL: http://codereview.chromium.org/5358004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67566 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 67560 - Mac: Disable UI elements in the content settings dialog if ↵thakis@chromium.org2010-11-295-486/+27
| | | | | | | | | | | | | | | | | | the controls are managed. This disables the radio buttons and the exceptions button in the first 5 tabs (cookies, images, javascript, plugins, popups), and the "block 3rd party cookies" checkbox in the cookies tab. xib change: Hook up the "enabled" bindings of the buttons / radio buttons / checkbox to the new functions. (The cookie radio group's enabled state and exceptions button's enabled state is now bound to cookieSettingsManaged with a NSNegateBoolean value transformer. Likewise for images, javascript, plugins, popups.) BUG=63181 TEST=none Review URL: http://codereview.chromium.org/5205008 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/5344009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67562 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI Prefs: Bring Basics closer to current mocksstuartmorgan@chromium.org2010-11-294-28/+45
| | | | | | | | | | | | | | Moves the homepage field to the same line as the option. Adds a favicon to the homepage field. Removes color from the default browser string, and puts it below the button Fixes enabled state of the default browser button when the default browser can't be set. BUG=63818,63822 TEST=DOMUI prefs homepage and default browser sections should look more like mocks. Review URL: http://codereview.chromium.org/5280002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67561 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Disable UI elements in the content settings dialog if the controls are ↵thakis@chromium.org2010-11-295-27/+486
| | | | | | | | | | | | | | | managed. This disables the radio buttons and the exceptions button in the first 5 tabs (cookies, images, javascript, plugins, popups), and the "block 3rd party cookies" checkbox in the cookies tab. xib change: Hook up the "enabled" bindings of the buttons / radio buttons / checkbox to the new functions. (The cookie radio group's enabled state and exceptions button's enabled state is now bound to cookieSettingsManaged with a NSNegateBoolean value transformer. Likewise for images, javascript, plugins, popups.) BUG=63181 TEST=none Review URL: http://codereview.chromium.org/5205008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67560 0039d316-1c4b-4281-b951-d872f2087c98
* Added a method to return the index of a bookmark with respect to its parent ↵pinkerton@chromium.org2010-11-294-5/+27
| | | | | | | | | | bookmark folder. Patch from v.a.shreyas@gmail.com. BUG=62522 TEST=Passes BookmarkFolderAppleScriptTest git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67559 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 67544 - Track permissions granted to extensions in prefsarv@chromium.org2010-11-2920-966/+218
| | | | | | | | | | | | | | | | | | | | Adds a section to the extension preferences to store the recognized permissions that the user has granted the extension. Ignores unknown permissions when installing extensions. Disables extension and prompts user to re-enable when unknown permissions become recognized (e.g., through browser upgrade). Allows extensions to remove a permission in one version, then add them back in the next without prompting the user. BUG=42742 TEST=ExtensionsServiceTest, ExtensionPrefsGrantedPermissions, ExtensionTest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67500 Review URL: http://codereview.chromium.org/4687005 TBR=jstritar@chromium.org Review URL: http://codereview.chromium.org/5259005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67557 0039d316-1c4b-4281-b951-d872f2087c98
* Small changes to the dev guide (which should've been in the last CL).kathyw@chromium.org2010-11-292-6/+10
| | | | | | | | | | TBR=aa BUG=none TEST=none Review URL: http://codereview.chromium.org/5308003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67553 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark manager: Fix issue where we cache the height of a list item.arv@chromium.org2010-11-291-7/+28
| | | | | | | | | | | This caused us to select the wrong item under some circumstances when the user zooms the page. BUG=49492 TEST=Go to bookmark manager. Select a folder with 8 or more items. Zoom twice. Select the 8th item using the mouse. Review URL: http://codereview.chromium.org/5278008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67549 0039d316-1c4b-4281-b951-d872f2087c98
* Track permissions granted to extensions in prefsjstritar@chromium.org2010-11-2920-218/+966
| | | | | | | | | | | | | | | | Adds a section to the extension preferences to store the recognized permissions that the user has granted the extension. Ignores unknown permissions when installing extensions. Disables extension and prompts user to re-enable when unknown permissions become recognized (e.g., through browser upgrade). Allows extensions to remove a permission in one version, then add them back in the next without prompting the user. BUG=42742 TEST=ExtensionsServiceTest, ExtensionPrefsGrantedPermissions, ExtensionTest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67500 Review URL: http://codereview.chromium.org/4687005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67544 0039d316-1c4b-4281-b951-d872f2087c98