summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Add support for getting the real process id from within the suid sandbox. ↵thestig@chromium.org2009-11-048-80/+298
| | | | | | | | | | | | The browser processes gets the real process ids, so they look correct in the task manager. When it asks the zygote to reap a process, we use the process ids internal to the sandbox. While we are at it, reap the sandbox process after it clones the zygote and figure out zygote's actual process id. Save the actual process id rather than that of the sandbox. BUG=20012,20714,23072 TEST=Process IDs for renderers should be correct in the task manager and you should be able to use the end process button to kill them. Review URL: http://codereview.chromium.org/262020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30938 0039d316-1c4b-4281-b951-d872f2087c98
* Fix valgrind error in SocketStreamDispatcherHostukai@chromium.org2009-11-041-1/+1
| | | | | | | | | BUG=26324 TEST=none Review URL: http://codereview.chromium.org/342113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30936 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite of chrome.exe startup codecpu@chromium.org2009-11-048-391/+225
| | | | | | | | | | | | | | | | | | | | | | | A lot of cruft and repeated code has deposited over the years on chrome's initialization code. This CL makes it all much more clear and straightforward. There is no fundamental change of behavior except the order of certain things is different but it should not alter the observed operation. - chrome's and chromium load is fundamentally the same but most of the code was repeated - chrome's way to load the dll was incorrect: using a relative path with LOAD_WITH_ALTERED_SEARCH_PATH - Use of SearchPath() was dangerous and not needed - removed google_update_client.cc and .h - removed bunch of #ifdefs TEST=all convered by UI tests already except [1] BUG=none [1] The only thing I don't see convered by test is the restart dialog ('woa! chrome crashed'). Review URL: http://codereview.chromium.org/345036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30934 0039d316-1c4b-4281-b951-d872f2087c98
* Keep track of when file dialogs are destroyed.thestig@chromium.org2009-11-041-14/+23
| | | | | | | | BUG=none TEST=Open two windows, open a file dialog in one, quit the browser in other. There should not be any GTK assertion errors. Review URL: http://codereview.chromium.org/339096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30930 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing what appears to be a typo. This will unbreak CF's command-linejoi@chromium.org2009-11-041-1/+1
| | | | | | | | | | | whitelisting of this flag. BUG=none TEST=The following command should not assert: chrome\Debug\servers\chrome_launcher.exe --enable-experimental-extension-apis Review URL: http://codereview.chromium.org/353026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30928 0039d316-1c4b-4281-b951-d872f2087c98
* Minor change to scary download UI text for extension install.aa@chromium.org2009-11-041-1/+1
| | | | | | | | | | BUG=19316 TEST=Install an extension. Text in download UI should mention both themes and extensions, not just extensions. Review URL: http://codereview.chromium.org/351032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30927 0039d316-1c4b-4281-b951-d872f2087c98
* Add first class support for user scripts.aa@chromium.org2009-11-0425-101/+668
| | | | | | | | | | | | Original review: http://codereview.chromium.org/340057 TBR=mpcomplete@chromium.org BUG=22103 TEST=Install a user script (such as from userscripts.org). You should get the extension install UI and the script should show up in the extension management UI. It should also work, though some scripts use Firefox-specific APIs and those won't work in Chromium. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30925 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 30903 - Gets find bar animation/clipping to work on views/gtk.sky@chromium.org2009-11-048-128/+124
| | | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/340077 TBR=sky@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30913 0039d316-1c4b-4281-b951-d872f2087c98
* Try to add more sanity checking to help track down a crash.pkasting@chromium.org2009-11-046-19/+46
| | | | | | | | BUG=20511 TEST=none Review URL: http://codereview.chromium.org/342112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30908 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 233.0 to 234.0oritm@chromium.org2009-11-041-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30907 0039d316-1c4b-4281-b951-d872f2087c98
* Gets find bar animation/clipping to work on views/gtk.sky@chromium.org2009-11-048-124/+128
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/340077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30903 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 30879.jcampan@chromium.org2009-11-042-11/+5
| | | | | | | | | | | Some devtool tests hang on Windows, one fails on Linux. I need to investigate more. BUG=None TBR=rafael Review URL: http://codereview.chromium.org/348067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30897 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug introduced during merging.sky@chromium.org2009-11-041-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=rafaelw Review URL: http://codereview.chromium.org/358001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30894 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Enables animations for the infobar. Changes the control flow for ↵rohitrao@chromium.org2009-11-038-230/+458
| | | | | | | | | | | | | | | infobar opening/closing to match Windows more closely. Nib file changes: - Embedded the InfoBarGradientView inside an AnimatableView. - Rebound [controller view] to the AnimatableView and added an infoBarView_ IBOutlet. - Bound the AnimatableView's delegate_ to the InfoBarController. BUG=http://crbug.com/25599 TEST=Infobars should animate in and out, except for during tab switches. Review URL: http://codereview.chromium.org/354008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30893 0039d316-1c4b-4281-b951-d872f2087c98
* Changes session restore to use a normal load rather than preferringsky@chromium.org2009-11-0317-83/+212
| | | | | | | | | | | | the cache. We need to do this else we don't honor page expiration and end up showing stale data for some sites. BUG=21195 TEST=make sure session restore works. Review URL: http://codereview.chromium.org/341043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30892 0039d316-1c4b-4281-b951-d872f2087c98
* Fix alignment of text and label in ReportBug nib.mirandac@chromium.org2009-11-031-20/+22
| | | | | | | | BUG= none TEST= none Review URL: http://codereview.chromium.org/342107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30890 0039d316-1c4b-4281-b951-d872f2087c98
* Linux Breakpad: Report process uptime in crash reports.thestig@chromium.org2009-11-031-2/+51
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/340080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30889 0039d316-1c4b-4281-b951-d872f2087c98
* Update the images for notification frames, since they had a transparent gap ↵johnnyg@chromium.org2009-11-032-0/+0
| | | | | | | | | | | between the balloon and the shelf, and also on the left edge. BUG=26631 TEST=create notifications over a busy desktop background Review URL: http://codereview.chromium.org/351028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30887 0039d316-1c4b-4281-b951-d872f2087c98
* Mark ShowModalDialogTest.BasicTest as FLAKYrafaelw@chromium.org2009-11-031-1/+2
| | | | | | | | | TBR=phajdan.jr,jam BUG=17806 Review URL: http://codereview.chromium.org/346045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30886 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up extension message port data in the renderer.mpcomplete@chromium.org2009-11-032-72/+18
| | | | | | | | BUG=26262 Review URL: http://codereview.chromium.org/344044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30884 0039d316-1c4b-4281-b951-d872f2087c98
* Use ChromeThread::DeleteOnIOThread in a few places where an object must be ↵jam@chromium.org2009-11-037-63/+36
| | | | | | | | | deleted on a certain thread. BUG=25354 Review URL: http://codereview.chromium.org/342090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30882 0039d316-1c4b-4281-b951-d872f2087c98
* Last patch in removing MessageLoop* caching.jam@chromium.org2009-11-0317-148/+107
| | | | | | | BUG=25354 Review URL: http://codereview.chromium.org/353015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30881 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate QueryOptions::most_recent_visit_only. All non-unittest consumers ↵pkasting@chromium.org2009-11-0314-99/+35
| | | | | | | | | | of this set it to true, so just turn it on unconditionally. BUG=none TEST=none Review URL: http://codereview.chromium.org/341087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30880 0039d316-1c4b-4281-b951-d872f2087c98
* Making the interactive ui tests run out of process to avoid runningjcampan@chromium.org2009-11-032-5/+11
| | | | | | | | | | | | into problems when running several browser tests in the same process. Turning previously failing tests on. BUG=26540 TEST=Run the interactive UI tests on Windows and Linux. Review URL: http://codereview.chromium.org/355014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30879 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the db_loop_ member variable which is a unused following r30163.eroman@chromium.org2009-11-032-6/+0
| | | | | | | | BUG=25354 Review URL: http://codereview.chromium.org/353023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30876 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Prefs window sizing/spacing:thomasvl@chromium.org2009-11-032-90/+88
| | | | | | | | | | | | | - Make some vertical spacing in basics more consistent - Make some vertical spacing in personal stuff more consistent - Make the views a bit wider to avoid some clipping and wrapping in a few languages. - A little code cleanup, no longer allow the pref views to be different widths, this resulted in some really odd looks, so we want to mange the layout ourselves up front (things not always being as wide as the window, etc). TEST=window looks ok (given our strings it won't always look great, but shoot for ok). BUG=26586 Review URL: http://codereview.chromium.org/351027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30871 0039d316-1c4b-4281-b951-d872f2087c98
* Make page and wrench buttons have correct hover look.avi@chromium.org2009-11-032-629/+73
| | | | | | | | | | | | | xib changes: - cell tags changed to make them styled independently - button attribute "bordered" disabled BUG=http://crbug.com/25644 TEST=as in bug Review URL: http://codereview.chromium.org/341088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30869 0039d316-1c4b-4281-b951-d872f2087c98
* Remove context-based dependencies on SyncerSession from ApplyUpdatesCommand.tim@chromium.org2009-11-038-46/+48
| | | | | | | | | | | | | | This helps clarify UpdateApplicator and removes SyncerSession from SyncerUtil. Part of work to separate sync session "context" like the ConflictResolver, ServerConnectionManager, ModelSafeWorker, etc from progress state. BUG=25266 TEST=sync unit tests Review URL: http://codereview.chromium.org/351026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30868 0039d316-1c4b-4281-b951-d872f2087c98
* Add OS version information to the bug report utility for the Mac version.mirandac@chromium.org2009-11-032-3/+8
| | | | | | | | BUG= http://crbug.com/26138 TEST= none Review URL: http://codereview.chromium.org/355013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30867 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark context menu "Edit" starts with current name, not "New Folder".jrg@chromium.org2009-11-036-59/+95
| | | | | | | | | | | | | | | | | | "Add Folder..." from either buttons or bar happier (always adds, doesn't edit). "Add Folder..." now allows you to rename new folders the default name ("New Folder"). BUG=http://crbug.com/26364, http://crbug.com/26407 TEST=Over a bookmark button for a 'mark or folder, context menu --> Edit. Make sure initial name is current name, not "New Folder". Over button for 'mark, for folder, or bar itself: context menu --> Add Folder. Make sure initial name is "New Folder", and that it creates a folder (not a rename). Make sure you are allowed to create a folder named "New Folder". Review URL: http://codereview.chromium.org/345045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30866 0039d316-1c4b-4281-b951-d872f2087c98
* BrowserActionsContainer breaks for nobody... or maybe someonefinnur@chromium.org2009-11-031-1/+2
| | | | | | | | | | | | | | | | | just forgot to hit the breaks. :) This avoids triggering a NOTREACHED in the default case that I hit during testing. BUG=None TEST=Load the set_page_color sample extension in debug build of Chrome and it should not NOTREACH (it should... um... REACH?) when pressing the browser action icon. :) Review URL: http://codereview.chromium.org/351023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30862 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Initialize |restored_bounds_| so new windows always have a proper size.thestig@chromium.org2009-11-031-2/+2
| | | | | | | | BUG=none TEST=Resize window to 400x300, hold down ctrl+N, new windows should all be the same size. Review URL: http://codereview.chromium.org/355007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30855 0039d316-1c4b-4281-b951-d872f2087c98
* Disable open all bookmarks context menu item if there are no bookmarks.jrg@chromium.org2009-11-031-0/+11
| | | | | | | | | | | | | BUG=http://crbug.com/26071 TEST=New empty bookmark bar. Maker sure "Open all bookmarks" in context menu is disabled. (You'll need to click in the bottom of the bar so you don't overlap the text). Add a bookmark. Make sure "Open all bookmarks" in context menu is ENabled. Review URL: http://codereview.chromium.org/351018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30853 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Adds a new view that will allow us to animate the height property of ↵rohitrao@chromium.org2009-11-034-0/+207
| | | | | | | | | | views. This class will be the base class for any view that needs to be animated. BUG=None TEST=No visible impact. New unittests should pass. Review URL: http://codereview.chromium.org/350002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30852 0039d316-1c4b-4281-b951-d872f2087c98
* Make bookmark folder look Mac-yavi@chromium.org2009-11-031-1/+5
| | | | | | | | | BUG=http://crbug.com/26457 TEST=as in bug Review URL: http://codereview.chromium.org/342103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30849 0039d316-1c4b-4281-b951-d872f2087c98
* Check word lengths before adding to dictionary and spellchecking.jschuh@chromium.org2009-11-031-2/+2
| | | | | | | | BUG=20469 TEST=None Review URL: http://codereview.chromium.org/326012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30845 0039d316-1c4b-4281-b951-d872f2087c98
* Convert tabcontentscontainer to use a vbox instead of a fixed. Thetony@chromium.org2009-11-033-53/+11
| | | | | | | | | | | | | | | comment in the code mentions that a vbox would cause a split screen, but looking at the code, it seems like that's not possible because we hide the old TCVG before adding new ones. These days the vbox contains all TCVGs and only shows one at a time (I think in the past we tried to remove them, but we don't have that problem now). This simplifies the code by not having to use our own size-allocate handler. Review URL: http://codereview.chromium.org/354018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30843 0039d316-1c4b-4281-b951-d872f2087c98
* Delete the temp dir created by CreateZip.thestig@chromium.org2009-11-032-7/+13
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/341074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30841 0039d316-1c4b-4281-b951-d872f2087c98
* Allows extension-devtools api to survive page navigation.jamesr@chromium.org2009-11-032-11/+2
| | | | | | | | | | | | | | | The problem was that the ExtensionDevtoolsBridge maintained explicit knowledge of the RenderViewHost is was monitoring. This would be invalidated on page navigations where the inspected RVH would be swapped out from underneath it. This patch removes knowledge of RenderViewHost from the ExtensionDevToolsBridge and makes sure it appropriately unregisters itself. Patch by: Jaime Yap (jaimeyap@google.com) TEST=none BUG=none Review URL: http://codereview.chromium.org/348042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30840 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: fix Text Encoding menu/submenuviettrungluu@chromium.org2009-11-032-118/+674
| | | | | | | | | | | | | | | (1) Clicking on the Text Encoding menu item should display the submenu, not try to execute a nonexistent command. (2) The Text Encoding menu item shouldn't be disabled, but instead the submenu's contents (so that the submenu is always visible). See Apple's HIG: <http://developer.apple.com/mac/library/DOCUMENTATION/UserExperience/Conceptual/AppleHIGuidelines/XHIGMenus/XHIGMenus.html#//apple_ref/doc/uid/TP30000356-TPXREF122>. Changes to MainMenu.xib: disconnected |-commandDispatch:| from the Text Encoding menu item. BUG=25957,26593 TEST=Check that the Text Encoding submenu is always available, with its contents disabled on the NTP (for example) and enabled (and working) on a normal web page. Check that clicking (and releasing) on the Text Encoding menu item itself shows the submenu. Review URL: http://codereview.chromium.org/345050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30836 0039d316-1c4b-4281-b951-d872f2087c98
* Disable failing in-process-browser interactive_ui_tests.rafaelw@chromium.org2009-11-032-5/+4
| | | | | | | | BUG=26540 Review URL: http://codereview.chromium.org/341078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30835 0039d316-1c4b-4281-b951-d872f2087c98
* Auto size the "reset to defaults" button i missed. Done with all nib ↵thomasvl@chromium.org2009-11-031-52/+122
| | | | | | | | | | objects so no code is needed. TEST=the reset to defaults button is the right size in all languages. BUG=20538 Review URL: http://codereview.chromium.org/345049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30834 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate WebViewImpl's dependency on WebDevToolsAgentImpl.darin@chromium.org2009-11-033-10/+4
| | | | | | | | | | | | | | | | | | This CL decouples the implementation of WebDevToolsAgent from the implementation of WebViewImpl. While this allows me to postpone the uplift of glue/devtools into webkit/api/src, I think it also has the advantage of simplifying dependencies. WebDevToolsAgentPrivate is introduced for the method calls made by the FrameLoaderClientImpl to the WebDevToolsAgentImpl. R=dglazkov BUG=none TEST=none Review URL: http://codereview.chromium.org/342092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30833 0039d316-1c4b-4281-b951-d872f2087c98
* Disable flaky (crashing) ExtensionApiTest.Popuprafaelw@chromium.org2009-11-031-1/+3
| | | | | | | | | TBR=mad,twiz BUG=26599 Review URL: http://codereview.chromium.org/353021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30831 0039d316-1c4b-4281-b951-d872f2087c98
* Better handling of UNKNOWN versus QUERY in a couple ways.pkasting@chromium.org2009-11-034-15/+69
| | | | | | | | | | | | First, made it possible to navigate to "invalid" hostnames in a number of additional cases, including when the user types an explicit scheme or when we have a valid TLD and no spaces. The default action for these kinds of inputs is still search, but we'll pull up an accidental search infobar if need be now. Second, made the HistoryURLProvider show a What You Typed match for UNKNOWN inputs when the user explicitly typed "http:" or "https:" at the front, since these have the highest probability of being navigational inputs. BUG=26341 TEST=Type "http://foo bar baz.com" and verify you are given a (non-default) entry in the dropdown to navigate. Review URL: http://codereview.chromium.org/353010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30830 0039d316-1c4b-4281-b951-d872f2087c98
* Change the background color in the under the hood prefs.thomasvl@chromium.org2009-11-031-32/+14
| | | | | | | | BUG=none TEST=a shade of grey now. Review URL: http://codereview.chromium.org/348059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30827 0039d316-1c4b-4281-b951-d872f2087c98
* New source files for overview images. I'll post the new image fileskathyw@google.com2009-11-032-950/+1180
| | | | | | | | | | | later, with the new overview.html file. TEST=none BUG=26164 Review URL: http://codereview.chromium.org/348058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30826 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Prefs under the hood work:thomasvl@chromium.org2009-11-033-119/+193
| | | | | | | | | | | | | | | | | - Make all the controls/labels wrap to the width they get. - Make the content vertically shift as it is made to fit its strings. - Add more spacing for the sections as listed in bugs. - Consistent indents for the sections/subsections. - Update the code to use constant naming (was was "under the hood" and some was "advanced" (just so it is clear they are talking about one thing, and not two). - DEPS roll for GTM to pick up support for NSPathControl. TEST=Under the hood content should fit in all languages. BUG=20538 BUG=25595 BUG=25597 Review URL: http://codereview.chromium.org/355011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30825 0039d316-1c4b-4281-b951-d872f2087c98
* Fix grammar.avi@chromium.org2009-11-032-2/+2
| | | | | | | | | BUG=http://crbug.com/26591 TEST=go to "under the hood" in prefs; see correct grammar Review URL: http://codereview.chromium.org/356001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30822 0039d316-1c4b-4281-b951-d872f2087c98
* Fix autofill popups not closing when there are no suggestions. We have to ↵avi@chromium.org2009-11-031-1/+1
| | | | | | | | | | | call through on an empty suggestion array so that the popup is told to close. BUG=http://crbug.com/25559 TEST=as in bug Review URL: http://codereview.chromium.org/353009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30821 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-07 00:19:21 +0000