| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
based on host permissions.
BUG=38398
TEST=none
Review URL: http://codereview.chromium.org/1095002
TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/1575036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
permissions.
BUG=38398
TEST=none
Review URL: http://codereview.chromium.org/1095002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Updated it so it matches with what we have on the mocks.
BUG=none
TEST=Run with --login-manager --login-screen=oobe and check that Welcome to Chromium OS label is visible and has the right color.
Review URL: http://codereview.chromium.org/1611025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebKit::WebGeolocationServiceBridgeImpl::stopUpdating().
(depends on the fix provided by http://trac.webkit.org/changeset/57335).
BUG=40660,40478
TEST=GeolocationBrowserTest.InvalidUrlRequest
Review URL: http://codereview.chromium.org/1626011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
application locale codes.
The change is necessary to integrate UI language selection in the language
settings dialog. In short, input languages and UI languaes (application
locale codes are used for UI languages) need to be compatible.
TEST=unit_tests
BUG=2336
Review URL: http://codereview.chromium.org/1575034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Along the way, refactor the code to use tags in ButtonPressed(),
and remove members that are no longer necessary by the change.
TEST=manually
BUG=crosbug.com/2545
Review URL: http://codereview.chromium.org/1525028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
websocket server. Submitting this as a 2-sided patch to make it easier
to roll it back if something breaks.
BUG=none
TEST=none
TBR=antonm
Review URL: http://codereview.chromium.org/1521026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=41291
TEST=DevToolsSanityTest.TestProfilerTab
TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/1578028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=40995
TEST=none
TBR=ukai
Review URL: http://codereview.chromium.org/1542028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1653001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
avoids unnecessarily performing a second map lookup
in many cases.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1631012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=40073
TEST=Focus the list or the tree. Press the context menu keyboard key. The menu should be positioned relative to the selected item.
Review URL: http://codereview.chromium.org/1542027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I have an SDCH experiment, and a DNS prefetch experiment running.
I reduced both percentages to 1 in 1000.
r=wtc
Review URL: http://codereview.chromium.org/1528031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
The swig action should depend on the headers it includes.
Review URL: http://codereview.chromium.org/1646002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=41196,38364
TEST=In the bugs
Review URL: http://codereview.chromium.org/1519033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
are opened in the new window instead of the original window. This change hinges on having URL opening code return the browser into which the URL was opened so that subsequent openings may now into which browser to do so.
BUG=39901,41104
TEST=Bring up context menu on a folder with two or more bookmarks and select "Open All in Incognito Window". Insure that all of the URLs are opened in the newly created, top-most window. Verify that no new tabs were created in the original window. Perform this same test using "Open All in New Window".
Review URL: http://codereview.chromium.org/1633009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Swap expected verus actual value in unit test. A small cleanup item.
BUG=none
TEST=AutoFillProfileTest
Review URL: http://codereview.chromium.org/1651001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44300 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
make sure HostContentSettingsMap correctly fires off notifications whenever
it modifies them, and re-loads them when they are modified.
Take 2...
BUG=40484,41003
TEST=HostContentSettingsMapTest.*
Review URL: http://codereview.chromium.org/1604020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=35038
TEST=PasswordStoreMacTest
Review URL: http://codereview.chromium.org/1524011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
is needed by <http://codereview.chromium.org/1604020> because the host_content_settings now registers as an observer of the profile and needs to unregister itself on the UI thread.
BUG=none
TEST=CookiePromptWindowControllerTest.*
Review URL: http://codereview.chromium.org/1527028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
According to http://mail.google.com/support/bin/answer.py?hl=en&ctx=mail&answer=10313#, gmail ignores period characters and case differences in the username portion of an email address. Follow those rules.
BUG=chromiumos:2260
TEST=unit tests, also run on device and log in with user@google.com and user@GOOGLE.COM; verify that you get the same tab state, etc. in both sessions.
Review URL: http://codereview.chromium.org/1539030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=41184
TEST=None
Review URL: http://codereview.chromium.org/1610022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix a bug where sites can be added to allow and deny lists multiple times.
BUG=none
TEST=Open two browsers with separate profiles. Request permission for notifications on a site on one. Check that the permissions are the same on the other browser.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44234
Review URL: http://codereview.chromium.org/1578023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
occurred because HistoryURLProvider used the url to determine what to
markup vs the actual text.
BUG=41054
TEST=see bug
Review URL: http://codereview.chromium.org/1562023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor EditFolderController into BookmarkFolderEditorController
class.
BUG=None
TEST=Add and/or edit a bookmark folder. It should works as before.
Review URL: http://codereview.chromium.org/1640007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=38611
Review URL: http://codereview.chromium.org/1649001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
conditions.
BUG=40724
TEST=none
Review URL: http://codereview.chromium.org/1602022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=41203
TEST=See bug.
Review URL: http://codereview.chromium.org/1520034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44275 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
A couple of post-mortem nits from Trung.
BUGS=none
TEST=trybots
Review URL: http://codereview.chromium.org/1542024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=two URLs in 6.1, and section 8.7 exists
Review URL: http://codereview.chromium.org/1574023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
We now rely on the fact that both html and nexe files exist in the prebuilt directory, so there is no reason to copy them.
Review URL: http://codereview.chromium.org/1637004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
connects to the location bar. Also fix info bubble positioning against location bar icons to put the arrow "up against the icon edge" (fixes the arrow overlapping some page action icons).
Remove BubblePositioner, which is now no longer needed.
BUG=27570,40730
TEST=Omnibox dropdown should line up with editable area edges, icons and text should line up with icon and text in the omnibox. Info bubbles should still be positioned correctly
Review URL: http://codereview.chromium.org/1578021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=37421
Review URL: http://codereview.chromium.org/1560025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Since CG preserves alpha, and plugins don't composite onto pages manually, we don't need the extra buffer on the Mac.
BUG=41194
TEST=Transparent plugins (mostly Flash) should continue to work normally.
Review URL: http://codereview.chromium.org/1549035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44265 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
reliable.
This way we'll be able to write good pyauto tests for them.
TEST=ui_tests
BUG=none
Review URL: http://codereview.chromium.org/1562021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=thakis
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1575029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(this is to avoid triggering a DCHECK on geolocation_host_content_settings_map).
Note: the bug will be fully fixed after we roll webkit to:
http://trac.webkit.org/changeset/57335
BUG=40660
TEST=GeolocationPermissionContextTests.InvalidURL
Review URL: http://codereview.chromium.org/1632006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
finding the form field in FindFormWithFormControlElement.
BUG=41013
TEST=none
Review URL: http://codereview.chromium.org/1527025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=40818
TEST=NameFieldTest.FirstMiddleLast2
Review URL: http://codereview.chromium.org/1612013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Make the list items a single row.
2. Make the title of the bookmark a link
3. Make the blue bar at the top slightly higher
4. Fix indentation bug of the tree.
5. Fix hover effect for performance.
6. Use default lnf for text inputs when renaming/editing items
7. Reorder context menu items ot better match the organize menu.
8. Don't show the path in search and recent.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/1643001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
postConsoleMessageToWorkerObject()
Patch contributed by caseq@chromium.org
BUG=https://bugs.webkit.org/show_bug.cgi?id=37155
TEST=none
Review URL: http://codereview.chromium.org/1528029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Stop using SetInputMethodActivated cros API and use the generic API, SetImeConfig, instead. This fix greatly reduces total number of ibus_config_set_value() calls.
I'm still not 100% certain, but this change might fix crosbug.com/2471, "Fails to activate an input method occasionally." ibus-daemon seems to ignore too frequent ibus_config_set_value("general", "preload_engines", ...) calls.
BUG=crosbug.com/2471
TEST=see the bug
Review URL: http://codereview.chromium.org/1596021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to be synced.
Fix a bug where sites can be added to allow and deny lists multiple times.
BUG=none
TEST=Open two browsers with separate profiles. Request permission for notifications on a site on one. Check that the permissions are the same on the other browser.
Review URL: http://codereview.chromium.org/1578023
TBR=zork@chromium.org
Review URL: http://codereview.chromium.org/1607012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fix a bug where sites can be added to allow and deny lists multiple times.
BUG=none
TEST=Open two browsers with separate profiles. Request permission for notifications on a site on one. Check that the permissions are the same on the other browser.
Review URL: http://codereview.chromium.org/1578023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
compiz. It can cause a really weird bug in the version of compiz in Ubuntu 8.04, which we still want to support.
BUG=19291
TEST=drag a window partially offscreen when using compiz in 8.04, then click in the title bar - it will not disappear or move
Review URL: http://codereview.chromium.org/1564024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Depends on http://codereview.chromium.org/1523019.
BUG=crosbug.com/2403
TEST=ran browser_tests.
Review URL: http://codereview.chromium.org/1519030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44232 0039d316-1c4b-4281-b951-d872f2087c98
|