| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
viettrunglu@gmail.com
BUG=19273
TEST=Make your mouse really sensitive; see if you can accidentally activate the
back/forward history dropdowns.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also fix a code path that seems to be missing on Windows (maybe
this regressed?).
This time make sure RWHV is not NULL.
BUG=619
TEST=http://code.google.com/p/chromium/issues/detail?id=619#c6
Review URL: http://codereview.chromium.org/165468
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
message filters.
Review URL: http://codereview.chromium.org/165395
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When an update fails, we display an error string and allow the
user to try again by manually pressing the update button. When
the user does that, we should clear the error message so that the
update throbber doesn't draw over the text, which looks ugly.
BUG=19272 (http://crbug.com/19272)
TEST=Difficult to repro: try to update chrome and fail, press the
update button and notice that the error message disappears when
the throbber is active.
Review URL: http://codereview.chromium.org/165462
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/164424
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/164450
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
was added to the info bar api in r22711.
There's a tiny flicker when the infobars are replaced, but it's a
lot better than the jerky animation there used to be.
I imagine mac will still have this bug.
BUG=19101
TEST=Install 2 themes from the theme gallery. The second theme should
be displayed.
Review URL: http://codereview.chromium.org/164456
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
On the Mac, Flash appears to cache the CGContextRef provided in NPP_SetWindow until the next NPP_SetWindow call, so we need to call it sometime before the next plugin paint. This allows us to call NPP_SetWindow before telling the plugin to paint, but not from the Paint function itself (where it could have bad side-effects).
BUG=18894,18980
TEST=Switch to HQ on a YouTube video; Flash should not crash.
Review URL: http://codereview.chromium.org/165344
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some tab opening crashes, I need to null check some pointers.
TBR=estade
This reverts commit r23317.
Review URL: http://codereview.chromium.org/164486
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a code path that seems to be missing on Windows (maybe this
regressed?).
BUG=619
TEST=http://code.google.com/p/chromium/issues/detail?id=619#c6
Review URL: http://codereview.chromium.org/164452
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is the first step towards shipping privacy blacklists in extensions.
TEST=Covered by unit_tests.
BUG=none
Review URL: http://codereview.chromium.org/164349
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/165463
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
file to ensure that the images are picked up for the complex theme tests.
BUG= http://crbug.com/18767
TEST= none
Review URL: http://codereview.chromium.org/164402
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23313 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
getting tripped. Note that the handle value can safely be zero here.
Review URL: http://codereview.chromium.org/165399
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
build, where C++ exceptions are already disabled.
BUG=19094 12248
TEST=Mac release-mode Google Chrome.app should shrink by about 6MB.
Mac disk image should shrink by about 1.5MB.
Linux binary and package should shrink too.
Review URL: http://codereview.chromium.org/165330
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=michaeln
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/164463
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=michaeln
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/164461
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/164444
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The login sheet looks very bare-bones…but that's probably ok for now.
BUG=12043
TEST=Go to a page that uses http auth, e.g. http://www.pagetutor.com/keeper/mystash/secretstuff.html . A sheet should come up that asks for login and password. Escape should cancel the sheet, return should confirm it. The sheet should be per-tab, e.g. tab switching while the sheet is open should work.
Review URL: http://codereview.chromium.org/164391
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-Don't display Event or Methods heading if there are none in api pages.
-Allow static pages to declare their title with a hidden div.
-Removed xhr.html (abandoned).
-Left Nav now selects current page.
-Breadcrumb removed.
TBR=aa, kathyw
Review URL: http://codereview.chromium.org/164457
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23275 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use en-dash instead of em-dash to separate match and description.
Popup font a little smaller than field font.
Make cell taller, and no gap between cells.
Use BaseFont from ResourceBundle instead of field's default font (this
is what Windows uses, I think).
http://crbug.com/19184
Review URL: http://codereview.chromium.org/164418
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
No functional change. This gets things compiling on linux, but it still needs some work before it can be run on linux.
BUG=19085
Review URL: http://codereview.chromium.org/164352
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
bookmark_utils.cc needs app_strings.h.
BUG=none
TEST=green build
Review URL: http://codereview.chromium.org/165409
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=19122
Review URL: http://codereview.chromium.org/165411
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The original issue is: http://codereview.chromium.org/144019
--------------
Functionality has been requested in the Extension API for Javascript to
take screenshots of the currently visible tab. This changelist builds this
function, chrome.tabs.getVisibleScreenCapture. This function takes a
single callback function and returns to that function a data URL of a JPEG
image of the current screen. A simple sample extension is provided as a
use case.
BUG=14760
TEST=There is an extension in chrome\test\data\extensions\samples\screenshot,
load this extension. It creates a toolstrip button. Click this button, you
should get a page with a screenshot of the active tab. The API function
is found at chrome.tabs.getVisibleScreenCapture.
Review URL: http://codereview.chromium.org/160228
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
was previously failing the purify step.
BUG=19002
TEST=HttpBridgeTest
Review URL: http://codereview.chromium.org/165363
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also line up image and title columns under star and field.
http://crbug.com/19182
Review URL: http://codereview.chromium.org/164415
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=19167
Review URL: http://codereview.chromium.org/164442
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=no
TEST=no
Review URL: http://codereview.chromium.org/165408
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Nothing in base/ uses it, and I'm going to make some non-trivial changes to it.
TEST=none
http://crbug.com/19202
Review URL: http://codereview.chromium.org/164428
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This test was checking that the system host resolver maintains an internal cache, by doing actual DNS resolves (which introduces a network dependency in the unit tests). This could be flaky on linux, which doesn't cache resolves.
As of r18236 however, chromium maintains its own host cache. So the DNS prefetcher does not need to rely on the OS caching DNS resolves in order to be a win.
BUG=http://crbug.com/18766
Review URL: http://codereview.chromium.org/164350
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Send crashes to Apple Crash Reporters so we get a nice UI to restart the Browser process if it crashes.
BUG=9231
TEST=Induce a browser crash in a Chrome build, Apple Crash reporter UI should appear aftera few seconds. Induce a renderer crash, no UI should be displayed.
Review URL: http://codereview.chromium.org/164433
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/165405
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://www.google.com/codesearch/p?hl=en&sa=N&cd=2&ct=rc#eSCqYNcHl48/gtk%2B-2.4.10/gdk/gdkevents.c&q=gdk_event_get_time
Review URL: http://codereview.chromium.org/164429
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
requests through automation to receive persistent cookies from the automation client. These cookies are passed in when the automation client notifies Chrome that a HTTP request was started.
The URLRequestAutomationJob object now informs Chrome whether an automation URL request was redirected.
The ExternalTabContainer now handles the NEW_FOREGROUND_TAB and displays a popup window in response. This gets around an ASSERT.
This fixes bug http://b/issue?id=2048046
Bug=2048046
Review URL: http://codereview.chromium.org/165350
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/164401
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
tests.
BUG=12140
Review URL: http://codereview.chromium.org/164335
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Location").
Patch by viettrungluu.
BUG=http://crbug.com/19172
TEST=Go to File menu and look.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Create a working desktop shortcut. For now it displays no UI, but the backend works.
TEST=none
http://crbug.com/17251
Review URL: http://codereview.chromium.org/164280
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/17402
TEST=Enter text in the omnibox and resize the window. Popup size should follow.
Review URL: http://codereview.chromium.org/165332
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bar.
It turns out that the frame is in the DelayedMenuButton's coordinate
system, but a fudge is needed to make things line up. (I don't
understand these fudges, especially vertically.)
Patch by viettrungluu.
BUG=http://crbug.com/19174
TEST=Surf a bit, check back menu with and without bookmark bar.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Localize the menu bar titles.
Have the browser platform delegate startup the resource bundle system so we can fetch localization data.
Make l10n_util::GetApplicationLocale return what cocoa says for the language so we match what the UI is using.
TEST=everything still works.
BUG=17380
Review URL: http://codereview.chromium.org/164413
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=cmp
BUG=19002
Review URL: http://codereview.chromium.org/165400
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/165398
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Partially based on patch by Dan Kegel.
Review URL: http://codereview.chromium.org/164371
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This feature is better implemented as an extension rather than being put into
the absolute-core UI.
Review URL: http://codereview.chromium.org/164301
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
not doing the cleanup that happens in real life.
BUG=19002
TEST=SyncSetupWizardTest
Review URL: http://codereview.chromium.org/164370
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://crbug.com/18471
TEST= Open new tab page in any theme, click "Change page layout" dropdown menu, note that text is always blue on white.
Review URL: http://codereview.chromium.org/165389
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/164404
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This required making it so that extension_api.json definitions defer to existing bindings so that the chrome.extension object can remain setup in renderer_extension_bindings.js.
Also fixed a minor bug with error handling in the api_generator.js
Moved "Port" type to the new extension module.
Removed a bunch of trailing whitespace from the extension_api.json.
Review URL: http://codereview.chromium.org/165323
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23200 0039d316-1c4b-4281-b951-d872f2087c98
|