| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
Uses libgps / gpsd to get gps fixes. Modified the location arbitrator to use GPS instead of network location provider.
Current version requires manual code edit to enable (ENABLE_LIBGPS_LOCATION_PROVIDER) See http://docs.google.com/View?id=dfbnm49n_1g8ktswhr for demo instructions (work in progress)
BUG=43868
TEST=Built with ENABLE_LIBGPS_LOCATION_PROVIDER and used gpsd's gpsfake script (see linked doc above)
Review URL: http://codereview.chromium.org/2032010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45203
TEST=as described in the bug
Review URL: http://codereview.chromium.org/2265003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45050
TEST=see bug
Review URL: http://codereview.chromium.org/2285001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2224003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:3601
TEST=Log in as new user, confirm mouse is faster
(can check with "synclient -l" on the command line...MaxSpeed
should be "1")
TBR:chocobo
Review URL: http://codereview.chromium.org/2296003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Remove modify_database flag.
Make sure we delete data structures on the WebKit thread.
Handle single process mode.
Review URL: http://codereview.chromium.org/2125017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=Compiles
BUG=40286
Review URL: http://codereview.chromium.org/2069016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
make sure that devtools client is detached from devtools agent if inspected render view is closing. It is necessary because render thread may be blocked by a script staying on a breakpoint in which case close message will never be dispatched(close message is posted as a non nestable task so it cannot be processed in the message loop in ScriptDebugServer).
Review URL: http://codereview.chromium.org/2238002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The change in Preferences.xib binds the homepage options container's enabled state to the new property PreferencesWindowController.IsHomepageManaged
BUG=43423
TEST=Manual, especially homepage options on general page of options dialog
Review URL: http://codereview.chromium.org/2059001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ananta
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/2225006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
on Chromium.
TBR=ben
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/2282005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The desktop notification service infobar would not display in ChromeFrame rendered pages as the code assumed the existing of a BrowserList
and associated objects like Browser etc. In ChromeFrame the tab contents is owned by the ExternalTabContainer. Fix is to pass the current tab
contents from the RenderViewHost to the DesktopNotificationService::RequestPermission function and use that if we don't have a browser list.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=44913
Bug=44913
Review URL: http://codereview.chromium.org/2266005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
was initially marked as flaky only for
windows.
Bug=36800
TBR=tonyg
Review URL: http://codereview.chromium.org/2274005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* There is a known issue where notification gets resized repeatedly.
This generates a lot of X/WM events which fills up message loop, and eventually cause freeze.
This CL fixes the flickering and freeze caused by above issue.
(See chrome/browser/notifications/balloon_collection.cc)
The resize issue will be tracked and fixed separately.
Correctly shutdown notificatino UI when browser exits.
* When restoring session, browser emits BROWSER_CLOSED notification and there is no last active window,
and BalloonCollectionImpl was incorrectly shutting down NotificationUI.
BUG=chromium-os:3410
TEST=manual: no freeze when calendar notification is shown.
Review URL: http://codereview.chromium.org/2307001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
with upstream libjingle again.
Changed GaiaOnlySaslHandler to GaiaTokenPreXmppAuth to match
libjingle changes.
BUG=none
TEST=made sure sync worked with an @google.com account.
Review URL: http://codereview.chromium.org/2221004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=None
BUG=None
TBR=huanr
Review URL: http://codereview.chromium.org/2283004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2224006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=10952
Review URL: http://codereview.chromium.org/2282004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. When to resize tabs during close didn't match old behavior. In
particular because of unload handlers I can't track whether the
close was user initiated but instead need to set a flag when the
user initiates it and reset it later on.
. When the user initiates a close if the tab is already closed I
should start closing the next tab. This matches what the old code
does and allows users to rapdily click the middle button to close a
bunch of tabs.
. For user initiated closes the animation should preserve existing
bounds, otherwise things may shift around by a pixel or so.
BUG=44785 44782 44781
TEST=make sure tab animations work smoothly, especially when removing tabs
Review URL: http://codereview.chromium.org/2145005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The desktop notification service infobar would not display in ChromeFrame rendered pages as the code assumed the existing of a BrowserList
and associated objects like Browser etc. In ChromeFrame the tab contents is owned by the ExternalTabContainer. Fix is to pass the current tab
contents from the RenderViewHost to the DesktopNotificationService::RequestPermission function and use that if we don't have a browser list.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=44913
Bug=44913
Review URL: http://codereview.chromium.org/2294002
TBR=ananta@chromium.org
Review URL: http://codereview.chromium.org/2222005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The change is for fixng trauncation that occurs with German.
BUG=chromium-os:3356
TEST=manually
Review URL: http://codereview.chromium.org/2220004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Patch by seh@chromium.org:
http://codereview.chromium.org/2249001/show
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2252004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
rendered pages as the code assumed the existing of a BrowserList
and associated objects like Browser etc. In ChromeFrame the tab contents is owned by the ExternalTabContainer. Fix is to pass the current tab
contents from the RenderViewHost to the DesktopNotificationService::RequestPermission function and use that if we don't have a browser list.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=44913
Bug=44913
Review URL: http://codereview.chromium.org/2294002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
consistenly hanging.
TBR=rafaelw
BUG=45173
TEST=ExtensionOverrideTest.OverrideHistory
Review URL: http://codereview.chromium.org/2240006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44967
TEST=1) Hide bookmark bar. 2) Show bookmark manager. 3) Delete a bookmark which would show on the bookmark bar. 4) Verify no 'poof' occurs. 5) Type an URL into the omnibox. 6) Click on the Star to bookmark. 7) Press the 'Remove' button. 8) Verify no 'poof' occurs. 9) Show the bookmark bar. 10) Delete a bookmark which shows on the bookmark bar. 11) Verify that the 'poof' animation occurs.
Review URL: http://codereview.chromium.org/2294001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- let AddFirstRunNewTabs() run as elsewhere on Mac (the list of first-run tabs
will be empty)
- move various #if defined(OS_MACOSX) stuff to (existing!) Mac-specific files
instead
- remove an essentially-unused argument to FirstRun::ProcessMasterPreferences()
(the location of the master prefs was never specified, so the standard
location was always used)
BUG=none
TEST=everything still works
Review URL: http://codereview.chromium.org/2077025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=26729
TEST=none
Review URL: http://codereview.chromium.org/2279003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Restores a bunch of tests that were disabled by bugs 36630 and 30307 (both of which were closed as fixed without the tests being re-enabled) to whatever state they had before.
BUG=30307,36630
TEST=Tests should run, and hopefully not hang or crash anything
Review URL: http://codereview.chromium.org/2157009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(control-w, middle click ...) the tab is not restored. OTOH if the
user closes the window, then the tab is restored.
BUG=4923
TEST=turn on session restore and close the last tab by clicking the
tab close button, it shouldn't be restored. Then close the last window
with one tab by way of alt-f4 (or clicking the window close button)
and make sure the tab is restored.
Review URL: http://codereview.chromium.org/2251002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=39785
TEST=VerifyHistoryLength* tests should be run.
Review URL: http://codereview.chromium.org/2293001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
panel).
BUG=44077
TEST=Bookmark bar should always be visible on the NTP if extension apps are disabled (default) and should be visible if attached when extension apps are enabled.
Review URL: http://codereview.chromium.org/2225004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
1. install permanent buffer exchange callback.
2. render provide buffer in read=>fillthisbuffer.
3. for ffmpeg path, the provided buffer is just dummy. it had no relation to decoded buffer. so as to keep the code almost same.
Review URL: http://codereview.chromium.org/2101022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2291003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Basically the linux version of http://codereview.chromium.org/2075006
BUG=10952
TEST=Go to http://www.adobe.com/shockwave/welcome/. The task manager should show that the default plugin is running, and the "Missing Plugin" text should look slightly different than it did before. Also, the plugin area is now grey instead of transparent. (this test depends on a small webkit shown below)
Requires commenting out
if (objectContentType(url, mimeType) != ObjectContentNetscapePlugin)
return 0;
in WebKit/WebKit/chromium/src/FrameLoaderClientImpl.cpp's createPlugin() as well, else the default plugin won't load.
Review URL: http://codereview.chromium.org/2079016
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/2291004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
is not empty.
BUG=None
TEST=Start an official ChromeOS build, open the NTP.
GMail, Calendar and Docs should be available as apps.
Review URL: http://codereview.chromium.org/2237003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=gman@chromium.org
Review URL: http://codereview.chromium.org/2286001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When we detect that the installed version is newer than the version you are
running we show a little throbbing orange dot over the wrench menu.
If you open the wrench menu and close it again, the throbbing will stop.
However, if you look at the contents of the wrench menu you'll notice that
the About box menu item has been removed and in its place is a menu item
"Update Chrome Now" with a bright orange icon to draw your attention to it.
Clicking on the icon shows a dialog box asking whether you want to restart
Chrome. If you do, the browser restarts with your session restored
(even if you have Session Restore turned off).
Known issues:
- Currently this is Windows only. We'll have to port this to Linux and do
something differnet for Mac (which doesn't have the wrench menu).
- Showing an icon in front of Update Chrome causes the checkbox for the
bookmark bar menu to go away. Given that we will soon redesign the menus I'm
not going to spend much time trying to fix it.
BUG=27941
TEST=Wait for Chrome to be upgraded in the background, an orange dot should
appear over the wrench menu and if you select Update Chrome your session should
be retained.
Review URL: http://codereview.chromium.org/2225003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48318 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
shown in the bookmark bar when there are no bookmarks in the bar, when the window resizes. Show ellipses when each gets trimmed and hide them when they get too small.
BookmarkBar.xib changes: Connect the "Import bookmarks now..." button up to the importBookmarksButton_ outlet in the BookmarkBarView.
BUG=32557
TEST=1) Start up a browser with no bookmarks on the bookmarks bar.
2) Verify that the "For quick access..." and "Import bookmarks now..." test fully shows.
3) Start shrinking the width of the browser window.
4) Verify that the "Import bookmarks now..." text is shrunk/clipped and finally disappears as the window gets narrower.
5) Continue shrinking the width and verify that the "For quick access..." text is shrunk/clipped with ellipses as the window gets narrower.
6) Grow the window and verify that the "For quick access..." reappears and then the "Import book now..." does.
Review URL: http://codereview.chromium.org/2243002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Basically the linux version of http://codereview.chromium.org/2075006
BUG=10952
TEST=Go to http://www.adobe.com/shockwave/welcome/. The task manager should show that the default plugin is running, and the "Missing Plug-in" text should look slightly different than it did before. Also, the plugin area is now grey instead of transparent. (this test depends on a small webkit shown below)
Requires commenting out
if (objectContentType(url, mimeType) != ObjectContentNetscapePlugin)
return 0;
in WebKit/WebKit/chromium/src/FrameLoaderClientImpl.cpp's createPlugin() as well, else the default plugin won't load.
Review URL: http://codereview.chromium.org/2079016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45115
TBR=jhawkins
Review URL: http://codereview.chromium.org/2249003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=mark
BUG=45108
TEST=Greener Mac UI test bots.
Review URL: http://codereview.chromium.org/2238003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
with the wrong path, standard_menus.h went away in r46987, pref_store.h in r47915, spellchecker_common in r32561, transport_dib.h in 42101.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2247006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48300 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
WizardBorder won't paint border it will be done by WizardPainter, WizardBorder will provide only insets.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2281002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Changes the shutdown type in the test on the Mac, since closing the last window (the default) destroys the session on the Mac. Marks two tests that fail consistently accordingly.
BUG=45108
TEST=SessionRestoreUITest tests should run.
Review URL: http://codereview.chromium.org/2280002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2271002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
r48279 did this for TestStepOver, but all of the TestStep* tests are timing out
on win, not just TestStepOver.
TEST=DevToolsSanityTest.TestStep*
BUG=45080
Review URL: http://codereview.chromium.org/2240003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=29201
TEST=Verify a web app shortcut for "chrome-extension://" url could be created.
Review URL: http://codereview.chromium.org/2193002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44780
TEST=see bug
Review URL: http://codereview.chromium.org/2226002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the user has enormous standard fonts.
BUG=43268
TEST=Set your system fonts to enormous sizes. Type in the location bar. The font should be small enough to fit.
Review URL: http://codereview.chromium.org/2132027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48288 0039d316-1c4b-4281-b951-d872f2087c98
|