summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* rollback these changesbeng@google.com2008-07-313-20/+11
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171 0039d316-1c4b-4281-b951-d872f2087c98
* fix bustage, not sure why this didn't break on my machinebeng@google.com2008-07-311-0/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169 0039d316-1c4b-4281-b951-d872f2087c98
* Stub out the files to be used for the new browser frame.beng@google.com2008-07-3112-0/+677
| | | | | | B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168 0039d316-1c4b-4281-b951-d872f2087c98
* Should not be able to construct a CustomFrameWindow directly. Should use ↵beng@google.com2008-07-312-11/+17
| | | | | | | | | | CreateChromeWindow instead. Move CustomFrameWindow's two constructors to the protected section. They should be called by subclasses only. B=1293984 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167 0039d316-1c4b-4281-b951-d872f2087c98
* Move some methods from public to protected, since only subclasses should be ↵beng@google.com2008-07-313-82/+79
| | | | | | | | | | calling them. Move some data members from protected to private and provide a protected setter, per C++ style guidelines. B=1293984 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157 0039d316-1c4b-4281-b951-d872f2087c98
* forgot these filesbeng@google.com2008-07-314-460/+75
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154 0039d316-1c4b-4281-b951-d872f2087c98
* Move dialog-specific aspects of ClientView into a new subclass DialogClientView.beng@google.com2008-07-3118-222/+714
| | | | | | | | | | | | | | ClientView becomes a generic representation of the View that occupies the "client area" of a window. All Windows now require a Client View (though they can use the default). Adjust WindowDelegate to provide a method for constructing the ClientView for a Window. The DialogDelegate overrides this to construct the DialogClientView. In the future, other specialized delegates will construct ClientViews specific to them, e.g. WizardDelegate would construct WizardClientView. Adjust the Window Init method to set up this new required Client View, and make some tweaks to CustomFrameWindow to make all this work. Remove all traces of dialog specific handling in Window into DialogClientView. B=1280060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153 0039d316-1c4b-4281-b951-d872f2087c98
* Adds exitcodes for the TerminateProcess calls on hung renderers. There are ↵ojan@google.com2008-07-313-3/+5
| | | | | | still plenty of TerminateProcess(..., 0) calls, but these are the ones I know. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152 0039d316-1c4b-4281-b951-d872f2087c98
* I looked at the full dump from the previous crashes and it looks like a ↵brettw@google.com2008-07-301-1/+2
| | | | | | testing issue. Hopefully it will be magically unbroken. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151 0039d316-1c4b-4281-b951-d872f2087c98
* At the first run use Omaha usagestats key to determine whether to collect ↵rahulk@google.com2008-07-304-3/+5
| | | | | | | | | | | user metrics. BUG=1299579 TEST=With clean profile and no "first run" file, start Chrome and make sure that Under the Hood->Help make Chrome better... option is checked or unchecked depending on whether the value of HKEY_CURRENT_USER\Software\Google\Update\ClientState\{8A69D345-D564-463c-AFF1-A69D9E530F96}\usagestats key is 1 or 0. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149 0039d316-1c4b-4281-b951-d872f2087c98
* Add views\non_client_view.cc to the SCons build.sgk@google.com2008-07-301-0/+1
| | | | | | TBR: beng git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147 0039d316-1c4b-4281-b951-d872f2087c98
* Removes a method never implemented in HistoryDB.sky@google.com2008-07-301-3/+0
| | | | | | | | | BUG=none TEST=none; this is just cleanup git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144 0039d316-1c4b-4281-b951-d872f2087c98
* Make the download arrow show and hide correctly in response to shelf ↵glen@google.com2008-07-305-9/+10
| | | | | | | | visibility. This was caused by both the shelf_visible_ bool not being set by the download shelf correctly, and the tab renderer not being aware of the new state. BUG=1300997 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143 0039d316-1c4b-4281-b951-d872f2087c98
* Simple change to make the "New [incognito] window" commands work like you'd ↵pkasting@google.com2008-07-302-6/+5
| | | | | | | | | | | | expect. The old behavior disabled "New incognito window" when in incognito windows, created a new incognito tab instead of a new window when you already had an incognito window open, and gave you no way to get a non-incognito window from an incognito one. Now, both commands are always enabled, and both do exactly what they say they'll do no matter what type of window you're currently in. BUG=1190035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142 0039d316-1c4b-4281-b951-d872f2087c98
* Make NonClientView an interface independent of CustomFrameWindow (i.e. move ↵beng@google.com2008-07-306-149/+229
| | | | | | | | | | | | it into its own file). Rename NonClientView's HitTest method to NonClientHitTest, so it doesn't collide with View's HitTest method. Also, consolidate some duplicated code between CustomFrameWindow and ConstrainedWindow's non-client view impl. B=1300864 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141 0039d316-1c4b-4281-b951-d872f2087c98
* sidchat@google.com2008-07-301-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140 0039d316-1c4b-4281-b951-d872f2087c98
* Made changes to display tooltip window when user navigates through the icons ↵stanguturi@google.com2008-07-304-8/+121
| | | | | | | | in the toolbar using keyboard arrow keys. I have already fixed this issue. (Issue:801). I have got LGTM also. But, I have checked in the code when tree was closed. So, all my changes were reverted. So, this new issue is created to upload the same changes. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139 0039d316-1c4b-4281-b951-d872f2087c98
* Update SCons build for recent changes:sgk@google.com2008-07-301-1/+1
| | | | | | | | | | Delete chrome_frame.cc, add frame_util.cc. url_request_http_cache_job.cc => url_request_http_job.cc. Rename sandbox *tests.exe to sbox_*.exe per upstream. Define ENABLE_CROSS_DOCUMENT_MESSAGING when generating V8 bindings. TBR: bradnelson git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135 0039d316-1c4b-4281-b951-d872f2087c98
* (Re-landing of) Support RunOnce() in message loop.jar@google.com2008-07-301-4/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | Deeply nested calls to MessageLoop::Run() were made, and a multitude of Quit() messages were handled at the most nested level. This left outer invocations hung, waiting for "their" kQuitMsg to arrive (but the the nested loop had already discarded them in its processing of pending messages before exit :-/ ). We now use a more controlled run of the message loop, which does not rely on kQuitMsg. This re-landing doesn't have the anti-hang assertion, which was breaking a lot of tests. bug=1291034 r=darin,mpcomplete M base/message_loop.h M base/message_loop.cc M chrome/common/ipc_sync_channel.cc git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130 0039d316-1c4b-4281-b951-d872f2087c98
* Insert a commasidchat@google.com2008-07-301-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128 0039d316-1c4b-4281-b951-d872f2087c98
* Install the "First Run" file next to chrome.exe.sgk@google.com2008-07-301-1/+9
| | | | | | | Add a place-holder comment for the dependencies.py call we'll need when we handle the release build. TBR: bradnelson git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127 0039d316-1c4b-4281-b951-d872f2087c98
* Now uninstall entry is called Google Chrome so delete the old entry that was ↵rahulk@google.com2008-07-301-0/+5
| | | | | | | | | called Chrome for users that upgrade. BUG=1300325 TBR=tc git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure we remove info-bars on reload.jcampan@google.com2008-07-301-1/+3
| | | | | | | BUG=1296826 TEST=See bug git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119 0039d316-1c4b-4281-b951-d872f2087c98
* Move some more classes from net/base into the net:: namespace.darin@google.com2008-07-3016-45/+48
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116 0039d316-1c4b-4281-b951-d872f2087c98
* Send the "shutdown didn't get to finish" metric to UMA.evanm@google.com2008-07-301-0/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114 0039d316-1c4b-4281-b951-d872f2087c98
* Rollback 109jar@google.com2008-07-301-3/+4
| | | | | | | | | | M base/message_loop.h M base/message_loop.cc M chrome/common/ipc_sync_channel.cc git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110 0039d316-1c4b-4281-b951-d872f2087c98
* M base/message_loop.hjar@google.com2008-07-301-4/+3
| | | | | | | | M base/message_loop.cc M chrome/common/ipc_sync_channel.cc git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 1295677: REGRESSION: Import SETS startup page to imported home page.finnur@google.com2008-07-3010-31/+72
| | | | | | | | | We had only kHomePage pref before, which if blank/set to chrome-internal: meant that the New Tab page should be shown when Home is pressed. Now we add a pref called kHomePageIsNewTabPage for this purpose, which allows us to set the kHomePage value during import without actually using it as the HomePage (effectively importing home page becomes importing a default suggestion for when the users want a home page instead of the New Tab page). BUG=1295677 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107 0039d316-1c4b-4281-b951-d872f2087c98
* build bustagebeng@google.com2008-07-302-2/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106 0039d316-1c4b-4281-b951-d872f2087c98
* Make HWNDViewContainer set up its contents view separately from its Init method.beng@google.com2008-07-3017-37/+49
| | | | | | | | | This is needed as a first step in further adjustments I'm going to be making to Window, ClientView, etc. B=1280060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105 0039d316-1c4b-4281-b951-d872f2087c98
* roll back this part of the fix since it has unintended side effects when ↵beng@google.com2008-07-301-1/+2
| | | | | | calling virtual overrides git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ChromeFrame->BrowserWindowbeng@google.com2008-07-3024-172/+224
| | | | | | | | | Move static utility functions to FrameUtil class. B=1294302 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102 0039d316-1c4b-4281-b951-d872f2087c98
* Move the initial sizing of a Window into a separate function ↵beng@google.com2008-07-302-76/+81
| | | | | | | | (SetInitialBounds) to tidy up the Init method a bit. Move SetInitialFocus into private section since it's not used by subclasses. B=1293984 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99 0039d316-1c4b-4281-b951-d872f2087c98
* forgot these filesbeng@google.com2008-07-302-0/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97 0039d316-1c4b-4281-b951-d872f2087c98
* Window Delegate Improvements:beng@google.com2008-07-3069-531/+528
| | | | | | | | | | | | | | | | | | | | | | - Windows now must have a Delegate. Just construct the default WindowDelegate if you don't want to have to write one in testing. - Windows now obtain their contents view by asking the delegate via WindowDelegate::GetContentsView. - Contents views no longer need to manually store a pointer to the Window that contains them, WindowDelegate does this automatically via its window() accessor. Reviewer notes: - review window_delegate.h first, then - window.h/cc - custom frame window.h/cc - constrained_window_impl.h/cc - then everything else (just updating all call sites) B=1280060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96 0039d316-1c4b-4281-b951-d872f2087c98
* Fix one more glitch when drag-attaching a tab to the tabstrip. Other tabs in ↵beng@google.com2008-07-301-0/+8
| | | | | | | | the strip were instantly sized to their start size for the insert tab animation (which is their current size) but this calculation didn't take into account the fact that a newly inserted tab has a minimum size so their initial size isn't just the width / n other tabs, it's (width / n other tabs) - (min width / n other tabs) B=1285677 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90 0039d316-1c4b-4281-b951-d872f2087c98
* Fix broken unittest. AttemptToClosePage now sets up state.ojan@google.com2008-07-301-0/+1
| | | | | | | | | Do the same in the overridden method in TestRenderViewHost. TBR=abarth git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash. Now sometimes TabContentses can be NULL it seems.beng@google.com2008-07-301-2/+3
| | | | | | B=1297990 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84 0039d316-1c4b-4281-b951-d872f2087c98
* I screwed this one up, and had my index munging wrong.beng@google.com2008-07-301-13/+8
| | | | | | | | This is actually a much simpler approach. Get the TabContents that the context menu was brought up for and reverse walk the list closing all Tabs that don't match. Duh. B=1298878 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83 0039d316-1c4b-4281-b951-d872f2087c98
* Fix hang detection when closing a tab to not fire when a modal dialog is open.ojan@google.com2008-07-291-0/+9
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82 0039d316-1c4b-4281-b951-d872f2087c98
* Fix not closing the browser with hung, crashed and interstitial tabs. Adds a ↵ojan@google.com2008-07-2913-45/+161
| | | | | | | | 1 second hang monitor for the beforeunload/unload events to fire. BUG=1296059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81 0039d316-1c4b-4281-b951-d872f2087c98
* Revert revision 73 because it was checked in when the tree was closed.nsylvain@google.com2008-07-294-121/+8
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74 0039d316-1c4b-4281-b951-d872f2087c98
* Made changes to display the tooltip window when user navigates through the ↵stanguturi@google.com2008-07-294-8/+121
| | | | | | icons in the toolbar using keyboard arrow keys. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting revision 70, 66 and 65 to fix crashes.nsylvain@google.com2008-07-292-5/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71 0039d316-1c4b-4281-b951-d872f2087c98
* Make the new tab thumbnail slighly less confusing -- laid out properly,evanm@google.com2008-07-291-2/+14
| | | | | | | | | | but unclickable -- when something goes wrong and the page is fed garbage input. (I don't expect new users will ever see this, but migration bugs in previous versions have made this a recurring problem.) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68 0039d316-1c4b-4281-b951-d872f2087c98
* Update chrome strings. No changes in webkit strings.tc@google.com2008-07-291-0/+1
| | | | | | TBR=glen git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67 0039d316-1c4b-4281-b951-d872f2087c98
* Puts back the optional unescaping of control characters and URL ↵brettw@google.com2008-07-291-1/+2
| | | | | | | | | | | | parse-affecting characters. That patch was reverted due to build problems. This is heavily modified from the original patch. That patch required an additional function and a bunch of internal boolean flags. This one uses the new flags enum I wrote to add this to the existing functionality more cleanly. BUG=1271340 BUG=1258819 Review URL: http://chrome-reviews.prom.corp.google.com/804 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the process model heuristic for generated searches only apply in ↵creis@google.com2008-07-291-2/+3
| | | | | | | | | --process-per-site, since it isn't relevant otherwise. (This matters now that process-per-site-instance is the default.) BUG=1256259 TEST=Visit a non-Google page, then run a search from the location bar. The tab should switch renderer processes. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65 0039d316-1c4b-4281-b951-d872f2087c98
* Add a return value to InternalCloseTabContentsAt, indicating whether or not ↵beng@google.com2008-07-292-9/+21
| | | | | | | | | | the TabContents was closed immediately or if we're waiting for an unload handler to fire. Adjust indices in Close other tabs handler to take into account the fact that some tabs may not close immediately B=1295790 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63 0039d316-1c4b-4281-b951-d872f2087c98
* Ugh. It turns out we were never properly removing the dragged tab from the ↵beng@google.com2008-07-295-11/+65
| | | | | | | | | | | | source tabstrip when a drag was completed. This was causing various problems, which were highlighted when you reverted a drag (e.g. press esc or alt+tab while dragging). See my comments inline in the diff for explanations. This manifests as Venkat's latest repro in: B=1262392 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-09 21:10:16 +0000