| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
TBR: maruel
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
won't need this separate class.
B=1031852
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=1323423
TEST=this is some tests.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=mal
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
CHROME_BUILD_TYPE=_official.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SessionService. There were already some notifications that could be used to
tell what's going on, and I filled out the rest. I moved some notifications from
various places to the NavigationController.
In ssl_blocking_page, I removed a notification because it also calls
DidNavigateToEntry which does the notification (we got duplicate calls before).
In browser.cc I removed the tab parented notification since this is already
called by NavigationController::SetWindowID.
I removed some obsolete notifications and associated structures, especially in
history (like HOST_DELETED that was never issued).
I renamed the window_map_ in the MetricsService becuase it was actually a map
of controllers and Windows.
This also reorders the navigation_types header file to try to bring some order
to it.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
with a test.
BUG=none
TEST=none; just make sure context menu for bookmark bar still works
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
2000
and add debugging information to know how SavePageTest.SaveCompleteHTML is failing.
TBR=rocking
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
disabled). Also disable PrintingLayoutTest.IFrame, it's still flaky.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Adds a timeout in waiting for a tab to be restored.
2. Adds a bunch of printfs that will hopefully let me figure out where
the test is failing.
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
and browser_views.lib(65 source files, 30 megs).
This will hopefully improve link time (well, not as much as I'd like) and will definitely help non-IB compilation parallelization.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
distributed tests. The goal is to make a test run of all combinations of 4 (as opposed to 5 now) for a total of 34^4 commands (as opposed to 17^5) and see what comes out of it. We won't be running any random keypresses in this run (except in the Dialog fuzzers), only explicit actions.
There were also some discrepancies in how we were using the HTML elements, which I have fixed (Import is now ImportSettings, EditKeywords is now EditSearchEngines and ClearBrowserData is now ClearBrowsingData). I also reordered some functions to match .h file (alphabetical order).
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
the IDC handler for ViewSource. If Navigate is not called before ViewSource we get a crash when trying to use the output from GetLastCommittedEntry(). To facilitate automatic testing We should instead just check it for null and only do something if a URL is available to us.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
account the width of the Go button when sizing the location bar so that the last button on the toolbar (the app menu) spilled off the end.
TBR=glen
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
-remove reply_lock_ since received_replies_ was only being used on the IPC thread
-stop using nested locks
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Rather than creating a frankenstein separate window type for popups, this just uses BrowserView2, and the regular BrowserToolbarView, but hides all the irrelevant controls.
B=1031854
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
get crash reports.
- Added env_vars to exe project instead of keep duplicating the strings.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the listener thread. I've fixed the renderer crashes which were happening because
SyncChannel was going away before the listener thread.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
for lang=fil.
BUG=1320328,1321164
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
RootView, as well as renaming RootView::ProcessPendingPaint to PaintNow.
BUG=1255929
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=maruel
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Please note that the goal of this CL is merely to move the Windowisms out of timer.cc and into message_loop.cc. Next up will be to refactor message_loop.cc so that the Windowisms are further isolated.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
on the listener thread.
BUG=1319842
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
RenderViewHost.
Don't know how what I had before built. Tested more thoroughly this time.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR: brettw
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
worker thread shutdown in a way that is safe even for printer driver that displays a dialog box and attaches to the browser window.
BUG=1274015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* Set -j default to %NUMBER_OF_PROCESSORS% + 1 only on Windows.
* Initialize LOAD= modules up front, and let Linux override to the subset that are currently building.
* Initialize Linux CCFLAGS, LINKFLAGS and LIBS in a separate if-clause (like we do for Windows).
* Remove SCONSCRIPT_MAIN code in {base,chrome}/SConstruct in favor of just call ../build/SConscript.main.
* Merge in evanm's changes to base/SConscript for separate lists of platform-neutral and platform-specific source files and test files.
R=evanm,deanm
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=mal
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
the beforeunload handler hangs, then is_waiting_for_unload_ack
will be true here.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
RenderViewHostManager object.
The goal for this patch is to change no logic or APIs, just move the code. So
there are some not very clean callback functions and no new unit tests for this
file (although is is still covered by the same WebContents unit tests). This
should make the actual cleanup in a later pass much easier to follow.
I changed the ordering of only a few operations (like WebContents shutdown), and checked that this shouldn't matter. I had to change the "source" for several notifications since they are no longer sent from the WebContents.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Applied glint.
No code change, just moving around.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
there's still a TabStrip available for it.
B=1145714
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR: bradnelson
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=mal
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
What is happening is that the ImporterView creates an ImportingProgressView to show the progress of the import but the ImportingProgressView receives the Cancel event before ImportStarted, so importing_ is not set to true. Cancel will think import is done and returns true (allowing the view to be destroyed) and then the ImporterView will try to communicate with a dead observer.
By initializing importing_ to true this crash is avoided (we wouldn't be creating the view unless we were about to import, right?).
BUG=1320194
TEST=Open Import dialog, press Enter and then Esc really quickly and Chrome should not crash (try it 10 times to be sure).
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR: bradnelson
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
after we had database corruption last week from bad data being served
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
blocking calls. This replaces my previous CL that was somehow duplicating some of these functionalities.
BUG=None
TEST=Run the unit tests.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@691 0039d316-1c4b-4281-b951-d872f2087c98
|