| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Final round of unique_id deprecation. These changes migrated web_database schemas for profiles and credit cards, clean up the web_dataservice interface, bring the personal_data_manager interface inline with the GUID interfaces for web_dataservice, convert remaining unit tests to be GUID-based, and some changes to platform UI code that used unique IDs for edits.
BUG=58813
TEST=WebDataServiceTest.*, WebDatabaseTest.*, WebDatabaseMigrationTest.*, PersonalDataManagerTest.*, AutoFillTest.*, AutoFillDialogControllerTest.AddNewProfile, AutoFillDialogControllerTest.AddNewCreditCard, AutoFillProfileTest.MergeWith, ProfileSyncServiceAutofillTest.*, TwoClientLiveAutofillSyncTest.*
Review URL: http://codereview.chromium.org/4388001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=this is a test
BUG=none
Review URL: http://codereview.chromium.org/4406003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
flaky.
I've tried to reproduce the flaky behaviour on my local machine, in a VM, and on the build-bots, but have not been able to reproduce the problem. Because this test is important, I am disabling the single assert so that the flaky label can be removed.
BUG=46601
TEST=ExtensionApiTest.Popup
Review URL: http://codereview.chromium.org/4264005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Contributed by: tburkard@chromium.org
TEST=trybot
BUG=61745
Review URL: http://codereview.chromium.org/4226002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
because on Chrome OS all default extensions are installed via external_extansions.json
BUG=http://code.google.com/p/chromium-os/issues/detail?id=8662
TEST=unit_test
Review URL: http://codereview.chromium.org/4477003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reverting because this causes problems on valgrind (for ChromeOS only).
Turns out that TabStripModel is not thread safe, and I'm calling from
another thread.
Review URL: http://codereview.chromium.org/4446002
TBR=gspencer@chromium.org
Review URL: http://codereview.chromium.org/4417006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=61518
TEST=none
Review URL: http://codereview.chromium.org/4257002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=chromium-os:5612
TEST=None
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://code.google.com/p/chromium-os/issues/detail?id=8662
TEST=manual
Review URL: http://codereview.chromium.org/4411001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=61489
TEST=manual. see bug.
Review URL: http://codereview.chromium.org/4441001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Removed methods for querying and enabling media cache as the cache has been stable enough we shouldn't have to worry about checking anymore.
BUG=None.
TEST=No specific test as this flag hasn't been used.
Review URL: http://codereview.chromium.org/4266001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=61424
TEST=valgrind tests should pass.
Review URL: http://codereview.chromium.org/4104016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=60211
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64960
Review URL: http://codereview.chromium.org/4222005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
jglasgow@chromium.org:
Change the libcros API for cellular data plans keep all memory
allocation and deletion within libcros.
BUG=chromium-os:8297
TEST=ad hoc
Review URL: http://codereview.chromium.org/4270004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/4303002
Patch from Varun Jain <varunjain@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=41113
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This prevents super-long titles/URLs in the content from making the bubble enormous. Also, if the bubble has multi-line strings, set its minimum width to 250. (This replaces some code that set the multi-line string width to exactly 256 regardless of the rest of the content.)
Also, elide the popup titles/URLs in the middle instead of the ends, in hopes of preserving more unique portions of them.
BUG=41113
TEST=Visit a test page that opens a popup with a very long URL or title. The popup blocked bubble should not become enormous.
Review URL: http://codereview.chromium.org/4242003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add path validation for SaveAs dialog in FileBrowse DOMUI;
- Add a UserCrosSettingsProvider instance to ExistingUserController.
This triggers cached settings refresh on login screen and protect us from
setting spoofing.
BUG=chromium-os:7738
TEST=Verify user could not save file outside default download dir andoverify that spoofed settings will be reverted on login screen show up.
Review URL: http://codereview.chromium.org/4181008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=61518
TEST=none
Review URL: http://codereview.chromium.org/4449002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change extends the log severities into the negative for VLOG verbosities.
It also keeps track of file/line information and passes it to any registered log handler.
The log level is naturally controlled by translating ETW log levels to the severities.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4164011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Add some tests.
BUG=none
TEST=interactive_ui_tests --gtest_filter=InstantTest.*
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
without doing anything in the test it was timing out.
BUG=30519
TEST=self
Review URL: http://codereview.chromium.org/4158009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=61746
TEST=Install an outdated extension. Clear the cache. Upadte extensions, see that new extension was downloaded. Reload about:cache. No entry for manifest or CRX present.
Review URL: http://codereview.chromium.org/4275002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This flag does not take effect when passed to browser processes, remove the comment lines saying otherwise.
BUG=None
TEST=compiles
Review URL: http://codereview.chromium.org/4213001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Separate the parts of ExternalPrefExtensionProvider that store the list of external extensions and the parts that parse the preference file. This makes it possible for other providers to reuse the storage code.
Also make it possible to have external extensions from update URLs with locations other than Extension::EXTERNAL_PREF_DOWNLOAD, by making it a parameter of OnExternalExtensionUpdateUrlFound.
Add new provider (ExternalPolicyExtensionProvider) to provide external extensions from policies.
BUG=59782
TEST=ExtensionsServiceTest.ExternalPrefProvider,ExternalPolicyExtensionProvider.*
Review URL: http://codereview.chromium.org/3826008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50943
TEST=browser_tests:*.WebNavigationEvents*,unit_tests:FrameNavigationStateTest.*
Review URL: http://codereview.chromium.org/4381001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add a URL chrome://keyboardoverlay/ for keyboard overlay.
BUG=chromium-os:6268
TEST=manually on the net book
Review URL: http://codereview.chromium.org/4226001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The timezone change has been already prohibited by r64579 in C++,
but we should also disable this in the system settings page.
Note that manually_disabled is introduced in pref_ui.js since setting
"disabled = true" in options pages is overridden in the event
listener in pref_ui.js.
BUG=chromium-os:8541
TEST=confirmed that the timezone selection was disabled in guest mode.
Review URL: http://codereview.chromium.org/4296001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
You know when you're running the unit tests and windows pop up and a
sheet slides in? This makes them not do that. Found this setting
while researching something else.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4410002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=61849
TEST=none
TBR=dmazzoni@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:8400
TEST=make sure cellular connection can be activated from chrome:mobilesetup
Review URL: http://codereview.chromium.org/4333002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[I actually did this two months ago, and though I had committed it, but
due to the "git cl push" vs "git cl dcommit" craziness, it was never
in the tree.]
It was previously reviewed and LGTM'd here:
http://codereview.chromium.org/3235007/show
BUG=none
TEST=Tested on device, both using large numbers of tabs, and
small tabs that used lots of memory.
Review URL: http://codereview.chromium.org/4446002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for now. It looks like run_testserver is crashing.
BUG=none
TEST=none
TBR=darin
Review URL: http://codereview.chromium.org/4411002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=test_directory_reader.cc
Review URL: http://codereview.chromium.org/4107004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
These files probably just predate us having a _win suffix on Windows-specific
code.
BUG=18504
TEST=compiles
Review URL: http://codereview.chromium.org/4451001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Loosely based on http://codereview.chromium.org/3038006 by estade.
BUG=57437
TEST=cool zippy exception lists in DOMUI content settings
Review URL: http://codereview.chromium.org/4191005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Until volume key grabbing is removed from window manager, Chrome needs to keep responding to the key messages from window manager. This patch puts that functionality back in until this is done.
BUG=chromium-os:6074, chromium-os:8635
TEST=Volume Up/Down and Mute keys should work when screen is locked and when logged in normally.
Review URL: http://codereview.chromium.org/4420001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a sad change that we have to hard code this. :( And hopefully,
we will get the enterprise feature complete soon and could remove
this hack.
BUG=none.
TEST=Verify that screen lock is enabled for google.com logins.
Review URL: http://codereview.chromium.org/4347001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Jankometer is monitoring durations for each
task, but most of the time, this work is not used.
I changed the system to only sample the durations,
unless someone turns on a watchdog, and then we
monitor every event. The sampling is deterministic,
(every N events is sampled) but should be fine
when we aggregate across thousands of users in
a histogram.
r=brettw
Review URL: http://codereview.chromium.org/4279003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a relanding of http://codereview.chromium.org/4174002
The change in this CL is that I've made the function
to look for errors virtual, and over-rode it in StatsHistograms.
The current override doesn't actually check for inconsistencies,
so that the UMA checks (and renderer-to-histogram checks) won't
complain and refuse to transport the histograms.
BUG=61281
r=rvargas
Review URL: http://codereview.chromium.org/4364001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch exposes hooks for sync in TestingAutomationProvider that the chrome pyauto test suite can use. It contains the following changes:
- Partial revert of an earlier change to ProfileSyncServiceHarness. Some of its methods were made pure virtual, but this ended up being unnecessary. Also ripped out unnecessary code from LiveSyncTest.
- Minor refactor of ProfileSyncServiceHarness to allow for scenarios where the browser is restarted.
- A bunch of new methods in TestingAutomationProvider: SignInToSync, GetSyncInfo, AwaitSyncCycleCompletion, EnableSyncForDatatypes and DisableSyncForDatatypes.
- A new method in model_type.h/cc called ModelTypeFromString. Required for automation.
- New APIs in pyauto.py for sync.
- New test suite sync.py with sample tests.
BUG=53651, 60970, 56460, 61639
TEST=run pyauto sync tests
Review URL: http://codereview.chromium.org/4096004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the 'go back' button big and green in a central place, to encourage people go back to safety; and more clear description about why we block the page.
Sample screenshots at: https://docs.google.com/document/edit?id=1Kk2wxsj8JjIjlC1WUPamDlEPWZH-iWUoECMRdyQ9t_4&hl=en&authkey=CJKfrM0D
Patch from Ke Wang <kewang@google.com>
BUG=60813
TEST=unit_tests. To see the UI change, start the browser and try load some sites in malware blacklist.
Review URL: http://codereview.chromium.org/4175003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
benchmarks extension."
This reverts commit fbf3155bc7b82cbf56c9e6bdbd806a81daf2f2ce.
Also update docs.
BUG=61650
TEST=Successfully ran build.py
Review URL: http://codereview.chromium.org/4421001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
settings.
TEST=make sure we don't show WEP passphrase in UI, make sure forget network button works again
BUG=chromium-os:8413, chomium-os:8441
Review URL: http://codereview.chromium.org/4162004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=60211
Review URL: http://codereview.chromium.org/4222005
TBR=jam@chromium.org
Review URL: http://codereview.chromium.org/4431001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ImageCache remains on Extension, on the expectation that it will eventually be
loaded at startup.
BUG=56558
TEST=no functional change
Review URL: http://codereview.chromium.org/4132005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add notifications for printer settings changed, and periodic update to check for new printers.
BUG=none
TEST=Make sure CP proxy works on Linux.
Review URL: http://codereview.chromium.org/4233004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=still compiles, passes try bots
Review URL: http://codereview.chromium.org/4405001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
accessibility object.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4337001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64967 0039d316-1c4b-4281-b951-d872f2087c98
|