| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=53399
TEST=none
TBR=trungl
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3252006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
8 to 6px, and remove the visible bounding box from the pressed state of the wrench icon.
BUG=52545
TEST=notifications on mac
Review URL: http://codereview.chromium.org/3270007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This prevents an awful debugging experience where things just silently hang.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3224001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46679
TEST=none (yet...)
Review URL: http://codereview.chromium.org/3053050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
add a column which is already present. If we create a table as part of the init process, don't try to alter the table, because it already exists.
BUG=10913
TEST= search engine dialog works, search engines don't disappear.
Review URL: http://codereview.chromium.org/3239006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Most things actually work.
Missing from this CL:
* Reloading thumbnails for tabs that change. This is required to show non-white thumbnails for thumbnails that are still waiting on the net when tabpose is opened.
* Showing infobars / bookmark bar in the thumbnail
* Showing accelerated surfaces (youtube videos on 10.6, compositor on 10.6)
BUG=50307
TEST=Enable tabpose. Should see thumbnails for all tabs (some loaded after a delay). Thumbnails should animate in correctly even if a tab has info bars, a detached NTP, or docked devtools. Tabs that haven't been frontmost since the window was last resized should look good. Opening many tabs and then immediately jumping into expose shouldn't crash.
Review URL: http://codereview.chromium.org/3163003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the last change needed to have an experimental sandboxed flash for windows
- Adds an export so flash can lower the token
- Thightents the policy a bit
- Sets a separate flash data directory.
BUG=50796
TES=see bug
Review URL: http://codereview.chromium.org/3245006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
already submitted).
TabContents.xib changes: it was converted to the latest IB version and vertical NSSplitView was added to it
as a child for existing horizontal NSSplitView hosting devTools; new one hosts page content and sidebar content.
BrowserWindowCocoa instance listen to SIDEBAR_CHANGED notification and updates sidebar content view according
to the sidebar state linked to the current tab (adds or removes the corresponding view).
Sidebar API design doc: http://www.chromium.org/developers/design-documents/extensions/sidebar-extension-api.
BUG=51084
TEST=Run browser_tests and interactive_ui_tests.
Review URL: http://codereview.chromium.org/3228003
Patch from Aleksey Shlyapnikov <alekseys@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should help us with some temporary bad conditions
on the bots. The browser shouldn't fail to start
three times in a row.
TEST=ui_tests
BUG=52746
Review URL: http://codereview.chromium.org/3126034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3162047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
settings, when the user is editing the omnibox.
BUG=none
TEST=Typing in the omnibox should make all items on the right disappear, and make ctrl-d do nothing.
Review URL: http://codereview.chromium.org/3218002
TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/3264005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
redness
due to the test timing out or crashing.
Bug=53853
TBR=dmazzoni
Review URL: http://codereview.chromium.org/3227004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=mpcomplete
TEST=browser_tests
BUG=53869
Review URL: http://codereview.chromium.org/3241006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert 57885 - [GTK] a couple of constrained window fixes:
1) don't grab focus when the parent tab isn't showing. Grab the focus when the tab is brought to the front.
2) handle escape via normal key handling rather than accelerator keys
3) don't allow the content view to take focus (via tab) when the constrained window is showing.
BUG=53242, 50799
TEST=see bugs. Also, tabbing between constrained window and url bar should work as expected.
Review URL: http://codereview.chromium.org/3227003
TBR=estade@chromium.org
Review URL: http://codereview.chromium.org/3257005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=53825
TEST=None
Review URL: http://codereview.chromium.org/3272006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) don't grab focus when the parent tab isn't showing. Grab the focus when the tab is brought to the front.
2) handle escape via normal key handling rather than accelerator keys
3) don't allow the content view to take focus (via tab) when the constrained window is showing.
BUG=53242, 50799
TEST=see bugs. Also, tabbing between constrained window and url bar should work as expected.
Review URL: http://codereview.chromium.org/3227003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
and PanelBeforeTab on Windows as well as they
randomly fail.
Bug=43061
TBR=skerner
Review URL: http://codereview.chromium.org/3252005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=52857
TEST=test extension install with RTL locale in ubuntu 9.04+
Review URL: http://codereview.chromium.org/3240003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Bug=53853
TBR=dmazzoni
Review URL: http://codereview.chromium.org/3225006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the user is editing the omnibox.
BUG=none
TEST=Typing in the omnibox should make all items on the right disappear, and make ctrl-d do nothing.
Review URL: http://codereview.chromium.org/3218002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
download in progress"
increased the size by 8% for es, it, ja, fr, ru, pt-BR and ko and verified that it fits
BUG=32164
TEST=In the bug. Original issue was on XP classic, please test there as it is most limited in the sense of space.
Review URL: http://codereview.chromium.org/3224004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
New pyauto functional test for declining dangerous downloads.
Review URL: http://codereview.chromium.org/3265002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
about:gpu to about:about.
BUG=none
TEST=visual, usage
Review URL: http://codereview.chromium.org/3214007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=53812
TEST=none
Review URL: http://codereview.chromium.org/3217009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3127004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of the call is that we de-prioritize work that is in the background.
Unfortunately, tab creation currently bounces through hidden/unhidden/
hidden/unhidden at least 2x before the tab is visible to the user.
Because we don't know if the tab will be in the foreground (and thus
prevent it from being SetBackgrounded), the right thing to do is to
simply not Background it on startup.
BUG=21884
TEST=none
Review URL: http://codereview.chromium.org/3249006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
current socket pool state. Table padding slightly increased for legibility.
TEST=manual
BUG=39756
Review URL: http://codereview.chromium.org/3267002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Please see http://crbug.com/50485 for details. This CL workarounds this issue by ignoring one "commit" signal triggered when resetting the gtk imcontext.
BUG=50485
TEST=See bug report.
Review URL: http://codereview.chromium.org/3214001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
info (url, title, mimetype, doctype) to WebAccessibility.
BUG=none
TEST=Modified unit test: RenderMessagesUnittest.WebAccessibility
TEST=Added new browser test: RendererAccessibilityBrowserTest.TestCrossPlatformAccessibilityTree
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57188
Review URL: http://codereview.chromium.org/3013035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Some hooks have small chances of race conditions that can cause hangs and test failures. Fix this by using the client-side WaitUntil for now.
Review URL: http://codereview.chromium.org/3222002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3245004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Preferences.xib changes: Rename various binding targets.
BUG=53830, 53834
TEST=Mac prefs get disabled properly when configuration policy is in effect.
Review URL: http://codereview.chromium.org/3274006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=53315
TEST=manual
Review URL: http://codereview.chromium.org/3162030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Preferences.xib changes: Bind Enabled state of password manager radio matrix and button to the new @properties.
BUG=52830
TEST=Change password manager policy, watch preferences UI.
Review URL: http://codereview.chromium.org/3241005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=42447
TEST=Load an extension with app.launch.fullscreen, saw that it had no effect.
Review URL: http://codereview.chromium.org/3275003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
failure as the old one had been duped through things to this point.
BUG=38522
TEST=none
Review URL: http://codereview.chromium.org/3239007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
On the CrOS UI (1) valgrind bot, this has been failing for the 5 days due to timeouts while running the test.
BUG=53825
TEST=None
Review URL: http://codereview.chromium.org/3219005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original CL: http://codereview.chromium.org/3259001
Adds curtain screen with "Checking for updates..." label and throbber to update screen. Curtain screen is shown at most 15 secs.
BUG=hromium-os:2444
TEST=Go through updating process and notice that first 15 seconds only spinner with "Checking for updates..." label is shown. After 15 seconds usual update progress screen is shown.
Review URL: http://codereview.chromium.org/3275004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
CID=12579
Review URL: http://codereview.chromium.org/3136023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add [NSPasteboard declareTypes] invocation before [NSPasteboard setData],
which is required on Loopard. (and not required SL.)
- Fixed a potential leak, using scoped_nsobject.
BUG=53519
TEST=manual
Review URL: http://codereview.chromium.org/3217006
Patch from Hamaji Morita <morrita@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:6079
TEST=Login on Chrome OS and see list of extensions installed (won't work without changes in ebuild file)
Review URL: http://codereview.chromium.org/3251001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=asargent@chromium.org
BUG=53779
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
benefit
of the call is that we de-prioritize work that is in the background.
Unfortunately, tab creation currently bounces through hidden/unhidden/
hidden/unhidden at least 2x before the tab is visible to the user.
Because we don't know if the tab will be in the foreground (and thus
prevent it from being SetBackgrounded), the right thing to do is to
simply not Background it on startup.
I will test to see if this effects startup performance on the build
bots. I wouldn't be surprised if it did, nor would I be surprised
if it had no effect!
NOTE: I'm uploading this as a test run through the performance bots.
I will revert this change.
BUG=21884
TEST=none
Review URL: http://codereview.chromium.org/3288001
TBR=mbelshe@chromium.org
Review URL: http://codereview.chromium.org/3263006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of the call is that we de-prioritize work that is in the background.
Unfortunately, tab creation currently bounces through hidden/unhidden/
hidden/unhidden at least 2x before the tab is visible to the user.
Because we don't know if the tab will be in the foreground (and thus
prevent it from being SetBackgrounded), the right thing to do is to
simply not Background it on startup.
I will test to see if this effects startup performance on the build
bots. I wouldn't be surprised if it did, nor would I be surprised
if it had no effect!
NOTE: I'm uploading this as a test run through the performance bots.
I will revert this change.
BUG=21884
TEST=none
Review URL: http://codereview.chromium.org/3288001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to GetTitle().
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3279005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=51178
TEST=The events described in the experimental.management API should fire for
extensions and apps being installed, uninstalled, enabled, and disabled.
Review URL: http://codereview.chromium.org/3278003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57831 0039d316-1c4b-4281-b951-d872f2087c98
|