| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This login status has two states:
1. The user is signed in. In this state we display their user name. Clicking on the user name shows the profiles menu (not implemented yet).
2. The user is not signed in. In this state we display a message saying that the user is not signed in. Clicking no the message navigates to the sync promo page.
BUG=93179
TEST=
Review URL: http://codereview.chromium.org/8107001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
settings.
BUG=96726
TEST=ExtensionSettingsApiTest
Review URL: http://codereview.chromium.org/8143015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add localized string for aria-label
Fix the aria-label to make the word 'password' come first.
BUG=chromium-os:21200
TEST=On login screen, press Ctrl+Alt+Z to enable accessibility and focus on a password field. Listen to what is spoken.
Review URL: http://codereview.chromium.org/8129001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=97131
TEST=none
Review URL: http://codereview.chromium.org/8162011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Chrome-side wrapper for v8::Context, so renamed to that.
Review URL: http://codereview.chromium.org/8110005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ignored.
If a site tries to register a protocol handler for which another protocol handler
for the same protocol and URL has already been registered, the request should be
ignored. Likewise, if another protocol handler for the same protocol and URL has
previously been ignored, the request should be ignored.
BUG=94933
TEST=Unit tests added.
Review URL: http://codereview.chromium.org/8137022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change adds a new error when the user tries to sign into sync using a user name that's already in use by another profile.
BUG=93102
TEST=
Review URL: http://codereview.chromium.org/8103009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
own file
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8146005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
target, and to use bounding client rect for clicking if the first client
rect does not exist.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8163006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8115017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Check if toplevel is NULL as GetTopLevelWidget can return null.
BUG=chromium-os:20826
TEST=none
Review URL: http://codereview.chromium.org/8165006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Work around race conditions on startup where an app page creates a background
page while the BackgroundContentsService is also opening the page. We now close
the existing page instead of opening one of the pages up in a visible tab.
Also added a new browser test to verify this functionality.
BUG=98046
TEST=Added new browser_test: AppBackgroundPageApiTest.OpenTwoBackgroundPages.
Review URL: http://codereview.chromium.org/8116015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=97131
TEST=none
Review URL: http://codereview.chromium.org/8163002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was introduced in
http://codereview.chromium.org/8041014/diff/3088/chrome/browser/ui/views/frame/browser_view_layout.cc
when I deleted the wrong branch of an if in line 461-466.
BUG=98754
TEST=see bug
Review URL: http://codereview.chromium.org/8148002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8166005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=99074
TEST=See bug.
Review URL: http://codereview.chromium.org/8161003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
notification that the fetcher can listen for to tell it to go ahead and display the infobar immediately.
BUG=99263
TEST=Turn on instant. Enter some intranet URL that will search by default. Wait until the instant search results display. Hit enter and verify you get an infobar. Do another instant search in the same tab and verify the infobar disappears.
Review URL: http://codereview.chromium.org/8162007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=98586
TEST=
Review URL: http://codereview.chromium.org/8083009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add some metrics to the quota enforcer for when the quota is exceeded.
BUG=96709
TEST=ExtensionSettingsQuotaUnittest/ExtensionSettingsApiTest
Review URL: http://codereview.chromium.org/8143016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Modified ExtensionApiTest.WindowOpenFocus to also check focus for Panels.
BUG=None
TEST=WindowOpenPanelTest.WindowOpenFocus
Review URL: http://codereview.chromium.org/8113020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
don't reset this state when switching between advanced/non-advanced customization.
BUG=98625
TEST=sync to an account with encrypt everything. At the customization dialog, click the advanced link. The "encrypt everything" radio button should be selected.
Review URL: http://codereview.chromium.org/8135020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=git try --bot win_rel,linux_rel,mac_rel,linux_clang,linux,win,mac
Review URL: http://codereview.chromium.org/8162001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=99214
TEST=sync_integration_tests, Run a client with --enable-sync-tabs-for-other-clients while another client is running
Review URL: http://codereview.chromium.org/8136039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8166007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Fixed test breakage. Removed instances of wstring.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8095004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
a hidden pending print preview tab.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8133014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Code was replicated in dragged_tab_controller_gtk.cc and
dragged_tab_controller.cc, this allows the same code to be reused. Also removing the corresponding TODO.
2) The old SplitRectangleInTwo() function was violating the styleguide by having not const references as parameters.
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/8137018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I realized I was unconditionally creating the database on disk, instead of
waiting until we actually need to write data in.
BUG=98138
TEST=Your profile dir should not contain a 'App Notifications' database until
you actually have an app notification (see TEST note on
http://codereview.chromium.org/8038040 for how to do this).
Review URL: http://codereview.chromium.org/8133031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the keyboard is focused while it's in the process of animating to hide, the
keyboard does not pop back up. This fixes that.
BUG=none
TEST=VirtualKeyboardManager.TestVisibility
Review URL: http://codereview.chromium.org/8152002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=90448
Review URL: http://codereview.chromium.org/8137012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=97131
TEST=none
Review URL: http://codereview.chromium.org/8133030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=97369
TEST=none
Review URL: http://codereview.chromium.org/8052027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
extensions to the browser
BUG=89642
TEST=everything still works
Review URL: http://codereview.chromium.org/8143019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also move the --process=extension command line flag to --extension-process
BUG=89642
TEST=everything still works
Review URL: http://codereview.chromium.org/8113035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=68267
R=sky@chromium.org
Review URL: http://codereview.chromium.org/8137026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=98843
TEST=
Review URL: http://codereview.chromium.org/8151001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cancelable_request.h: ForwardType is needed to handle functions that take references parameters.
BUG=none
TEST=none
R=csilv@chromium.org
Review URL: http://codereview.chromium.org/8136019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implemented and verified for linux, mac and win. 2 tests out of 4 are currently disabled because activation story in tests is still not understood by me completely, I'm going to continue fixing it. This patch fixes 2 issues with activation (implements it on Mac and properly waits for it on Linux)
Pieces of this patch:
1. Added NativePanelTesting::VerifyDrawingAttention() that does platform-specific 'deep verification' if the panel indeed shows 'draw attention' decorations.
2. Added NOTIFICATION_PANEL_CHANGED_ACTIVE_STATUS notification which is fired when a panel is transitioning active<->inactive. This allows to wait for activation, which is especially useful in GTK and Mac case, where gaining/loosing focus can involve cross-process interactions and thus running local loop is not enough.
3. Implemented Show()/ShowInactive() on Mac so they correspond to their names.
4. Implemented 4 tests, 2 of them currently enabled. Will enable more in a subsequent patch.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103583
Review URL: http://codereview.chromium.org/8072017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The UIPerfTest class implements a PrintResult() method. One
of its arguments is a flag that determines if a given result
is "important". The only difference in handling an important
result compared to a non-important result is that important
results are prefixed with '*' in stdio. The rest of the
message printed to stdio is exactly the same.
This change causes most/all of these stats to no longer be
important, which means the *-prefix is removed from the
message. By removing the *-prefix, this causes the Buildbot
to not include the result information in the step status
box in the waterfall view.
We should remove these results from the step status box since
they were originally added when there were much fewer bots
and steps so the display was not hindered by so many steps
showing many results. And now that we auto-detect perf
regressions and improvements, the 'important' ones to watch
will be auto-included by the Buildbot.
Review URL: http://codereview.chromium.org/8139021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Necessary for OAuth 2.0 code on some sites until we support cross-process
postMessage (http://crbug.com/99202).
BUG=59285
TEST=Log in with Facebook on a third party hosted app.
Review URL: http://codereview.chromium.org/8137020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=44773
TEST=none
Review URL: http://codereview.chromium.org/8143023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=sanjeevr@chromium.org
BUG=83592
TEST=existing tests
Review URL: http://codereview.chromium.org/8112003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=92373
TEST=none
Review URL: http://codereview.chromium.org/8135009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8143024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change updates the wording in some of the sync UI.
BUG=98845
TEST=
Review URL: http://codereview.chromium.org/8137017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
don't work.
BUG=94920
TEST=Make sure default apps are not installed in any chinese locales.
Review URL: http://codereview.chromium.org/8138007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
google.com sites in stable releases. It is also desirable to fix the need for manual intervention on each promotion to stable, and to beef up the whitelist.
BUG=98611
Review URL: http://codereview.chromium.org/8080004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8122013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
and Linux.
BUG=62079
TEST=Missing plug-in placeholder looks different
Review URL: http://codereview.chromium.org/7990005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Such values no longer crash extension processes in the DCHECK in DispatchChromeHiddenMethod.
BUG=none
TEST=Load an extension that uses window.onFocusChanged. Switch focus between a browser and some other app. Don't see extension crash notification bubble.
Review URL: http://codereview.chromium.org/8136025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104142 0039d316-1c4b-4281-b951-d872f2087c98
|