| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
truncating them with a "...".I tried to copy the Mac implemenation from here:http://code.google.com/p/google-toolbox-for-mac/source/browse/trunk/AppKit/GTMFadeTruncatingTextFieldCell.mbut my version is not as good since I couldn't figure out how to draw text on a transparent background.BUG=69301TEST=Ran Chromium and verified that things looked ok.Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80416Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80748Review URL: http://codereview.chromium.org/6695043
TBR=sail@chromium.org
Review URL: http://codereview.chromium.org/6815022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change fades tab titles instead of truncating them with a "...".
I tried to copy the Mac implemenation from here:
http://code.google.com/p/google-toolbox-for-mac/source/browse/trunk/AppKit/GTMFadeTruncatingTextFieldCell.m
but my version is not as good since I couldn't figure out how to draw text on a transparent background.
BUG=69301
TEST=Ran Chromium and verified that things looked ok.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80416
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80748
Review URL: http://codereview.chromium.org/6695043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will help determine whether differing scores on the same URL are related
to data that is passed through the ref (as in Google Instant queries). Also
add a test for the url feature extractor to verify that the ref is not used to
form any token features.
BUG=none
TEST=PhishingClassifierDelegateTest,PhishingUrlFeatureExtractorTest
Review URL: http://codereview.chromium.org/6812009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Check whether the form has been set because non-GetLogins requests won't set this.
Note: this is the same effect as the previous check of whether the stl map had the
request.
Carry over from http://codereview.chromium.org/6677125/
BUG=78726,75296,78723
TEST=
Review URL: http://codereview.chromium.org/6810026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use the global default context to get *some* UA
string in a preconnect. This is a change that was
suggested by wtc, and I've tested it by adding
(in my local build) a CHECK() of the getter
result in net/socket/client_socket_pool_manager.cc.
This change is a very low risk, high reward P1 fix.
It is pretty inconceivable that it could do anything
other than help the status quo.
I was going to land the CHECK(), but the number of
changes to unit tests was large, and adding the
CHECK() is best done on a canary. As a result, I'll
break out the changes to at least:
net/http/http_stream_factory_impl_unittest.cc
net/http/http_network_transaction_unittest.cc
along with the CHECK() change to:
net/socket/client_socket_pool_manager.cc
in a separate CL.
r=wtc
BUG=78037
Review URL: http://codereview.chromium.org/6799018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=jam
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL contains some changes necessary to make the file manager work better as a component extension (rather than just in the test harness.)
file_manager_dialogs.cc: turn off context menu
file_manager.css: add opacity transition, comments
file_manager.css: encode images as data: urls
file_manager.js: embed preview images, close window, fix path calculation
file_manager_dialogs.cc: allow closing, hide title
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/6816029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=78732
Original BUG=71097
Original TEST=no visible change
Original Review URL: http://codereview.chromium.org/6735042
TBR=avi@chromium.org
Review URL: http://codereview.chromium.org/6814029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=phajdan.jr
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
testSetDownloadDirectory
testEnabledPlugins
BUG=55480
TEST=none
Review URL: http://codereview.chromium.org/6805021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
URLRequestContextGetter for doing its I/O rather than creating its own worker thread.
BUG=None
TEST=Unit-tests, Cloud print notifications, sync notifications.
Review URL: http://codereview.chromium.org/6793047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
accessors to the singleton for more values that various code wants, then convert almost everyone using OSVERSIONINFO or SYSTEM_INFO structs to calling these accessors. Declare an AtExitManager in the out-of-process test runner since it didn't have one and that breaks singleton-using code in the test executable (as opposed to in chrome.dll).
A few other minor cleanups along the way (binding of "*", shorter code, etc.). Because I ran into problems with it while modifying gcapi.cc, I cleaned up our usage of strsafe.h a bit, so that files that don't need it don't include it and files that do use STRSAFE_NO_DEPRECATE instead of a modified #include order.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6816027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this change we now move the profile menu button to the left if a full screen button exists.
Here's a screenshot of what this looks like:
https://docs.google.com/leaf?id=0B0Odde3V7EhWMmEzOGFhYzktOWE1Ny00NjU2LWE2NDYtZTcwMTRhNmUzMjRi&hl=en
when collapsed:
https://docs.google.com/leaf?id=0B0Odde3V7EhWOGUxMDlmYzgtZjEyMi00NjdiLTg1YTUtNDE3MmZjZDdhMTFm&hl=en
BUG=None
TEST=Ran and verified that the profile menu button didn't overlap the fullscreen button.
Review URL: http://codereview.chromium.org/6802026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The RenderViewObserver currently sends two messages to the browser related
to tracking client redirects, which is needed for determining whether to
wait for a future navigation.
This is particularly needed to wait correctly in chromedriver for form
submissions and javascript redirects. However, timed redirects still need
to be considered.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6676136
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Allows synchronous http requests to be cancelled.
BUG=61150
TEST=HttpBridgeTest.Abort
Review URL: http://codereview.chromium.org/6802016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Download manager unit tests no longer leak in Valgrind.
Review URL: http://codereview.chromium.org/6815015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Show arguments when only a single slice is seleted.
- Refresh raw events view only when it is visible. Put events in a pre to reduce load time.
- Use more recent data in simulated trace data.
- Report 3 digits of precision on timestamps.
- Add labels to large-enough slices.
- Split TimelineTrack into TimelineThreadTrack and TimelineSliceTrack. Style TimelineThreadTrack independently.
- Make escape stop tracing. Correctly unregister key listeners when ending tracing via button click.
- Add standalone timeline test code.
Review URL: http://codereview.chromium.org/6677166
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
it did not fit in the table and was elided.
BUG=none
TEST=as in description
Review URL: http://codereview.chromium.org/6807002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
actual URL, wherepossible without WebKit API changes. The WebKit changes will happen in anotherCL.BUG=noneTEST=noneReview URL: http://codereview.chromium.org/6767010
TBR=ericu@google.com
Review URL: http://codereview.chromium.org/6813025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
possible without WebKit API changes. The WebKit changes will happen in another
CL.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6767010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6801058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=78679
TEST=see bug
Review URL: http://codereview.chromium.org/6814009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
is off for the password field.
- testPwdInfoNotStoredWhenAutocompleteOff
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/6813008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reuse infrastructure for chrome.tabs.executeScript() to
implement chrome.tabs.update({url:"javascript:...."}) since
it has built-in safeguards against navigation races.
BUG=77026
Review URL: http://codereview.chromium.org/6771062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6783005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/6816024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
R=tony@chromium.org,darin@chromium.org
Review URL: http://codereview.chromium.org/6726005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=clang bots are happy.
TBR=jam
Review URL: http://codereview.chromium.org/6810024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:13045
TEST=rginda's filemanager will use/test this api.
Review URL: http://codereview.chromium.org/6728032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
accessors to the singleton for more values that various code wants, then convert almost everyone using OSVERSIONINFO or SYSTEM_INFO structs to calling these accessors. Declare an AtExitManager in the out-of-process test runner since it didn't have one and that breaks singleton-using code in the test executable (as opposed to in chrome.dll).
A few other minor cleanups along the way (binding of "*", shorter code, etc.). Because I ran into problems with it while modifying gcapi.cc, I cleaned up our usage of strsafe.h a bit, so that files that don't need it don't include it and files that do use STRSAFE_NO_DEPRECATE instead of a modified #include order.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6713107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=76795
TEST=none
Review URL: http://codereview.chromium.org/6750018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the event that an extension uninstall is skipped (not allowed)
because that extension is not user-manageable, a new notification is
sent. The automation hook UninstallExtensionById is revised to handle
this case, and a new PyAuto test is written to exercise this new
functionality (the test attempts to uninstall the WebStore and verifies that
this extension cannot be uninstalled).
BUG=76598
TEST=None.
Review URL: http://codereview.chromium.org/6794040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for the client to fetch the server's version. If the server's version is
newer than the client's, warn the client and quit.
Additional small changes:
-Add /healthz callback that sends a 200 status, for checking if the server is up.
-Fix shutdown crash where the AutomationProxy is deleted on the wrong thread.
-Initialize logging correctly.
-Disable mongoose file serving capabilities by default
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6690060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the tiling should:
- offer 6-wide and 3-wide tile grids to the user
- in the 6-wide format, icons will grow to use the available space (within reason)
- animate between these two states
- not animate when not switching between these two states (keeping mouse-drag window resizing smooth)
- always be smooth; not flicker or jump around
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/6793033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80811 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/6799022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
GTK can restore focus if the native widget has a focus, and views always remembers the focused_view, so there is no need to store/restore on linux for this case. Opening it (like wrench menu) was causing the issues in bugs because it changes window activation.
BUG=70032,chromium-os:8829
TEST=see bugs
TEST=
Review URL: http://codereview.chromium.org/6691052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
match recent libcros changes around Store/RetrievePolicy
BUG=None
TEST=unit tests
R=stevenjb@chromium.org
Review URL: http://codereview.chromium.org/6815001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on ChromeOS.
After this change, on ChromeOS we will use the TPM to generate keys
for keygen tags in forms. NSS will also have opencryptoki loaded so
it can talk to the TPM.
BUG=chromium-os:12416, chromium-os:12417
TEST=Generated keys on a ChromeOS device.
Review URL: http://codereview.chromium.org/6667020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
track of changes.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6759038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a download error occurs, we now mark it as "Interrupted", and display the new status on the Download Shelf.
This is handled through the OnResponseCompleted() method, from:
DownloadResourceHandler ->
DownloadFileManager ->
DownloadManager
The latter checks the error value, and if not zero calls DownloadError().
DownloadError() marks the download as interrupted (stopping the progress timer), updates the download history, and updates its Observers.
DownloadItem::DownloadState now has a new state, INTERRUPTED.
There are also new display strings that show up on interrupted downloads in the download shelf and download page.
BUG=35278
TEST=Pass unit and browser tests. Also, run a python server that behaves as described below, connect to it, and observe that "Interrupted" shows up in the item on the download shelf. Check that the item behaves as if it were cancelled.
The Python server should respond to a GET request with a content length that is large, then provide several chunks of data (but less than the specified length) and then send a 'No file' response (code 204) and close the connection.
Review URL: http://codereview.chromium.org/6613024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
on the UI thread.
Review URL: http://codereview.chromium.org/6720051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6803016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=20781
TEST=see bug
R=arv@chromium.org
Review URL: http://codereview.chromium.org/6801017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix up callers to use the new location and namespace.
BUG=None
TEST=None
R=brettw@chromium.org,avi@chromium.org
Review URL: http://codereview.chromium.org/6816004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=30572
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/6793052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Plumb TabContentsWrapper through the AppleScript code.
BUG=71097
TEST=none
Review URL: http://codereview.chromium.org/6815002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://bugs.webkit.org/show_bug.cgi?id=57957
We are migrating the protocol to JSON-RPC-2.0 spec.
TEST=none
BUG=none
TBR=yurys, pfeldman
Review URL: http://codereview.chromium.org/6816013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This also simplifies the PrerenderBrowserTest framework quite a bit. The main message loop is only run once, and is quit only if the correct number of loads have been seen for FINAL_STATUS_USED, or after the TestPrerenderContents are destroyed for all other final statuses.
BUG=73580
TEST=browser_tests --gtest_filter="PrerenderBrowserTest.*"
Review URL: http://codereview.chromium.org/6793018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The "DNS Prefetch" option currently controls DNS prefetching, TCP preconnection,
and prerendering of pages. This modifies the text string to replace
this, and changes variable names to reflect it.
The underlying preference name remains the same so settings are not
lost. However, I changed the policy name to make name changes
consistent. If this does not migrate well, I will retain the old
policy name.
BUG=77783
TEST=Existing tests, make sure text is correct in browser.
Review URL: http://codereview.chromium.org/6793045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
When opening DevTools window there is an exception in the console: "Uncaught ReferenceError: WebInspector is not defined" because some commands are sent to the front-end before it's loaded.
BUG=None
TEST=Open DevTools window, you should see no exceptions in the console
Review URL: http://codereview.chromium.org/6801044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80767 0039d316-1c4b-4281-b951-d872f2087c98
|