| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
BlockedPopupContainerView class into a windows specific instance owned by the new BlockedPopupContainer.
http://crbug.com/12843
Review URL: http://codereview.chromium.org/118401
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=no
TEST=no
Review URL: http://codereview.chromium.org/119327
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TabContents::FocusThroughTabTraversal(reverse), as SetInitialiFocus can be easily confused with TabContentView::SetInitialFocus().
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/118392
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=13290,13128
TEST=Add --enable-user-scripts to command line without --enable-extensions or --load-extension. Start Chrome, user scripts should work. Also run ui tests with --enable-extensions.
Review URL: http://codereview.chromium.org/119256
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TEST=test page and app menus thoroughly.
Review URL: http://codereview.chromium.org/119291
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=11507
Review URL: http://codereview.chromium.org/118399
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
reviewed! (Wow, brainfart.)
TBR=aa
Review URL: http://codereview.chromium.org/119324
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Sadly, the only way I could find to fix this was a latest_result() accessor, because when the user hits enter, we really do need to use the very latest results. This just highlights how more of this stuff should move to the AutocompleteController.
BUG=13428
TEST=Type "food.c" and wait for the popup to stabilize. Then _very_ quickly type "om" and hit enter. You should navigate to food.com instead of searching for "food.c".
Review URL: http://codereview.chromium.org/118398
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=The lock should still show up on SSL pages.
Review URL: http://codereview.chromium.org/119323
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
contexts rather than frames.
Also change the way we call through to javascript, to avoid a v8::Compile.
This is so we don't skew the histogram stats on our script cache.
BUG=?
TEST=none
Review URL: http://codereview.chromium.org/118353
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When multiple page actions are active, there was no padding between icons. Also, the entry_width was being truncated too much (the more page actions the more apparent it came).
This fixes that.
BUG=12060
TEST=Have multiple page actions (more than 3) active in the Omnibox, make sure there is a little bit of space between each icon. Start typing and make sure you can type all the way to the page action icons.
Review URL: http://codereview.chromium.org/118390
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
pixels to the wrong location when the scrolled region did
not start at y=0.
BUG=13521
TEST=Open url in bug report. Scroll in the two frames with scrollbars,
then switch to a different window. The webpage should not get scrambled.
Review URL: http://codereview.chromium.org/118372
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
forgot to change back in my last changelist).
BUG=none
TEST=Print Dialog on Windows should not have the print selection option active.
Review URL: http://codereview.chromium.org/118391
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
If the bookmarks backend finishes loading during shutdown (after the browser's gtk window has been destroyed but before the application is finished shutting down), we may try to call show() on a destroyed widget.
BUG=13575
Review URL: http://codereview.chromium.org/119317
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- drag into folders
- improve pre-drop highlighting
- use default drag icon instead of row bitmap for tree view row drag.
Review URL: http://codereview.chromium.org/118357
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/118311
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=thestig
Review URL: http://codereview.chromium.org/118389
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
query, since that's the mode that was used to start it.
BUG=13348
TEST=Cancelling a login query should not fail in off-the-record mode.
Review URL: http://codereview.chromium.org/119204
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Much of this CL is refactoring; it's not as large as it looks.
(Do I always claim that? It's really true this time.)
Review URL: http://codereview.chromium.org/115150
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/118388
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
IPC and implements the Windows dialog interaction but does not enable this just yet.
BUG=http://crbug.com/1682
TEST=none
Review URL: http://codereview.chromium.org/118338
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Works on Windows and Linux. On Mac V8's sampling doesn't work with Chromium due to an unknown reason.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118384
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I don't completely understand the problem, but I hacked up glipper to dump
what was going on. It watches the primary clipboard ownership changes, then
waits for the clipboard contents. There are some races there and then it eats
our selection.
The solution, which isn't great, is to disable the primary selection around
setting up the inline autocomplete selection. This means that the primary
selection is the full text and not just the inlined portion, but I don't see a
huge case for using the autocompleted portion as the primary selection anyway.
The other clipboard (ctrl-c / ctrl-v) should work the same as before.
BUG=11956
TEST=That inline autocomplete works correctly like it did before. It should
now also work correctly with glipper / klipper running.
Review URL: http://codereview.chromium.org/119170
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Folder selection and the Edit... button should now work.
BUG=11738
Review URL: http://codereview.chromium.org/119174
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We need to manually reset the omnibox by reverting the text before the bookmark click event occurs
BUG=12627 (http://crbug.com/12627)
TEST=Clicked on bookmark while editing in omnibox to bring up suggestionlist, as well tried unfocused omnibox while clicking on a focused inpage browser link
Review URL: http://codereview.chromium.org/119292
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/13514
TEST=See bug.
Review URL: http://codereview.chromium.org/119278
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Limitations that need addressing still:
- Doesn't forcibly terminate children that should have exited but haven't
Enable with env var ENABLE_ZYGOTE_MANAGER=1.
BUG=11841
TEST=
start the browser, then make chrome and all .pak files unreadable; or alternately, start an installed browser, and uninstall the browser while it's running. Then create a new tab and browse to two new sites.
Here's an example script to hide and unhide the .pak files (note: do not move the directory they're in, that doesn't work):
#!/bin/sh
chmod_all() {
chmod $1 sconsbuild/Debug/chrome
for path in . locales obj/chrome/app/intermediate/repack obj/global_intermediate/* themes
do
chmod $1 sconsbuild/Debug/$path/*.pak
done
}
case $1 in
hide) chmod_all 000 ;;
show) chmod_all 755 ;;
esac
Review URL: http://codereview.chromium.org/115773
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
It seems that 'l' data type of Python's array uses long, which is 64bit integer in LP64 environemnts. This means that this script generates corrupt headers in LP64 environments such as AMD64. Let's just use 'i' data type for 32bit integer.
http://docs.python.org/library/array.html
Review URL: http://codereview.chromium.org/119283
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118362
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119282
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* ui_tests.exe: add precompiled_wtl to the build.
* unit_tests.exe:
add dependency on installer_util_strings and hunspell;
add modules from tools/convert_dict;
add aditional tests from ../views;
add missing resources.
* perf_tests.exe: add missing modules.
* interactive_ui_tests.exe:
add dependency on installer_util_strings;
add missing browser/debugger/devtools_sanity_unittest.cc module;
add missing resources.
* Cleanup: alphabetize sources in test_support_common.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119281
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119265
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Killed (1) the "start download" (big arrow) animation and (2) fade and resize animation on NTP page, when the following conditions is met:
(XP) Chromium is used over RDP.
(Vista) "Turn off all unnecessary animations (when possible)" option in "Control Panel - Ease of Access Center - Make the computer easier to see" is checked. Note that the option automatically becomes checked when a user turns off the "Menu and window animation" option of a remote-desktop client.
Review: http://codereview.chromium.org/115304
BUG=805
TEST=For (1), download a file and verify the arrow doesn't appear over RDP. For (2), set NTP as your homepage, start chromium on RDP session, verify fade animations on thumbnails are killed, then resize browser window, verify resize animations on thumbnails are also killed. Do the same thing with --new-new-tab-page command line flag.
Review URL: http://codereview.chromium.org/118307
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the first part of the change. I will submit code to listen
for new extension processes while task manager is open in following patch(es).
TEST=Install an extension which renders to the extension shelf, like Buildbot Monitor from http://dev.chromium.org/developers/design-documents/extensions/samples. Open the task manager. You should see the extension process.
http://crbug.com/12127
Review URL: http://codereview.chromium.org/115858
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/119279
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CTRL+W is duplicated twice, we just need one, so this is just a cleanup.
BUG=none
TEST=CTRL+W works
Review URL: http://codereview.chromium.org/118360
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/119274
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
operation. Instead let JS do the call as needed. This is in preparation
for the new new tab page which will do other things when an URL is
blacklisted.
Also, fix some issue in the last CL
BUG=13362
TEST=Add and clear most visted items like before. Things should work as
before
Review URL: http://codereview.chromium.org/118350
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=13362
TEST=No visible changes yet.
Review URL: http://codereview.chromium.org/119273
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Reorganize functions in CC to match header and related OCD activities.
No logic changes.
Review URL: http://codereview.chromium.org/118352
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Right now, this means windows with the same Profile.
http://crbug.com/12241
TEST=Open some tabs in incognito and regular windows. Try to drag between. Should be able to drag between like security contexts (incognito to incognito, regular to regular), but not across.
Review URL: http://codereview.chromium.org/119266
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
would still be the NTP's one.
http://crbug.com/11998
TEST=See bug.
Review URL: http://codereview.chromium.org/119262
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118344
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=non
Review URL: http://codereview.chromium.org/118323
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
declarations, modify or add a couple comments, change a function name in hopes of greater accuracy.
Review URL: http://codereview.chromium.org/119264
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Trying to send decoded images over IPC didn't work too well. Instead, we'll
write them to a file and have the browser slurp them in from there. My first
instinct was to use SharedMemory, but that would require us to impose a limit
on the size of the decoded image data.
Also made sure that the undecoded images are deleted when we install.
BUG=13455
TEST=Try the repro steps in bug 13455 several times and make sure it works
every time.
Review URL: http://codereview.chromium.org/119255
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Use it on the custom startup url buttons.
BUG=11507
Review URL: http://codereview.chromium.org/118327
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=6906
TEST=Type "foo" into the Omnibox. Verify the Go button tooltip refers to searching for "foo" using your default engine. Change to "foo.com". Verify the Go button tooltip refers to navigating to foo.com. Change to using some custom search engine (e.g. tab-to-search on yahoo.com) and put in a search term. Verify the Go button tooltip refers to searching for your term on the chosen engine.
Review URL: http://codereview.chromium.org/119263
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17791 0039d316-1c4b-4281-b951-d872f2087c98
|