| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/114052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=10005
Review URL: http://codereview.chromium.org/115723
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(For reference, it was committed with the wrong message: "Patch to make
password patch build.")
This reverts commit r16708.
Review URL: http://codereview.chromium.org/113871
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115801
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115802
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113869
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The logic for resource loading for media file has
a problem in determining the wait condition that it
waited for one extra cycle (about ~5s) to know that
the resource loading has completed, it is fixed in
this patch. Also made clear about the logic in it.
Review URL: http://codereview.chromium.org/113861
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
cross-platform.
Review URL: http://codereview.chromium.org/115799
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
We were crashing while trying to load fonts. Your patch for font
fallback fixes the crash.
Review URL: http://codereview.chromium.org/112061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit 071e95bcdcefcd2cb86c9aed5cb073bbcaa7f2a7.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113863
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
previous change that used the wrong parent variable when showing HTML dialogs.
Review URL: http://codereview.chromium.org/113864
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This checkin adds gmock, and a small example of how to write a gmock-based unittest.
Review URL: http://codereview.chromium.org/113807
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113862
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113865
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115790
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
first-run dialogs.
Review URL: http://codereview.chromium.org/113858
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115795
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115786
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=crash handler should not print garbage to the console following the crash id.
Review URL: http://codereview.chromium.org/115796
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
r16889 triggered some warnings with GCC 4.3: http://pastebin.com/m3a9415af
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115784
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/12555
TEST=Browse to a page. Bring up a new tab (Command-t), should be able to start typing in autocomplete.
http://crbug.com/12556
TEST=With a partial URL entered, switch tabs, and switch back. Should be able to type to replace autocomplete. This does not fix the entire bug.
Review URL: http://codereview.chromium.org/115734
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ever receiving a drag-motion signal. In this case we'd crash because dragged_tab_ isn't created yet.
BUG=12473
TEST=Open a browser with three tabs. Rapidly click on the first and third tabs. This should not cause the browser to crash.
Review URL: http://codereview.chromium.org/113854
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It's still used by the unit test.
TBR=erg
Review URL: http://codereview.chromium.org/115791
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a crash spike in ChromeBot.
The crash spike is caused by some observers
don't remove themselves from notification list
after being deleted. The clean up done by pkasting
may fix this so I am give this change another
try.
TEST=None
BUG=None
Original change description:
Close browser window synchronously during UI test
tear down. This is an effor to reduce random
failure due to browser crash with multiple window
open during shutdown.
Review URL: http://codereview.chromium.org/113856
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113851
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
views build so that we only include the gtk classes we need.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115788
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
up on drags and the buttons look depressed when the menu is showing.
BUG=12427
TEST=back/forward button behavior should be as on windows (see bug desc. for details).
Review URL: http://codereview.chromium.org/113806
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
design doc linked from the bug. This implements the ability to read existing Keychain passwords, but no storage/updating yet, and no adding of our own metadata as passwords are used; all that will be done in follow-up patches.
This also includes a Keychain wrapper for the functionality necessary so far, and a mock Keychain sufficient to unit-test essentially all of the code.
This patch deliberately excludes the step of instantiating a PasswordStoreMac and hooking it up to the profile, because a bug in autocomplete itself prevents passwords we load from actually being used, and we don't want to trigger Keychain UI for passwords that will be ignored. So this won't be used in builds yet, but it will be unit tested.
BUG=11745
TEST=none (no user-visible effect yet)
Review URL: http://codereview.chromium.org/115658
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Open a browser window with two tabs, pull one of the tabs out of the tab strip. On release, a new window should be created with the dragged tab contents.
Review URL: http://codereview.chromium.org/113787
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
views.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113849
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
of chrome. This renames the _win version to _views and makes the header
compilable on non-Windows.
Review URL: http://codereview.chromium.org/113844
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
process-per-worker model and remove uses of V8 lockers. Due to this, we can not run any worker layout test that starts multiple workers because we load V8 instance in DLL in test shell. To cover this deficiency, we need to add UI tests to test multiple workers.
BUG=12554
TEST=none
Review URL: http://codereview.chromium.org/115731
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Some VNC users still have this setup.
BUG=10616
http://codereview.chromium.org/113848
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=12560
Review URL: http://codereview.chromium.org/115785
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After asking for an extension to be unpacked, sometimes the
temp directory gets cleaned up before the unpacker can do its
work (in LoadExtensionsFromInstallDirectory, because the dir
contains no current version).
BUG=None
TEST=Add a reg key to HKLM to install an external extension
and make sure the extension gets installed.
Review URL: http://codereview.chromium.org/113795
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
--proxy-bypass-list.
R=robertshield,eroman
BUG=http://crbug.com/266
TEST=N/A
Review URL: http://codereview.chromium.org/115725
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GetBrowserViewForNativeView and implements the GTK side. I could have
went with NativeWindow here, but we end up with more flexibility if we
keep this as NativeView.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113842
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
GetDockInfoAtPoint, but that's not important for now.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115776
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Move extension.* from browser to common, so it can be included by the utility
process.
Review URL: http://codereview.chromium.org/115716
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115774
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
targeted when the window isn't the foreground window.
BUG=12505
TEST=closing and minimizing background windows. all mouse interactions with foreground tabs.
Review URL: http://codereview.chromium.org/112059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Matt - please revert this change once you've fixed the leak.
TBR=thomasvl
BUG=12661
TEST=XP unit (purify) bot should cycle green
Review URL: http://codereview.chromium.org/115777
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
names, function parameter keys, error messages and event names so that
they can be reused when writing extension UI tests.
Original review: http://codereview.chromium.org/113771
Review URL: http://codereview.chromium.org/113831
Patch from Joi Sigurdsson <joi.sigurdsson@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Commit: http://codereview.chromium.org/113733
BUG=12170
TEST=Enable user scripts and create one. See that it runs. Now delete it. See
that it does not run!
Review URL: http://codereview.chromium.org/113741
Patch from Ted Crossman <tedoc2000@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115742
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16847 0039d316-1c4b-4281-b951-d872f2087c98
|