| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Along the way, refactor some related code.
BUG=now
TEST=manually
Review URL: http://codereview.chromium.org/1605029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Use ISO 639-1 language code for input method indicator.
- Do not use raw language codes in the drop-down menu.
BUG=crosbug.com/2428
BUG=crosbug.com/2564
TEST=manual
Review URL: http://codereview.chromium.org/1622025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
document or query params.
We should only remove the icon when visiting a new origin or the underlying setting has changed.
BUG=40742
Review URL: http://codereview.chromium.org/1640004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
At this moment, this requires a browser restart, thus shows
a dialog about it.
DPENDS_ON http://codereview.chromium.org/1595026/show
BUG=crosbug.com/2336
TEST=manually
Review URL: http://codereview.chromium.org/1645007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the UI by Options->Change AutoFill settings->click on an
address->click on "Make this my default profile" flag.
( Original patch by raz@chromium.org )
BUG=41247
TEST=Set this pref in one browser, sync it in the other
Review URL: http://codereview.chromium.org/1612019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=confirmed it worked on linux and didn't break the windows build by trybots
BUG=none
Review URL: http://codereview.chromium.org/1595026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Startup perf was not impacted in an earlier test run, so this should be safe.
BUG=38182
Review URL: http://codereview.chromium.org/1530031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed Control+space since it's just for testing. Added Alt+~ which is popular for Japanese IME users on Windows.
We will add more hot-keys like 'Right-Alt+Right-Shift' and 'Zenkaku_Hankaku' later (in a separate CL).
BUG=crosbug/492
TEST=manual
Review URL: http://codereview.chromium.org/1593026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Along the way, remove "Cance" button. If really needed,
we could adding support for canceling in the future.
BUG=crosbug.com/2074
TEST=manually
Review URL: http://codereview.chromium.org/1612018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44452 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
is called after Start().
BUG=41359
TEST=unittests
Review URL: http://codereview.chromium.org/1547033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
For now, the logic for UI language switching is not yet implemented.
Will add the logic in a separate patch.
TEST=manually
BUG=crosbug.com/2336
Review URL: http://codereview.chromium.org/1652002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
reason the assert is no longer valid is that browser tests no longer
run a nested message loop.
BUG=none
TEST=none
TBR=suzhe@chromium.org
Review URL: http://codereview.chromium.org/1645006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a test run to see how it impacts startup perf (if any).
BUG=38182
TBR=chase
Review URL: http://codereview.chromium.org/1595027
TBR=tony@chromium.org
Review URL: http://codereview.chromium.org/1560034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is a test run to see how it impacts startup perf (if any).
BUG=38182
TBR=chase
Review URL: http://codereview.chromium.org/1595027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This encapsulates differences between the language codes used in
InputMethodDescriptor and Chrome's application locale codes.
TEST=unit_tests
BUG=crosbug.com/2336
Review URL: http://codereview.chromium.org/1611026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows us to move the chrome specific version informaton used by
Linux into src/chrome.
Add a GetChromeVersionInfo() for Linux in src/chrome/app/ and make sure to use this in src/chrome.
In src/webkit/glue, add a new glue method for getting the product version. When compiling chrome, use an implementation in src/chrome/renderer (which uses GetChromeVersionInfo()) and a stub implementation for test_shell.
Review URL: http://codereview.chromium.org/1560027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
but enabled on other platform.
new-run-webkit-websocketserver won't run on Windows
because of https://bugs.webkit.org/show_bug.cgi?id=37518
BUG=40976,40995,41319
TEST=trybots pass
Review URL: http://codereview.chromium.org/1630019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Parses the json file
BUG=27885
TEST=test modified
Review URL: http://codereview.chromium.org/1609022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
AutoFill suggestions from the AutoFillManager.
BUG=41378
TEST=none
Review URL: http://codereview.chromium.org/1633011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
accessing members of a destroyed object while unwinding the callstack.
BUG=41274
TEST=Run Chrome with full page heap on. Clicking an item in the omnibox dropdown should not crash.
Review URL: http://codereview.chromium.org/1566040
TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/1589033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=30242
TEST=Go to this page:
http://weston.ruter.net/projects/test-cases/chrome-mp3-audio-crash/
Click play and it won't hang.
Opening (not) too many audio streams in Leopard will cause a
deadlock in AudioQueue, freezing the browser process. Unfortunately
there isn't a way to detect that in the AudioQueue API. So this
change limits the number of streams allowed.
The limit for Leopard is set to 15 and other OSes are 50.
Review URL: http://codereview.chromium.org/1559024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=40902
TEST=Go to a folder with not enough items to show a vertical scrollbars. Copy and paste items so that the scrollbar is shown. The scrollbar should be next to the window edge. Also try resizing the window.
Review URL: http://codereview.chromium.org/1625013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
See screen cap in bug.
BUG=41356
Review URL: http://codereview.chromium.org/1642006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG= 37564
TEST= start Chrome with --first-run enabled -- you should see a new search engine selection dialog.
Review URL: http://codereview.chromium.org/1586005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Technically, this still isn't centered (there's one more pixel below the
icon then there is over it). But being off-center one pixel up looks better
than being off-centere one pixel down. (And both look better than the
current trunk.)
BUG=41189
TEST=none
Review URL: http://codereview.chromium.org/1568031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LoginDatabase"
This reverts commit 2fa9a35a2e607688e7c2f8908c0d1e4c31ff5c96.
TBR=stuartmorgan
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1545033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The extension bubble animation would trigger an infinite loop of resizing of the web content between two heights. By deferring the call to render_widget_host->WasResized() it seems to allow the height to settle and gets rid of the flickering. This was mostly prevalent on 10.5, but occasionally showed up on 10.6 when using devtools to inspect the popup.
BUG=31970
TEST=Using RSS extension, open the rss popup at www.aaronboodman.com
Review URL: http://codereview.chromium.org/1596013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=jcivelli
Review URL: http://codereview.chromium.org/1606018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
error check clearer.
BUG=41380
TEST=ExtensionApiTest.CaptureVisibleTab
Review URL: http://codereview.chromium.org/1545031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
instead of using WebDataService. Once PasswordStoreWin is migrated as well,
PasswordStoreLinux will likely be folded back into PasswordStoreDefault.
BUG=35038
TEST=PasswordStoreLinuxTest.*
Review URL: http://codereview.chromium.org/1525026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
a destroyed object while unwinding the callstack.
BUG=41274
TEST=Run Chrome with full page heap on. Clicking an item in the omnibox dropdown should not crash.
Review URL: http://codereview.chromium.org/1566040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Tint highlighted icons (the *_DARK variety) the color of highlighted text.
- Use new variants of the IDR_OMNIBOX_HTTP* and IDR_OMNIBOX_HISTORY* icons in
GTK mode where there isn't a white background.
BUG=41189
TEST=none
Review URL: http://codereview.chromium.org/1559029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=40604
TEST=Do something that shows an infobar (e.g. go to youtube and kill flash). Switch to and from fullscreen, resize window. Infobar text should stay visible. For infobars with links (e.g. geolocation infobar), the link should still show a hand cursor.
Review URL: http://codereview.chromium.org/1654004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
width to be incorrect.
BUG=40902
TEST=Switch between two folders. One that has enough items to show a scrollbar and one that does not show
Review URL: http://codereview.chromium.org/1549040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Change by Jan Voung (jvoung@google.com)
Review URL: http://codereview.chromium.org/1585033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
by the views hierarchy, but it was only taking ownership of the BalloonViewHost's native_view.
This was manifesting as a crasher when the chrome://extensions page attempted to access an EFD whose RVH was dead.
BUG=40967
Review URL: http://codereview.chromium.org/1619012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/39105
TEST=as in bug
Review URL: http://codereview.chromium.org/1513022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=cpu
BUG=none
TEST=Install with brand code CHHS or CHHM --> no RLZ.
Review URL: http://codereview.chromium.org/1613013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
requestPermission work in extensions.
BUG=40495
Review URL: http://codereview.chromium.org/1568028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 20226b236864eebd7af84703cc5a70056babd34a.
Revert "Fix conditional in PasswordStoreMac initialization"
This reverts commit 0d07a3783fc100c2cfe2a4d2f1c8f52ee94e3da7.
TBR=stuartmorgan
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1604033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
fullscreen controller.
BUG=41263
TEST=See test case in bug.
Review URL: http://codereview.chromium.org/1654002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(e.g. fire and forget). As implemented on the Mac, the termination
chain (e.g. when OK is pressed) is to call [NSApp endSheet:].
didEndSheet then closes the window, and the controller (set as the
delegate of the window) gets a windowWillClose: callback (so the
controller knows to delete itself).
The problem here was that the window was ordered out (offscreen) but
not actually closed, so we didn't clean up properly.
BUG=40429
TEST=no valgrind suppression needed and unit_tests stay happy.
nib change: window controller (file's owner) is the delegate of the window
(for both nibs)
Review URL: http://codereview.chromium.org/1654003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- The reload button in GTK mode now is the normal stock gtk icon again.
- The horizontal bounds of the omnibox popup are now the equal to the location
bar box in GTK mode.
BUG=41189
TEST=none
Review URL: http://codereview.chromium.org/1604028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Loosen up a DCHECK and add a unit test.
BUG=41315
TEST=Repro steps in Bug.
Review URL: http://codereview.chromium.org/1525030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=41332
TEST=Mac version should use keychain to read/store passwords.
Review URL: http://codereview.chromium.org/1528035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Most tests from krisr
Review URL: http://codereview.chromium.org/1541009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=40880
TEST=try to Customize Sync so you're syncing 0 datatypes. You shouldn't be able to.
Review URL: http://codereview.chromium.org/1641001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
"Customize" button in case of an error.
BUG=none
TEST=build and run Chrome for Linux. Start syncing. Then build for Chrome OS. Try to stop syncing. Note that you cannot.
Review URL: http://codereview.chromium.org/1578020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
invert already within the layout code. This change puts notifications in the correct place regardless of the height of the dock.
BUG=40593
TEST=notifications on mac, with dock set to NOT auto-hide
Review URL: http://codereview.chromium.org/1593017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44362 0039d316-1c4b-4281-b951-d872f2087c98
|