| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Just the ability to read/write the data structure to a file. File
format is a simple header, the contents of the vectors, and a
checksum.
BUG=71832
TEST=none
Review URL: http://codereview.chromium.org/6625002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=74871
TEST=changing expanding items in the cookies list doesn't cause the items below to jiggle around as much
Review URL: http://codereview.chromium.org/6621054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This makes automatic generation of IPC messages much easier.
Convert autofill messsage to automatic generation in the process.
Attempt #2: fix build on chromeos, see http://codereview.chromium.org/6633001
for original CL.
Review URL: http://codereview.chromium.org/6625087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Move GetShowState to BrowserFrameWin rather than needlessly delegate to BrowserView. This removes a small amount of WIndows-specific code from BrowserView.
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/6627079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=75296
TEST=NONE
TBR=zea
Review URL: http://codereview.chromium.org/6623088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6621055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72732
TEST=trybot, unit_tests, permissions warning for https://chrome.google.com/extensions/detail/pjmjjdikcijaponjlhnibejonnjlfohg
Review URL: http://codereview.chromium.org/6596085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This makes it easy to write automated serilization code for it.
Review URL: http://codereview.chromium.org/6621057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77300 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are very few reasons that the BrowserView needs to know anything specific about the TabStrip. Most of them have to do with drag and drop.
So we introduce in this patch, an AbstractTabStripView interface that is the BrowserView's interface to the tab strip (instead of BaseTabStrip). Furthermore, we acknowledge that the View and the Controller are tightly coupled (they know about each other) and are therefore bound together at creation time inside the factory function rather than by the caller of the factory function (which would have been the BrowserView.)
1) The extensions need to restrict the ability to move/remove tabs when a drop operation is active. So we have IsTabStripEditable() and IsTabStripCloseable().
2) The only other reason to know about the internals seems to be some notification of loading animations. So we have UpdateLoadingAnimations().
Ideally, some day a tab strip can just be a view from the browser's perspective. For now, we still need these three methods.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6597107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Convert autofill messages to use the new IPC macros. This requires
changing the FormField class to a struct with publically-visible members,
which was what should have been done in the first place, instead of the
trivial setters/getters which are accessed in various combinations
independently of each other throughout the code.
Review URL: http://codereview.chromium.org/6633001
TBR=tsepez@chromium.org
Review URL: http://codereview.chromium.org/6623086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
disable switch.
Since currently on download url is checked, this only enables download url checks.
Because the safe browsing server used by safe_browsing_test.cc does not understand the new list for safebrowsing download, we have to disable the download protect in that test.
TEST=safe browsing related tests stay green.
BUG=60822
Review URL: http://codereview.chromium.org/6611006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
changing the FormField class to a struct with publically-visible members,
which was what should have been done in the first place, instead of the
trivial setters/getters which are accessed in various combinations
independently of each other throughout the code.
Review URL: http://codereview.chromium.org/6633001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is part of a serie of patches to make the TreeNode more closer to style
used in the Views Tree API (see views/view.h for reference).
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6623037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6621045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=75274
TEST=NONE
TBR=erg,zea,andreip
Review URL: http://codereview.chromium.org/6626074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moved the page and icon mapping from URLDatabase to
ThumbnailDatabase.
a. Created a new table icon_mappings in ThumbnailDatabase.
b. Migrated the mapping data during the upgrade.
c. Provided the new interface to access the icon_mapping data.
d. Removed the API to access the faviconID field in url database.
Support IconType.
a. Added additional column icon_type in favicons table.
b. Provided the APIs to access the icon_type field.
c. Currently hard-code all icon_type as FAV_ICON in history backend.
BUG=71571
TEST=new testcases in thumbnail_database_unittest.cc, and the existent
tests in history_backend_unittest.cc, history_unitest.cc,
bookmark_html_writer_unittest.cc etc.
Review URL: http://codereview.chromium.org/6620001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=71558
TEST=A file named VERSION should show up in policy_templates.zip
Review URL: http://codereview.chromium.org/6596071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The corresponding WebKit-side changed is
https://bugs.webkit.org/show_bug.cgi?id=55777
BUG=70845
TEST=none
Review URL: http://codereview.chromium.org/6624092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:12715
TEST=Manual
Review URL: http://codereview.chromium.org/6621064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77260 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Old interface is obsoleted by https://bugs.webkit.org/show_bug.cgi?id=55453
This is a sequel of the change:
http://src.chromium.org/viewvc/chrome?view=rev&revision=77118
Pass around preferred language to font fallback selection. For Fixing chinese font issue.
BUG=chromium-os:11699
TEST=manually
Review URL: http://codereview.chromium.org/6626050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
InfoBarContainer::RemoveInfoBar() instead of calling parent()->RemoveChildView() directly, so that the container knows the infobar is gone. (The container was trying to access deleted infobars because it never saw them go away.) Unlike the first version of this patch, we don't try to deref a NULLed |container_| in the middle of Close().
This also removes the "if (container_)" conditional in Close() because it cannot be called with a NULL |container_|, and opportunistically makes it private.
BUG=75021
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/6623075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change updates the app icons for chromium.
BUG=None
TEST=Ran on Mac and Linux. Verified that the app icon and the About dialog look ok. Windows build pending.
Review URL: http://codereview.chromium.org/6628068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=74894
TEST=browser_tests --gtest_filter=FormManagerTest.FillFormNonEmptyField
Review URL: http://codereview.chromium.org/6635028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
they depend on and which depends on them.TBR=avi
Review URL: http://codereview.chromium.org/6628071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[This is a re-landing of CL 6623059, which broke the
shared library build on windows in revision 77207.
An ifdef has been added to avoid the unresolved variable
when allocator_shim.cc is never even compiled]
Continue to support selection of a browser allocator
selection via the environment variable CHROME_ALLOCATOR,
and also add CHROME_ALLOCATOR_2 that can select the
allocator to use in subprocesses, such as a renderer.
Temporarilly set the browser default to the
default windows heap allocator, and the subprocess
allocator to TCMalloc to help detect memory corruption
in a cannary for a few days.
This may illuminate some flakiness in the tree, as
double frees (hidden by races) may cause crashes.
Add minor cleanup (removing reserved word "override"
etc.).
BUG=74901
TBR=mbelshe
Review URL: http://codereview.chromium.org/6623072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome sync is dependent on other areas of chrome, and patches committed to
these areas could potentially break sync. In the past, we have seen
sync integration test failures caused by patches to chrome/common/net.
This patch adds a PRESUBMIT.py file to this directory, that will cause the
sync integration tests to be run on any code that touches the directory as
part of their try runs.
BUG=70311
TEST=modify something under chrome/common/net and do a "git try" or "gcl try"
Review URL: http://codereview.chromium.org/6624087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
InfoBarContainer::RemoveInfoBar() instead of calling parent()->RemoveChildView() directly, so that the container knows the infobar is gone. (The container was trying to access deleted infobars because it never saw them go away.)
This also removes the "if (container_)" conditional in Close() because it cannot be called with a NULL |container_|, and opportunistically makes it private.
BUG=75021
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/6627069
TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/6624088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Go to NTP. The logo should be in the lower left corner. Also close some of
the sections. The should now be right aligned.
Review URL: http://codereview.chromium.org/6623062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
InfoBarContainer::RemoveInfoBar() instead of calling parent()->RemoveChildView() directly, so that the container knows the infobar is gone. (The container was trying to access deleted infobars because it never saw them go away.)
This also removes the "if (container_)" conditional in Close() because it cannot be called with a NULL |container_|, and opportunistically makes it private.
BUG=75021
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/6627069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
-Tests were failing due to the new country drop-down list field.
-The dictionary entry for ADDRESS_HOME_COUNTRY were no longer matching the country name within profiles due to casing mismatch.
BUG=74843
TEST=none
Review URL: http://codereview.chromium.org/6624084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Cleanup files in /home/chronos not just /home/chronos/user
BUG=
TEST=
Review URL: http://codereview.chromium.org/6625073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
observe-prefetch-without-actually-prefetching.
Also, drop prefetch probability to 0%.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6621044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=youtube, nba, amazon
Review URL: http://codereview.chromium.org/6625034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed GPU plugin.
Pepper 3D v2 does not use the GPU plugin. It is integrated with the accelerated compositor.
TEST=PPAPI 3D v2 still works, trybots
BUG=none
Review URL: http://codereview.chromium.org/6635026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50307
TEST=tab overview mode looks different
Review URL: http://codereview.chromium.org/6621056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
has loaded.
BUG=74088
TEST=see bug.
Review URL: http://codereview.chromium.org/6623061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6633002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The last param is for languages, which is already a std::string in
most places.
BUG=23581
Review URL: http://codereview.chromium.org/6627061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes it clear that it's not an override of WidgetGtk::Show
No intended functionality change.
BUG=70465,72205
TEST=none
Review URL: http://codereview.chromium.org/6635031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also eliminate stupid and unnecessary conversion of data to a big string, only
to be parsed back.
BUG=none
TEST=everything still works
Review URL: http://codereview.chromium.org/6635009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The current toast (re-activation) experiment suffers from the following problems:
1- False negative: the toast can be triggered even if chrome is being used
2- Nested message loop crash: If chrome tries to run while the toast is being shown, it crashes
This change addresses both conditions. Before running the toast we leverage the
process_singleton to detect another instance. If so we abort with "no thanks".
When showing the toast and its nested message loop we take the process_singleton lock which
inhibits dispatch of the wm_copydata message which spawns new tabs in the current process if
we try to span a new tab while in the nested message loop we crash.
BUG=32026
TES=see bug
Review URL: http://codereview.chromium.org/6625037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=74492
TEST=unit-tested
Review URL: http://codereview.chromium.org/6621004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6614023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
for a state that wasn't bad.
BUG=none
TEST=installation and uninstallation still work
Review URL: http://codereview.chromium.org/6625063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=nduca
Review URL: http://codereview.chromium.org/6625064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Continue to support selection of a browser allocator
selection via the environment variable CHROME_ALLOCATOR,
and also add CHROME_ALLOCATOR_2 that can select the
allocator to use in subprocesses, such as a renderer.
Temporarilly set the browser default to the
default windows heap allocator, and the subprocess
allocator to TCMalloc to help detect memory corruption
in a cannary for a few days.
Add minor cleanup (removing reserved word "override"
etc.).
r=mbelshe
bug=74901
Review URL: http://codereview.chromium.org/6623059
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/6623069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Continue to support selection of a browser allocator
selection via the environment variable CHROME_ALLOCATOR,
and also add CHROME_ALLOCATOR_2 that can select the
allocator to use in subprocesses, such as a renderer.
Temporarilly set the browser default to the
default windows heap allocator, and the subprocess
allocator to TCMalloc to help detect memory corruption
in a cannary for a few days.
Add minor cleanup (removing reserved word "override"
etc.).
r=mbelshe
bug=74901
Review URL: http://codereview.chromium.org/6623059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Mac/Linux we keep the socket open, so don't get an OnChannelConnected
message when a new Chromium launches and connects to the service, so we weren't
properly marking ourselves as having a client connected. When the service was
disable and Chromium exited, it meant we weren't properly exiting
immediately. This is only a partial fix for the bug.
BUG=74983
TEST=Start Chromium, enable the proxy, quit Chromium, start Chromium, disable the proxy, quit Chromium. With this fix the service process immediately exits.
Review URL: http://codereview.chromium.org/6635023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77206 0039d316-1c4b-4281-b951-d872f2087c98
|