| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
TBR=nick
Review URL: http://codereview.chromium.org/594017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38521 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=35141
TEST=Trigger an autocomplete popup; watch the renderer not crash.
Review URL: http://codereview.chromium.org/594015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
new index to syncable. Added new DB col to syncable. Renamed singleton tag to UNIQUE_CLIENT_TAG. Added syncapi layer support for unique client tags.
Hooked up wire protocol to use this index.
Downintegrate of sync.proto from trunk.
TEST=unit tests included
BUG=32636
Review URL: http://codereview.chromium.org/558015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38518 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
window.
BUG=34692
TEST=Open the content settings dialog to any page, hit "Exceptions", move the exceptions window and hit "Exceptions" again; we shouldn't spawn another window.
Review URL: http://codereview.chromium.org/596020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the SSLClientSocketNSSFactory function there.
Put the --use-nss-for-ssl command-line switch inside ifdefs
for the platforms that need it.
Call EnsureNSPRInit on the main thread so that PR_Cleanup
will be called on the main thread.
R=mark
BUG=28744
TEST=No build errors.
Review URL: http://codereview.chromium.org/573041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/34855
TEST=as in bug
Review URL: http://codereview.chromium.org/600021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=34396
TEST=SyncerTHreadWithSyncerTest.AuthInvalid
Review URL: http://codereview.chromium.org/596007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bug=chromiumos:1275
Test=There should be no "Create Application Shortcuts" menu item.
All others should be the same as Chrome, except that Print...
should be disabled. This is true for both the page menu and the
content area menu.
Review URL: http://codereview.chromium.org/596014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=10603
TEST=*_test.exe --gtest_filter=*Bookmark*
Also manually tested changing the URL through the bookmarks extension API, bookmark manager, bookmark bar and saw it update in all places and correctly sync to another chrome instance.
Review URL: http://codereview.chromium.org/582022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moved --invalidate-sync-login switch logic to profile_sync_service.
Removed unneeded command_line.h includes.
BUG=none
TEST=trybots, manual
Review URL: http://codereview.chromium.org/582017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add local storage getters to CookieTreeNode
* XIB: Embed cookie info labels into an NSView (inside the NSBox) and add
another for info NSView for local storage.
* Roll GTM r280:293
BUG=33068
TEST=Chromium-->Preferences-->Under the Hood-->Show cookies... Find and click on a local storage node. Info should be displayed.
Review URL: http://codereview.chromium.org/599003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
that lead to chrome not shutting down.
BUG=34941
TEST=bring up clear browsing data dialog, click on link, close
windows, make sure no chrome processes still around.
Review URL: http://codereview.chromium.org/594012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/588013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=35176
Review URL: http://codereview.chromium.org/601007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=23066
TEST=notify_demo.html
Review URL: http://codereview.chromium.org/548208
TBR=johnnyg@chromium.org
Review URL: http://codereview.chromium.org/600015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
parent_context.
This fixes a DCHECK which gets hit when a content script runs when javascript
has been disabled.
Review URL: http://codereview.chromium.org/595001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=33081
TEST=none
Review URL: http://codereview.chromium.org/594010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=30661
TEST=Green valgrind bots
Review URL: http://codereview.chromium.org/596016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=34971
TEST=run reliabilty tests
Review URL: http://codereview.chromium.org/588001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Moved RoundRectPainter to common place to be reusable in other login screens.
BUG=none
TEST=Tested login screen.
Review URL: http://codereview.chromium.org/587001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=35051
TEST=none
Review URL: http://codereview.chromium.org/596015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/584009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
any more
Review URL: http://codereview.chromium.org/593015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This CL makes it also translate frames and iframes.
BUG=34533
TEST=See bug for repro case.
Review URL: http://codereview.chromium.org/577032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
it will call LaunchUserExperiment with "true" for system_install instead of "false".
R=huanr
BUG=none
TEST=Run setup.exe --system-level-toast with official build system-level install, toast should appear.
Review URL: http://codereview.chromium.org/586005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
reversed if the children of the folder weren't committed in the same
batch as the folder.
Refactor ApplyUpdatesCommandTest, pulling out functionality that would
be useful for any SyncerCommand test, into syncer_command_test.h.
Add a test case for ProcessCommitResponseCommand using the new
SyncerCommandTest framework. Add a test for the bug.
BUG=33081
TEST=sync_unit_tests. Also, manual testing, using the reduced repro
instructions described in comment #26 of the bug.
Review URL: http://codereview.chromium.org/572021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28184
TEST=None
Review URL: http://codereview.chromium.org/587013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23066
TEST=notify_demo.html
Review URL: http://codereview.chromium.org/548208
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=brettw
TEST=you can possibly break the tree, right?
BUG=none
Review URL: http://codereview.chromium.org/602002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
in the tree, and earlier I only fixed one. This fixes the second one.
TBR=brettw
Review URL: http://codereview.chromium.org/602001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=If it compiles it is perfect.
Review URL: http://codereview.chromium.org/585008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/582015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
forced to figure out what's broken.
TBR=phajdan.jr
TEST=none
BUG=34997
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DirectoryWatcher was problematic. We couldn't get it right on Linux,
it can hit the disk on UI thread on Windows (Really Bad, tm). And
finally, the UserScriptMaster didn't work right with it.
TEST=Covered by unit_tests and browser_tests
BUG=8968, 6051, 6080, 20832
Review URL: http://codereview.chromium.org/586010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
pointers between trusted and untrusted processes. Move HWNDs and other Windows HANDLEs serialization to use 32 bits even on 64 bit platforms since that's all that's needed.
Review URL: http://codereview.chromium.org/565001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
used on the IO thread.
Review URL: http://codereview.chromium.org/600002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=34147
TEST=Fewer crash reports in RenderWidgetHost::ForwardInputEvent
Review URL: http://codereview.chromium.org/598005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This behavior was disabled by debugging code introduced in r38379
BUG=none
TEST=delete browsing data on windows. The dialog should close eventually.
R=sky
Review URL: http://codereview.chromium.org/595003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18119
TEST=open cert info, look at details
Review URL: http://codereview.chromium.org/596005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=34912
TEST=Open Content Settings dialog in Windows Classic theme and make sure there's a Flash Player link at the bottom.
Review URL: http://codereview.chromium.org/598001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=35068
TEST=Open content settings dialog, select a different tab, close and reopen it, the same tab should be selected.
Review URL: http://codereview.chromium.org/596003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
using the CurrentContext, not the EnteredContext so that it grabs the right
object based on the frame being called.
The security of this object is not in question - access to the window itself
is already protected from XSS access.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/593003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Minor fix for api page generator to allow "experiment.*" modules to be documented
TBR=kathyw,aa
Review URL: http://codereview.chromium.org/587016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=29457,31767
TEST=self-testing
Review URL: http://codereview.chromium.org/580019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
hideSuggestionsPopup.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/586011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=34633
TEST=none
Review URL: http://codereview.chromium.org/589005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
also, always show cut/copy/paste for bookmark menus (see bug 32064)
also, don't add "Show in folder" on menus that aren't going to enable it anyway
BUG=32830
TEST=manual
Review URL: http://codereview.chromium.org/580018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also added tests for the ExtensionToolbarModel.
BUG=33401
TEST=ExtensionToolbarModelTest (new test).
Review URL: http://codereview.chromium.org/587002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I've added minimal probing to check if IPv6 is at all possible, and when it is not, then we disable IPv6 resolution.
I've also added histograms and A/B test support to evaluate the impact of
this change.
(I landed originally, but had tree problems, and this is a new CL to tryto reland).
Note that I've switched back to MACRO style enums as well, per http://dev.chromium.org/developers/coding-style
(search for "enum").
This version now does the conditional testing at a higher level (in io_thread.h), so that it should interfere less with other testing.
r=wtc,eroman
Review URL: http://codereview.chromium.org/585005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38402 0039d316-1c4b-4281-b951-d872f2087c98
|