| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
opened within one window when teh "Options" button is pressed on the extensions settings page.
BUG=none
TEST=Install an extension that specifies an options_page in it's manifest file. Open the extensions page (wrench menu) and click the "Options" button for that extension. The options page will open and come to the forefront. Go back to the extensions tab and click "Options" again. The same tab as before should be brought to the forefront.
Review URL: http://codereview.chromium.org/366026
Patch from Akira <akira@yayakoshi.net>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This implements about:memory on Mac. It calls /bin/ps to obtain information
about processes (this is Apple's officially supported "API"). Unfortunately, ps
provides fairly minimal information (rss and vsize); top is better, but not a
stable API -- it has changed greatly between Mac OS 10.5 and 10.6, and moreover
the 10.6 version is more limited in its output formatting.
BUG=9653
TEST=Go to about:memory under a variety of conditions (with a variety of browsers loaded).
Review URL: http://codereview.chromium.org/333008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=26749
Review URL: http://codereview.chromium.org/360043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With "On startup"/"Restore the pages that were open last" set (in Preferences), a window which was explicitly closed (using the red button, Cmd-Shift-W, the menu item -- but not due to quit) should not be restored on startup. This is the behaviour of Firefox and Camino (Safari doesn't appear to implement this feature).
Note about this patch: Depending on how we decide things will work for App mode, much more code could be disabled on Mac.
BUG=13341
TEST=Set the browser to restore pages on start (see above). Navigate somewhere interesting; close window; quit; restart; should open a browser with default window (NTP or homepage or whatever). Navigate somewhere; quit; restart; should open previously opened stuff. Make sure that session restore (also crash recovery) still work as expected.
Review URL: http://codereview.chromium.org/362016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=rafaelw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added a --enable-shared-workers flag, and return false from SharedWorkerRepository::isAvailable() if it is not set.
BUG=26233
TEST=None (unit tests do not run yet)
Review URL: http://codereview.chromium.org/372004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
in the bookmark manager.
BUG=26779
Review URL: http://codereview.chromium.org/360064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is exactly what you reviewed before, Erik. I plan to update the screenshots next week.
BUG=none
TEST=none
TBR=erikkay
Review URL: http://codereview.chromium.org/376001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
extension (disable/enable...).
BUG=26163
TEST=Click on Disable/Reload links and check if the whole page got reloaded.
Review URL: http://codereview.chromium.org/341076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Nib file changes:
- Connected DownloadShelfView's delegate_ to DownloadShelfController.
BUG=http://crbug.com/25602
TEST=Download shelf should animate open/closed.
Review URL: http://codereview.chromium.org/342083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=26299
Review URL: http://codereview.chromium.org/363022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactored WebWorkerImpl into WebWorkerBase to enable code sharing with
WebSharedWorkerImpl.
Changed how SharedWorkers are instantiated (now routed through WebFrameClient
just like DedicatedWorkers, because WebFrameClient is the only one who knows
how to send messages to RenderViewHost.
BUG=26233
TEST=none (will enable layout tests when basic functionality available)
Review URL: http://codereview.chromium.org/362020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/369006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a tool item is added but there is no room for it, it doesn't get an allocation right away, so our check to see if it fit was failing. This would be fixed the next time there was an allocate event (e.g. due to a resize).
I noticed while debugging this that SetChevronState is getting called like 10 times in a row when you type in a url and press enter. This is in repsonse to allocate signals. I don't know why there are so many allocate signals, but it warrants further investigation.
BUG=26736
Review URL: http://codereview.chromium.org/372002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
this for tabs, just not windows.
BUG=21316
TEST=see bug
Review URL: http://codereview.chromium.org/360060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Use a test-specific subclass to isolate the stopgap use of 'ps'
to collect memory stats on Mac.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/342070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
recording is enabled, it sets the client id for crash reporting.
- On Windows this id gets stored in the registry so that we can read it pretty early regardless of the process type. If the id has not been generated (like in the case of first run) we initialize with empty string but the real id gets inserted once metrics service gets initialized.
- On Linux we were creating a hash and storing it in 'Consent to Send Stats'. This change replaces that hash with the metrics id. Unlike before calling SetConsentToSendStats doesn't generate a new id, if an id already exists.
- On Mac there was no id set. Now we use metrics id as guid for the browser process. For other process types a change is still required to pass that id as command line param to renderers/plugins (like Linux).
BUG=23658
TEST=Cause a deliberate crash in Chrome renderer/browser/plugin and make sure the clientID reported to the crash server is the right GUID.
Review URL: http://codereview.chromium.org/346007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/343078 ), r=me.
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
UI for disabled extensions.
Also, desaturate the icons of disabled extensions to make them
look more disabledy.
BUG=25963
TEST=On the extensions page, disable an extension, then press
reload. You should see a greyscale version of the icon.
Review URL: http://codereview.chromium.org/360039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=akalin
Review URL: http://codereview.chromium.org/360047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pool isn't created while the app is handling an event sent via -[NSApp sendEvent].
Branches browser/chrome_application_mac into browser/chrome_browser_application and base/chrome_application. Renderers will run as chrome_applications, and browsers will run as chrome_browser_applications.
BUG=26418, 25462, 25463, 25465
TEST=1) See bug 25857. 2) Start up. Open 3+ windows. 3)Quit. See bugs for other repro cases.
Review URL: http://codereview.chromium.org/345051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=26069
TEST=With no bookmarks showing in the bar (The text "For quick access, place your bookkmarks here in the bookmarks bar." should be showing.) right-click on the "For quick access..." text. A contextual menu should appear and operate as when right-clicking on the bookmarks bar when the text is not being shown.
Review URL: http://codereview.chromium.org/362021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Patch contributed by thiago.farina@gmail.com
Review: http://codereview.chromium.org/343079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
toolsrip.
BUG=none
TEST=Manual testing on linux and windows.
Review URL: http://codereview.chromium.org/353025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(and also the icon for the default plugin window).
MSVS's resource compiler can only compile resources of the same
type from a single .rc file, so we can't have ICON types scattered
across rc files. This change moves all the icon files out of
theme_resources.rc and puts them in chrome_dll.rc. This worked
in the past because these were different dlls.
This has the side benefit of not including the ico files in
the linux/mac builds.
BUG=26600
Review URL: http://codereview.chromium.org/361031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
patch in (http://codereview.chromium.org/345051) without adding shess's patch
(http://codereview.chromium.org/362013). I'm not sure how to repro otherwise.
Either way, I think this is actually what's intended to happen. Certainly better
than what is there now.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/355045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a bug where all drop down menus were blank (we never
told the renderer our size).
This was regressed in r31031 when I removed the size allocate
handler.
BUG=26759
Review URL: http://codereview.chromium.org/361034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=12126
TEST=put a window.prompt() in a background page, a browser action, and a page action.
Make sure it gets the result back correctly. Also make sure it still works when
called from a web page.
Review URL: http://codereview.chromium.org/341089
TBR=pam@chromium.org
Review URL: http://codereview.chromium.org/360063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
event_sys_unittests.cc
BUG=21833
Review URL: http://codereview.chromium.org/360040
TBR=idana@chromium.org
Review URL: http://codereview.chromium.org/361035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
it's initted.
Also add sanity checking like in the Windows version.
BUG=20511
TEST=none
Review URL: http://codereview.chromium.org/361020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is in anticipation of support for re-rendering the page on extension install/uninstall without reloading.
TEST=none
BUG=26163
Review URL: http://codereview.chromium.org/361027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
popups. The bug stemmed from browser initializing the enabled state of
IDC_RESTORE_TAB to false for popups, but CanRestoreTab returns true
for popups. There is no need to diable restoring tabs for popups as we
don't always restore to the current window, or we may end up restoring
a closed window.
BUG=13774
TEST=see bug
Review URL: http://codereview.chromium.org/369005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
on the NTP.
BUG= 22820
TEST= remove thumbnails. notice that "undo" butterbar doesn't overlap anything or elide text uncomfortably.
Review URL: http://codereview.chromium.org/361017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=12126
TEST=put a window.prompt() in a background page, a browser action, and a page action.
Make sure it gets the result back correctly. Also make sure it still works when
called from a web page.
Review URL: http://codereview.chromium.org/341089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=21833
Review URL: http://codereview.chromium.org/360040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/356003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make tweak_info_plist less chatty. We've been using this script for a long
time, we've worked the kinks out, and it's really stable. We don't need this
kind of crazy verbosity any longer.
BUG=-1
TEST=slightly less build output
Review URL: http://codereview.chromium.org/361028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TODO: Remove this in a couple of weeks.
BUG=0
TEST={}
Review URL: http://codereview.chromium.org/360055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
that were open last'.
BUG=21195
TEST=none
Review URL: http://codereview.chromium.org/366017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
tabs. This is necesitated by the fact that when closing a tab we don't grab the most recent content state, leaving session restore with slightly stale data. To really fix this requires sending a message on tab close and waiting for it, but that induces tab close jank, something we're not going to do.
BUG=17220
TEST=none
Review URL: http://codereview.chromium.org/342100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactored WebWorkerClientProxy into two classes - WebWorkerDispatcher which dispatches incoming IPCs for the worker, and WebWorkerClientProxy, which handles outgoing API calls from WebWorkerImpl. This allows WebWorkerClientProxy to be reused by WebSharedWorkerDispatcher.
BUG=26233
TEST=none (will enable layout tests when basic functionality available)
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31077
Review URL: http://codereview.chromium.org/351004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add plumbing to allow multiple Sandbox profiles on OS X.
* Separate sandbox_init_wrapper into platform specific files.
* Sandbox Worker process & add plumbing to Sandbox utility process when we bring that up.
* Remove mention of stale bugs in utility process on Mac.
BUG=23582
TEST=Worker process should work.
Review URL: http://codereview.chromium.org/341033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=20969
TEST=none
Review URL: http://codereview.chromium.org/348056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/360007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=|'localStorage' in window| should only be true iff --enable-local-storage is specified
Review URL: http://codereview.chromium.org/335034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
hack for making them work in test shell and single process mode.
This replaces http://codereview.chromium.org/335034/show
TEST=none
BUG=24581
Review URL: http://codereview.chromium.org/363014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit 31077.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31080 0039d316-1c4b-4281-b951-d872f2087c98
|