| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
attention to the format of the file.
TBR=rahulk
BUG=none
TEST=covered by buildbots
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
breakpad is back in.
BUG=none
TEST=none (covered by buildbots)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
(It's controlled by an environment variable.)
BUG=1296800
TEST=covered by buildbots
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The official builder will need the CHROMIUM_BUILD environment variable set to "_google_chrome".
Same as Rietveld issue 2943, approved by nsylvain and rahulk, but in the writeable repository rather than the read-only one.
BUG=1296800
TEST=covered by buildbots
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
since it will be shared with WebCore and Gears in the
future.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=sky
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
GetProcAddress() call.
TBR=nsylvain
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BU=1296800
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
do not ever get to see this file and it will make the signing of executables process more complex.
BUG=1179486
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to a char*. The string could contain null bytes, which led to data
loss and failures in safebrowsing.
R=wtc
BUG=1352561
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
popup windwos:
- Pull out the favicon
- Manually check the current locale; if it's an english one then
display the string "Popup Blocked", otherwise use just the
popup's title (without the product name suffixed to it).
BUG=1085485
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
for the memory tests.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
upgraded SQLite.
Removing now because WebCore will soon need sqlite in
the include path and this file will then conflict with
std::limits.
See also:
http://www.sqlite.org/cvstrac/chngview?cn=4091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
current UI language is not the same as the installation language.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
support for distribution
specific dependencies in depedency checker.
BUG=1296800
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
- Adds --log-level=n with n=0,1,2,3
- Increases the default logging level from INFO to WARNING there is way too much noise there.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
title. I'm going to use this in the omnibox. There are a couple of
other random spelling errors I came across that are included for your
review pleasure.
BUG=1256202
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
couple of fields that I felt were redundant. I'm pretty sure I got the
same logic, but you better stare at this to convince yourself.
BUG=1256202
TEST=covered by unit tests
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=mal
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
across this in investigating another problem.
BUG=1307747
TEST=Create > 3 tabs. In the last one open the html file attached to
1305707. Click on the button. Rapidly drag the first tab in and
out of the tab strip and make sure none of the remaining tabs get the wrong title.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=sgjesse
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
change in V8 where the implicit breaks currently issued when receiving
a command while running will be removed. To get in contact with the
V8 debugging interface and send messages V8 needs to be in the break
state. Getting V8 into the break state will be the responsebility of the
debugger using the V8 debugging interface.
Changed the messages between the renderer and the debugger. There are now
explicit messages for break and detach. Alse renamed the SendToDebugger
message to DebugCommand. There is now messages DebugAttach, DebugBreak,
DebugCommand and DebugDetach. The message DebugBreak has a force flag
to indicate whether the renderer should issue some JavaScript to help
the break along or whether it should just schedule a break to happen
whenever JavaScript executes.
Removed the artificial attach JSON response send by the renderer and
replaced that with an on debug attach call to the debugger shell. This
call is reouted to the on_attach function in the debugger JavScript code.
Changed the debugger to issue break requests whenever a suitable command,
e.g. setting a break point, is issued. In this case a flag is used to
track whether execution should be automatically resumed after the command
have been send to the V8 debugger interface. Changed the handling of the
plain break event to not force a break by executing additional JavaScript.
Thereby a plain break does not break JavaScript execution until code on
the tab beeing debugged is actually executed.
Set the command name explicitly on all commands.
Removed parseSimpleCommand as it was just used for the the continue command
for which an explicit parseContinueCommand has been added.
Removed the last_command field from DebugShell as it was not used.
Updated the debugger protocol test to reflect the removed attach event.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
resource and .h files from their .grd files.
TBR: rahulk
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
and for real.
TBR: brettw
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1521 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
use this for the non-secure case, which simplifies things since we shouldn't need to worry about threading anymore.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
automated tests. If the window is closed while a removal is in
progress the BrowsingDataRemover would be left with a reference to a
deleted object. This can only happen during automated testing as
while clearing is in progress we don't allow the user to close the
dialog.
BUG=1138705
TEST=covered by automated test bot
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
ASSERT that we got it (which ends the test on NULL pointers). Otherwise we continue on and crash when we try to use these pointers, such as when passing it into GetBrowserForWindow.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NavigationController create and commit the new NavigationEntries (currently WebContents does a bunch of the details of this which is hard to understand and not easily testable).
This tries to consolidate the logic that I want to move to the NavigationController without actually moving it there yet. I removed all of the "PreCommit" functions in WebContents, since when the NavigationController does
all of the committing, there won't be a phase where the NavigationEntry exists but isn't committed.
Most of the logic could be moved to the PostCommit functions without any problem, which is an indication that the current design was busted anyway. I had to precompute some data and pass it to the *PostCommit function to work around some of the components that required old data. I had to change InfoBars around since it relied on having both the committed and uncommitted entries, but I think the new design is much better anyway.
BUG=1343593,1343146
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=1296800
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Major changes:
OneShotTimer and RepeatingTimer become template classes that no longer require
a Task or a Timer object. They just use PostDelayedTask. Under the hood that
still uses a Timer object.
The API is much simpler for consumers as they now no longer need to worry about
allocating a Task or managing the lifetime of the object pointer held by the
Task.
I added some new unit tests to timer_unittest.cc to cover the API.
I preserved the old TimerManager / Timer API for now, but I plan to soon kill
it.
R=brettw
BUG=1346553
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
it's worth a shot.
BUG=1345092
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
to get the Browser window, which internally uses ::GetForegroundWindow(). This means that when other application windows are on top we fail to get the Browser window. By switching to GetLastActiveWindow() we avoid that.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
window rect. The usage of GetWindowRect in the ChromeClientImpl::windowRect() function is erroneous, and my modification of GetWindowRect to return the HWND's root ancestor rect broke drop down combo boxes and other embeded controls.
So instead, add a GetRootWindowRect which gets the root anncestor of the HWND's rect and use it in ChromeClientImpl::windowRect().
BUG=1344367,1186573,1334505
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
"is_loading_", which represents state on the main frame, and thus should only be updated to reflect changes to that frame (as ProgressTracker is careful to do by testing "m_originatingProgressFrame"). It's also redundant because it is already triggered through the ProgressTracker, even when there is a ProvisionalLoad error.
This fixes issues where the favicon for a page was not being loaded because of errors in subframes.
BUG=1186854
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The just adds "Model" and "View" to the end of the current classname, leaves everything in the same files, and doesn't really change or remove any functionality, creation order, ownership semantics, etc. In other words, it's basically just moving some code around to get things split into two classes, and the harder work comes later.
Also removes/trims some overly long comments, fixes a couple comment errors I noticed, and trims one or two bits of logic to be shorter.
What really needs review the most is the high-level decisions about how to split data and functionality between the two classes.
BUG=1343512
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This fixes that.
TBR=sky
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and close a tab. Test is disabled until we fix the bug.
Also made the error message for when tests fails because crash_service isn't running a bit explicit (unrelated to the rest of this change).
BUG=1343052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
navigating to a new TabContents.
BUG=1349274
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=1296800
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
got a sub for some prefixes.
BUG=1315628
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
service is available.
Add utf8 output flag to Naver (#1 engine in Korea) so that JSON comes back in UTF-8.
meta.ua (Ukraine search engine) was changed similarly.
Change the url for Yahoo_sg to sg.yahoo.com (from tw.yahoo.com) and that for Yahoo_nz to nz.yahoo.com (from sg.yahoo.com)
Disable the suggestion service for Daum because it returns the result in EUC-KR and currently we assume it's in UTF-8 (issue 1293145).
Also disable Yahoo_xx's that do not offer suggestion/ac services. We can do some mappings (e.g. at, ch => de, qc => ca or fr, hk => tw or en and nl,no,dk, fi => en, the rational for the last being that English proficiency of general public in those countries is rather good.), but disable it for now.
BUG=1342120
TEST=Install various language versions of Chrome and set the default search engines to a regional Yahoo variant and see if suggest works in the omnibar.
Install Korean Chrome and set the default search engine to Naver and see if suggesst works.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=1296800
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1474 0039d316-1c4b-4281-b951-d872f2087c98
|