| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
This also makes changes to MenuController to support NIB-based initialization.
Screen shots: http://cl.ly/1cyU (en) and http://cl.ly/1cyE (ru).
BUG=47848
TEST=Click on Wrench menu and see buttons. Buttons perform their function.
Review URL: http://codereview.chromium.org/2923009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Only disable those homepage-related gui controls, that are explicitly overridden by policies.
This is a different solution than the expected behavior described in the bug below. The main point is that it avoids the ambiguous state, when the user has HomepageIsNewTabPage=true selected, and the policies only specify the HomepageLocation URL.
BUG=46486
TEST=manual
Review URL: http://codereview.chromium.org/2843022
Patch from Gabor Feher <gfeher@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update network_library to use libcros to fetch wifi access point list, and update the geolocation code to use this for wifi scanning.
Depends on changes codereview.chromium.org/2927007 and codereview.chromium.org/2958008 (will be landed after them both)
BUG=45671
TEST=Open maps.google.com/maps/m on netbook with wifi enabled, it should go to your location with a few hundred
Review URL: http://codereview.chromium.org/2905008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=manually
TBR=tyoshino
Review URL: http://codereview.chromium.org/3010002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45230
TEST=Canned*.Unique
Review URL: http://codereview.chromium.org/2854045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
known_crashes.txt
BUG=49142
TEST=none
Review URL: http://codereview.chromium.org/3014003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Not integrated into OOBE yet.
BUG= http://crosbug.com/3653
TEST=none
Review URL: http://codereview.chromium.org/2946008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=48470
TEST=Configure policy, check advanced page of preferences dialog.
Review URL: http://codereview.chromium.org/2908007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
r52288 accidentally nuked the --disable-sync command line flag, make it work
again.
BUG=none
TEST=Starting with --disable-sync should actually disable sync
Review URL: http://codereview.chromium.org/2943016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a layouting problem that resulted in the "Stop syncing this account"
button not being sized properly after setting up sync.
BUG=48807
TEST=Open options dialog in non-synced state, configure sync, check "Stop syncing this account" button after setup.
Review URL: http://codereview.chromium.org/2980005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For Pinyin, use "拼".
For Chewing, use "酷".
For Cangjie, use "倉".
For now, we use "TW" for Quick since we're not sure which Hanzi is good for the input method.
BUG=chromium-os:4696
TEST=manually checked.
Review URL: http://codereview.chromium.org/2832054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=47843,47863
TEST=unittests, valgrind
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51215
Review URL: http://codereview.chromium.org/2872024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44202
TEST=none
Review URL: http://codereview.chromium.org/2827049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=48655
TEST=interactive_ui_tests.exe --gtest_filter=AccessibilityWinBrowserTest.*
Review URL: http://codereview.chromium.org/2955008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=48988
TEST=tested manually with a gmail account with a canonical name including capital letters
Review URL: http://codereview.chromium.org/2805080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=38475
TEST=None (Nothing to test yet.)
Review URL: http://codereview.chromium.org/2873044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
"ZH".
BUG=chromium-os:4696
TEST=checked manually
Review URL: http://codereview.chromium.org/2979008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
after the new 2-0 dictionary becomes live.
BUG=47891,47007
TEST=SpellCheckTest.SpellCheckText
Review URL: http://codereview.chromium.org/2824042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=4456
TEST=Change the UI languge to Japanese and log out. At the lower-left corner
of the login screen, there's no more sequence of 'black question marks'.
Review URL: http://codereview.chromium.org/2864033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45612
TEST=new unit tests
Review URL: http://codereview.chromium.org/2966011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
When launching an application on the text size larger than 120 DPI, Windows runs the application on the DPI-virtualization mode to hide the text size from it. Unfortunately, this virtualization mode causes some problems when using a custom frame, such as we cannot click system buttons. To fix this issue, this change disables the DPI-virtualization mode on Vista or later.
BUG=1715,36939
TEST=Run chrome.exe on the screen resolution higher than 120 DPI.
Review URL: http://codereview.chromium.org/2867031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Omnibox recently got taller on Mac, which screwed up the centering.
Visually inspect and re-center.
BUG=49101
TEST=https://www.thawte.com/, lock should be centered vertically.
Review URL: http://codereview.chromium.org/2856037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
My http://codereview.chromium.org/2998004 refactored calculation of
the page-action info-bubble position, but didn't fully factor in a
coordinate-system change.
BUG=none
TEST=Page-action info-bubble position at bottom, not top.
Review URL: http://codereview.chromium.org/2980014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
network.
* Added OfflineResourceHandler that intercept the request and show interstitial page.
* Added OfflineLoadPage that is shown when offline.
This gets deleted when
- User pressed "Load now" btton to proceed or
- User pressed "Cancel" button to cancel loading
- Network become available.
The page first appears as blank page (a little darker than white for now. I'll update when mock is ready),
and then options become available after 3 seconds maximum.
* Added unit test for OfflineLoadPage class.
* OfflineLoadService class to control when/if a load request
should proceed regardless of network status.
The current implementation is tentative and will proceed
if if loading was requested in a given tab.
I'll revisit this class to improve the logic in separate CL
later.
Known Issue:
- thumbnail is not working yet. I'll working on this in separate Cl.
- a tab shows URL instead of title string. I'll fix this in separate CL.
- InitNavigationParams in offline_load_page_unittest is copied from safe_browsing_blocking_page_unittest. I'll move this to common place in separate CL. (hopefully before checking this in)
BUG=chromium-os:3605
TEST=unit test: offline_load_page_unittest
manual: disable wifi and ethernet, then login.
chrome will show the offline page when tab is activated. Enable network (wifi or ethernet) and all tab will start loading again.
Review URL: http://codereview.chromium.org/2931005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49123
TEST=Start autocompleting something, check that things line up.
Review URL: http://codereview.chromium.org/2968012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Erik ran into a problem related to this while working on some changes to
permissions handling for event listening.
BUG=none
TEST=Context Menus API onclick callbacks should work normally.
Review URL: http://codereview.chromium.org/2963012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
label from the strings that can be displayed. The old approach
resulted in too small a width and clipping.
BUG=chromium-os:4406
TEST=see bug
Review URL: http://codereview.chromium.org/2993005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor to convert star decoration to LocationBarDecoration.
BUG=none
TEST=Star icon continues to work.
TEST=Bookmark bubble pops in the right place.
Review URL: http://codereview.chromium.org/2971004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49120
TEST=manually tested
Review URL: http://codereview.chromium.org/2950009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CID=9159
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2924014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
before null check.
CID=9433
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2943012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2893017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=estade
TEST=compile, please...
BUG=42892
Review URL: http://codereview.chromium.org/2917015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Flaky on linux/views as well as chromeos.
BUG=48920
TEST=tree stays marginally greener
TBR=dmazzoni
Review URL: http://codereview.chromium.org/3000003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=42892
Review URL: http://codereview.chromium.org/2847050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=Tested by gmerge chromeos-chrome onto device and checking
about histograms.
Review URL: http://codereview.chromium.org/2899014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
GpuBackingStore{GLX,Win}::OnPaintToBackingStore
CID=8190,9146
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2997002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2986006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This may have lead to some bad stats in Sync.UserPerceivedAuthorizationTime histogram.
CID=11400
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2976003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2909005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=38334,48921
TEST="mini_installer --chrome-sxs", check about box, about:version, start menu shortcut name
Review URL: http://codereview.chromium.org/2931018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- The local state and the overall size of the profile dir
BUG=42561
Review URL: http://codereview.chromium.org/2934019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CID=10885
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2942009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To make recycle work, we had to define the usage scope of current frame. otherwise we are introducing tearing because we will begin to decode into the buffer before it is done by the renderer/painter/compositor.
current mechanism depends on hold reference of a copied picture. we had no that luxury if we do not copy output buffers. we had to compromise by
1. in pause() ( which is not the sense of pipeline->pause(), which is implemented by set playrate = 0 ) in filter->pause() ( or in the future flush() ), which is part of seeking ( and in the future, part of stop() too) , we had to return all the buffers to owner. we had no current buffer to display. we use NULL as current frame in this case.
2. remove black frame from render base, this is only valid for system memory based video frame, even that should we use color fill instead of color conversion and scale.
3. pause and stop has to wait for pending read (actually flush) and pending paint.
4. we only advance frame when there are two or more frames in ready queue.
Review URL: http://codereview.chromium.org/2836038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Drive by download for foo.bash gets a dangerous download prompt.
Review URL: http://codereview.chromium.org/2906008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Acquire a lock on the syncer thread vault before setting listener expectations so it is not possilbe to get a notification while setting expectations.
BUG=39070
Review URL: http://codereview.chromium.org/2991003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
consolidation of pinned and nano tabs tracked in issue 49013.
TEST=none
BUG=45539,49013
Review URL: http://codereview.chromium.org/2952004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=yes
BUG=39370
Review URL: http://codereview.chromium.org/2975012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52392 0039d316-1c4b-4281-b951-d872f2087c98
|