summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Move the ffmpeg loading function into media library.ajwong@chromium.org2009-04-182-60/+6
| | | | | | | | This will allow us to hide the platform specific library loading code from the main chrome code. Review URL: http://codereview.chromium.org/69027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13991 0039d316-1c4b-4281-b951-d872f2087c98
* Several minor changes to API framework.aa@chromium.org2009-04-187-86/+148
| | | | | | | | | | - Implement 'choices' JSON schema feature - Made 'additionalProperties' false by default - Made all API requests flow through one native function Review URL: http://codereview.chromium.org/77020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13988 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor DataSourceImpl to get rid of using ReleaseRendererResource for cleanuphclam@chromium.org2009-04-176-165/+128
| | | | | | | | | | | | | The previous model of waiting in Stop() was extremely bad, it created a lot of deadlocks and made cleanup harder. What should be the correct way of doing cleanup is that DataSourceImpl should signal it has stopped so no more activity in other threads, post a task on render thread to do final cleanup on that thread, if render thread is dying then it's simply leaked and don't care. This refactoring helped cleanup some ugly pattern in cleaning up. Review URL: http://codereview.chromium.org/77008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13984 0039d316-1c4b-4281-b951-d872f2087c98
* Create a test program for generating false positive statisticspaulg@google.com2009-04-174-0/+288
| | | | | | | | | | | | | | for SafeBrowsing data. The program reads a regular SafeBrowsing database and creates bloom filters of various sizes, comparing the hit and miss statistics against a list of URLs. BUG=10584 (http://crbug.com/10584) Review URL: http://codereview.chromium.org/67245 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13981 0039d316-1c4b-4281-b951-d872f2087c98
* In system level install case go back to copying files instead of moving them.kuchhal@chromium.org2009-04-171-10/+25
| | | | | | | | | BUG=10656 Review URL: http://codereview.chromium.org/79060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13979 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a couple of style issues.michaeln@google.com2009-04-172-3/+3
| | | | | | | TBR=darin Review URL: http://codereview.chromium.org/67259 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13978 0039d316-1c4b-4281-b951-d872f2087c98
* A subset of the bookmarks API- missing events- missing unit tests- missing ↵erikkay@google.com2009-04-1712-122/+903
| | | | | | | | ability to change URL Review URL: http://codereview.chromium.org/77003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13977 0039d316-1c4b-4281-b951-d872f2087c98
* Due to some crashes in teardown, change NotificationObserversmbelshe@google.com2009-04-176-39/+44
| | | | | | | | | | for TAB_CONTENTS_DESTROYED to use the NotificationRegistrar to ensure proper cleanup. Review URL: http://codereview.chromium.org/79051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13970 0039d316-1c4b-4281-b951-d872f2087c98
* Initial implementation of the FindBar on Mac.rohitrao@chromium.org2009-04-1717-42/+1047
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13969 0039d316-1c4b-4281-b951-d872f2087c98
* Move the implementation of AutocompletePopupView from AutocompletePopupWin ↵ben@chromium.org2009-04-177-165/+162
| | | | | | | | to AutocompletePopupContentsView, a more central location. Review URL: http://codereview.chromium.org/77012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13967 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a hack that's no longer needed.pinkerton@chromium.org2009-04-171-7/+0
| | | | | | Review URL: http://codereview.chromium.org/79050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13963 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a comment stating what needs to be recompiled in orderfor changes to ↵finnur@chromium.org2009-04-175-0/+41
| | | | | | | | | | take effect. Also added a copyright message,while I was at it.Eventually, we want to fix the dependencies, but since multiple people are tripping over this, I think this is a good short term measure. Review URL: http://codereview.chromium.org/69045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13962 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind reports memory leak in unit test. This is true since we had ↵brg@chromium.com2009-04-171-26/+38
| | | | | | | | re-used the XmlReader object for each test. This CL changes this to use a new XmlReader object per test. Review URL: http://codereview.chromium.org/79049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13961 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes saving files that don't have valid extensions.avi@chromium.org2009-04-174-4/+16
| | | | | | | | | | | | Two fixes here. First was a disturbing discovery that FilePath::Extension returns an extension starting with a period. I am of the belief that this is the wrong API to expose, but that's a different fight. Fixed. Second is a subtle behavior of the old code that wasn't preserved. In the case where the extension did not exist in the registry, the old code dropped the extension from the filter. We now also do so. BUG=10561 Review URL: http://codereview.chromium.org/79045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13960 0039d316-1c4b-4281-b951-d872f2087c98
* Implement a unit test for the toolbar controller. Plumb the profile into the ↵pinkerton@chromium.org2009-04-177-19/+144
| | | | | | | | loation bar instead of picking it up globally, which cannnot be unit tested. Review URL: http://codereview.chromium.org/79041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13959 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce the false positive rate for SafeBrowsing gethash requests.paulg@google.com2009-04-174-4/+27
| | | | | | | | | | | | | | | | | | | | | | | | This CL increases the memory consumption of the bloom filter used by the SafeBrowsing system in order to decrease the number of false positive gethash requests (gethash requests that result in an empty or 204 response from the servers). The filter size in bytes is calculated as: number_of_add_prefixes * bits_per_prefix / 8 From analysis of our histograms, users have between 250k - 330k add prefixes. 'bits_per_prefix' is hard coded to 25, which means that we expect the typical bloom filter to be between 760-1000 kB, compared to the current value of approximately 450 kB. We add histograms to track the filter size, as well as the number of gethash requests that return empty results and non-empty results. BUG=10584 (http://crbug.com/10584) Review URL: http://codereview.chromium.org/67243 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13958 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for startup_tests to tools/valgrind/chrome_tests.pydkegel@google.com2009-04-171-5/+14
| | | | | | | | Also fix a typo and an 80 col nit in its list of tests. Review URL: http://codereview.chromium.org/79043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13957 0039d316-1c4b-4281-b951-d872f2087c98
* Fix break due to disabling Toolbar5Importer test.scherkus@chromium.org2009-04-171-1/+1
| | | | | | Review URL: http://codereview.chromium.org/69044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13956 0039d316-1c4b-4281-b951-d872f2087c98
* Disabled Toolbar5ImporterTest.BookmarkParse due to failing valgrind/purify ↵scherkus@chromium.org2009-04-171-1/+3
| | | | | | | | | | tests. BUG=10679 Review URL: http://codereview.chromium.org/79048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13955 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the move/size/maximize entries on the system menu in fullscreen ↵pkasting@chromium.org2009-04-171-15/+23
| | | | | | | | | mode. Ignore those commands if we do receive them. BUG=8024 Review URL: http://codereview.chromium.org/79039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13954 0039d316-1c4b-4281-b951-d872f2087c98
* Rename AllowCrossOriginAccessHack to GrantUniversalAccess, and move the HACKmpcomplete@google.com2009-04-171-1/+5
| | | | | | | warnings to the callsite. Review URL: http://codereview.chromium.org/79028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13953 0039d316-1c4b-4281-b951-d872f2087c98
* Add a script to make necessary zip files for chromebothuanr@chromium.org2009-04-171-0/+61
| | | | | | | | | | | | runs. I did not extend make_zip.sh because we may add more options to make_chromebot_zip.sh and I want to keep make_zip.sh simple. For now this script only pack standard things. We could add options to pack extensions later. Review URL: http://codereview.chromium.org/78003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13952 0039d316-1c4b-4281-b951-d872f2087c98
* Port page_cycler_http to Macnirnimesh@chromium.org2009-04-171-3/+10
| | | | | | | Accompanying buildbot changes @ http://codereview.chromium.org/67234 Review URL: http://codereview.chromium.org/79017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13950 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing <string> include for release build.finnur@chromium.org2009-04-171-0/+2
| | | | | | | | TBR=jcampan Review URL: http://codereview.chromium.org/67255 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13947 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 10573: Dismissing Find-in page doesn't set focusfinnur@chromium.org2009-04-175-63/+189
| | | | | | | | | | | | | | | | | | | | | | | | | to the link found. We no longer use the selection controller to highlight the active match. Before this change, the focus would not be set if the user had changed the selection. After this change, the focus will be set unless the user has selected something on the page. I also wrote an in-browser unit test for this to catch this regression in the future, but it is disabled due to problem with running multiple in-process browser tests in a row (teardown problem). BUG=10573 TEST=Covered by in process browser test now, see bug for repro steps. Review URL: http://codereview.chromium.org/79024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13945 0039d316-1c4b-4281-b951-d872f2087c98
* Add a comment explaining the ownership model between AppModalDialogtc@google.com2009-04-171-1/+4
| | | | | | | | | and the NativeDialog. Review URL: http://codereview.chromium.org/77034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13942 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor NineBox to take 9 image ids instead of having to createtc@google.com2009-04-175-129/+103
| | | | | | | | | | | | | | the GdkPixbuf array and passing it into the constructor. This allows us to remove some resource_bundle.h includes. Clean up the style in gtk_chrome_button.cc. There was some C style and moved the globals to just static pointers. I verified with a debugger that we call gtk_chrome_button_class_init only once. Review URL: http://codereview.chromium.org/69025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13941 0039d316-1c4b-4281-b951-d872f2087c98
* EscapeQueryParamValue differs from encodeURIComponent in that it doesn't ↵glen@chromium.org2009-04-171-5/+4
| | | | | | | | | | | escape spaces, so we have to do some manual fiddling to make searches that have come from the New Tab Page work (see GetHistoryURLWithSearchText). BUG=9940 TEST=Verify that searches from the new tab page and from the history page result in the same search query appearing in the history results page. Review URL: http://codereview.chromium.org/67249 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13938 0039d316-1c4b-4281-b951-d872f2087c98
* History observer was observing the wrong profile in incognito mode.glen@chromium.org2009-04-171-2/+4
| | | | | | | | | BUG=9984 TEST=Open two history tabs, one inside an incognito window. Delete a day's history in each and observe that the changes are reflected in the other. Review URL: http://codereview.chromium.org/67250 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13937 0039d316-1c4b-4281-b951-d872f2087c98
* Delete dialog after calling completion routines.pinkerton@chromium.org2009-04-171-0/+1
| | | | | | Review URL: http://codereview.chromium.org/69037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13932 0039d316-1c4b-4281-b951-d872f2087c98
* Makes SupportsFeature virtual and adds a virtual destructor to Browser.sky@chromium.org2009-04-171-2/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/69022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13931 0039d316-1c4b-4281-b951-d872f2087c98
* Disable installer tests while I work on fixing them.kuchhal@chromium.org2009-04-171-4/+4
| | | | | | | | | TBR=ananthak Review URL: http://codereview.chromium.org/69035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13927 0039d316-1c4b-4281-b951-d872f2087c98
* On uninstall ask whether to delete profile.kuchhal@chromium.org2009-04-179-28/+168
| | | | | | | | | BUG=8431 Review URL: http://codereview.chromium.org/62097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13926 0039d316-1c4b-4281-b951-d872f2087c98
* added windows.getWindows() and tabs.moveTab()rafaelw@chromium.org2009-04-176-63/+316
| | | | | | Review URL: http://codereview.chromium.org/79026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13919 0039d316-1c4b-4281-b951-d872f2087c98
* Re-word this menu item.ben@chromium.org2009-04-171-1/+1
| | | | | | | | TBR=glen Review URL: http://codereview.chromium.org/77015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13916 0039d316-1c4b-4281-b951-d872f2087c98
* Remove overlap between TabContents and WebContents. Now all the functions inbrettw@chromium.org2009-04-174-204/+162
| | | | | | | | TabContents are either pure virtual and implemented in WebContnets, or are non-virtual. This makes it possible to merge the classes by a union operation. Review URL: http://codereview.chromium.org/66057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13915 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Make all devtools messages dispatch through debugger interrupt.pfeldman@chromium.org2009-04-178-48/+166
| | | | | | Review URL: http://codereview.chromium.org/73002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13910 0039d316-1c4b-4281-b951-d872f2087c98
* Reorganize fullscreen mode handling. Now nearly everything is in WindowWin. ↵pkasting@chromium.org2009-04-1712-272/+344
| | | | | | | | This also includes work area change notifications, which only really apply to Windows (and not pure Widgets) anyway. Some parts (namely, the browser-specific things) are still in BrowserView.This allows me to fix the bug where unlocking your screen resized fullscreen mode windows incorrectly.There are probably one or two other small bits tangled in here -- this got a bit messy. I moved the exit bubble out of browser/ because it wasn't browser-specific; in theory, any WindowWin can now go into fullscreen mode.BUG=8159 Review URL: http://codereview.chromium.org/78002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13908 0039d316-1c4b-4281-b951-d872f2087c98
* Use different names for Chrome/Chromium for Chrome HTML prog id. If wekuchhal@chromium.org2009-04-173-29/+18
| | | | | | | | | | | | | | | | | user the same name for both (ChromeHTML) Vista reports that http/https are associated with Chrome as well as Chromium and each treats itself as default browser. Also do some cleanup - instead of trying to update only the Chrome open cmd, go ahead and register the whole browser again (this doesn't change user preferences). BUG=9697 Review URL: http://codereview.chromium.org/67229 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13906 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent Plugin Channel Host from dropping reply messages while plugins are ↵pfeldman@chromium.org2009-04-173-13/+28
| | | | | | | | disabled; do not create plugins while plugin messages are being dropped. Review URL: http://codereview.chromium.org/69021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13905 0039d316-1c4b-4281-b951-d872f2087c98
* Split out the contents view into its own header. rename it to ↵ben@chromium.org2009-04-165-448/+495
| | | | | | | | | | AutocompletePopupContentsView from AutocompletePopupViewContents too. No other changes. Review URL: http://codereview.chromium.org/79032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13901 0039d316-1c4b-4281-b951-d872f2087c98
* Fix errordkegel@google.com2009-04-161-1/+2
| | | | | | | | | [FATAL:at_exit.cc(40)] Check failed: false. Tried to RegisterCallback without an AtExitManager in (possibly unused) binary perf_tests Review URL: http://codereview.chromium.org/60103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13899 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure to delete the tab when we remove it from the tab strip. Also ↵jhawkins@chromium.org2009-04-161-1/+5
| | | | | | | | removes a call to Layout that should be removed now that we have RemoveTabAnimation. Review URL: http://codereview.chromium.org/79029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13898 0039d316-1c4b-4281-b951-d872f2087c98
* Start creating results rows, making sure their visual representation is ↵ben@chromium.org2009-04-162-33/+351
| | | | | | | | | | | | clipped by the containing popup's roundrect. No text yet, though they seem to actually work when clicked on. This is not the final construction I'd like, but I'm checkpointing here before the changelist gets any bigger. In the end, I'm thinking AutocompletePopupView will end up being implemented by the popup's contents view rather than the popup itself. I want to do this because the popup, the contents view and the individual result item views need access to the model and as it stands I need to wire model data methods all the way from the result view up to the popup which is annoying. But for now, I have some of that wiring. I'll do this adjustment after this one, since it requires creating some new files. Review URL: http://codereview.chromium.org/79023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13897 0039d316-1c4b-4281-b951-d872f2087c98
* Re-introducing the toolbar importer code.This is the same code that was ↵brg@chromium.com2009-04-168-0/+1275
| | | | | | | | removed in CL http://codereview.chromium.org/18550.The UI will be reworked in a CL immediately following review/submission of this code.Please contact Nick Baum for information regarding this change. Review URL: http://codereview.chromium.org/66065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13895 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the process creation problem. This forces transitions betweenbrettw@chromium.org2009-04-165-5/+71
| | | | | | | | | | BrowsingInstances when we force a transition for DOM UIs. BUG=9364 TEST=see bug Review URL: http://codereview.chromium.org/67201 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13892 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the tab button logic into TabButtonGtk.jhawkins@chromium.org2009-04-169-300/+390
| | | | | | | * Modify the tabstrip input handling to match the new interface. Review URL: http://codereview.chromium.org/79025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13891 0039d316-1c4b-4281-b951-d872f2087c98
* Make Browser::set_window defined all the time, and adds the ability tosky@chromium.org2009-04-163-1/+16
| | | | | | | | | | | set the non client frame view. BUG=none TEST=none Review URL: http://codereview.chromium.org/67236 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13890 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 5729 - RTL: TabStrip context menu should be positioned ↵xji@chromium.org2009-04-161-1/+4
| | | | | | | | | | | | | properly, If window is not maxmized. (http://crbug.com/5729). The fix is to popup tabstrip context menu from the left of the click in RTL UI. Without the fix, tabstrip context menu always popup from the right of the click. Review URL: http://codereview.chromium.org/73021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13888 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ExtensionProcessManager and move its functionality ontompcomplete@google.com2009-04-1617-215/+136
| | | | | | | | | | | ExtensionsService. Also add "chrome-extension" to the list of schemes that BrowsingInstance groups per-site, instead of per-tab. This means that navigating to an extension URL will use the same process as a running extension toolstrip. Review URL: http://codereview.chromium.org/77002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13887 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-04 18:54:01 +0000