summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* When the plugin crashes, cleanup references to its window in the renderer.piman@chromium.org2009-08-066-2/+31
| | | | | | | | | This avoids spurious messages when the plugin crashes, and potential issues (plugin crashes, the HWND/XID gets destroyed, a new one gets created by a new instance and gets the same HWND/XID, the browser operates on the new one instead of the old one). Review URL: http://codereview.chromium.org/160614 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22688 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up copy pasta hotkeys in gtk bookmark manager.estade@chromium.org2009-08-062-4/+32
| | | | | | | | | | | Also change the display hotkey for tab reload from f5 (windowsy) to ctrl+r (linuxy). BUG=none TEST=use the new hotkeys Review URL: http://codereview.chromium.org/164097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22685 0039d316-1c4b-4281-b951-d872f2087c98
* Don't pack an empty label into bookmarks with empty titles.estade@chromium.org2009-08-061-9/+16
| | | | | | | | BUG=18348 Review URL: http://codereview.chromium.org/164101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22684 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding Coverity fixes from http://codereview.chromium.org/159862 ↵phajdan.jr@chromium.org2009-08-063-3/+3
| | | | | | | | | | | | | excluding the broken ones. The change of GURL -> const GURL& caused some nasty crash and the change got reverted. TEST=none BUG=none Review URL: http://codereview.chromium.org/164095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22682 0039d316-1c4b-4281-b951-d872f2087c98
* CL 22502 dropped the app_strings as part of the switch, so we don't have ↵thomasvl@chromium.org2009-08-061-0/+3
| | | | | | | | | | some of the strings we actually need to run. BUG=none TEST=none (no really good way to confirm that app_strings are in there now, pending cl uses them). Review URL: http://codereview.chromium.org/164098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22681 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Pass font settings through to interstitial renderers.derat@chromium.org2009-08-065-46/+77
| | | | | | | | | BUG=18483 TESTED=restarted and visited a page with a broken SSL cert a few times while changing font settings via gnome-appearance-properties Review URL: http://codereview.chromium.org/164094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22679 0039d316-1c4b-4281-b951-d872f2087c98
* Add recent crash found by reliability bot to known_crashes.txt. Bug for ↵senorblanco@chromium.org2009-08-061-0/+2
| | | | | | | | | | | crash logged as 18700. BUG=http://crbug.com/18700 TEST=less redness == more goodness Review URL: http://codereview.chromium.org/165092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22678 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Don't choke when there's no selection in the bookmark editor tree view.estade@chromium.org2009-08-062-7/+24
| | | | | | | | | 1) disable "new folder" when no folder is selected 2) if a user clicks apply when no folder is selected, apply the title/url edits but leave it in its original location Review URL: http://codereview.chromium.org/164016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22676 0039d316-1c4b-4281-b951-d872f2087c98
* Properly size accepted dangerous downloads.estade@chromium.org2009-08-061-4/+6
| | | | | | | | BUG=18448 Review URL: http://codereview.chromium.org/165086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22675 0039d316-1c4b-4281-b951-d872f2087c98
* Add filters for IPC::SyncChannel leaks on purify.tim@chromium.org2009-08-061-0/+135
| | | | | | | | | | | | | | | | | | | | Most already are suppressed and have bugs for valgrind. RevocableStore- issue 17385 CreateChannel - issue 17979 IPC::Channel::Channel() - issue 17888 SyncChannel::SyncChannel - issue 16128 CreatePipe - issue 18696 ReceivedSyncMsgQueue - issue 8469 OnAddFilter - 18698 IPC::Channel::ChannelImpl::Connect - issue 18699 BUG=17385, 17979, 17888, 16128, 18696, 8469, 18698, 18699 Review URL: http://codereview.chromium.org/165088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22674 0039d316-1c4b-4281-b951-d872f2087c98
* Correctly handle extensions width in the GTK extension shelf.phajdan.jr@chromium.org2009-08-066-6/+14
| | | | | | | | | | | Also make the method name used on Windows shorter and more obvious. TEST=none http://crbug.com/16759 Review URL: http://codereview.chromium.org/164092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22672 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the size of a cancelled download in the download shelf.paul@chromium.org2009-08-062-5/+3
| | | | | | | | | | | | | Patch created by Thiago Farina, original CL: http://codereview.chromium.org/160465 BUG=17180 (http://crbug.com/17180) TEST=Download some file, then cancel it and notice the shelf UI does not any longer display the size of download. Review URL: http://codereview.chromium.org/165073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22666 0039d316-1c4b-4281-b951-d872f2087c98
* Switch extension update manifest parse errors to LOG(WARN).asargent@chromium.org2009-08-061-1/+1
| | | | | | | | | | | | | | | | Before this patch they are using ExtensionErrorReporter, but I don't think it's actually useful for users to see them on the chrome://extensions page. BUG=http://crbug.com/18565 TEST=You should no longer see messages like "Extension update manifest parse error: Invalid codebase url"on the chrome://extensions page. Review URL: http://codereview.chromium.org/164008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22662 0039d316-1c4b-4281-b951-d872f2087c98
* Another day, another round of suppressions from my local continous mac ui ↵dank@chromium.org2009-08-061-0/+2
| | | | | | | | | | | | | | | valgrind run. Move one suppression from 6547 to new bug 18664 as we widen it, 'cause 6547 was marked closed, and the history was messy. Also disable ErrorPageTest.DNSError_GoBack2Forward2 -- it hangs often on mac under valgrind, possibly a bug in valgrind. BUG=6547,16628,18661,18664 TEST=swing mac around your head on its power cord, see if any memory leaks out Review URL: http://codereview.chromium.org/165076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22661 0039d316-1c4b-4281-b951-d872f2087c98
* More theme fixes.tc@google.com2009-08-065-30/+38
| | | | | | | | | | | | | | 1) Fix the bookmark bar to draw the same as the toolbar (tile the background image and have a transparent background). 2) Fix the tab backgrounds to be offset correctly rather than always drawing as if we're the first tab. Some small code cleanup in views/tabs/tab_renderer.h. Review URL: http://codereview.chromium.org/165078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22660 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: handle Escape in omnibox when numlock/scrolllock/caps lock is on.estade@chromium.org2009-08-061-1/+2
| | | | | | | | | BUG=18643 TEST=turn on num lock. Escape in omnibox resets the address. Review URL: http://codereview.chromium.org/165079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22659 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "GTK: Rounded corner on status bubble."erg@google.com2009-08-062-124/+28
| | | | | | | | | | This reverts commit d98d01314c8b0905ac236d98dc39508ad8acfd05 (r22644). This should make the linux ui tests green. Review URL: http://codereview.chromium.org/164086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22656 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of warning on CHROME_OS builder.jam@chromium.org2009-08-061-2/+2
| | | | | | Review URL: http://codereview.chromium.org/165080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22655 0039d316-1c4b-4281-b951-d872f2087c98
* Enable message ports for workers.jam@chromium.org2009-08-0613-32/+174
| | | | | | | TEST=included ui test Review URL: http://codereview.chromium.org/160576 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22653 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Rounded corner on status bubble.erg@google.com2009-08-062-28/+124
| | | | | | | | http://crbug.com/18309 Review URL: http://codereview.chromium.org/164010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22644 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add GYP flag to build with system libbz2.agl@chromium.org2009-08-062-2/+12
| | | | | | | | | | | | | This follows the general style of r21663, which we agreed was the way to do this. Note that, currently, one cannot build with system libbz2 on a 64-bit system since it's not part of the ia32-compat package. http://codereview.chromium.org/165016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22640 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: don't use GOT patching to intercept localtime(_r)agl@chromium.org2009-08-061-57/+70
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Our current GOT patching code is platform specific and fails to work when V8 is built as a library. Instead we define global functions for those functions which we wish to override. Since we will be first in the dynamic resolution order, the dynamic linker will point callers to our versions of these functions. However, we have the same binary for both the browser and the renderers, which means that our overrides will apply in the browser too. The global |g_am_zygote_or_renderer| is true iff we are in a zygote or renderer process. It's set in ZygoteMain and inherited by the renderers when they fork. (This means that it'll be incorrect for global constructor functions and before ZygoteMain is called - beware). Our replacement functions can check this global and either proxy the call to the browser over the sandbox IPC (http://code.google.com/p/chromium/wiki/LinuxSandboxIPC) or they can use dlsym with RTLD_NEXT to resolve the symbol, ignoring any symbols in the current module. TEST=Run javascript:alert(new Date().getTimezoneOffset()). It shouldn't return 0 unless you're actually in GMT. BUG=16800 http://codereview.chromium.org/165011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22636 0039d316-1c4b-4281-b951-d872f2087c98
* More Linux theme fixes.tc@google.com2009-08-063-11/+28
| | | | | | | | | | | | | | | | | | (1) If the theme provides a inactive tab background, don't offset the image. This matches the Windows code. (2) Tile the toolbar background in both the X and Y direction (no longer use a ninebox for this). (3) Make the toolbar event box have an invisible window so toolbar backgrounds with transparency will show the background behind it. TEST=Install the Grass theme from the theme gallery. It shouldn't look janky. Review URL: http://codereview.chromium.org/164023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22631 0039d316-1c4b-4281-b951-d872f2087c98
* Free demuxed audio packets if audio device failshclam@chromium.org2009-08-061-0/+1
| | | | | | | | | | | | | | | | BUG=17481 TEST=media_unittests Introduced a mesage broadcasting mechanism to notify filters of events from another filter. In particular this is used to notify all filters that the audio device has failed and special actions should be taken to handle it. In this case, demuxer should disable the audio stream and should free the demuxed audio packets instead of caching them. This will fix the memory leak that happens if audio device fails during playback. Review URL: http://codereview.chromium.org/159845 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22630 0039d316-1c4b-4281-b951-d872f2087c98
* Changed the bookmark sync login dialog message and the dialog's width.idana@chromium.org2009-08-062-4/+4
| | | | | | Review URL: http://codereview.chromium.org/165021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22628 0039d316-1c4b-4281-b951-d872f2087c98
* Enable worker layout tests after the WebKit patch to fix an assert is landed.jianli@chromium.org2009-08-061-8/+8
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/160676 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22627 0039d316-1c4b-4281-b951-d872f2087c98
* Apply theme to incognito NTP.mirandac@chromium.org2009-08-066-8/+93
| | | | | | | | | BUG= http://crbug.com/18480 TEST= Open incognito window. Note that NTP is themed. Review URL: http://codereview.chromium.org/164002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22613 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that status bubble does not obscure download shelf.mirandac@chromium.org2009-08-062-9/+7
| | | | | | | | | | BUG= http://crbug.com/18425 TEST= Cause download shelf to appear. Hover over a link in the extreme lower left corner of the page. Note that status bubble dodges to the right, instead of dropping to obscure the shelf. Review URL: http://codereview.chromium.org/159878 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22610 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting r22603, which reverts r22591. It seems that the revert doesn't help...hamaji@chromium.org2009-08-061-278/+130
| | | | | | | | | | TEST=none BUG=none TBR=eroman Review URL: http://codereview.chromium.org/164057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22605 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting r22591. It seems to be making purify fail.hamaji@chromium.org2009-08-061-130/+278
| | | | | | | | | | | | | | r22590: http://build.chromium.org/buildbot/waterfall/builders/XP%20Unit%20(purify)/builds/5026 r22591: http://build.chromium.org/buildbot/waterfall/builders/XP%20Unit%20(purify)/builds/5030 TEST=none BUG=none TBR=eroman Review URL: http://codereview.chromium.org/165048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22603 0039d316-1c4b-4281-b951-d872f2087c98
* Disable SSLUITest.TestGoodFrameNavigation as it seems to be flaky.hamaji@chromium.org2009-08-061-1/+1
| | | | | | | | | | BUG=18626 TEST=none TBR=jcampan Review URL: http://codereview.chromium.org/165047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22602 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of r22559.aa@chromium.org2009-08-0623-36/+31
| | | | | | | | | | | | | | | | | | This caused an easily reproducible crash: 1. Start with a fresh profile 2. Navigate to google.com 3. Restart 4. Navigate to google.com 5. crash The change from pass-by-value to pass-by-ref in fav_icon_helper.* seems to be to blame, but I can't see it right off. TBR=phajdan.jr@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22595 0039d316-1c4b-4281-b951-d872f2087c98
* Remove dependency on SingleThreadedProxyResolver from ↵eroman@chromium.org2009-08-061-278/+130
| | | | | | | | | | | | | | resolve_proxy_msg_helper_unittest.cc. Extracts MockAsyncProxyResolver to "mock_proxy_resolver.h". This should be the last unittest that needs cleanup post r21631. BUG=http://crbug.com/11079 Review URL: http://codereview.chromium.org/160619 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22591 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bunch of layout tests related to dumpResourceLoadCallbacks.darin@chromium.org2009-08-062-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | There are several changes included: 1- Fixed up some of the signatures of virtual methods on TestWebViewDelegate so that they actually get called. 2- Fudged the output of some of the events so that they match the WebKit Mac results. This means outputing NSError instead of WebError, etc. 3- Modified WebURLLoaderImpl to send a more meaningful redirect request. This allows some tests to observe that we are for example going to be issuing a POST request in response to a 307 redirect of a POST request. 4- Modified WebViewDelegate::WillSendRequest to take a redirect_response parameter so that the TestWebViewDelegate can log information about that. 5- Deleted a number of custom baselines that are now unnecessary! :-) 6- Removed some code from WebFrameLoaderClientImpl::dispatchWillSendRequest that was causing our setting for firstPartyForCookies to differ from Safari. This CL depends on WebKit r46820. R=dglazkov,abarth BUG=none TEST=none Review URL: http://codereview.chromium.org/164033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22590 0039d316-1c4b-4281-b951-d872f2087c98
* Don't show themes in extension config UI. This fixes various bugsaa@chromium.org2009-08-063-22/+6
| | | | | | | | | | | | | | | | where the extension config UI doesn't work right with themes. This isn't ideal because users go to chrome://extensions/ expecting themes to be listed. If they aren't there, users might be confused. But I don't have an alternate solution. Also, this change removes the error listing from the top of chrome://extensions/. These errors are just getting noisy, I don't think they provide much value. BUG=13649,18456 Review URL: http://codereview.chromium.org/160631 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22578 0039d316-1c4b-4281-b951-d872f2087c98
* Don't run the SetProxyConfig task on the UI thread as it causes a bunch of ↵ananta@chromium.org2009-08-061-14/+2
| | | | | | | | | | DCHECKS to fire in the ProxyConfigService objects. Review URL: http://codereview.chromium.org/164013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22577 0039d316-1c4b-4281-b951-d872f2087c98
* Icon loader: respect delegate's response to NotifyDelegate call (false means ↵estade@chromium.org2009-08-061-2/+2
| | | | | | | | the delegate doesn't assume ownership). Review URL: http://codereview.chromium.org/164038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22575 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP: Fix window tooltip so that it is not shown out of place.arv@google.com2009-08-061-11/+15
| | | | | | | | | | | BUG=18529 TEST=The bug is hard to reproduce but it involved moving the mouse fast over the link. Review URL: http://codereview.chromium.org/164012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22567 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP: Minor tweak to make the Google chrome logo line up better.arv@google.com2009-08-061-1/+1
| | | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/165010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22566 0039d316-1c4b-4281-b951-d872f2087c98
* Bunch of Coverity fixes, rather minor severity.phajdan.jr@chromium.org2009-08-0623-31/+36
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/159862 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22559 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land extension docs build/render/presubmit. The original patch, ↵rafaelw@chromium.org2009-08-0521-1190/+787
| | | | | | | | | | http://codereview.chromium.org/159607, was reverted because of incorrect dependencies. Note that the extension docs build.py is no longer a gyp build target. Review URL: http://codereview.chromium.org/159830 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22558 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where a download isn't canceled when the user requests it.paul@chromium.org2009-08-052-7/+21
| | | | | | | | | | | | | | | This particular bug only occurs when the user is prompted via save file dialog and then chooses cancel. In this case, the file selection code path for canceling was not the same as regular cancel case, so the network requests continued. BUG=18160 TEST=When prompted to save a download, choose cancel and notice that there is no further network traffic due to that download. Review URL: http://codereview.chromium.org/160627 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22557 0039d316-1c4b-4281-b951-d872f2087c98
* Safari Bookmark/Favicon import.jeremy@chromium.org2009-08-059-89/+367
| | | | | | Review URL: http://codereview.chromium.org/159750 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22556 0039d316-1c4b-4281-b951-d872f2087c98
* This is a quick fix for include file path issue in livesynctest related file.tejasshah@google.com2009-08-051-1/+1
| | | | | | Review URL: http://codereview.chromium.org/165015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22549 0039d316-1c4b-4281-b951-d872f2087c98
* Fix include path for header file to fix sync build.tim@chromium.org2009-08-051-1/+1
| | | | | | | I'll hold off committing until Idan lets me know I didn't butcher anything else, too :) Review URL: http://codereview.chromium.org/165004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22546 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Fancy html5 draggy stuff.estade@chromium.org2009-08-053-60/+159
| | | | | | | | | | | | | | | | | | | | | Also, don't crash in release mode when the tab contents is deleted during a drag. 1) Source side: when the tab contents is going down, abort the current drag (if any). Initiate drags on a GtkInvisible (matching firefox, among other programs I assume). This lets us give up ownership of the drag widget and let the drag unwind. 2) Destination side: make a seemingly harmless GTK assert point to a crbug bug. This warrants further investigation. BUG=16249 TEST=drag around ntp thumbnails BUG=18557 In release mode, you should be able to do all the following without crashing or getting any asserts besides the two mentioned in 18557 TEST=drag something from gedit over a tab that closes TEST=drag something from the render view over a tab that closes TEST=drag something from the render view off of the browser from within a tab that closes TEST=repeat all the above with a tab that is being swapped out according to the repro steps in bug 16073 Review URL: http://codereview.chromium.org/159889 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22542 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 22517.rohitrao@chromium.org2009-08-0524-493/+438
| | | | | | Review URL: http://codereview.chromium.org/165001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22541 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that we never call into WebCore::Page static methods when Page ↵dglazkov@chromium.org2009-08-058-1/+22
| | | | | | | | | | | | | | | | constructor hasn't been called. This is a top crash for Mac right now. The crash occurs because the static table of all pages in the renderer is initialized in WebCore:: Page constructor, and if we attempt to access this table before the Page was created (i.e. before WebView::Create is called), we get into a crashy situation. I am really not sure how to reproduce this, but I can defend against the situation. BUG=17555 R=darin TEST=unable to repro, speculative fix. Review URL: http://codereview.chromium.org/159887 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22540 0039d316-1c4b-4281-b951-d872f2087c98
* Draw the theme overlay. I hadn't implemented this previously becausetc@google.com2009-08-051-7/+7
| | | | | | | | | | | | I didn't have an example theme that does this. TEST=Install the Folders theme from the theme gallery and you should see a paperclip and some paper in the theme. Review URL: http://codereview.chromium.org/165002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22539 0039d316-1c4b-4281-b951-d872f2087c98
* Add the anti-clockwise waiting throbber to app mode/popup windows.tc@google.com2009-08-055-24/+50
| | | | | | | | | BUG=18181 Review URL: http://codereview.chromium.org/160653 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22537 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-31 19:50:56 +0000