| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
(~1.3 megs off Debug linux .a files)
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3556013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
natively.
BUG=None
TEST=NTP, Bookmarks manager, settings should all continue to work.
Review URL: http://codereview.chromium.org/3521015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also fix a memory leak in that area.
BUG=56721, None
TEST=None
Review URL: http://codereview.chromium.org/3534010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3539008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
not the whole theme.
BUG=57187
TEST=no more crash on Linux.
Review URL: http://codereview.chromium.org/3576014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=evan
Review URL: http://codereview.chromium.org/3594011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3539014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* Ignore false mouseover when switching to submenu, which was closing submenu.
* Fixed a bug that was setting selection when moving a mouse. (in native_menu_domui.cc)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3615010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3570011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
compositing mode.
BUG=57968
Review URL: http://codereview.chromium.org/3584011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The underlying change has now been drovered to the branch, so I'm reverting
to 50-50 in trunk.
Per a discussion with laforge & jar, we're backing off in m7 to just
2% field trial on prefetching.
BUG=58046
TEST=nope
Review URL: http://codereview.chromium.org/3608008
TBR=gavinp@chromium.org,jar@chromium.org,laforge@chromium.org
Review URL: http://codereview.chromium.org/3560012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I want to see timestamps for these logging messages on the buildbots.
Matt said they were using std::cout to work around LOG(INFO) not printing,
but we fixed LOG(INFO) so that shouldn't matter anymore.
Review URL: http://codereview.chromium.org/3562006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously we'd only show LOG(WARNING) or above. This change makes
us show LOG(INFO) as well.
Now that we have VLOG(), we should remove LOG(INFO) for information
we don't care about.
Review URL: http://codereview.chromium.org/3599016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Per a discussion with laforge & jar, we're backing off in m7 to just
2% field trial on prefetching.
BUG=58046
TEST=nope
Review URL: http://codereview.chromium.org/3608008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This code creates an X window that overlays where tab contents are drawn. The handle associated with this window never changes (unlike the X window associated with a GTK widget that is created and destroyed whenever the widget is realized and unrealized respectively). This is helpful when creating a GL context associated with an X window. Also, having a floating overlay allows us to handle detaching GPU accelerated tabs.
This code seems to have uncovered a race condition within the GPU process. When a tab that uses accelerated compositing is detached (e.g. http://webkit.org/blog/386/3d-transforms/), the tab contents often don't get displayed even though the tab is redrawn. A slight delay of about 100ms in the GPU process on the call to glXSwapBuffers (in gl_context_linux.cc) fixes this. To witness that GL can draw to the overlay after delay, try it with a tab with constant animation (e.g. http://webkit.org/blog-files/3d-transforms/poster-circle.html).
I've written a bare bones test (about 150 lines of C) of the overlay technique, and it requires no such delay b/w reparenting the glXSwapBuffers. I've also confirmed that there is no synchronization issues w.r.t. the X server between my patch and GL draw commands. I propose filing a new bug for the race, if this patch gets accepted.
BUG=53345,56419
TEST=Open two tabs, one with GPU rendered content (http://webkit.org/blog/386/3d-transforms/). Detach the tab with GPU rendered content. GPU process shouldn't crash.
Review URL: http://codereview.chromium.org/3509004
Patch from Jonathan Backer <backer@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
entire Linux printing pipeline to match Win/Mac.
BUG=none
TEST=printing works.
Review URL: http://codereview.chromium.org/3619002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=31434
TEST=browser_tests --gtest_filter=ExtensionApiTest.*Tabs
Review URL: http://codereview.chromium.org/3584010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
contain any changes other than renaming/moving, as such I'm TBRing.
BUG=54833
TEST=none
TBR=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/3602015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
host all types of services. Also implemeneted a rudimentary singleton mechanism for the service process on Windows.
BUG=None
TEST=Test cloud print proxy and remoting UI.
Review URL: http://codereview.chromium.org/3521012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compile
Review URL: http://codereview.chromium.org/3597008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also makes the label text line up correctly if the label needs to wrap.
This also fixes a bug where the menu could be scrolled off the screen.
I went through and fixed a bunch of indentation errors in the HTML I touched.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3590006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=unittests
Review URL: http://codereview.chromium.org/3544008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SavingHistoryDisabledThenEnabled timeout / fails
Disabling failing tests on Vista.
http://build.chromium.org/buildbot/waterfall/builders/Vista%20Tests/builds/23137/steps/browser_tests/logs/stdio
Note: Google Test filter = HistoryBrowserTest.SavingHistoryDisabled
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from HistoryBrowserTest
[ RUN ] HistoryBrowserTest.SavingHistoryDisabled
[3040:568:1005/060732:99222312:INFO:install_util.cc(72)] No existing Chrome install found.
[3040:4140:1005/060732:99222453:INFO:chrome_plugin_lib.cc(201)] ChromePluginLib::CP_Initialize(c:\b\slave\chromium-rel-vista-tests\build\src\build\Release\gears.dll): initialized=0
[3040:4140:1005/060732:99222453:INFO:chrome_plugin_lib.cc(222)] ChromePluginLib::CP_Initialize(c:\b\slave\chromium-rel-vista-tests\build\src\build\Release\gear
command timed out: 600 seconds without output, killing pid 5712
program finished with exit code 1
elapsedTime=919.310000
http://build.chromium.org/buildbot/waterfall/builders/Vista%20Tests/builds/23142/steps/browser_tests/logs/stdio
Note: Google Test filter = HistoryBrowserTest.SavingHistoryDisabledThenEnabled
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from HistoryBrowserTest
[ RUN ] HistoryBrowserTest.SavingHistoryDisabledThenEnabled
[5828:4796:1005/082951:107761968:INFO:install_util.cc(72)] No existing Chrome install found.
[5828:5820:1005/082951:107762109:INFO:chrome_plugin_lib.cc(201)] ChromePluginLib::CP_Initialize(c:\b\slave\chromium-rel-vista-tests\build\src\build\Release\gears.dll): initialized=0
[5828:5820:1005/082951:107762109:INFO:chrome_plugin_lib.cc(222)] ChromePluginLib::CP_Initialize(c:\b\slave\chromium-rel-vista-tests\build\src\build\Release\gears.dll): initialized=1): result=0
[ OK ] HistoryBrowserTest.SavingHistoryDisabledThenEnabled (251 ms)
[----------] 1 test from HistoryBrowserTest (251 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case r
command timed out: 600 seconds without output, killing pid 2452
program finished with exit code 1
elapsedTime=921.136000
BUG=57994
TEST=HistoryBrowserTest.SavingHistoryDisabled and SavingHistoryDisabledThenEnabled
TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/3570010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61537 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3599001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=57045
TEST=interactive_ui_tests:AccessibilityWinBrowserTest.TestNotificationFocusChanged
Review URL: http://codereview.chromium.org/3582008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts http://codereview.chromium.org/3506007
(r61225 -- the original change) and
http://codereview.chromium.org/3616005 (r61446 -- a fix for
a double-free in Pepper caused by the original change).
Doing asynchronous copying to the backing store in the
browser requires some large changes to Pepper that I'm not
going to have time to work on anytime soon. A cache of
in-flight TransportDIBs would need to be added (similar to
what the renderer already does), and we'd also need to do
copy-on-write when a plugin wants to draw on top of a
previous frame that's currently held by the browser. It
seems safer to revert the early part of the asynchronous
copying change instead of leaving it partially checked in.
BUG=none
TEST=ran it
Review URL: http://codereview.chromium.org/3583012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Expose the cloud print proxy UI command line switch through a lab
(Windows only for now, others as we get the proxy and UI going there).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3599014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also make BubbleWindow title left aligned per mock and fix wrong
background color for DialogClientView by setting bg color to widget style.
BUG=chromeium-os:6305
TEST=Verify js dialog on chrome os is in new bubble look again.
Review URL: http://codereview.chromium.org/3598008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none.
TEST=Verify icons are not broken in "Internet" of options page.
Review URL: http://codereview.chromium.org/3603004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Use batch begin/end notifications to group tree update per rsesek;
- Defer CookiesTreeModel creation until it is searched the first time which
happens when cookies view is visible for the first time;
BUG=chromium:56989
TEST=Verify fix for chromium:56989.
Review URL: http://codereview.chromium.org/3590003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Changing the OnLoginSuccess api as we have discussed offline. Had to update all classes that inherit from LoginStatusConsumer, all callsites, etc.
BUG=chromium-os:4929
TEST=unit tests
Review URL: http://codereview.chromium.org/3526014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61518 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Browser::AddSelectedTabWithURL(const GURL& url, PageTransition::Type transition)
-> A good many callsites just wanted a way to open a tab somewhere and select it.
- Browser::AddTabWithURL(AddTabWithURLParams* params)
-> For the callsites with specialized needs, this new signature allows the parameter set to change as features are added without having to update a bunch of callers every time.
BUG=none
TEST=existing unit tests
Review URL: http://codereview.chromium.org/3599006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:7038
TEST=unit tests, install on device and test for crashes on "full sync" after PW change
Review URL: http://codereview.chromium.org/3443029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
buttons actually make sense in that context.
BUG=none
TEST=grammatical sentences in the clear browsing data dialog.
Review URL: http://codereview.chromium.org/3575014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=57965
TEST=none
TBR=isherman@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3520015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
occasionally on windows.
BUG=57965
TEST=none
TBR=isherman@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=57964
TEST=none
TBR=brettw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeCookiePolicy::CanGetCookies(). Cookie-getting code paths don't
know (or care) about session-only status for a domain; return that
special value for only the cookie-setting code path.
Patch from Todd Vierling <tv@duh.org>
BUG=57677
TEST=User-facing example using facebook.com is in the bug description
Review URL: http://codereview.chromium.org/3576009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50943
TEST=*.WebNavigationEvents
Review URL: http://codereview.chromium.org/3561008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=57952
TEST=none
TBR=thakis@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=57962
TEST=none
TBR=isherman@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=57959
TEST=none
TBR=ctguil@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=56021
TEST=see bug
Review URL: http://codereview.chromium.org/3425020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=55423
TEST=none
Review URL: http://codereview.chromium.org/3542005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is upstreaming a Gentoo Linux patch.
This patch prevents having multiple conflicting copies of sqlite3Preload at link time, and also fixes a dependency problem that could result in a header mismatch. The gyp file change ensures that we propagate the USE_SYSTEM_SQLITE preprocessor symbol to all targets that need it.
BUG=22208
TEST=none
Review URL: http://codereview.chromium.org/3519002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=57578
TEST=none
Review URL: http://codereview.chromium.org/3575012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:6791
TEST=Go BWSI mode, click menu->Preferences, click on the 'Personal stuff' item in the left menu, notice that line that corresponds to sync says 'Sync is disabled in this mode'.
Review URL: http://codereview.chromium.org/3444008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to the spec recently.
http://lists.w3.org/Archives/Public/public-webapps/2010JulSep/1101.html
> For a move/copy of a file on top of existing file, or a directory on
> top of an existing empty directory, you get an automatic overwrite.
> A move/copy of a file on top of an existing directory, or of a
> directory on top of an existing file, will always fail.
> A move/copy of a file or directory on top of an existing non-empty
> directory will always fail.
BUG=32277
TEST=FileSystemOperationTest.*
Review URL: http://codereview.chromium.org/3567012
TBR=kinuko@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
recently.
http://lists.w3.org/Archives/Public/public-webapps/2010JulSep/1101.html
> For a move/copy of a file on top of existing file, or a directory on
> top of an existing empty directory, you get an automatic overwrite.
> A move/copy of a file on top of an existing directory, or of a
> directory on top of an existing file, will always fail.
> A move/copy of a file or directory on top of an existing non-empty
> directory will always fail.
BUG=32277
TEST=FileSystemOperationTest.*
Review URL: http://codereview.chromium.org/3567012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61480 0039d316-1c4b-4281-b951-d872f2087c98
|