| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
BUG=9183
Review URL: http://codereview.chromium.org/67030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is used to make the background behind toolstrips 'shine
through' them. It isn't possible to make them really transparent
due to cleartype (cleartype must know the pixels behind the text
to work), so instead we paint the background we want behind the
transparent webview.
Review URL: http://codereview.chromium.org/88076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
browser. This works by monitoring the MozillaPlugins registry key and reloading the plugin list afterwards.
Note: I'll commit the WebKit change separately, but putting it in this change right now so everything can be reviewed together.
BUG=10574
Review URL: http://codereview.chromium.org/88020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
failures of window_proxy->IsActive() to complete are problematic, but we
should keep other coverage while investigating.
TBR=robertshield
BUG=10916
TEST=covered by buildbot ui_test
Review URL: http://codereview.chromium.org/93094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Split TabContentsDelegate and PageNavigator.
Review URL: http://codereview.chromium.org/88063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This should make the valgrind builder green again.
Valgrind ipc test child processes, too.
Review URL: http://codereview.chromium.org/93088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
takes a printf style format string.
Review URL: http://codereview.chromium.org/97008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
* Tabs cannot be dragged out of the browser window.
* Most of this logic needs to be refactored into DraggedTabControllerGtk.
Review URL: http://codereview.chromium.org/92028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Folders can be created and edited in the bookmark bar. They
aren't drop targets nor do they popup a menu with their contents.
- Refactor the input window interface to be platform neutral
and use that in EditFolderController.
Review URL: http://codereview.chromium.org/87010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=10901
TBR=mbelshe
Review URL: http://codereview.chromium.org/92099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=10865
Review URL: http://codereview.chromium.org/92057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/93054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=10866
Review URL: http://codereview.chromium.org/93074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/92007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
notification from the
renderer that it is done cycling through the controls on the page.
Review URL: http://codereview.chromium.org/93001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
used by the getters I moved to take a TabContents instead of a WebContents.
Review URL: http://codereview.chromium.org/96010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/10916
TBR=http://codereview.chromium.org/92086
Review URL: http://codereview.chromium.org/92086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
pending messages must happen *after* the WebContents is destroyed, since the
messages we're processing are sent from the destructor.
Review URL: http://codereview.chromium.org/93081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Disable memory tests until I can fix them.
BUG=10895
TEST=I'm disabling some of them :)
Review URL: http://codereview.chromium.org/93079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
failures here:
http://hae14.jail:8010/waterfall?builder=Vista%20Tests%20(dbg)(1)
log: http://hae14.jail:8010/builders/Vista%20Tests%20(dbg)(1)/builds/5460/steps/ui_tests/logs/stdio
BUG=http://code.google.com/p/chromium/issues/detail?id=10916
TBR=http://codereview.chromium.org/92083
Review URL: http://codereview.chromium.org/92083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14340 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The goal of this change is to *not* make any behavioral change, but to
instead just get all the plugin-related files linking on Linux with
a bunch of NOTIMPLEMENTED()s in the appropriate places. It's enormous
enough already without any refactorings or new features.
Changes include:
- Lots of gcc warning fixes.
- Use portable replacements for Windows-specific functions (_strdup, etc.).
- Use TransportDIB instead of just shared memory in the plugin messaging.
Note that this is not fleshed out on Linux and on Windows it just hacks
in the existing handles so there should be no functional change.
- Fix --plugin-launcher to use cross-platform APIs.
Review URL: http://codereview.chromium.org/79020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This fixes a bug where it wouldn't notice when a renderer died because it was
observing the notification on the wrong thread. This also simplifies some
logic in ExtensionMessageService.
Review URL: http://codereview.chromium.org/88002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/88051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/93051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/95009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/92078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/95011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/95002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14318 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. The default/keyword suggest providers are queried appropriately.
. History results are asked for default/keyword providers.
More assertions can be added over time, but we have to start some
where.
This uncovered one bug in SearchProvider, we were never marking the
provider as properly done.
BUG=3636
TEST=none
Review URL: http://codereview.chromium.org/87062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
test breakage.
Example: http://build.chromium.org/buildbot/waterfall/builders/XP%20Tests%20(dbg)(2)/builds/1268/steps/unit_tests/logs/stdio
TBR=http://codereview.chromium.org/95010
Review URL: http://codereview.chromium.org/95010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=9710
Review URL: http://codereview.chromium.org/93039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14313 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
in chromium sources.
BUG=10872
Review URL: http://codereview.chromium.org/92074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/96007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=9022
TEST=none
TBR=glen
Review URL: http://codereview.chromium.org/95008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
icon and the text to show the number of closed windows.
BUG=9022
TEST=With more than one window open close a window. Go to the new tab
page and make sure you see an entry for the closed window. The entry
should have the chrome/chromium logo and instead of 'Window' it
should say the number of tabs in the window.
Review URL: http://codereview.chromium.org/92022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/93060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/95003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rebaselines:
http://trac.webkit.org/changeset/42722 resulted in
LayoutTests/editing/inserting/insert-3907422-fix.html
LayoutTests/editing/pasteboard/paste-text-015.html
LayoutTests/editing/style/font-family-with-space.html
http://trac.webkit.org/changeset/42723 resulted in
LayoutTests/editing/selection/select-all-iframe.html
LayoutTests/svg/custom/pointer-events-path.svg
http://trac.webkit.org/changeset/42716 resulted in
LayoutTests/fast/dom/HTMLSelectElement/named-options.html
http://trac.webkit.org/changeset/42725
Broke the close event behavior and resulted in disabling these ui tests:
* BrowserCloseBeforeUnloadOK and
* BrowserCloseBeforeUnloadCancel
Review URL: http://codereview.chromium.org/92051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
not trigger its deletion.
BUG=10527
TEST=Open the New Tab Page. Click the "Remove thumbnails" link to enter edit mode. Right-click on a thumbnail. The context menu should be displayed and the thumbnail should not be removed.
Review URL: http://codereview.chromium.org/92018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When that disposition is used and no "normal" window is opened, it crashes.
"normal" means non POPUP, non APPLICATION window type. This happens because
background disposition doens't focus or activate the window unless selected. A
crash happens because GetSelectedTabContents() is null since nothing initially
there.
This fix might have stopped it crash, but would be best to see if its a "good"
approach.
I fixed some lints such as, header file already exists, extra white space, etc)
BUG=10591 ( http://crbug.com/10591 )
Original patch by Mohamed Mansour (see http://codereview.chromium.org/67205/show), r=me,pkasting
Review URL: http://codereview.chromium.org/93058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change adds a new test "RenderViewTest.OnHandleKeyboardEvent" to verify we can receive proper DOM events when we send platform-specific keyboard events.
This test is mainly for verifying our WebKit-glue code can convert platform-specific keyboard events to keyboard events of WebKit without any problems, which is hard to implement with LayoutTests.
To emulate non-US layouts, this test loads the following keyboard-layout drivers:
* Arabic (qwerty);
* United States (qwerty);
* French (azerty);
* Hebrew, and;
* Canadian French (qwerty).
Review URL: http://codereview.chromium.org/75034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
it too.
Review URL: http://codereview.chromium.org/87007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
change needs to change all open windows with the same preferences,
not just the current one).
Improve unit testing.
Limit bookmark menu size width (1st pass).
Cleanup/delete of code which no longer does much.
Review URL: http://codereview.chromium.org/79068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tests.
Log of hanging tests:
http://build.chromium.org/buildbot/waterfall/builders/XP%20Tests%20(dbg)(2)/builds/1246/steps/unit_tests/logs/stdio
TBR=http://codereview.chromium.org/92055
Review URL: http://codereview.chromium.org/92055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use HTML5 placeholder instead of js code for the text input place holders.
Use HTML5 doctype in all html files.
Skip optional type in script and style tags.
Some small optimizations in LocalStrings.
Review URL: http://codereview.chromium.org/88072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
first-run dialog (ta,kn,te,ml)
BUG=10687
Review URL: http://codereview.chromium.org/88017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
breaking horribly. When it _is_ small, draw the frame correctly.This is an incomplete fix; only non-Aero main/popup/app windows are handled so far, but this was becoming hairy enough I wanted to checkpoint it.BUG=9885
Review URL: http://codereview.chromium.org/88069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[Retry of 14260 with fixed unit test.]
1) Moves renderer_initialized_ from RenderWidgetView into RenderWidgetHost (its parent). Should be identical semantics to before.
2) Test renderer_initialized_ in RWH::WasResized().
This also reverts r13725, which was another attempt at fixing this problem.
BUG=9830,10659
TEST=From the Linux start page, click a link then click back -- should not get a gray page. From Google reader, click a link (which spawns a new tab within the same process) -- should not get a gray page.
Review URL: http://codereview.chromium.org/93038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14273 0039d316-1c4b-4281-b951-d872f2087c98
|