| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Also drops fragile code.
TEST=Covered by ui_tests.
BUG=10840
Review URL: http://codereview.chromium.org/545006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/542052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32015
TEST=Open devtool window and dock it into the browser window and move the focus into the devtool tab, then try if shortcut keys like ctrl-t are still work.
Review URL: http://codereview.chromium.org/542049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=27618
TEST=none
Review URL: http://codereview.chromium.org/460106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=1850
Review URL: http://codereview.chromium.org/549005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Resolve issue 30641
Extension files were being selected for auto-open even though an install of the
extension was not requested. This patch changes this behaviour so that download
an extension (that's not explicitly requested as an extension install) does not
force an attempt to install it.
BUG=30641
TEST=Right-click an extension link and "Save Link As...". Download appears in shelf.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
trigger the bots to test r36104.)
TBR=oshima
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/542051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=27544
TEST=none
Review URL: http://codereview.chromium.org/542044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"cooca" where it should have read "cocoa". This was evident in xcode
as a red (broken) link to cookie_tree_node.h.
BUG=35512
TBR=jrg@chromium.org
Landing http://codereview.chromium.org/545035 for dhollowa.chromium
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GTK.
NOTE: This change does not contain src/chrome/app/nibs/ClearBrowsingData.xib. It'll be edited by someone who knows about Mac.
BUG=none
TEST=The clear browser data dialog box should have a new option: Delete local storage"
Landing for Marcus
Original CL: http://codereview.chromium.org/524026
Review URL: http://codereview.chromium.org/542048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebKitClient::createSessionStorageNamespace to using
WebViewClient::createSessionStorageNamespace doesn't break us while the rest of
the SessionStorage change lands.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/546017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Nib change: Reduce row height, make scrollbars smaller.
Make text in task manager table slightly smaller.
Show in decimal digit for %cpu.
Show memory in KB/MB, not always in K.
Change update frequency from 1s to 2s to match Activity Monitor's default.
(all mac-only. ui team is fine with this.)
Finally, turn taskman on.
BUG=13156
TEST=Open task manager, look at it. Should look & feel similar to Activity Monitor.
Review URL: http://codereview.chromium.org/536038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- added flag to factory to request low latency mode
- implemented switch from triple buffered to double buffer on windows (mac is already double buffered all the time)
- added tests
BUG=28292
TEST=ut included
Review URL: http://codereview.chromium.org/523073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pull NSImage cache out of search engine dialog into its own class, reuse that.
Implement browser icon code in task_manager_resource_provider's browser resource provider.
BUG=13156
TEST=Open task manager. You should see icons. Open search engine manager, should still show icons.
Review URL: http://codereview.chromium.org/549021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
They are fixed now and can be re-enabled.
BUG=32125
TBR=johnnyg
Review URL: http://codereview.chromium.org/542047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the sync
service is showing an INVALID_GAIA_CREDENTIALS or CAPTCHA_REQUIRED auth error,
instead of just showing the 'Synced to ...' yellowbox.
BUG=32116
TEST=manually generated auth error, observed NTP sync error, clicked re-login link,
observed login dialog opened.
Review URL: http://codereview.chromium.org/541038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tab. This is the first pass and is currently a bit buggy and incomplete.
This patch refactors the backing store to make it a virtual interface which is
then implemented by the platform-specific backing stores. This cleans up the
multi-platform aspects of the old code, and also makes it possible to create
different backing stores (such as ones in another process).
This renames the BackingStore::PaintRect function to PaintToBackingStore which
clears up what it does. I would often get confused and think that it paints
the backing store to the screen.
This makes a common way to capture backing store information and adds it to the
backing store API. This removed a bunch of ugly ifdefs.
This adds the ability for a backing store to specify that the TransportDIB
should not be freed by RenderWidgetHost when painting is complete. This is
necessary since the out-of-process version needs to use it after the
RenderWidget paint function has returned.
This pushes up the vector of copy_rect from RenderWidgetHost to the actual
BackingStores. This prevents us from sending duplicate data over IPC. It also
makes the common non-IPC case more efficient, since we end up setting up various
surfaces only once when there are multiple update rects.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/523028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=atwilson
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/546020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/543019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
CROS_BUG=310
TEST=see bug
Review URL: http://codereview.chromium.org/550020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/437028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
delegates implement protocols, and -delegate methods no longer return type
|id|. Add casts as needed.
BUG=none
TEST=10.6 SDK build
Review URL: http://codereview.chromium.org/550022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Weird. I'll look into this, but for now let's get the builder green.
BUG=30398
TEST=none
Review URL: http://codereview.chromium.org/541033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jcampan
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/543030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/550016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=Run the unit-tests.
Review URL: http://codereview.chromium.org/541013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28292
TEST=none
Patch by neb@chromium.org
Original review: http://codereview.chromium.org/524006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeFrame need to process
accelerators. Currently accelerators are processed by the focus manager. We already have code in browser_view
to process unhandled keyboard messages coming back from the renderer. Moved this code to a new class
UnhandledKeyboardEventHandler which maintains state about whether the next character event has to be ignored, etc.
This class is now used by BrowserView and the ExternalTabContainer to process unhandled keyboard messages.
To support accelerators in ChromeFrame, the ExternalTabContainer needs to implement an Accelerator target. I also
added a minimal accelerator table for Chromeframe in the chrome_dll.rc and chrome_dll_resource.h files.
This fixes bug http://code.google.com/p/chromium/issues/detail?id=31672
Bug=31672
Review URL: http://codereview.chromium.org/536023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I have no good ideas about this, so I'm moving the theme building to the
UI thread to remove the possibility of clobbering the memory of the
Task*. If THAT doesn't work, I've tried to get the theme name into the
stack trace and therefore the minidumps.
BUG=31719
TEST=none
Review URL: http://codereview.chromium.org/536024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=11950
TEST=Install Chrome and in Windows Default Programs make sure we have more text than simply "Google Chrome"
Review URL: http://codereview.chromium.org/523158
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
was introduced when adding the views/gtk support. As we don't need
non-views/gtk support anymore, I'm nuking the defines in this file.
BUG=32057
TEST=see bug
Review URL: http://codereview.chromium.org/546019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also a few random copyedits to API doc,
while I was in there.
Changes to note:
* Beefed up intro and added new figure for file hierarchy
(consequently simplified the section that follows)
* Added a section on using Windows shortcuts to launch the browser
* Color -> Color(es|s)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/536034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to implement the autofill dialog.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/549014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
reusable subclass of NSMenu that is used by both.
BUG=30655
TEST=Right click on any Page action or Browser Action, observe a context menu appears.
Review URL: http://codereview.chromium.org/525098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is closed.
Also change how the controller is deallocated, which should fix a valgrind bug.
Nib change: Make TaskManagerWindowController the delegate of the window in the nib, so that its windowWillClose: gets called.
TFR=trungl
BUG=13156,30398
TEST=Open Activity Monitor, look at browser %cpu. Open chrome's task manager, note %cpu goes up slightly. Close task manager again, %cpu should go down again. Open task manager again, should still work.
Review URL: http://codereview.chromium.org/536026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
From an application mode window, if you call chrome.tabs.create and specify a
index for the new tab (and had no other windows open), chrome will crash.
BUG=29810
TEST=Crash should no longer happen when following steps in the bug report.
Review URL: http://codereview.chromium.org/542018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16305
TEST=Pinch on a multi-touch-capable trackpad; page should zoom in or out.
Review URL: http://codereview.chromium.org/545020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16932
TEST=BlacklistTest.Generic
Review URL: http://codereview.chromium.org/541025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=BlacklistTest.QueryStringMatch
Review URL: http://codereview.chromium.org/523137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36013 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
dragged. This was happening because the renderer would think we were
doing a drag operation. We need to tell the renderer to end the drag,
otherwise the renderer thinks the drag operation is ongoing.
BUG=31259
TEST=see bug
Review URL: http://codereview.chromium.org/548006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- NPAPITester.NoHangIfInitCrashes
- MetricsServiceTest.CrashRenderers
- ResourceDispatcherTest.CrossSiteAfterCrash
- RendererCrashTest.Crash
BUG=32048
TEST=none
TBR=jar, nsylvain
Review URL: http://codereview.chromium.org/548009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28445
Review URL: http://codereview.chromium.org/536027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Allow for patterns to start with a - to mark exceptions. A URL matches a
filter, if it matches at least one pattern and no exception.
BUG=16932
TEST=covered by unit_tests
Review URL: http://codereview.chromium.org/541009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit r35991 due to a perf regression to New Tab Cold
on Mac.
TBR=thakis
Review URL: http://codereview.chromium.org/545024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
platforms.
Patch by Brian Lum (brianlum at google.com)
Original Review http://codereview.chromium.org/526016
Review URL: http://codereview.chromium.org/536025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Fix case A reported by Satoshi.Matsuzaki where a 2nd icon is created
on launching chromium in non-default profile. This is because the
shortcuts for non-default profile is created with wrong app id. The
old use uses user data dir to generate the app id while the
GetChromiumAppId expects profile path;
- Fix an issue in jump list for non-default profile where the
recently close/most visted pages are always opened in the default
profile because the underlying shortcuts does not have the correct
user-data-dir arguments.
BUG=30414
TEST=Verify case A of Satoshi's comments @5 is fixed; Verify the jump list items are opened with correct profile;
Review URL: http://codereview.chromium.org/547011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the file exists. Otherwise, just load like normal on the UI thread.
This failed before because the browser may have shutdown before the
posted task ran. When the posted task finally runs, it tried to
use the profile, but the profile was already deleted. Make a small
change to VisitedLinkMaster so GetDatabaseFileName no longer depends
on the profile.
BUG=24163
Review URL: http://codereview.chromium.org/507047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=26973
TEST=Install a packaged extension. Verify the InfoBubble is shown, with the install icon and some description. The InfoBubble should disappear when the bubble looses focus (click elsewhere). For a browserAction, the bubble should point to the browserAction icon. For a pageAction **that has a "default_icon" set in it's manifest (see the samples/subscribe_page_action in this CL)**, it should point to a temporarily shown pageAction icon that will be hidden when the bubble closes. Otherwise it should point to the wrench menu.
Review URL: http://codereview.chromium.org/547010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35989 0039d316-1c4b-4281-b951-d872f2087c98
|