summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Simplify the PowerObserver API by removing unneeded args and providing ↵pkasting@chromium.org2009-10-014-29/+18
| | | | | | | | | | | | default implementations. This also makes all the subclasses use the same code to add/remove observers. BUG=none TEST=none Review URL: http://codereview.chromium.org/244054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27740 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 220.2 to 221.0jon@chromium.org2009-10-011-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27739 0039d316-1c4b-4281-b951-d872f2087c98
* Download shelf menus in title case.thomasvl@chromium.org2009-10-011-40/+118
| | | | | | | | | | | Make the show_in_folder menu and link "Show in Finder" on the Mac as requested by Cole. BUG=22647 BUG=23548 TEST=Download shelf menus (for inprogress download and completed download) should be in title case. Mac should say "Finder" instead of "Folder" Review URL: http://codereview.chromium.org/246065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27735 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Don't call MemoryDetails::Release() from AboutMemoryHandler's constructor.shess@chromium.org2009-10-011-6/+5
| | | | | | Review URL: http://codereview.chromium.org/252008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27731 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a typo in a comment.pkasting@chromium.org2009-10-011-2/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/244053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27728 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the indenting in chrome_switches.cc to be consistent.pkasting@chromium.org2009-10-011-51/+52
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/249053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27727 0039d316-1c4b-4281-b951-d872f2087c98
* Make the no bookmarks text a small control so it doesn't stick out, this ↵thomasvl@chromium.org2009-10-011-8/+8
| | | | | | | | | | makes it more inline with windows and with the buttons when they do have bookmarks. TEST=Show bookmark bar with no bookmarks, font should be closer to the font bookmark buttons use. BUG=none Review URL: http://codereview.chromium.org/242094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27721 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in determining if we can paste from the clipboard. Need tosky@chromium.org2009-10-012-1/+40
| | | | | | | | | | | use IsFormatAvailableByString rather than IsFormatAvailable. BUG=21106 TEST=see bug, also covered by unit test now. Review URL: http://codereview.chromium.org/256016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27720 0039d316-1c4b-4281-b951-d872f2087c98
* Privacy Blacklist Unblockidanan@google.com2009-10-015-24/+115
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Summary ------- Mostly implemented the unblocking for visual resources for the Privacy Blacklist. Merging now before I leave. Eveything here only has effect if the --privacy-blacklist flag specifies a Privacy Blacklist. Detailed Changes ---------------- [chrome/browser/resources/privacy_blacklist.html] - Replaced the about:blank place-holder with variable to set the unblock link. - Open the Privacy Blacklist provider page in a new tab. This works around an issue where such request for a full-page (rather than a sub-resource) gets blocked indefinitely. [chrome/browser/render_host/resource_dispatcher_host.h] - Added a BlockedResponse member which is now a class rather than a namespace, see below for more information. [chrome/browser/render_host/resource_dispatcher_host.cc] - Generate headers for the blocked response to redirect to the chrome-blocked URL which prevents an enclosing page from reading the URL of the unblock link. This was suggested by Darin to avoid scripted bypassing of blocked contents. - Recover the original URL for blocked content, in order to fetch it during unblocking. - Do not create CrossSiteResourceHandler when an unblocked link is requested. Otherwise the request never resumes as the blocked page never gets closed since it is not a real page. [chrome/browser/privacy_blacklist/blocked_response.cc] - Defined chrome-block and chrome-unblock URL schemes. The block scheme is used to return the blocked response. The unblock scheme is used request a blocked resource's URL without being intercepted by the Privacy Blacklist. - Defined a hash function for a blocked resource as its address in memory. Function to reverse the hash is therefore trivial. - Added a function to return headers for a blocked response. - Added a function to generate a block URL from a requested one. - Added a function to get an unblock URL from a requested one. - Added a function to return the original URL for a blocked one. [chrome/browser/privacy_blacklist/blocked_response.h] - Made the BlockedResponse namespace into a class. - Created a member set to keep all the blocked resources URL. BUG=16932 TEST=none TBR=darin Review URL: http://codereview.chromium.org/252001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27719 0039d316-1c4b-4281-b951-d872f2087c98
* Enabling WorkerTest.MessagePorts as the upstream regression was fixed:hamaji@chromium.org2009-10-011-1/+1
| | | | | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=29798 BUG=23320 TEST=none Review URL: http://codereview.chromium.org/249055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27715 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 220.1 to 220.2laforge@chromium.org2009-10-011-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27714 0039d316-1c4b-4281-b951-d872f2087c98
* Add EscapeURL to the ASCII escape methods.EscapeURL escapes all forbidden ↵brg@chromium.com2009-10-011-1/+1
| | | | | | | | | | ascii characters in an URL and repalces spaces with '+'. Test=Escape.EscapeUrl BUG=23029 Review URL: http://codereview.chromium.org/244056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27713 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 27705 - Move various methods from glue/webview.h to api/public/WebView.hmal@chromium.org2009-10-013-11/+16
| | | | | | | | | | | | | | | | | | | | | | | | ** browser_tests started failing at this revision. See: http://build.chromium.org/buildbot/waterfall/builders/Chromium%20XP/builds/7697/steps/browser_tests/logs/stdio ** I'll reorder the methods in webview_impl.cc in a followup CL. I wanted to keep this one easy to review. SetBackForwardListSize is no longer necessary given that BackForwardListChromium.cpp doesn't care about its capacity. R=dglazkov BUG=10033 TEST=none Review URL: http://codereview.chromium.org/251051 TBR=darin@chromium.org Review URL: http://codereview.chromium.org/246060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27711 0039d316-1c4b-4281-b951-d872f2087c98
* Move various methods from glue/webview.h to api/public/WebView.hdarin@chromium.org2009-10-013-16/+11
| | | | | | | | | | | | | | | | I'll re-order the methods in webview_impl.cc in a follow-up CL. I wanted to keep this one easy to review. SetBackForwardListSize is no longer necessary given that BackForwardListChromium.cpp doesn't care about its capacity. R=dglazkov BUG=10033 TEST=none Review URL: http://codereview.chromium.org/251051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27705 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: *Correctly* fill file extension as drag source.viettrungluu@chromium.org2009-10-011-12/+15
| | | | | | | | | | | (We have to strip the '.' from the file extension.) BUG=23431 TEST=Make sure images can still be dragged to, e.g., the desktop; make sure images can be dragged to Acorn <http://www.flyingmeat.com/acorn/>. Review URL: http://codereview.chromium.org/255035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27704 0039d316-1c4b-4281-b951-d872f2087c98
* Minor copyedits to packaging to provide better context.kathyw@google.com2009-10-012-12/+22
| | | | | | | | TBR=aa Review URL: http://codereview.chromium.org/255033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27701 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: improve app mode .desktop file creation.estade@chromium.org2009-10-013-24/+41
| | | | | | | | | | | 1) pass --user-data-dir when appropriate 2) don't overwrite old .desktop files that share the same name. BUG=23353 Review URL: http://codereview.chromium.org/255016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27700 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Allow window/app. to be closed when tab modal sheets are showing.viettrungluu@chromium.org2009-10-013-49/+0
| | | | | | | | | | | | | | | | | | This patch consists only of code deletions. Despite the comments in the deleted code, it's all okay since sheets are closed: |TabContents::~TabContents()| calls |ConstrainedWindowMac::CloseConstrainedWindow()|, which calls |ConstrainedWindowMacDelegate::DeleteDelegate()|, which should close the sheet if it's still open. This code path has been in use for quite some time, since we've allowed (or failed to disallow!) tabs containing sheets to be closed via the close tab button. BUG=19427 TEST=Open some tabs (possibly in multiple windows) with some tab modal sheet (e.g., by navigating to <http://www.pagetutor.com/keeper/mystash/secretstuff.html>); close a window containing such a tab, with a tab modal sheet visible or not; quit application while a tab modal sheet is active (not nec. visible). Review URL: http://codereview.chromium.org/242059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27699 0039d316-1c4b-4281-b951-d872f2087c98
* Reenables showing crashed info bar on chrome os.sky@chromium.org2009-10-013-7/+1
| | | | | | | | | BUG=23502 TEST=none Review URL: http://codereview.chromium.org/249050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27698 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Make sure download shelf items and download items don't share names.rsesek@chromium.org2009-10-011-2/+2
| | | | | | | | | | Mac side of http://codereview.chromium.org/242082 BUG=23046 Review URL: http://codereview.chromium.org/246054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27697 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure download shelf items and download items don't share names.mhm@chromium.org2009-10-013-3/+7
| | | | | | | | | BUG=23046 TEST=Compiled and ran on Windows Review URL: http://codereview.chromium.org/242082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27696 0039d316-1c4b-4281-b951-d872f2087c98
* Rollback Scavenge implemetation and rely on existing functionality to freejar@chromium.org2009-10-012-3/+3
| | | | | | | | | | | | | | This is a landing of a patch provided by antonm. See: http://codereview.chromium.org/235022 Also included change to browser_about_handler.cc to fix build, and I set TCMALLOC_RELEASE_RATE to 1.0 on line 40 of page_heap.cc (I think this was an inadvertent rollback element). r=antonm Review URL: http://codereview.chromium.org/257009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27692 0039d316-1c4b-4281-b951-d872f2087c98
* Add "copy" to context menu on bookmark button.jrg@chromium.org2009-09-303-38/+550
| | | | | | | | | | BUG=http://crbug.com/16941 TEST=Right-click on bookmark button; pick copy. Go to any other app and paste. Make sure you got URL. Review URL: http://codereview.chromium.org/249048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27690 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Fix memory leak from r27666.estade@chromium.org2009-09-304-3/+8
| | | | | | | | | | | Make MenuGtk take ownership of submenus. BUG=none TEST=valgrind doesn't complain Review URL: http://codereview.chromium.org/251053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27689 0039d316-1c4b-4281-b951-d872f2087c98
* Set the initial enabledness state of any browser actions whenaa@chromium.org2009-09-301-0/+12
| | | | | | | | | | | | | the window first comes up. BUG=23380 TEST=Install an extension that has a browser action. Open a new window. Browser action menu item should be disabled in wrench menu. Review URL: http://codereview.chromium.org/242083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27686 0039d316-1c4b-4281-b951-d872f2087c98
* Turn extension script injection histograms into uma histograms.asargent@chromium.org2009-09-301-8/+11
| | | | | | | | | | | | | | | -Switch to UMA_HISTOGRAM_* macros. -Rename to reflect that extensions are subsuming content scripts, and better fit the common style of histogram names. -Count css and scripts separately, and fix script count to account for multiple scripts per extension. BUG=none TEST=none Review URL: http://codereview.chromium.org/244038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27685 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize dialog_ in the constructor.jhawkins@chromium.org2009-09-301-1/+3
| | | | | | | | | CID=5060 BUG=none TEST=none Review URL: http://codereview.chromium.org/243039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27683 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Remove a check for >= 0 because it is always true. Type is ↵jhawkins@chromium.org2009-09-301-1/+1
| | | | | | | | | | | unsigned int. CID=573 BUG=none TEST=none Review URL: http://codereview.chromium.org/256019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27682 0039d316-1c4b-4281-b951-d872f2087c98
* Tweak constants used by sync setup wizard unittest. Reviewed by nick.tim@chromium.org2009-09-301-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27677 0039d316-1c4b-4281-b951-d872f2087c98
* Look for sync_password under %USERPROFILE% in addition to alongside the script,tim@chromium.org2009-09-301-398/+404
| | | | | | | | | | | under src/. TEST=TwoClientLiveBookmarksSyncTest BUG=23478 Review URL: http://codereview.chromium.org/242085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27667 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Implement popup favicon menu.estade@chromium.org2009-09-306-69/+154
| | | | | | | | BUG=18181 Review URL: http://codereview.chromium.org/244029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27666 0039d316-1c4b-4281-b951-d872f2087c98
* Stops the throbber from spinning if the user cancels a beforeunload dialog,creis@google.com2009-09-303-0/+37
| | | | | | | | | | | if the dialog is triggered by a reload or location bar entry. BUG=22004 TEST=BrowserTest.ReloadThenCancelBeforeUnload Review URL: http://codereview.chromium.org/256015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27663 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: tips_cache_->GetSize() returns an unsigned int so the comparison ↵jhawkins@chromium.org2009-09-301-1/+3
| | | | | | | | | | | >= 0 is always true. Change the check to != 0 to actually have an effect. CID=6044 BUG=none TEST=none Review URL: http://codereview.chromium.org/255030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27662 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Rewrite and renable a badly-written unittest.rohitrao@chromium.org2009-09-301-59/+37
| | | | | | | | BUG=None TEST=Test should pass. Review URL: http://codereview.chromium.org/255029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27661 0039d316-1c4b-4281-b951-d872f2087c98
* Remove IdleTimer, which no one uses.pkasting@chromium.org2009-09-301-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/244049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27658 0039d316-1c4b-4281-b951-d872f2087c98
* Make the cache columns in the Task Manager sortable and only displayed once ↵pkasting@chromium.org2009-09-303-2/+45
| | | | | | | | | | per process on GTK and Mac, just like was already done on Windows. BUG=16221 TEST=Open Task Manager on GTK or Mac, add a WebCore Cache column, see that it only prints one line of output per process, and verify it's sortable. Review URL: http://codereview.chromium.org/251046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27657 0039d316-1c4b-4281-b951-d872f2087c98
* Make browser actions highlight on mouseover using theme colors.aa@chromium.org2009-09-302-18/+17
| | | | | | | | | | | | Also, adjust layout a bit to allow for larger icons. BUG=23363,23377 TEST=Install an extension that has a browser action. It should highlight on rollover. Review URL: http://codereview.chromium.org/246051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27654 0039d316-1c4b-4281-b951-d872f2087c98
* Landing patch from contributor Thiago Farina.finnur@chromium.org2009-09-309-13/+12
| | | | | | | | | | | Update GetDownloadDirectory to take FilePath instead of wstring to avoid conversions "To and From wstring". BUG=None TEST=run ui_tests.exe Review URL: http://codereview.chromium.org/243047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27653 0039d316-1c4b-4281-b951-d872f2087c98
* Remove all MemoryModel-related code, since we're unlikely to use it again. ↵pkasting@chromium.org2009-09-3012-127/+5
| | | | | | | | | | | | Also changes some sample code to use a random generic name ("PruningAlgorithm") instead of MemoryModel in hopes that no one will be confused. This does not remove IdleTimer, even though it now has no users. I do plan to remove it, but I want to do that in a separate commit so it's easy to reference and revert if at some later point we want this functionality. BUG=none TEST=none Review URL: http://codereview.chromium.org/242079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27652 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Make the "Get themes" button in Preferences a link (again)rsesek@chromium.org2009-09-302-15/+27
| | | | | | | | | BUG=21414 TEST=Preferences-->Personal Stuff, "Get themes..." is a hyperlink. Review URL: http://codereview.chromium.org/244047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27649 0039d316-1c4b-4281-b951-d872f2087c98
* Add an optional WebFrame parameter to WebView::findFrameByName.darin@chromium.org2009-09-303-0/+37
| | | | | | | | | | | | | This parameter is used to support _self and other names that need to be evaluated relative to a subframe. R=jam BUG=23009 TEST=none Review URL: http://codereview.chromium.org/257005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27646 0039d316-1c4b-4281-b951-d872f2087c98
* Page Info Windowthomasvl@chromium.org2009-09-303-51/+190
| | | | | | | | | | | | | | | | - Localize title - Localize button - Autosize button to text - Localize headings - Fetch the page info good/bad images from the resource bundle Stop including the page info good/bad images in the app bundle. TEST=Page Info dialog is localized and the button isn't clipped. BUG=20230 BUG=20536 Review URL: http://codereview.chromium.org/246048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27641 0039d316-1c4b-4281-b951-d872f2087c98
* Added command line argument --enable-webgl to facilitate turning onkbr@google.com2009-09-304-1/+10
| | | | | | | | | | | | ENABLE_3D_CANVAS in development builds. Currently this argument also requires disabling the sandbox. BUG=http://crbug.com/21852 TEST=none (runs preexisting WebGL layout tests; more coming) Review URL: http://codereview.chromium.org/246042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27637 0039d316-1c4b-4281-b951-d872f2087c98
* Make it possible to sort the WebCore Cache size columns in the Task Manager. ↵pkasting@chromium.org2009-09-305-69/+65
| | | | | | | | | | Also only show cache sizes once per process since the WebCore Cahce is a singleton within the renderer process. BUG=16221 TEST=none Review URL: http://codereview.chromium.org/244041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27636 0039d316-1c4b-4281-b951-d872f2087c98
* Enable <video> using cachehclam@chromium.org2009-09-302-0/+5
| | | | | | | | | | | | Retrying the following two patches: http://codereview.chromium.org/253001/show http://codereview.chromium.org/248012/show TBR=scherkus Review URL: http://codereview.chromium.org/242073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27632 0039d316-1c4b-4281-b951-d872f2087c98
* Make moles work for --show-extensions-on-top.sidchat@chromium.org2009-09-301-5/+8
| | | | | | | | BUG=www.crbug.com/21271 TEST=none Review URL: http://codereview.chromium.org/249033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27630 0039d316-1c4b-4281-b951-d872f2087c98
* PGO build other changecpu@chromium.org2009-09-301-0/+7
| | | | | | | | | | | | | | | | - I am not pursuing the 'another sln target' approach. PGO will happen as an option of a release build. This change is to fix an build error because the theme dll does not contain code so it is an error to pass optimization flags. So we override it for that project. BUG=21932 TEST=none Review URL: http://codereview.chromium.org/248039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27626 0039d316-1c4b-4281-b951-d872f2087c98
* Change disk access on theme install from UI to File thread.mirandac@chromium.org2009-09-302-61/+121
| | | | | | | | | | | BUG= http://crbug.com/17696 TEST= none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27520 Review URL: http://codereview.chromium.org/222025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27625 0039d316-1c4b-4281-b951-d872f2087c98
* Moving the work done in WinMain to another method called explictly,jcampan@chromium.org2009-09-302-21/+34
| | | | | | | | | | | as WinMain hold the loader lock and may be causing dead-locks. BUG=None TEST=Run the browser tests. R=darin Review URL: http://codereview.chromium.org/242067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27624 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bad Crash signature in known list.huanr@chromium.org2009-09-301-4/+3
| | | | | | Review URL: http://codereview.chromium.org/242077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27622 0039d316-1c4b-4281-b951-d872f2087c98