summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Revert 74451 - Add autocomplete provider for "about:" URLs. Original patch ↵pkasting@chromium.org2011-02-107-152/+18
| | | | | | | | | | | | by simonmorris@chromium.org (see http://codereview.chromium.org/6246016/ ), r=me. BUG=6870 TEST=Typing "about:s" into the omnibox should result in a couple of "about:s..." URL entries in the dropdown even if you've never visited them. TBR=pkasting@chromium.org Review URL: http://codereview.chromium.org/6485004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74454 0039d316-1c4b-4281-b951-d872f2087c98
* Add autocomplete provider for "about:" URLs. Original patch by ↵pkasting@chromium.org2011-02-107-18/+152
| | | | | | | | | simonmorris@chromium.org (see http://codereview.chromium.org/6246016/ ), r=me. BUG=6870 TEST=Typing "about:s" into the omnibox should result in a couple of "about:s..." URL entries in the dropdown even if you've never visited them. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74451 0039d316-1c4b-4281-b951-d872f2087c98
* Declare DOMStorageMessageFilter::OnDestruct() const.bauerb@chromium.org2011-02-102-2/+2
| | | | | | | | BUG=72424 TEST=no clange error TBR=thakis git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74448 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a leak. Remove suppression for the leak and update bug number for ↵pkasting@chromium.org2011-02-101-2/+1
| | | | | | | | | | unrelated suppression. BUG=72288,72547 TEST=none Review URL: http://codereview.chromium.org/6478011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74447 0039d316-1c4b-4281-b951-d872f2087c98
* Marks SessionRestoreTest as flaky. I'm close to fixing the cause of the flake,sky@chromium.org2011-02-101-8/+3
| | | | | | | | | | | | but until then I'm marking as flaky. BUG=52022 TEST=none TBR=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/6486001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74446 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup:pkasting@chromium.org2011-02-101-101/+163
| | | | | | | | | | | | | | | | * Add a predicate function for checking infobar request equality and use it several places * Make use of the PendingInfoBarRequests typedef where possible * Remove some unhelpful comments * De-inline PendingInfoBarRequest and add a constructor for caller brevity * Add UI-thread sanity checks to the rest of the GeolocationInfoBarQueueController public API functions * Remove some dupe-checking code in CreateInfoBarRequest() that should be obsolete * Reorder and reformat some code so that my upcoming functional changes will minimally differ BUG=none TEST=none Review URL: http://codereview.chromium.org/6483008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74445 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 667.0 to 668.0chrome-release@google.com2011-02-101-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74444 0039d316-1c4b-4281-b951-d872f2087c98
* Hoist some similar code from Before/AfterTranslateInfoBar up to ↵pkasting@chromium.org2011-02-106-53/+34
| | | | | | | | | | TranslateInfoBarBase. Along the way, remove the ClearMaxTextSize() calls; it seems to me that leaving the button size alone when changing from a longer language name to a shorter one is better (and apparently whoever made that the default behavior for Menu and TextButtons agrees). BUG=none TEST=none Review URL: http://codereview.chromium.org/6480017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74442 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Let RWHVMac::GetViewBounds() return screen coordinates like on linux ↵thakis@chromium.org2011-02-108-57/+74
| | | | | | | | | | | | | | | | | and windows. Now the behavior matches the comment in rwhv.h Since the new behavior matches the old (mac-only) GetWindowRect() function, delete it. Introduces a new function that returns the bounds in the cocoa sense, and update one the one calling side that needs it to use this. BUG=71368 TEST=Open chrome at ui scale of 2, make sure extension popups look broken in the same way as before this patch. Make sure the web still looks like it did before (pixel-scaled). Review URL: http://codereview.chromium.org/6463012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74441 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Fix warnings in nib filesthakis@chromium.org2011-02-1057-1195/+21739
| | | | | | | | | | | | | | | | | | | | | | | With all this file moving, many nib files had outdated paths in them. I did: 1. A build of the "chrome" target 2. |open chrome/app/nibs/*.xib| 3. Wait for the communication between XCode and IB to cease 4. Hit Cmd-S Cmd-W for every nib window This was with xcode 3.2.5 on OS X 10.6 57 files changed, 21802 insertions(+), 1258 deletions(-) No intended behavior change. BUG=none TEST=none Review URL: http://codereview.chromium.org/6476021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74440 0039d316-1c4b-4281-b951-d872f2087c98
* Remove failed attempt at overriding a functionthakis@chromium.org2011-02-102-5/+5
| | | | | | | | | BUG=72148 TEST=none Review URL: http://codereview.chromium.org/6480024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74437 0039d316-1c4b-4281-b951-d872f2087c98
* Adapt a function in ProfileSyncServiceMock to again match the parent class's ↵thakis@chromium.org2011-02-101-2/+3
| | | | | | | | | | | signature. BUG=72154 TEST=none Review URL: http://codereview.chromium.org/6480026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74436 0039d316-1c4b-4281-b951-d872f2087c98
* Only invoke WebKit methods in browsing data helpers on the WEBKIT thread.jochen@chromium.org2011-02-1014-380/+572
| | | | | | | | | BUG=71786 TEST=browser & unit tests Review URL: http://codereview.chromium.org/6246105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74433 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 3 at: Splits ChromeURLDataManager into 2 chunks:sky@chromium.org2011-02-1060-854/+857
| | | | | | | | | | | | | | | | | | | | | | | | | | | | . ChromeURLDataManager is no longer a singleton and is always used on the UI thread. ChromeURLDataManager is now profile specific (you get from the profile). . ChromeURLDataManagerBackend handles the URLRequests and the DataSources. ChromeURLDataManagerBackend is created by ChromeURLRequestContext. All DataSources are now profile specific. There were two that wanted to be global, but have been converted. This differs from the last version in that DataSource::SendResponse does nothing if the DataSource is schedule for deletion. This is necessary otherwise SendResponse will up the ref count and by the time the request is processed on the IO thread chances are the DataSource will have been deleted. And if it wasn't deleted, it'll get scheduled for deletion again. <insert comment here about the perils of using delayed deletion> This has always been possible, it just appears to be more likely with my patch. BUG=52022 71868 TEST=none Review URL: http://codereview.chromium.org/6479007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74432 0039d316-1c4b-4281-b951-d872f2087c98
* Destroy DOMStorageMessageFilter on the IO thread.bauerb@chromium.org2011-02-102-1/+7
| | | | | | | | | BUG=72424 TEST=no DCHECK, see bug Review URL: http://codereview.chromium.org/6460039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74431 0039d316-1c4b-4281-b951-d872f2087c98
* Add metrics for omnibox Google searches that has no RLZ token for windows.pastarmovj@chromium.org2011-02-104-1/+38
| | | | | | | | | | | | | This metric will give us idea whether we need to take further measures to close the short gap between the time the RLZ token is first cached and later used to perform searches. BUG=71548 TEST=Manual. Review URL: http://codereview.chromium.org/6465020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74430 0039d316-1c4b-4281-b951-d872f2087c98
* Restore old title in WebViewPlugin only when loading the plugin.bauerb@chromium.org2011-02-101-0/+1
| | | | | | | | | BUG=72437 TEST=see bug for manual test Review URL: http://codereview.chromium.org/6476006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74428 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Show a tooltip for the location icon in the omnibox.tfarina@chromium.org2011-02-102-0/+6
| | | | | | | | | BUG=41073 TEST=launch chrome, hover the location icon, a tooltip with "View site information" should appears. Review URL: http://codereview.chromium.org/6463024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74426 0039d316-1c4b-4281-b951-d872f2087c98
* Stops throbber when hiding animation is about to start.altimofeev@chromium.org2011-02-106-28/+18
| | | | | | | | | | | | Also fixes possible problem with white rectangle blinking when spinner window is shown. BUG=chromium-os:7919 TEST=manual Review URL: http://codereview.chromium.org/6452005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74425 0039d316-1c4b-4281-b951-d872f2087c98
* Disable FormStructureBrowserTest.DataDrivenHeuristics for now.isherman@chromium.org2011-02-101-7/+8
| | | | | | | | | | | | Also fix the logging for more debugging tomorrow. BUG=none TEST=none TBR= dhollowa@chromium.org Review URL: http://codereview.chromium.org/6476026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74424 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 666.0 to 667.0chrome-release@google.com2011-02-101-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74419 0039d316-1c4b-4281-b951-d872f2087c98
* Add logging to FormStructureBrowserTest.DataDrivenHeuristicsisherman@chromium.org2011-02-101-1/+7
| | | | | | | | | | BUG=none TEST=none TBR= dhollowa@chromium.org Review URL: http://codereview.chromium.org/6480028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74417 0039d316-1c4b-4281-b951-d872f2087c98
* Set the hardware keyboard layout based on startup_manifest.json.satorux@chromium.org2011-02-105-2/+52
| | | | | | | | | | | | | For instance, if initial_locale in startup_manifest.json is set to "fr", we'll set up the hardware keyboard to French, and use it in the OOBE screen. BUG=chromium-os:10964 TEST=manually on the netbook. Confirm that French keyboard layout is enabled by default by putting startup_manifest.json with initial_locale set to "fr". Review URL: http://codereview.chromium.org/6463018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74416 0039d316-1c4b-4281-b951-d872f2087c98
* Do not try to update XKB layout and Preferences file unless they're really ↵yusukes@google.com2011-02-104-23/+24
| | | | | | | | | | | needed, in order to make input method switching light-weight. BUG=chromium-os:9206 TEST=manually Review URL: http://codereview.chromium.org/6459018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74413 0039d316-1c4b-4281-b951-d872f2087c98
* Hopefully fix FormStructureBrowserTest.DataDrivenHeuristics on 'Win' full ↵isherman@chromium.org2011-02-101-8/+2
| | | | | | | | | | | | | builder. This is the only functional difference that I can see between the previous version of the test and the current one. BUG=72401 TEST= Review URL: http://codereview.chromium.org/6478012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74412 0039d316-1c4b-4281-b951-d872f2087c98
* Convert GetHardwareInputMethodDescriptor to GetHardwareInputMethodId()satorux@chromium.org2011-02-106-14/+18
| | | | | | | | | | | | | We plan to save the hardware kayboard layout information as ID like "xkb:us::eng", hence the function to get the information should just return the ID, rather than a descriptor struct. BUG=chromium-os:10964 TEST=input methods work as before on the netbook Review URL: http://codereview.chromium.org/6465022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74410 0039d316-1c4b-4281-b951-d872f2087c98
* Migrate Event API methods to Google Style.ben@chromium.org2011-02-1057-229/+218
| | | | | | | | | | | | | | Re-landing, moving the bits Mac uses to ui/base/events.h BUG=72040 TEST=none TBR=sky Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74377 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74408 0039d316-1c4b-4281-b951-d872f2087c98
* Disable passwords management settings for gueststuartmorgan@chromium.org2011-02-102-4/+13
| | | | | | | | | | BUG=9075 TEST=Login as Guest, go to chrome://settings, Personal Stuff, Passwords, ensure all settings concerning saving passwords are disabled and never save passwords is selected. Review URL: http://codereview.chromium.org/6250199 Patch from Vsevolod Vlasov <vsevik@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74407 0039d316-1c4b-4281-b951-d872f2087c98
* Specify 'sans-serif' as a fallback font for newtab page apps.kochi@chromium.org2011-02-101-1/+1
| | | | | | | | | | | | Undesired font is rendered for Japanese if only Helvetica and Arial are specified. BUG=chromium-os:11863 TEST=manually see new tab page font (text for 'web store', specifically) Review URL: http://codereview.chromium.org/6349104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74404 0039d316-1c4b-4281-b951-d872f2087c98
* Don't include render_message_params.h from headers.jam@chromium.org2011-02-1010-22/+33
| | | | | | Review URL: http://codereview.chromium.org/6479002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74401 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 74315 to see if it fixes media_unittests - GPU blacklist reporting to ↵rvargas@google.com2011-02-102-11/+0
| | | | | | | | | | | | | | | about:gpu page. BUG=71879 TEST= Review URL: http://codereview.chromium.org/6460016 Patch from John Bates <jbates@chromiu.org>. TBR=nduca@chromium.org Review URL: http://codereview.chromium.org/6476019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74398 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for potential crash in network_library (chromium-os:11861)stevenjb@google.com2011-02-101-2/+2
| | | | | | | | | BUG=chromium-os:11861 TEST=Test network menu Review URL: http://codereview.chromium.org/6465028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74397 0039d316-1c4b-4281-b951-d872f2087c98
* WebUI: Get rid of more references to DOMUI.tfarina@chromium.org2011-02-1032-72/+73
| | | | | | | | | BUG=59945 TEST=trybots Review URL: http://codereview.chromium.org/6478014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74395 0039d316-1c4b-4281-b951-d872f2087c98
* Importer: Don't check the |observer_| on the target thread, as it's possible tojhawkins@chromium.org2011-02-102-9/+20
| | | | | | | | | | | | race the removal of the observer with the check. Use a private flag instead until this hack can be removed. BUG=67174 TEST=none Review URL: http://codereview.chromium.org/6469017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74394 0039d316-1c4b-4281-b951-d872f2087c98
* Add instant tests for common file types.nirnimesh@chromium.org2011-02-102-0/+56
| | | | | | Review URL: http://codereview.chromium.org/6355012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74389 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix a chrome frame crash seen in the stable channel build ↵ananta@chromium.org2011-02-101-0/+4
| | | | | | | | | | | | | | | | | | 9.0.597.84. The crash occurs when the external tab container instance is being torn down which takes down the rootview which attempts to destroy child views leading to a crash while accessing a deleted focusmanager instance. Proposed fix is to destroy the root child views in the TAB_CONTENTS_DESTROYED notification which is sent out in the destructor of the TabContents object. BUG=72356 TEST=none Review URL: http://codereview.chromium.org/6463032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74388 0039d316-1c4b-4281-b951-d872f2087c98
* Fix flaky browser_tests incoming_queue_.empty() failuredavej@chromium.org2011-02-101-0/+13
| | | | | | | | | | | AudioMixerPulse was sometimes being destroyed while the Init call was still in it's worker thread's queue. If we see that Init hasn't been called yet, RunAllPending() is called to clear out the queue first. This is goes along with the previous fix, where we are trying to close the AudioHandler sooner in the shutdown process http://codereview.chromium.org/646500 BUG=chromium-os:11745 TEST=browser_tests should not fail with "check failed: incoming_queue_.empty()" Review URL: http://codereview.chromium.org/6476004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74387 0039d316-1c4b-4281-b951-d872f2087c98
* WebUI: Rename the class DOMUI to WebUI.tfarina@chromium.org2011-02-1071-303/+313
| | | | | | | | | | | | | Add a typedef for WebUI to allow us renaming the class now, and then renaming the other entries in small chunks. Also rename the file from dom_ui.[cc,h] to web_ui.[cc,h]. BUG=59945 TEST=trybots Review URL: http://codereview.chromium.org/6458016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74386 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 74340 - Attempt 2 at: Splits ChromeURLDataManager into 2 chunks:sky@chromium.org2011-02-1060-831/+856
| | | | | | | | | | | | | | | | | | | | | | | | | . ChromeURLDataManager is no longer a singleton and is always used on the UI thread. ChromeURLDataManager is now profile specific (you get from the profile). . ChromeURLDataManagerBackend handles the URLRequests and the DataSources. ChromeURLDataManagerBackend is created by ChromeURLRequestContext. All DataSources are now profile specific. There were two that wanted to be global, but have been converted. This differs from the version I landed in that there is now a NULL check in ChromeURLDataManager::DeleteDataSources. BUG=52022 71868 TEST=none TBR=willchan, evan, ahendrickson Review URL: http://codereview.chromium.org/6462036 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/6478010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74384 0039d316-1c4b-4281-b951-d872f2087c98
* Added an new argument to chrome.experimental.bookmarkManager.paste so that ↵mad@chromium.org2011-02-104-32/+99
| | | | | | | | | | we can insert the pasted bookmarks after the selection. BUG=49362 TEST=Make sure that pasting Bookmarks in the BookmarkManager view makes sense. Review URL: http://codereview.chromium.org/6460011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74383 0039d316-1c4b-4281-b951-d872f2087c98
* Don't remember pages that returned a 404 status code in our history.mad@chromium.org2011-02-101-1/+1
| | | | | | | | | BUG=18727 TEST=Make sure that we are properly recording all (and only) valid pages in our history. Review URL: http://codereview.chromium.org/6475001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74382 0039d316-1c4b-4281-b951-d872f2087c98
* Check for null child process in backgrounding of processdavemoore@chromium.org2011-02-091-1/+2
| | | | | | | | | | BUG=None TEST=None TBR=mbelshe Review URL: http://codereview.chromium.org/6469016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74380 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 74377 - Migrate Event API methods to Google Style.ben@chromium.org2011-02-0929-72/+76
| | | | | | | | | | | | BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6480001 TBR=ben@chromium.org Review URL: http://codereview.chromium.org/6469014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74379 0039d316-1c4b-4281-b951-d872f2087c98
* Migrate Event API methods to Google Style.ben@chromium.org2011-02-0929-76/+72
| | | | | | | | | BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6480001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74377 0039d316-1c4b-4281-b951-d872f2087c98
* views: Move more layout constants to the views namespace. Part 2.tfarina@chromium.org2011-02-0924-42/+51
| | | | | | | | | | | The other constants will be moved in future patches. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6458014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74372 0039d316-1c4b-4281-b951-d872f2087c98
* BUG=71824rohitbm@google.com2011-02-091-0/+1
| | | | | | Review URL: http://codereview.chromium.org/6483005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74364 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstring from RVH's run Javascript command.avi@chromium.org2011-02-0929-120/+145
| | | | | | | | | BUG=23581 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6458013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74362 0039d316-1c4b-4281-b951-d872f2087c98
* Add --show-composited-layer-borders to about:flags.amarinichev@google.com2011-02-092-0/+13
| | | | | | | | | | BUG=60196 TEST=enabled composited-layer-borders entry in about_flags.cc and checked layer borders appear/disappear accordingly. Review URL: http://codereview.chromium.org/6458020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74361 0039d316-1c4b-4281-b951-d872f2087c98
* Reorganized phone field parsing, fixing parsing for fax numbers in the ↵georgey@chromium.org2011-02-0912-211/+295
| | | | | | | | | | process - bug "Fax number is populated wrong" BUG=63736 TEST=Form in the bug + unit-tested. Review URL: http://codereview.chromium.org/6286127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74360 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of BaseTabStrip::GetPreferredHeightrjkroege@google.com2011-02-0910-22/+4
| | | | | | | | | | | | | | | | In an ongoing effort to simplify BaseTabStrip, I observed that GetPreferredHeight is an extra method of the BaseTabStrip base class that is only used to retrieve the height quantity of the GetPreferredSize. GetPreferredSize is a View method, so I changed the callers to call GetPreferredSize().height() instead and removed this method. In a subsequent CL, I plan to refactor so that the frames can interface to view::Views::GetPreferredSize instead of BaseTabStrip::GetPreferredHeight, thus generalizing the interface and reducing dependency on BaseTabStrip and its design. This first step just cleans up BaseTabStrip. The next CL will simplify the frame views. BUG=None TEST=None Review URL: http://codereview.chromium.org/6312196 Patch from Chad Faragher <wyck@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74356 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 07:13:20 +0000