| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bookmark bar menu/folder maximum window width is now 1000, not 150.
High cosmetic impact.
BUG=36487, 17608
TEST=\
1) Add bookmarks on the bar with small (e.g. 'x') and big titles.
Make sure all looks OK (e.g. small ones are small.)
2) Add bookmarks in a folder.
Make sure text is left aligned on the menus.
3) Add bookmarks in a folder with long names (e.g. 100 characters).
Make sure folder/menus are now much wider.
4) Add bookmarks in a folder with mega long names (e.g. 4000 characters).
Make sure menus have a maximum size of ~1000 pixes (no need to be exact but 'no limit' is fail).
5) In a folder, add a subfolder named 'x' and a bookmark with a REAL long name.
Make sure the "button" (menu item) is the full width of the menu.
Review URL: http://codereview.chromium.org/842005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
window.
BUG=38008
TEST=Press Ctrl+Shift+B when in an incognito window
Review URL: http://codereview.chromium.org/909001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/905001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
algorithm, and for non-Windows, modifies sizing algorithm to just make the icon size be the same as the titlebar font size, minimum 16 px, since the old crazy code just seemed wrong.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/807001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
run successfully.
BUG=36601
TEST=none
Review URL: http://codereview.chromium.org/873005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=23086
TEST=see bug
Review URL: http://codereview.chromium.org/682001
Patch from Thiago Farina <thiago.farina@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Future changes will hook up extension APIs and add testing.
BUG=27247
Review URL: http://codereview.chromium.org/868001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/877002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
dialog. Making the Close button the default focused view.
BUG=33942
TEST=Open the "Clear browsing data" dialog. The close
button should be focused.
Review URL: http://codereview.chromium.org/778004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=37807
TEST=\
Run a debug build of Chrome like this:
NSZombieEnabled=YES xcodebuild/Debug/Chromium.app/Contents/MacOS/Chromium
Open a bubble then Cmd-Q.
Make sure you don't see a line like this:
2010-03-10 19:24:20.381 Chromium[73024:903] *** -[ChromeBrowserWindow removeChildWindow:]: message sent to deallocated instance 0x18f8b2a0
Repeat 20 times.
Review URL: http://codereview.chromium.org/851005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Resize smartly after dragging (animate to the "right" size)
- Add the overflow menu (it is clickable, but you can't drag to/from it)
- Resize appropriately after adding/removing buttons
still TODO:
- persist the #icons that are visible
BUG=32101
TEST=manual
Review URL: http://codereview.chromium.org/897001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=On Linux, "chrome --enable-logging --user-data-dir=/tmp/foobar" writes renderer logs to chrome_debug.log in /tmp/foobar rather than in $XDG_CONFIG_HOME.
Review URL: http://codereview.chromium.org/885003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
notification permission is loaded.
Review URL: http://codereview.chromium.org/842002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
names. This is a stop-gap until a fix is made for WebKit. Add another variation of middle initial.
BUG=37988
TEST=See repro steps in the bug.
Review URL: http://codereview.chromium.org/904001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is the Mac part of issue 826002.
BUG=37372
TEST=Start chrome with --enable-tabbed-bookmark-manage and open the BMM from the app menu, as well as bookmark bar context menu etc. All entries should take you to the tabbed bookmark manager.
Review URL: http://codereview.chromium.org/871003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Create the "off the side" menu on demand (since that has "all the rest" in it).
BUG= http://crbug.com/32843
TEST=1) Do the "sync 1000+ bookmarks" test from the bug and watch Chrome NOT run out of memory.
Make sure these bookmarks are all children of the bar for it to be even harder.
2) Add about 5 bookmarks. Make sure you can grow and shrink (in
width) the window to cause the off-the-side chevron to appear and
disappear as appropriate, and that the off-the-side menu always has
the right contents (bookmarks which fall off the side).
3) Change theme then relaunch; make sure theme set on launch for bookmarks.
4) Using both a big and a small width, make sure the chevron shows (or
not, as appropriate) on launch of Chrome.
Review URL: http://codereview.chromium.org/853001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
was including files from chrome and only used in
chrome/browser/renderer_host, so it should live in src/chrome/.
TEST=compiles
Review URL: http://codereview.chromium.org/852001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Browser::ShowBookmarkManager.
This covers views and gtk.
BUG=37372
TEST=None
Review URL: http://codereview.chromium.org/826002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
translate info-bar for all supported languages, as they
are reported by the CLD.
BUG=None
TEST=Run the unit-test.
Review URL: http://codereview.chromium.org/856001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/37807
TEST=\
Run a debug build of Chrome like this:
NSZombieEnabled=YES xcodebuild/Debug/Chromium.app/Contents/MacOS/Chromium
Open a bubble then CmdQ.
Make sure you don't see a line like this:
20100310 19:24:20.381 Chromium[73024:903] *** [ChromeBrowserWindow removeChildWindow:]: message sent to deallocated instance 0x18f8b2a0
Repeat 20 times.
Review URL: http://codereview.chromium.org/839003
TBR=jrg@chromium.org
Review URL: http://codereview.chromium.org/902001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28176
TEST=this change
Review URL: http://codereview.chromium.org/791002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/883002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/847003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=37717
TEST=none
Review URL: http://codereview.chromium.org/863005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
First, size calculations for multi-line, character-breaking strings with no prespecified width were returning useless values, and when given pathological input, could take extremely long time.
Second, the flag calculations for text layout were a bit odd. For example, we wouldn't add an ending ellipsis on elided text if it was multi-line, and we wouldn't add an ellipsis on a clipped word if character breaking was off. Fixed these and reordered the calculations to match the order in which the header declares the flags.
Third, message boxes shouldn't need to trim their inputs, or add an ellipsis character, as both of these should now be handled safely by the underlying code.
BUG=34721
TEST=alert("AAAAA") for strings of As that are, say, 4000 characters long should not cause the UI to hang up for noticeable lengths of time
Review URL: http://codereview.chromium.org/810003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/37807
TEST=\
Run a debug build of Chrome like this:
NSZombieEnabled=YES xcodebuild/Debug/Chromium.app/Contents/MacOS/Chromium
Open a bubble then Cmd-Q.
Make sure you don't see a line like this:
2010-03-10 19:24:20.381 Chromium[73024:903] *** -[ChromeBrowserWindow removeChildWindow:]: message sent to deallocated instance 0x18f8b2a0
Repeat 20 times.
Review URL: http://codereview.chromium.org/839003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/856003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=37967
TEST=\
1) make sure bookmark buttons still work (click to open)
2) make sure basic DnD of bookmark buttons still works
3) In Debug build, drag a bookmark button. ESC to cancel. Then mouse up.
Make sure no crash.
Review URL: http://codereview.chromium.org/871002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41340 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is enabled.
From http://developer.apple.com/mac/library/DOCUMENTATION/UserExperience/Conceptual/HiDPIOverview/HiDPISupport/HiDPISupport.html:
"Because of scaling, the coordinates of the window frame and its top-level view (the frame view) are not always the same. [...] These methods provide the means to transform geometry to and from a base coordinate space that is pixel-aligned with the backing store into which the view is being drawn."
Stuff is still pretty broken with this patch (it used to be better), but it's a low-hanging fruit.
BUG=19476
TEST=Open QuartzDebug, set scale factor to e.g. 1.5. Reopen Chrome. Tabs should be visible.
Review URL: http://codereview.chromium.org/893001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
mainichi.jp (from an English profile).
BUG=36714,37528
TEST=Open up a page that's not in your current language. You should be presented with a toolbar offering to apply Google Translate to the page.
Review URL: http://codereview.chromium.org/830005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a number of form field parsing issues. Ecml field name matching. Adds country field parsing. Adds state field parsing. Multi-line address parsing. Fixes issue with empty field names confusing the parser. Fixes issue with phone field parsing. Adds unit tests in form_structure_unittest.cc to verify parsing order issues. Adds new unit tests address_field_unittest.cc that cover parsing of each address component as well as Ecml variants.
BUG=37776
TEST=FormStructureTest.Heuristics:AddressFieldTest.*, as well as manual steps described in bug report.
Review URL: http://codereview.chromium.org/867003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
moved or resized. This is used to close the AutoFill popup in the renderer.
BUG=31865
TEST=none
TBR=jhawkins@chromium.org
Review URL: http://codereview.chromium.org/878003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
moved or resized if the window has actually moved or resized. This fixes a ~20ms startup performance regression.
BUG=37975
TEST=none
TBR=jhawkins@chromium.org
Review URL: http://codereview.chromium.org/868002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=37989
TEST=Go fullscreen on a secondary monitor. Should not hide the menubar.
Review URL: http://codereview.chromium.org/872003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=19370
TEST=None
Review URL: http://codereview.chromium.org/755002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the browser's print workflow. For now, added an interface for raster print output.
Also modified vector_platform_device_win.cc to allow the caller to set a bitmap compression mode for use in the internalDrawBitmap method. Supported compression modes are JPEG and PNG.
BUG=none
TEST=Test printing with new plugins that support this interface.
Review URL: http://codereview.chromium.org/669280
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=37797
TEST=See test cases in bug.
Review URL: http://codereview.chromium.org/801008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
resized if the window has actually moved or resized. This fixes a ~20ms startup performance regression.
BUG=37975
TEST=none
Review URL: http://codereview.chromium.org/844004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
we should have been passing longs.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/879002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=37950
TEST=none
Review URL: http://codereview.chromium.org/837006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=trybots
Review URL: http://codereview.chromium.org/859003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32012
TEST=Once CA plugins are enabled, they should display immediately, without having to resize or scroll the window.
Review URL: http://codereview.chromium.org/854004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ToolbarController's) so we stop violating the ODR and things start working properly.
BUG=http://crbug.com/37898
TEST=as in bug
Review URL: http://codereview.chromium.org/887002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TODO: persist the size of the browser actions container to the profile.
TODO: implement the overflow menu.
BUG=32101
TEST=manual
Review URL: http://codereview.chromium.org/800003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Updates NavigationController so that the back and forward menus can
be used while an interstitial page is showing. Also fixes tab cloning
while an interstitial page is showing, so that the cloned tab does not
have the interstitial navigation entry.
BUG=37215
BUG=37894
TEST=SSLUITest.TestHTTPSExpiredCertAndGo{Back,Forward}
TEST=NavigationControllerTest.CloneOmitsInterstitials
Review URL: http://codereview.chromium.org/861001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
fix "may be used uninitialized" error
BUG=NONE
TEST=buildbot compiles
TBR=finnur
Review URL: http://codereview.chromium.org/880002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=everything still works
Review URL: http://codereview.chromium.org/793003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=33032
TEST=none
Review URL: http://codereview.chromium.org/815004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
as downloads and history.
BUG=37371,4890
TEST=Open three tabs, History, Downloads and Bookmarks. Ctrl+tab between them and notice how the section icon, input and button all stay in the same position.
Review URL: http://codereview.chromium.org/837003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/830002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41292 0039d316-1c4b-4281-b951-d872f2087c98
|