| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
network stack. The host network
stack in ChromeFrame intercepts HTTP requests based on registered render views. When a popup window is created
we register it in the AddNewContents notification on the TabContentsDelegate. This is a little late as network
requests could be issued before the view actually becomes visible.
To fix this we now have a new method in the TabContentsDelegate interface called TabContentsCreated which
notifies the delegate about the creation of a new TabContents. The ExternalTabContainer implements this
method and registers the render view as pending. I also changed the signature of the
RenderViewHostDelegateViewHelper::CreateNewWindow method to return the new TabContents.
As part of this fix we also unregister the render view when the ExternalTabContainer is deleted. The
container registers for the NotificationType::RENDER_VIEW_HOST_DELETED notification. However we end up
deleting the TabContents in WM_DESTROY, which results in the container never receiving this notification.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=36323
Bug=36323
Test=Will be covered by the automation proxy test which Stoyan is adding
Review URL: http://codereview.chromium.org/652009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I thought this would be a small job but I pulled the thread
and it kept coming. :(
BUG=24672
Review URL: http://codereview.chromium.org/650034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
WmIpc.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/646079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
xib changes: Added a tab view with all the UI, set up bindings for radio groups and checkboxes. Hooked up buttons.
Missing for now:
* "Exception" dialogs ("exception" buttons are disabled until then)
* Some polish
* The cookie "ask" dialog
BUG=34894
TEST=Open content settings dialog. Set different things, click various things, and make sure they all have the expected effect.
Review URL: http://codereview.chromium.org/652037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles on bots
Review URL: http://codereview.chromium.org/619008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds a menu item "Force Reload This Page" with keyboard shortcut Command-Shift-R to the View menu in MainMenu.xib as an alternative, meaning it is shown instead of "Reload This Page" when the shift key is held down.
BUG=36245
TEST=Open the view menu. Pressing shift should change "reload this page" into
"force reload this page", which should do what it says. Also, Command-Shift-R
should do the same thing. Astronomy picture of the day is a good test site for
this.
Review URL: http://codereview.chromium.org/651040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a temporary workaround. We'll implement better options page
for input languages.
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/652036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also introduce scaffolding for the actual content settings dialog.
xib changes:
+ Personal stuff
* Move "Clear browsing data" button to under the hood tab
* Move themes stuff up a bit to cover hole left by missing button
+ under the hood:
* Created "Content Settings..." button
* Got rid of cookie settings
* Moved stuff around
+ clear data:
* Added horizontal rule and flash player settings link, linked its action to
new method.
+ content settings:
* Added mostly empty window that contains "This is not implemented yet" label and a button that shows cookies (since I removed that from the prefs, so that it's still available). This window will be fleshed out very soon (in my next CL).
* The window _is_ set up for l10n
+ bubble xibs:
* Enable "Manage" links now that they open a window
Four screenshots at http://imgur.com/axGiR&78O8g&wgk3p&6oOHj
BUG=34656,34894
TEST="Clear data" button has moved from "Personal Stuff" to "Under the hood" in prefs. There's a "Content Settings" button next to it that opens a mostly empty window. The "Clear data" dialog now has a link to flash's privacy settings (which hang if one has the AdThwart extension installed, heh).
Review URL: http://codereview.chromium.org/650124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
best guess is that the size we're trying to restore is bigger
than the current monitor causing the window to be sized to the
monitor, triggering the fullscreen behavior.
BUG=31199
Review URL: http://codereview.chromium.org/651018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Two screenshots at http://imgur.com/5NDoC&pJJwP .
xib changes: All 5 xibs contain a window of type InfoBubbleWindow with a custom InfoBubbleView. The view is connected to the controller's |bubble_| outlet. The controller is the window's |delegate|, and the window is the controller's |window|. The window is not visible at launch. It autorecalculates its key view loop. For the non-cookie xibs, the two buttons at the bottom are in GTMWidthBasedTweakers.
Issues:
* Clicking "blocked" icon with open bubble doesn't close the bubble
BUG=35594,34894
TEST=Go to popuptest.com, start test. Click "Popups blocked" icon in omnibox. Bubble should appear. It should look sane in multiple locales (I tried English and German). The left button and the radio buttons are disabled at the moment, but the close button and the popup links should be functional.
Review URL: http://codereview.chromium.org/650073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
... and use an existing window rather than create a new one. Also, when a dialog
box (e.g., Preferences, Bookmark Manager, etc.) is active, those commands should
activate an existing window (if one exists) instead of always creating a new
window.
The complete list of commands which should activate a miniaturized window if
possible (otherwise create a new window):
- File->New Tab (Cmd-T)
- File->Open Location... (Cmd-L)
- Edit->Find->Search the Web... (Opt-Cmd-F)
- History->History (Cmd-Y)
- Window->Downloads (Shift-Cmd-J)
- Window->Extensions
- Help->Chromium/Google Chrome Help
For now, I'm letting File->Open File... (Cmd-O) always create a new window,
which is consistent with Safari.
BUG=21434
TEST=Close all windows; try one of the commands above (in commit message/CL description); a new window should be created and the command should work; this is all as before this CL. Create a window (if necessary) and minimize all browser windows; try one of the commands above; the last-active browser window should unminimize and the command should execute in that window.
Review URL: http://codereview.chromium.org/652018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
"clear cookie on exit" item wrap.
http://crbug.com/35118
TEST=none
Review URL: http://codereview.chromium.org/646059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=wtc
BUG=35670
TEST=none
Review URL: http://codereview.chromium.org/652020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also create necessary infrastructure to know the address
a client socket is connected to.
TEST=Covered by net_unittests.
BUG=35670
Review URL: http://codereview.chromium.org/598071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
make its decision. Before, it used the TabContents to get the profile to get the map, but this was incorrect because the current tab isn't necessarily from the same profile as the original request.
As long as we have the HostContentSettingsMap, we might as well handle "remember" in CookieModalDialog.
This bug exists in 4.1.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/651023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24494
TEST=Open Preferences... -> Basics -> Manage; Search Engines dialog box pops up; press Esc; Search Engines dialog box should close.
Review URL: http://codereview.chromium.org/650114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
instead of mouse down.
BUG=33155
TEST=Make sure right-click menus for Page Actions
still work. Then right-click a Page Action and
while the context menu is up, right click a
browser action/bookmark bar (the right menu should
show).
Review URL: http://codereview.chromium.org/650087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
duplicating it in multiple places.
Also rename that method to better reflect what it is used for.
BUG=35382
Review URL: http://codereview.chromium.org/650086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- pressing Ctrl+F5 or Shift+F5 or Ctrl+Shift+R
- Shift- or Ctrl-clicking the Reload button.
Should work on Windows and Chrome OS (including compact navigation mode).
BUG=36244
TEST=Verify that everything works as described above.
Review URL: http://codereview.chromium.org/650048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds the following methods to chrome.experimental.bookmarkManager:
startDrag(idList)
drop(parentId, opt_index)
as well as the following events:
onDragEnter(function(BookmarkDragData))
onDragLeave(function(BookmarkDragData))
onDrop(function(BookmarkDragData))
BUG=32194
TEST=None
Review URL: http://codereview.chromium.org/596105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=glen
BUG=35337
TEST=Block everything, all notification icons should be sans-blue-background.
Review URL: http://codereview.chromium.org/650101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39536 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WM_PAINT results in a call to Pepper repaint callback.
Implemented WM_ERASEBKGND to prevent flickering on repaint.
Implemented PGL_NO_CONTEXT (copied from EGL spec). This is already reviewed by alokp but unfortunately got entangled with this CL.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/571018
TBR=alokp@chromium.org
Review URL: http://codereview.chromium.org/650100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
sends the (name, label) key requested to fill out a specific field. The RenderView finds the form to AutoFill using the FormManager and requests the AutoFillManager to fill in the data for the form. At the end, the FormManager uses this data to fill out the fields in the form on the web page.
BUG=18201
TEST=none
Review URL: http://codereview.chromium.org/651002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=erikkay
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/651091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WM_PAINT results in a call to Pepper repaint callback.
Implemented WM_ERASEBKGND to prevent flickering on repaint.
Implemented PGL_NO_CONTEXT (copied from EGL spec). This is already reviewed by alokp but unfortunately got entangled with this CL.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/571018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
blocked image.
BUG=36021
TEST=Right-click a blocked image, "copy image" should be greyed out
Review URL: http://codereview.chromium.org/651075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
While investigating another bug, I tried changing the PostTask(CloseNow)
to a PostDelayedTask(CloseNow) in WidgetWin. This exposed a crash in the
cookie prompt if I clicked the Allow or Block buttons more than once.
R=sky
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/650067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
page cycler regression.
TBR=jam
BUG=36310
TEST=none
Review URL: http://codereview.chromium.org/650089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39518 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Added ability to change label font in gtk menu item.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/650074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
View::MirroredX is defined inline in the .cc, which apparently means
gcc won't export it for callers outside of view.cc.
Changes the rendering of mini-tabs slightly:
. the icons of mini-tabs scales up to 24x24 on mouse over.
. phantom tabs are rendered in their own layer behind other tabs at
40% opacity. The icon for phantom tabs are rendered at 60% opactiy.
BUG=32845
TEST=none
Review URL: http://codereview.chromium.org/650066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SafeBrowsingDatabaseBloom stores a integer prefix column and a blob
hash column, where the first four bytes of the hash are the prefix.
This isn't necessary, so getting rid of the duplication rather than
propagating it into the future.
[Previously this was left alone because it wasn't too harmful because
the code could always drop the duplication from the file format. A
future change for SafeBrowsingStoreFile will write an array of hashes,
making the duplication unavoidable.]
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/651057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Currently this information is in .../trunk/api_index.html.)
Also update the group URL in the header of the experimental
API pages.
My next set of commits will replace the experimental info
in api_index.html with a link to this page (at the URL
http://code.google.com/chrome/extensions/dev/experimental.html).
TBR=erikkay
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/650077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=33454
TEST=verify per bug report.
Review URL: http://codereview.chromium.org/650071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
its OnDestroy handler. Doing it
in the destructor as well causes DCHECKs to fire in the code path which checks if it is the innermost ExternalTab
for which we received a CloseContents notification and if not post the task back to be handled later. Posting
a task from the destructor causes the DCHECK as it tries to grab a ref on the object.
Part of the fix for http://code.google.com/p/chromium/issues/detail?id=35729
Bug=35279
Review URL: http://codereview.chromium.org/651051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DownloadShelfContextMenuGtk.
BUG=31365
TEST=manually
patch by Thiago Farina
original review at http://codereview.chromium.org/552251/show
Review URL: http://codereview.chromium.org/647059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change puts appversion at the same level as buildtime, and
so it is avalable (now) for use in histogram versioning, as well
as stability versioning (or user metrics versioning).
r=huanr
Review URL: http://codereview.chromium.org/650017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/570015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. the icons of minitabs scales up to 24x24 on mouse over.
. phantom tabs are rendered in their own layer behind other tabs at
40% opacity. The icon for phantom tabs are rendered at 60% opactiy.
BUG=32845
TEST=none
Review URL: http://codereview.chromium.org/646067
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/650062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. the icons of mini-tabs scales up to 24x24 on mouse over.
. phantom tabs are rendered in their own layer behind other tabs at
40% opacity. The icon for phantom tabs are rendered at 60% opactiy.
BUG=32845
TEST=none
Review URL: http://codereview.chromium.org/646067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
page (so use of the --host-resolver-rules flag doesn't limit features), and run through the Shutdown() method on exit.
This reworks the "IsHostResolverImpl()" hack to be a bit more general.
BUG=36053
Review URL: http://codereview.chromium.org/646003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=SxS install can run together with normal install.
BUG=35574
Review URL: http://codereview.chromium.org/639002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
are some pretty complicated rules, and this helps isolate that code and better test it.
This also lays a framework for addressing bug 9835 (IP/CIDR matching)
Lastly, adds support for the exclusion format ".domain" on all platforms, which is interpreted as "*.domain".
BUG=28112
TEST=ProxyBypassRulesTest.*
Review URL: http://codereview.chromium.org/601070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
showDebugBorders setting in WebKit which is
used for displaying a border around composited layers.
BUG=35613
TEST=NONE
Review URL: http://codereview.chromium.org/593099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=36273
TEST=Switch to fullscreen with the status bubble hidden, then mouseover a link. Status bubble should have the proper width.
Review URL: http://codereview.chromium.org/650050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
show its title.
Of course, many window managers don't show the title at all, don't let you control the size of the window, or will have window decorations that make this technique not work; so this is really only designed to work on gnome metacity/compiz.
BUG=35468
TEST=manual
Review URL: http://codereview.chromium.org/646047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=36109
TEST=Enter fullscreen mode. Make sure Cmd-M and Window->Minimize work. Also make sure fullscreen windows are restored properly.
Review URL: http://codereview.chromium.org/646005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=35178
TEST=none
Review URL: http://codereview.chromium.org/646060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39468 0039d316-1c4b-4281-b951-d872f2087c98
|