summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Speculatve fix for a chrome crash caused in a chrome frame instance while ↵ananta@chromium.org2010-02-231-4/+9
| | | | | | | | | | | | | | | | | | | processing an automation message to focus through an external tab. Based on the crash dump, it appears that the tab_contents_ member is destroyed and set to NULL in the context of a call to TabContents::Focus which calls the Windows API SetFocus on the native HWND, which could dispatch messages like WM_DESTROY for the external tab. Fix is to add a second NULL check for tab_contents_ after the call to TabContents::Focus. Added a comment describing this scenario in the code. Fixes bug http://code.google.com/p/chromium/issues/detail?id=29246 Bug=29246 Review URL: http://codereview.chromium.org/653005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39757 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Cookie confirmation dialog.thakis@chromium.org2010-02-237-9/+157
| | | | | | | | | | | This is not the final UI (the "more info" disclosure triangle is missing), but it's pretty close and, more importantly, functional. BUG=34894 TEST=Go to Preferences->under the hood->content settings->cookies and select "ask me every time". Then browser around and note that a message box pops up all the time. All the buttons on the message box should do what they claim. Review URL: http://codereview.chromium.org/650206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39756 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the --enable-new-autofill switch. This enables the AutoFillManager ↵jhawkins@chromium.org2010-02-236-20/+25
| | | | | | | | | | to show the infobar asking the user to enable/disable AutoFill++. BUG=18201 TEST=none Review URL: http://codereview.chromium.org/650169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39755 0039d316-1c4b-4281-b951-d872f2087c98
* Add '-ldl' to Linux targets that use dynamic loader functions.mmoss@google.com2010-02-231-0/+6
| | | | | | | | | | | | | This fixes compilation errors on Karmic, where dlopen() and friends were undefined: http://chrome-buildbot.corp.google.com:8016/builders/Chromium%20Linux%20Builder%20(dbg-shlib)/builds/7777/steps/compile/logs/stdio The missing '-ldl' is papered over on Hardy because pretty much everything depends on gtk, which brings that in through pkg-config, but pkg-config gtk no longer includes '-ldl' on Karmic. Review URL: http://codereview.chromium.org/656014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39754 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when 2 extension uninstall dialogs were open and then confirmed.mpcomplete@chromium.org2010-02-231-1/+7
| | | | | | | | BUG=36456 Review URL: http://codereview.chromium.org/656010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39753 0039d316-1c4b-4281-b951-d872f2087c98
* Change find bar close button to use the standard hover close buttonfeldstein@chromium.org2010-02-231-34/+706
| | | | | | Review URL: http://codereview.chromium.org/652086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39750 0039d316-1c4b-4281-b951-d872f2087c98
* Another pass at removal of GTMTheme. Also fixes unreadability of bookmark ↵avi@chromium.org2010-02-2319-96/+146
| | | | | | | | | | | | bar/status bubble in unthemed incognito mode. BUG=http://crbug.com/35554 ; http://crbug.com/29845 TEST=no visible change in normal mode; themed incognito windows should look ugly still but in a different way Review URL: http://codereview.chromium.org/650092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39749 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark Manager: Set the direction and the font size based on the language.arv@chromium.org2010-02-232-6/+10
| | | | | | | | | BUG=36457 TEST=Change the language to Hebrew (for example) and notice the RTL UI. Review URL: http://codereview.chromium.org/652079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39748 0039d316-1c4b-4281-b951-d872f2087c98
* do not mention other browsers in about:memory for chromeoskuan@chromium.org2010-02-234-1/+10
| | | | | | | | | BUG=34839 TEST=verify per bug report Review URL: http://codereview.chromium.org/650161 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39746 0039d316-1c4b-4281-b951-d872f2087c98
* PyAuto: Fix some methods that assume that they're working on the first window.nirnimesh@chromium.org2010-02-235-62/+151
| | | | | | | | | | - Provide args to specifiy tab_index or window_index. - Re-order the methods to group by functionality, rather than from where they are implemented. Review URL: http://codereview.chromium.org/650106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39745 0039d316-1c4b-4281-b951-d872f2087c98
* Add 3D support for the Mac on Leopard (OS X 10.5) and earlier. This CL usesdspringer@google.com2010-02-2315-18/+194
| | | | | | | | | | | | | | | | | FBO rendering with glGetTexImage() into a TransportDIB that is then used as a texture for rendering the final image in the render view in the browser. While not optimal, it works and can be optimized later, after the new GPU process work is completed. This CL also enables stencil buffer support on the Mac. All the Pepper3D demos run on the Mac with these changes. BUG=none TEST=3D rendering unit tests. Review URL: http://codereview.chromium.org/647043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39744 0039d316-1c4b-4281-b951-d872f2087c98
* Fix mac builder bustageskrul@chromium.org2010-02-231-2/+2
| | | | | | Review URL: http://codereview.chromium.org/656003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39743 0039d316-1c4b-4281-b951-d872f2087c98
* Landing this patch on behalf of Mark Hahnenberg <mhahnenb(at)gmail.com>skrul@chromium.org2010-02-234-50/+230
| | | | | | | | | | | | | | Added a vector of Time objects to the AutofillEntry object for storingthe results retrieved from the date_created field of the autofill_datestable corresponding to the AutofillKey retrieved from the autofill table. Also modified the old GetAllAutofillEntries test to account for this newlystored data. BUG=35230 TEST=WebDatabaseTest.GetAllAutofillEntries Review URL: http://codereview.chromium.org/600070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39742 0039d316-1c4b-4281-b951-d872f2087c98
* Whitespace!mark@chromium.org2010-02-231-1/+4
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/652127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39740 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for more types of controls and events to GTK implementation ofdmazzoni@chromium.org2010-02-2327-111/+528
| | | | | | | | | | | | accessibility extension API. Enable accessibility API for all subdialogs of the main Options dialog. BUG=none TEST=none Review URL: http://codereview.chromium.org/651037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39738 0039d316-1c4b-4281-b951-d872f2087c98
* Mark WorkerTest.WorkerClonePort as flaky.phajdan.jr@chromium.org2010-02-231-2/+4
| | | | | | | | | | | | Also add a bug reference explaining why the test is disabled on Linux and Mac. TBR=dimich TEST=still flaky BUG=36555, 35965 Review URL: http://codereview.chromium.org/652123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39736 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some bugs discovered whilst making trial integration of geolocaiton ↵joth@chromium.org2010-02-235-88/+103
| | | | | | | | | | | pieces (http://codereview.chromium.org/650060/) & add tests for these cases. BUG=none TEST=GeolocationNetworkProviderTest.{NoRequestOnStartupUntilWifiData|NewDataReplacesExistingNetworkRequest} Review URL: http://codereview.chromium.org/652066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39734 0039d316-1c4b-4281-b951-d872f2087c98
* Notify when database access is blocked due to content settings.jochen@chromium.org2010-02-233-3/+24
| | | | | | | | | | | | | Note that this code relies on the fact that the render thread is blocked and waits for the database thread to open the database in order to get the routing id. BUG=36435 TEST=block all cookies, go to html5 database demo, icon should appear. Review URL: http://codereview.chromium.org/652113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39732 0039d316-1c4b-4281-b951-d872f2087c98
* Don't build NaCl's syscall handler into a shared libraryjochen@chromium.org2010-02-231-1/+4
| | | | | | | | | | | | Fixes shared library Chromium build on x86-64 on Linux. BUG=35829 TEST=build Review URL: http://codereview.chromium.org/652109 Patch from mseaborn@. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39729 0039d316-1c4b-4281-b951-d872f2087c98
* Revert back to using Send for now.darin@chromium.org2010-02-231-6/+4
| | | | | | | | | | | | | Sadly, my attempts to isolate the performance problem were not fruitful. Tomorrow is another day... TBR=jam BUG=36310 TEST=none Review URL: http://codereview.chromium.org/654007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39710 0039d316-1c4b-4281-b951-d872f2087c98
* Improve example code for cancelable request -- pass consumer base class ↵joth@chromium.org2010-02-232-13/+14
| | | | | | | | | | | | | pointer in StartRequest as it is more general Make a small optimization: passing an iterator in CancelRequestLocked rather than Handle can avoid a call to map::find() BUG=none TEST=none Review URL: http://codereview.chromium.org/650143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39708 0039d316-1c4b-4281-b951-d872f2087c98
* Remove usages of obsolete WebSettings::setGeolocation so it can be removed ↵joth@chromium.org2010-02-232-4/+0
| | | | | | | | | | | from webkit BUG=https://bugs.webkit.org/show_bug.cgi?id=35242 TEST=none Review URL: http://codereview.chromium.org/650148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39707 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress calls to willEnter/didExitModalLoop to avoid deferring resource loadsdarin@chromium.org2010-02-231-0/+6
| | | | | | | | | | | | | | | while querying cookies. This is another attempt to isolate the Intl2 performance regression caused by r39327. TBR=jam BUG=36310 TEST=none Review URL: http://codereview.chromium.org/654002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39706 0039d316-1c4b-4281-b951-d872f2087c98
* Fix badge icon logic.chocobo@chromium.org2010-02-234-38/+72
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/652094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39705 0039d316-1c4b-4281-b951-d872f2087c98
* Move more files from chrome/common to chrome/browserphajdan.jr@chromium.org2010-02-2328-40/+41
| | | | | | | | | | to further reduce bad dependencies on chrome/browser. BUG=none TEST=none Review URL: http://codereview.chromium.org/652051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39703 0039d316-1c4b-4281-b951-d872f2087c98
* [Linux]Fix text justification of find bar.suzhe@chromium.org2010-02-233-2/+86
| | | | | | | | | BUG=34724 Text in omnibox and find bar is not right justified correct under RTL locale. TEST=Run chrome with LTR locale, the text in find bar should always be left justified, regardless of the text's direction. With RTL locale, the text should always be right justified. It matches the behavior of windows version. Review URL: http://codereview.chromium.org/652105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39702 0039d316-1c4b-4281-b951-d872f2087c98
* Make the translation bar not show up again when you closed it in a page jcampan@chromium.org2010-02-2310-42/+267
| | | | | | | | | | | | | | | | | | | | | | | and navigate in page. This is the case with web apps like GMail where many actions result in an in-page navigation. It would originally bring back the translation infobar, which is very anoying. This CL fixes the is_in_page state of LoadCommittedDetails, it was always false. This triggered a bug in the SSLManager that was wrongly not setting the SSL states when an in-page navigation is performed. Since we create a new navigation entry for in-page navigations, not setting these states would make a bad page being reported as OK after an in-page navigation. See original review: http://codereview.chromium.org/650146/show BUG=36304 TEST=Login to gmail, change the GMail language to a language different than the Chrome language. When a translate infobar shows up, close it. Click on the different links in GMail (inbox, drafts, select email...) the translate infobar should not show again. Review URL: http://codereview.chromium.org/650207 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39700 0039d316-1c4b-4281-b951-d872f2087c98
* Add MessageLoop::QuitNow and use it to terminate a sync IPC.darin@chromium.org2010-02-231-5/+1
| | | | | | | | | | | | | This is a test to observe the performance impact of this change. As such, I'm reverting r39518 as part of this change. R=jam BUG=36310 TEST=none Review URL: http://codereview.chromium.org/652089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39699 0039d316-1c4b-4281-b951-d872f2087c98
* Small preparation for the cookie confirmation dialog on linux/osx.thakis@chromium.org2010-02-235-24/+21
| | | | | | | | BUG=34894,35178 Review URL: http://codereview.chromium.org/650204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39696 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for crash on early return from browser_main.cccpu@chromium.org2010-02-234-4/+39
| | | | | | | | | | | | | | | | BrowserImpl dtor assumes full construction of all sub-objects, this is not true at least in one case (the try chrome again toast). See bug for more details - Added a UI test to detect these shenaningans in all platforms - had to hack ui_tests a bit, I hope is palatable BUG=34799 TEST= UI test included Review URL: http://codereview.chromium.org/571017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39690 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: adjust OTR spy spacing in titlebar.estade@chromium.org2010-02-231-9/+2
| | | | | | | | | BUG=36474 TEST=visual comparison with windows Review URL: http://codereview.chromium.org/650192 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39687 0039d316-1c4b-4281-b951-d872f2087c98
* Fix app shortcut mess up per issue 31789xiyuan@chromium.org2010-02-231-0/+8
| | | | | | | | | | | | | | | | | | Issue 31789 is caused by a longer than MAX_PATH chars web app description. Fix it by limiting the description string size to MAX_PATH. Note: 1. MSDN mentions that the size limitation for Win2000 or later is INFOTIPSIZE but the limit on my vista dev machine is MAX_PATH. <http://msdn.microsoft.com/en-us/library/bb774955(VS.85).aspx> 2. The size limit includes the terminating NULL. BUG=31789 TEST=Verify fix for issue 31789. facebook.com has a 261-char description and chromium should be able to create a working shortcut for it. Review URL: http://codereview.chromium.org/650186 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39686 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Only hide the menubar if the fullscreen window is on the main screen.rohitrao@chromium.org2010-02-232-11/+16
| | | | | | | | BUG=35973 TEST=Fullscreen a window on a non-main screen. Menubar should still be visible on the main screen. Review URL: http://codereview.chromium.org/650187 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39685 0039d316-1c4b-4281-b951-d872f2087c98
* Tie the lifetime of persisted transport-security metatdata to clearing cookies,cevans@chromium.org2010-02-232-7/+23
| | | | | | | | | | | | | | | | thus giving the user control over it. This involved adding in a "creation" date to the metadata so we can respect the user's choice of how far back to go when deleting browsing data. Care is taken to handle older metadata without the creation date set. Also fix a bug whereby we weren't making sure to persist the removed metadata when it expires. BUG=33445 TEST=TransportSecurityStateTest.DeleteSince, TransportSecurityStateTest.SerializeOld Review URL: http://codereview.chromium.org/652035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39684 0039d316-1c4b-4281-b951-d872f2087c98
* Archive and upload pyauto artifacts for Mac.nirnimesh@google.com2010-02-231-0/+2
| | | | | | | | | TEST=Should see _pyautolib.so & pyautolib.py in http://build.chromium.org/buildbot/continuous/mac/LATEST/chrome-mac.test/ BUG=36498 Review URL: http://codereview.chromium.org/652088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39683 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure bookmarks_drag_ is initialized to NULL to prevent crash.arv@chromium.org2010-02-231-0/+1
| | | | | | | | | | BUG=36473 TEST=None Review URL: http://codereview.chromium.org/652092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39682 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Change the vertical offsets in non-custom tab background images ↵erg@chromium.org2010-02-235-3/+41
| | | | | | | | | | | | | depending on how the window is configured. This fixes the vertical positioning of transparent tabs when no tab background image was specified. BUG=34815 TEST=none Review URL: http://codereview.chromium.org/650076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39681 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 39662 - Update various test scripts to use the upstream version ofdpranke@chromium.org2010-02-231-10/+8
| | | | | | | | | | | | | | | runchromiumwebkittests and rebaselinechromiumwebkittests BUG=23099 TBR=victorw TEST=bots don't explode Review URL: http://codereview.chromium.org/639001 TBR=dpranke@chromium.org Review URL: http://codereview.chromium.org/650189 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39678 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a bug where the "remove" and "remove all" buttons areian@chromium.org2010-02-231-2/+3
| | | | | | | | | | | enabled in the "Cookies" page even when there is nothing selected in the tree view. BUG=34886 TEST=open cookies view, see that remove and remove all are not enabled until you select something. Review URL: http://codereview.chromium.org/650173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39676 0039d316-1c4b-4281-b951-d872f2087c98
* Found repeated rlz.gyp ref in chrome.gypcpu@chromium.org2010-02-231-1/+0
| | | | | | | | | | | | | - Lets delete one of them. BUG=none TEST=none Review URL: http://codereview.chromium.org/650004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39674 0039d316-1c4b-4281-b951-d872f2087c98
* Do not send extra blur and focus events if popup menu is showingvictorw@chromium.org2010-02-223-3/+51
| | | | | | | | | | | | | | | | Add flag to RenderWidget to remember the popup menu state and suppress focus / blur events when popup menu is showing. This fixes the issue that extra focus / blur events are fired after select control is clicked. R=darin BUG=23499 TEST=none Review URL: http://codereview.chromium.org/647047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39670 0039d316-1c4b-4281-b951-d872f2087c98
* Add "deb" and "rpm" to dangerous extension list on linux.estade@chromium.org2010-02-221-0/+2
| | | | | | | | | BUG=31144 TEST=download a .deb or .rpm file, download shelf should warn Review URL: http://codereview.chromium.org/650165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39669 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: only throb twice when a bookmark is added to a bookmark bar folder.estade@chromium.org2010-02-223-8/+8
| | | | | | | | | | | TODO=to match windows better, throb continuously when bookmark bubble is open BUG=36450 TEST=see bug Review URL: http://codereview.chromium.org/652065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39667 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: record location of Chromium.app (or Google Chrome.app) bundle.viettrungluu@chromium.org2010-02-224-0/+82
| | | | | | | | | | | This will be needed by the app mode loader. BUG=13148 TEST=Run Chromium; do (from command line): "defaults read org.chromium.Chromium LastRunAppBundlePath" -- should get path to Chromium.app; move Chromium.app to another location and run it again; do "defaults ..." again -- should get path to Chromium.app at new location. Review URL: http://codereview.chromium.org/651061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39665 0039d316-1c4b-4281-b951-d872f2087c98
* Implement suggestions from Broc Seib:kathyw@chromium.org2010-02-2243-133/+130
| | | | | | | | | | | | | | | | | | | | | | | | | | | * Update the group URL in all pages * Move xhr.send() down in the xhr.html samples * Add a note to xhr.html about content scripts * Link to Arne's new example of cross-origin xhr for a content script Also update the chrome.* APIs page to point to the dev version of the experimental page. Only the following files have changes besides the group URL change: api_index.html xhr.html messaging.html (added links to examples) content_scripts.html (added link to new example) I'll merge this change into all branches. TBR=erikkay TEST=none BUG=none Review URL: http://codereview.chromium.org/650107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39664 0039d316-1c4b-4281-b951-d872f2087c98
* Update various test scripts to use the upstream version ofdpranke@chromium.org2010-02-221-8/+10
| | | | | | | | | | | | run-chromium-webkit-tests and rebaseline-chromium-webkit-tests BUG=23099 R=victorw TEST=bots don't explode Review URL: http://codereview.chromium.org/639001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39662 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fix a crash when switching to a fullscreen window after rearranging ↵rohitrao@chromium.org2010-02-221-1/+10
| | | | | | | | | | monitor positions. BUG=36467 TEST=See test case in bug. Should not crash. Review URL: http://codereview.chromium.org/652061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39660 0039d316-1c4b-4281-b951-d872f2087c98
* TBR=erikkaykathyw@chromium.org2010-02-226-1/+120
| | | | | | | | | TEST=none BUG=36211 Review URL: http://codereview.chromium.org/652077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39658 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 39642 - Update some windowsonly browser tests to run on all platforms.skerner@chromium.org2010-02-224-17/+9
| | | | | | | | | | | | TEST=Ran affected browser tests. BUG=None Review URL: http://codereview.chromium.org/618010 TBR=skerner@chromium.org Review URL: http://codereview.chromium.org/652084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39657 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where close other tabs would not show the correct enabledsky@chromium.org2010-02-221-2/+6
| | | | | | | | | | | state. BUG=none TEST=none Review URL: http://codereview.chromium.org/650147 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39653 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 11:38:49 +0000