| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL increases the memory consumption of the bloom filter used
by the SafeBrowsing system in order to decrease the number of false
positive gethash requests (gethash requests that result in an empty
or 204 response from the servers).
The filter size in bytes is calculated as:
number_of_add_prefixes * bits_per_prefix / 8
From analysis of our histograms, users have between 250k - 330k add
prefixes. 'bits_per_prefix' is hard coded to 25, which means that we
expect the typical bloom filter to be between 760-1000 kB, compared
to the current value of approximately 450 kB.
We add histograms to track the filter size, as well as the number of
gethash requests that return empty results and non-empty results.
BUG=10584 (http://crbug.com/10584)
Review URL: http://codereview.chromium.org/67243
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also fix a typo and an 80 col nit in its list of tests.
Review URL: http://codereview.chromium.org/79043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/69044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
tests.
BUG=10679
Review URL: http://codereview.chromium.org/79048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
mode. Ignore those commands if we do receive them.
BUG=8024
Review URL: http://codereview.chromium.org/79039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
warnings to the callsite.
Review URL: http://codereview.chromium.org/79028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
runs. I did not extend make_zip.sh because we may
add more options to make_chromebot_zip.sh and I want
to keep make_zip.sh simple. For now this script only
pack standard things. We could add options to pack
extensions later.
Review URL: http://codereview.chromium.org/78003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Accompanying buildbot changes @ http://codereview.chromium.org/67234
Review URL: http://codereview.chromium.org/79017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=jcampan
Review URL: http://codereview.chromium.org/67255
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to the link found.
We no longer use the selection controller to
highlight the active match. Before this change,
the focus would not be set if the user had changed
the selection. After this change, the focus will
be set unless the user has selected something on
the page.
I also wrote an in-browser unit test for this to
catch this regression in the future, but it is
disabled due to problem with running multiple
in-process browser tests in a row (teardown
problem).
BUG=10573
TEST=Covered by in process browser test now, see
bug for repro steps.
Review URL: http://codereview.chromium.org/79024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
and the NativeDialog.
Review URL: http://codereview.chromium.org/77034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the GdkPixbuf array and passing it into the constructor. This allows
us to remove some resource_bundle.h includes.
Clean up the style in gtk_chrome_button.cc. There was some C style
and moved the globals to just static pointers. I verified with
a debugger that we call gtk_chrome_button_class_init only once.
Review URL: http://codereview.chromium.org/69025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
escape spaces, so we have to do some manual fiddling to make searches that have come from the New Tab Page work (see GetHistoryURLWithSearchText).
BUG=9940
TEST=Verify that searches from the new tab page and from the history page result in the same search query appearing in the history results page.
Review URL: http://codereview.chromium.org/67249
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=9984
TEST=Open two history tabs, one inside an incognito window. Delete a day's history in each and observe that the changes are reflected in the other.
Review URL: http://codereview.chromium.org/67250
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/69037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/69022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=ananthak
Review URL: http://codereview.chromium.org/69035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=8431
Review URL: http://codereview.chromium.org/62097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/79026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=glen
Review URL: http://codereview.chromium.org/77015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TabContents are either pure virtual and implemented in WebContnets, or are
non-virtual. This makes it possible to merge the classes by a union operation.
Review URL: http://codereview.chromium.org/66057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/73002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This also includes work area change notifications, which only really apply to Windows (and not pure Widgets) anyway. Some parts (namely, the browser-specific things) are still in BrowserView.This allows me to fix the bug where unlocking your screen resized fullscreen mode windows incorrectly.There are probably one or two other small bits tangled in here -- this got a bit messy. I moved the exit bubble out of browser/ because it wasn't browser-specific; in theory, any WindowWin can now go into fullscreen mode.BUG=8159
Review URL: http://codereview.chromium.org/78002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
user the same name for both (ChromeHTML) Vista reports that http/https
are associated with Chrome as well as Chromium and each treats itself
as default browser.
Also do some cleanup - instead of trying to update only the Chrome open
cmd, go ahead and register the whole browser again (this doesn't change
user preferences).
BUG=9697
Review URL: http://codereview.chromium.org/67229
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
disabled; do not create plugins while plugin messages are being dropped.
Review URL: http://codereview.chromium.org/69021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
AutocompletePopupContentsView from AutocompletePopupViewContents too.
No other changes.
Review URL: http://codereview.chromium.org/79032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
[FATAL:at_exit.cc(40)] Check failed: false. Tried to RegisterCallback without an AtExitManager
in (possibly unused) binary perf_tests
Review URL: http://codereview.chromium.org/60103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
removes a call to Layout that should be removed now that we have RemoveTabAnimation.
Review URL: http://codereview.chromium.org/79029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
clipped by the containing popup's roundrect. No text yet, though they seem to actually work when clicked on.
This is not the final construction I'd like, but I'm checkpointing here before the changelist gets any bigger.
In the end, I'm thinking AutocompletePopupView will end up being implemented by the popup's contents view rather than the popup itself. I want to do this because the popup, the contents view and the individual result item views need access to the model and as it stands I need to wire model data methods all the way from the result view up to the popup which is annoying. But for now, I have some of that wiring. I'll do this adjustment after this one, since it requires creating some new files.
Review URL: http://codereview.chromium.org/79023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
removed in CL http://codereview.chromium.org/18550.The UI will be reworked in a CL immediately following review/submission of this code.Please contact Nick Baum for information regarding this change.
Review URL: http://codereview.chromium.org/66065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BrowsingInstances when we force a transition for DOM UIs.
BUG=9364
TEST=see bug
Review URL: http://codereview.chromium.org/67201
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
* Modify the tabstrip input handling to match the new interface.
Review URL: http://codereview.chromium.org/79025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
set the non client frame view.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/67236
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
properly, If window is not maxmized.
(http://crbug.com/5729).
The fix is to popup tabstrip context menu from the left of the click in RTL UI.
Without the fix, tabstrip context menu always popup from the right of the click.
Review URL: http://codereview.chromium.org/73021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ExtensionsService.
Also add "chrome-extension" to the list of schemes that BrowsingInstance
groups per-site, instead of per-tab. This means that navigating to an
extension URL will use the same process as a running extension toolstrip.
Review URL: http://codereview.chromium.org/77002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
1. Punch holes in Sandbox config to accomodate changes in the Font Server.
2. Add warmup for CGImageSourceGetStatus().
3. Misc cleanup for rendererMainPlatformDelegate::PlatformInitialize() function.
Review URL: http://codereview.chromium.org/67232
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
mind and not intercept after all. This allows the decision to start or not to start to be made asynchronously.2) Allow an interceptor to intercept on error conditions if the original job fails. This is to support the FALLBACK semantics in the appcache.Info about where this is going can be found in the appcache design doc at https://docs.google.com/a/google.com/Doc?docid=agv6ghfsqr_15f749cgt3&hl=enI still have to put together test cases, so I'm not ready to submit this yet, but wanted to get some feedback at this point.
Review URL: http://codereview.chromium.org/67019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/67186
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/79012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove calls to CoInitialize / CoUninitialize
- CoUninitialize sometimes causes the OS to try to load oleauth.dll
- An exception for in-process-plugins.
BUG=10589
Review URL: http://codereview.chromium.org/75028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
First step to have smoother audio playback. We previously
performed audio messages handling on render thread, which
gave us huge amount of latency, especially when renderer
is busy compositing or is blocked by synchronous IPC call.
A lot of these latencies are eliminated by moving audio
messages handling to IO thread, this is the first step to
see if sharing the regular IPC channel for audio messages
is creating too much stress for the IPC channel. Also
doubled the audio packet size to 8192 samples, ~194ms of
audio for 16bit/44.1khz/2ch.
Review URL: http://codereview.chromium.org/62125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
controller. Don't dead-strip un-referenced objective-C code in the unit_test target. Use the appropriate bundle when loading the tab nib. (take two, most of this was backed out earlier).
Review URL: http://codereview.chromium.org/77004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement BookmarkContextMenuGtk and hook it up to most bookmark bar elements.
Also:
- Fixes window dispositions (shift-click works on bookmark bar items).
- Reorganizes gtk_utils
Original Review URL: http://codereview.chromium.org/76002
Review URL: http://codereview.chromium.org/67223
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
more readable. I verified chromebot has no
problem parsing it.
Review URL: http://codereview.chromium.org/79003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/75008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
external tab has finished loading. Unfortunately we cannot
reuse AutomationMsg_InitialLoadsComplete because it has
overloaded meaning.
Review URL: http://codereview.chromium.org/69018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the same as how ResourceBundle owns the SkBitmaps it loads.
This should be faster than before because ResourceBundle will only
load each bitmap once and cache the image.
Also fix a memory leak in GdkPixbufFromSkBitmap.
valgrind says we're not leaking here.
BUG=9988
Review URL: http://codereview.chromium.org/67179
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Refactor a bunch of the Pango attributes code.
- Walk the classifications, and create the pango attributes for
the text foreground color and weight (bolding).
- Cache the GdkGC and PangoLayout across expose messages.
Review URL: http://codereview.chromium.org/75041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, I removed the GetWebFrame method on WebDataSource since it is not
actually needed.
Removed some dead-code from webframe_impl.cc.
Removed some bogus null-checking of WebCore::Frame::loader().
R=dglazkov
Review URL: http://codereview.chromium.org/67169
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/75022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13843 0039d316-1c4b-4281-b951-d872f2087c98
|