summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Add menu shortcuts on linux instead of & everywhere.tc@google.com2009-02-181-2/+28
| | | | | | | Review URL: http://codereview.chromium.org/21486 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9993 0039d316-1c4b-4281-b951-d872f2087c98
* Undo revert http://codereview.chromium.org/23028dkegel@google.com2009-02-182-20/+5
| | | | | | | | | | | | Changes since original http://codereview.chromium.org/16207 : - use Release rather than delete on reference counted objects - Preserve bool WaitToFinish(int milliseconds) and std::wstring GetDataDirectory() at Tommi's request, and add unit test for WaitToFinish(). Review URL: http://codereview.chromium.org/20444 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9992 0039d316-1c4b-4281-b951-d872f2087c98
* Renables the session restore ui tests in hopes of finding out why theysky@google.com2009-02-182-8/+6
| | | | | | | | | | | | are flakey. I'll watch the bot to see where they are failing after landing. Also fixes leaks in the tests I noticed when run under Purify. BUG=6495 TEST=none Review URL: http://codereview.chromium.org/20477 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9991 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress error dialog in automated UI test inhuanr@chromium.org2009-02-181-1/+8
| | | | | | | | | | headless mode. This is not done accross UI tests because automated UI only runs in ChromeBot. Review URL: http://codereview.chromium.org/20476 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9990 0039d316-1c4b-4281-b951-d872f2087c98
* Modifies setup to have all the supported languages available for the ↵gwilson@google.com2009-02-182-9/+124
| | | | | | | | in-application EULA dialog. Review URL: http://codereview.chromium.org/21437 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9989 0039d316-1c4b-4281-b951-d872f2087c98
* Fix save complete .html page.estade@chromium.org2009-02-181-11/+4
| | | | | | | | BUG=7616 Review URL: http://codereview.chromium.org/21482 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9988 0039d316-1c4b-4281-b951-d872f2087c98
* Prepare some files for porting:estade@chromium.org2009-02-1813-54/+58
| | | | | | | | | - Trade in some old wstrings for FilePaths. - Remove some unnecessary headers. Review URL: http://codereview.chromium.org/21466 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9986 0039d316-1c4b-4281-b951-d872f2087c98
* Try to land strings on linux again (r9972). This time, enabletc@google.com2009-02-186-9/+25
| | | | | | | | | | the resource bundle on linux unittests and make the unit_tests executable require the various .pak files. Review URL: http://codereview.chromium.org/20471 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9984 0039d316-1c4b-4281-b951-d872f2087c98
* Port back_forward_menu_model to linux.estade@chromium.org2009-02-1815-252/+629
| | | | | | | | | | | * Refactor BackForwardMenuModel. - Create platform-specific subclasses that implement menu delegate interfaces - Push almost all functionality into BackForwardMenuModel * Implement GTK back/forward dropdowns (in MenuGtk and BrowserToolbarViewGtk) Review URL: http://codereview.chromium.org/21440 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9983 0039d316-1c4b-4281-b951-d872f2087c98
* Fix two problems with bookmarking and fullscreen mode:pkasting@chromium.org2009-02-1815-50/+45
| | | | | | | | | | | * The bubble didn't close when toggling in/out of fullscreen mode. This was because we only ever closed on an activation change, rather than on a window move. Made the bubble close when the window moves. This required refactoring the bubble code to have a static instance; once I did that I also cleaned up the rest of the code a bit to not check if the bubble was already showing, and just let the bookmark bubble itself take care of this. * The bubble positioning was wrong in fullscreen mode. This was because the toolbar layout was in turn wrong in fullscreen mode. Made the toolbars able to handle being 0-height. BUG=534 TEST=Bookmark a page and hit F11. The bubble should disappear. Hit ctrl-D. The bubble should appear at the right spot, not floating in the middle of the screen. Hit F11 again. The bubble should disappear, and the toolbar button should be drawn undepressed. Review URL: http://codereview.chromium.org/21479 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9982 0039d316-1c4b-4281-b951-d872f2087c98
* Implement skeletal ProcessSingleton on Linux to cut down on NOTIMPLEMENTED()s.evan@chromium.org2009-02-185-15/+100
| | | | | | | | | | | We now will refuse to run a second browser process if one is already running; making the second invocation bring up new windows in the first remains left to be implemented. Review URL: http://codereview.chromium.org/20448 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9980 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "load strings and display them on linux" because linux unittests broke.tc@google.com2009-02-182-19/+6
| | | | | | | | | | | This reverts commit r9972. TBR=evan Review URL: http://codereview.chromium.org/21478 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9979 0039d316-1c4b-4281-b951-d872f2087c98
* Changes tab dragging code to continue iterating through windows ifsky@google.com2009-02-181-8/+27
| | | | | | | | | | | | | | window's rect contains the point but the window region doesn't. This is necessary as some apps create a window the size of the desktop and set a window region on it. Without this check we don't allow docking when these apps are running. BUG=6149 TEST=see bug Review URL: http://codereview.chromium.org/21476 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9974 0039d316-1c4b-4281-b951-d872f2087c98
* Fix window close and application quit on Mac to call the proper Browser ↵pinkerton@chromium.org2009-02-185-13/+54
| | | | | | | | machinery in the proper order. Add comments to BrowserWindow::Close to stress its assumptions. DCHECK that nobody adds a NULL browser to the browser list. Review URL: http://codereview.chromium.org/20460 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9973 0039d316-1c4b-4281-b951-d872f2087c98
* load strings and display them on linuxtc@google.com2009-02-182-6/+19
| | | | | | | Review URL: http://codereview.chromium.org/21465 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9972 0039d316-1c4b-4281-b951-d872f2087c98
* Make interstitial_page.cc compile on Posix.jhawkins@chromium.org2009-02-187-29/+32
| | | | | | Review URL: http://codereview.chromium.org/21467 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9971 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up toolbar layout code. I originally did this while looking into ↵pkasting@chromium.org2009-02-181-74/+50
| | | | | | | | bookmark bubble positioning issues. Review URL: http://codereview.chromium.org/20467 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9969 0039d316-1c4b-4281-b951-d872f2087c98
* Add the referrer value to the new NavigationEntry.paulg@google.com2009-02-181-0/+1
| | | | | | Review URL: http://codereview.chromium.org/21464 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9968 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes drag of images from new tab page. We need to pass in the mimesky@google.com2009-02-181-4/+6
| | | | | | | | | | | | | type, otherwise webkit isn't able to get the mime type and we try and drag an image with a bogus name. BUG=none TEST=drag a thumbnail from the new tab to explorer. You should end up with a file named foo.png. Review URL: http://codereview.chromium.org/21435 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9967 0039d316-1c4b-4281-b951-d872f2087c98
* The DOM Automation controller object uses the RenderView instance as the ↵ananta@chromium.org2009-02-184-18/+83
| | | | | | | | | | | | | | | | | | | | message sender, i.e. to send replies to javascript requests issued by the browser. The DOM automation controller object is bound to the frame in the WindowObjectcleared code path.The current implementation maintains the message sender object as a static pointer, which causes a crash if the RenderView instance goes out of scope. This can be reproduced with a page which causes a popup window to show up and close. If we attempt to use the Dom Automation controller instance bound to the original Renderview, which is still valid, we crash. The fix is to maintain the message sender as a member variable. The lifetime of the Dom Automation controller instance depends on the RenderView lifetime anyway as it is a member variable. This mimics the other CppBindings like the external host bindings, etc. Added an automation test to test this case. I verified that the test crashes without this fix. This fixes bug http://code.google.com/p/chromium/issues/detail?id=3941 Bug=3941 Review URL: http://codereview.chromium.org/21441 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9963 0039d316-1c4b-4281-b951-d872f2087c98
* Trivially port more unittests in chrome/phajdan.jr@chromium.org2009-02-181-4/+0
| | | | | | | | | | | | Added to the build: common/resource_dispatcher_unittest.cc renderer/net/render_dns_master_unittest.cc renderer/render_view_unittest.cc renderer/render_widget_unittest.cc Review URL: http://codereview.chromium.org/21461 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9961 0039d316-1c4b-4281-b951-d872f2087c98
* Dictionary-related Linux porting.phajdan.jr@chromium.org2009-02-185-21/+18
| | | | | | | | | | - build convert_dict tool - compile & pass hunspell tests - misc gcc cleanups Review URL: http://codereview.chromium.org/20462 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9960 0039d316-1c4b-4281-b951-d872f2087c98
* Build break. In revision 9958, I hadn't intented to commit this change.maruel@chromium.org2009-02-181-1/+1
| | | | | | Review URL: http://codereview.chromium.org/20466 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9959 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce the amount of included header files. Vast change like in "Oh God! ↵maruel@chromium.org2009-02-1853-225/+273
| | | | | | | | This revision changes half of the source files!". Review URL: http://codereview.chromium.org/20378 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9958 0039d316-1c4b-4281-b951-d872f2087c98
* Add locale_settings.grd to the build. This generatestc@google.com2009-02-1891-351/+296
| | | | | | | | | | | | a locale_settings.h file that we use on all platforms. However, the rc generation isn't correct yet, so for now, use the existing locale_settings_*.rc files. Also go ahead and generate the en-US locale pak on linux. Review URL: http://codereview.chromium.org/20447 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9956 0039d316-1c4b-4281-b951-d872f2087c98
* fix linux build, add stub functions to browser window gtktc@google.com2009-02-182-0/+11
| | | | | | | Review URL: http://codereview.chromium.org/21463 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9955 0039d316-1c4b-4281-b951-d872f2087c98
* Stub more Mac functions to fix another build breakpkasting@chromium.org2009-02-182-0/+11
| | | | | | | TBR=pinkerton Review URL: http://codereview.chromium.org/20463 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9954 0039d316-1c4b-4281-b951-d872f2087c98
* Solved 2 bugs which caused Chrome to maximize itself whendouble clicking, ↵idanan@chromium.org2009-02-1811-42/+72
| | | | | | | | either on the new tab button, on the closetab button or on a single tab.BUG=2827BUG=3787The problem comes from the Windows event sequence upon adouble-click (simplified here):1 - hit-test2 - mouse-down4 - mouse-up/click5 - hit-test6 - mouse down7 - mouse up/double-clickThe 1st hit-test is always performed correctly, returningclient for tabs and non-client for the tab-strip (background).The 2nd hit test is not performed correctly to avoid crashesin Chromebot from events being processed while tabs are animating.Since we have no record of these crashes, Ben prefers we keepthis special-case, even though we are responding incorrectlyto the windows hit-test. So, when the tabs are animating wereturn a HTNOWHERE hit which the caller translates into anHTCAPTION hit. This even though a tab-control (new-tab/close-tab)may have been hit.The problem is that having returned HTCAPTION to Windows defaultmessage handling, we get a NON-CLIENT double-click event insteadof a standard one.To keep the behavior of the second hit-test AND prevent theChrome window from maximizing, this change simply declaresthe non-client double-click as handled when the tabs areanimating.Another trick we pulled in the hit-test is to return HTCAPTIONwhen a single tab is present. This allows the entire window to be dragged but causes the context menu to be wrong and the windowto maximize when double clicking on the single tab.The solution here is to correct return a client hit for a singletab and, upon handling a client single-click, delegate to thenon-client single-click default handler. Review URL: http://codereview.chromium.org/21268 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9953 0039d316-1c4b-4281-b951-d872f2087c98
* Preliminary fullscreen mode support.pkasting@chromium.org2009-02-1811-39/+174
| | | | | | | | | There is no UI for this (yet), just F11 to toggle in and out. BUG=534 Review URL: http://codereview.chromium.org/20423 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9950 0039d316-1c4b-4281-b951-d872f2087c98
* bump for 165 dev cyclemal@chromium.org2009-02-181-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9949 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 9944.yurys@google.com2009-02-1822-928/+2
| | | | | | | This change broke ui, interactive and Vista Perf tests. I felt like reverting. Review URL: http://codereview.chromium.org/24020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9947 0039d316-1c4b-4281-b951-d872f2087c98
* Create communication channel between developer tools UI implemented in JS ↵yurys@google.com2009-02-1822-2/+928
| | | | | | | | | | | | | and residing in a process different from inspected page renderer process. There is no direct IPC channel between the two processes so all messages are routed through browser process. On the side of inspected page there is ToolsAgent existing in all renderers so that we can start inspecting the page at any moment by talking to this object. On the side of developer tools renderer there is ToolsClient which is created only for RenderView that host developer tools UI. This change is a slightly modified version of http://codereview.chromium.org/20221/show Review URL: http://codereview.chromium.org/20430 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9944 0039d316-1c4b-4281-b951-d872f2087c98
* Add IPC messages to send data between inspected page and developer tools.yurys@google.com2009-02-181-0/+30
| | | | | | | | | | | | Although there is no sematic changes I'd like to commit render_messages_internal.h changes in its own CL since trying to combine this change with other(even unrelated) changes lead to mysterious test failures on linux: http://build.chromium.org/buildbot/try-server/builders/linux/builds/2878 http://build.chromium.org/buildbot/try-server/builders/linux/builds/2877 http://build.chromium.org/buildbot/try-server/builders/linux/builds/2876 Review URL: http://codereview.chromium.org/21451 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9943 0039d316-1c4b-4281-b951-d872f2087c98
* Translation update.mal@chromium.org2009-02-1898-321/+533
| | | | | | | | | | | Update all .xtb files with current translations from the translation console. BUG= None TBR= tony TEST= Find 49 friends who each speak a different language ...nevermind. Review URL: http://codereview.chromium.org/20451 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9940 0039d316-1c4b-4281-b951-d872f2087c98
* Fix mac build. I ranjam@chromium.org2009-02-181-0/+2
| | | | | | | | | tools\xcodebodge\xcodebodge.py -p chrome\chrome.xcodeproj -t browser add_source chrome\common\child_process_info.cc and now the trybot builds. Review URL: http://codereview.chromium.org/21444 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9937 0039d316-1c4b-4281-b951-d872f2087c98
* Fix release build breakjam@chromium.org2009-02-181-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9936 0039d316-1c4b-4281-b951-d872f2087c98
* Take out common functionality from PluginProcessHost and move it to ↵jam@chromium.org2009-02-1814-256/+364
| | | | | | | | ChildProcessHost. Review URL: http://codereview.chromium.org/21443 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9935 0039d316-1c4b-4281-b951-d872f2087c98
* Get something in chrome/plugin/ compiling to make Scons happy.thestig@chromium.org2009-02-182-2/+5
| | | | | | Review URL: http://codereview.chromium.org/20449 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9934 0039d316-1c4b-4281-b951-d872f2087c98
* Don't pass out pointers that belong to other processes.tommi@chromium.org2009-02-181-7/+13
| | | | | | Review URL: http://codereview.chromium.org/20385 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9931 0039d316-1c4b-4281-b951-d872f2087c98
* Display the current URL and connect the entry widget to OpenURLFromTab().erg@google.com2009-02-183-8/+40
| | | | | | | | | This currently crashes when trying to load a new URL. (It looks like some housekeeping isn't being done in RenderWidgetHostViewGtk, the underlying widget isn't attached to any GTK window...) Review URL: http://codereview.chromium.org/21438 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9930 0039d316-1c4b-4281-b951-d872f2087c98
* Don't use relative path for net/url_request/url_request_test_job.thestig@chromium.org2009-02-181-2/+2
| | | | | | Review URL: http://codereview.chromium.org/20443 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9927 0039d316-1c4b-4281-b951-d872f2087c98
* Follow-up rename to my previous commit.evan@chromium.org2009-02-182-1/+1
| | | | | | | | | process_singleton.cc can just become process_singleton_win.cc since it's all Windows-specific. Review URL: http://codereview.chromium.org/20442 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9926 0039d316-1c4b-4281-b951-d872f2087c98
* HtmlDialogs had focus problems.jcampan@chromium.org2009-02-1818-16/+30
| | | | | | | | | | | | | | | | | | They would not be focused when shown and tab traversal was not working. This was caused by several issues: - HWNDView was not focusing its HWND when focused through the View::RequestFocus() method (it would rely on the default view behavior which is to focus the root view HWND), so it would not be focused by default. - DOMView (parent of HtmlDialogView) was not focusable so would not get the focus when pressing tab. - DOMView was not eating tab keys events (by returning false in View::CanProcessTabKeyEvents()), so the render view would not get the tab key press messages (for focus traversal in the render view). Note: most of the file changes in this CL are just the consequence of changing the constness of the WindowDelegate::GetInitiallyFocusedView method. BUG=6859 TEST=Open a web page, from the page menu, select the "Create application shortcut..." menu. In the dialog, press the TAB key, focus should alternate between the different fields Review URL: http://codereview.chromium.org/21439 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9925 0039d316-1c4b-4281-b951-d872f2087c98
* Add a couple functions missed in r9921 during conflict resolution.thestig@chromium.org2009-02-181-0/+9
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9924 0039d316-1c4b-4281-b951-d872f2087c98
* Rename MessageWindow to ProcessSingleton in anticipation of more refactoring.evan@chromium.org2009-02-186-40/+43
| | | | | | | Review URL: http://codereview.chromium.org/20437 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9923 0039d316-1c4b-4281-b951-d872f2087c98
* step 1 on getting strings in linux: create a locale_settings.grdtc@google.com2009-02-183-3/+285
| | | | | | | | | | | | | | | | | | based on locale_settings_en-US.rc. We don't use this anywhere yet, just putting things in place. - Fix preprocessor defines in grit vcproj files (needs to be defined everywhere) and update grit_localized_resources.rules to pass the preprocessor define to grit. - Add generated .h files to chrome_strings.vcproj so people can ctrl+alt+a open them. - Update GRIT so it knows how to substitute [GRITLANGCODE] in strings to the locale value. Review URL: http://codereview.chromium.org/20440 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9922 0039d316-1c4b-4281-b951-d872f2087c98
* Add more scaffolding to make shared linking work.thestig@chromium.org2009-02-182-5/+63
| | | | | | Review URL: http://codereview.chromium.org/21429 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9921 0039d316-1c4b-4281-b951-d872f2087c98
* Nukes PrefServiceUITest file deletion code in favor of DieFileDie,sky@google.com2009-02-181-10/+1
| | | | | | | | | | | which I suspect is causing purify ui test flakeyness. BUG=6557 TEST=none Review URL: http://codereview.chromium.org/20439 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9920 0039d316-1c4b-4281-b951-d872f2087c98
* Make gears_integration.cc compile on Posix. Change the GearsCreateShortcut ↵jhawkins@chromium.org2009-02-179-22/+32
| | | | | | | | callback to use GearsShortCutData2. Review URL: http://codereview.chromium.org/20412 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9918 0039d316-1c4b-4281-b951-d872f2087c98
* Check the file handle for NULL before using it to write. Under somebrettw@chromium.org2009-02-171-20/+15
| | | | | | | | | | | | | circumstances this might be NULL if we opened the file after initialization and it failed. In this case, we should just silently fail rather than throwing an invalid parameter exception. I'm not 100% sure this will fix the bug below, I did this by inspection. BUG=7566 Review URL: http://codereview.chromium.org/21425 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9917 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 11:42:22 +0000