summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Don't let a malicious web site open an unbounded number of constrained popups.darin@chromium.org2008-09-261-0/+7
| | | | | | | | | | Patch by abarth@chromium.org R=ben BUG=2632 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2654 0039d316-1c4b-4281-b951-d872f2087c98
* Roll the third_party/icu38 revision in DEPS to have SCons build libicu,sgk@google.com2008-09-2620-21/+21
| | | | | | | | | | not libicuuc. Add a new $ICU_LIBS construction variable to allow different platforms to link with different sets of ICU libraries. Use it in the LIBS lists of the various construction environments used to build the things that link with it. Review URL: http://codereview.chromium.org/4312 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2651 0039d316-1c4b-4281-b951-d872f2087c98
* Factor out a RenderThread interfacecpu@google.com2008-09-266-29/+212
| | | | | | | | | | | - RenderWidget was not unit testable as it was - Adding the first ever RederWidget unit tests It is possible to do more. Taking it step by step. Review URL: http://codereview.chromium.org/4271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2649 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug 455: Active match in Find is not selected and links are not focused ↵finnur@google.com2008-09-261-1/+1
| | | | | | | | after you close the Find box. Review URL: http://codereview.chromium.org/4283 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2645 0039d316-1c4b-4281-b951-d872f2087c98
* Make the link in the About box clickable (Issue 657)finnur@google.com2008-09-263-14/+39
| | | | | | | | The URL in the About box was added as a last minute string addition. I have now made it clickable. I also converted the TextField for the main label into a regular label, since there is no need to copy anything anylonger. Review URL: http://codereview.chromium.org/5013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2643 0039d316-1c4b-4281-b951-d872f2087c98
* Sync the function names. The unit tests overrode this function to prevent ↵brettw@google.com2008-09-261-1/+1
| | | | | | | | interactions with the UI. Review URL: http://codereview.chromium.org/5011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2641 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build bustage from my previous renaming.brettw@google.com2008-09-261-1/+1
| | | | | | Review URL: http://codereview.chromium.org/4307 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2640 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for a crash in the info bubble at first runcpu@google.com2008-09-261-3/+6
| | | | | | | | | | | - Null deref in GetDefaultSearchEngineName - This is a stopgap fix Issue = 2573 Review URL: http://codereview.chromium.org/4304 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2636 0039d316-1c4b-4281-b951-d872f2087c98
* Reorganize the declarations to have some grouping and logical ordering in ↵brettw@google.com2008-09-2620-1704/+1654
| | | | | | | | | tab contents and web contents. Reorder the derived classes overrides to match, and reorder the definitions of the functions to match the order in the header file. This doesn't actually change any code. I removed a few functions that were declared but never implemented (!) as well as some that were marked vitual but were never overridden. I renamed some things to make them more consistent. Review URL: http://codereview.chromium.org/5005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2634 0039d316-1c4b-4281-b951-d872f2087c98
* Change made based on comment in previous CL (that had already landed).jar@google.com2008-09-261-1/+1
| | | | | | | | | Add extra check on received dictionary status before saving it for use r=kmixter,openvcdiff Review URL: http://codereview.chromium.org/4285 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2633 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the ability to sort TableView. Contrary to what we spoke aboutsky@google.com2008-09-269-161/+978
| | | | | | | | | | | | | | | | | | | | | | | the other day I ended up doing the sorting in tableview. This makes it a heck of lot easier than having every model have to deal with it. As part of this I removed the optional non-caching logic from TableView, which was never used. Sadly though, this means there are coordinate transformations. I've only enabled sorting in the keyword editor, I have to make sure all the other places that use TableView can deal with it. For example, task manager can't deal with it currently as it expects the getters to be called only once where as when sorting they may be called multiple times. BUG=2790 TEST=This enables sorting ONLY in the keyword editor. Make sure there aren't any problems in adding/removing/changing entries in the keyword editor after this. Review URL: http://codereview.chromium.org/4276 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2631 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in importer where we could set the default search providersky@google.com2008-09-262-14/+50
| | | | | | | | | | | | | | | | | | to one that doesn't support replacement. Also changed uniquing to consider invalid OSDD urls. Need this to pick up Windows Live Search. I also changed the ff importer to return out early on if it couldn't find the value for the search provider. I encountered this do to hitting a NOTREACHED. BUG=1507 TEST=In IE set your default search to Live Search. Import from IE and make sure Chrome sets the default search to Live Search. Also make sure this didn't break keyword importing. Review URL: http://codereview.chromium.org/4281 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2630 0039d316-1c4b-4281-b951-d872f2087c98
* See if 'charset' is available in HTTP response header and use that to ↵jungshik@google.com2008-09-262-19/+24
| | | | | | | | | | | | | | | | | convert the response to UTF-8 before sending over to JSON deserializer. (previously this issue was tracked internally as issue 1293145) BUG=2806 TEST=In French Chrome, set your default search engine to Voila and begin to type a word with an accented letters and see if 'Search Voila for ' contains the word (it's not a bullet-proof test). In Korean chrome, set the default search engine to Daum and begin to type a Korean word (with Korean IME on, type 'qk'). Review URL: http://codereview.chromium.org/4287 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2623 0039d316-1c4b-4281-b951-d872f2087c98
* Add --js-flags to the list of flags accepted by UI tests.patrick@chromium.org2008-09-253-0/+16
| | | | | | Review URL: http://codereview.chromium.org/4290 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2616 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure that the request context is released when a URLFetcher is deleted.rvargas@google.com2008-09-252-222/+322
| | | | | | | | | BUG=b/1340170 TEST=unittest Review URL: http://codereview.chromium.org/4077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2615 0039d316-1c4b-4281-b951-d872f2087c98
* Move a bunch of stuff out of WebContents. I removed a bunch of render view ↵brettw@google.com2008-09-2518-382/+132
| | | | | | | | | host pass-throughs and just made the callers call the render view host directly. I don't think we're trying to isolate the layers to this degree, and WebContents is so big these just added noise. I removed the RenderViewHost->WebContents->SavePackage pass-through by using a delegate that the SavePackage implements (like we already do for find in page). I also noticed some file upload stuff wasn't used at all and removed it. Review URL: http://codereview.chromium.org/4088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2612 0039d316-1c4b-4281-b951-d872f2087c98
* Stop spamming delayed tasks on each input event.darin@chromium.org2008-09-253-28/+54
| | | | | | | | | R=mbelshe BUG=2693 Review URL: http://codereview.chromium.org/4262 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2609 0039d316-1c4b-4281-b951-d872f2087c98
* "Make Chrome your default browser" should now appear as a checkbox at the ↵finnur@google.com2008-09-2548-137/+162
| | | | | | | | | bottom of the First Run dialogs and be opt-out. Therefore I moved it from the FirstRunCustomizeView view to the FirstRunViewBase. I also moved the override function for GetDialogButtonLabel to the base class (since both dialogs should have the same label for the OK button) and aligned the "Import" label vertically to the "Import" combobox. Review URL: http://codereview.chromium.org/4244 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2605 0039d316-1c4b-4281-b951-d872f2087c98
* Remove DidNavigate from the tab contents delegate and all the related plumbing.brettw@google.com2008-09-249-140/+129
| | | | | | | | | | | I added additional information to the regular load commit notification so all interested parties can listen for that instead. I removed the old navigation type enum, and replaced it with the enum from the NavigationController, so it's now public. Review URL: http://codereview.chromium.org/3112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2573 0039d316-1c4b-4281-b951-d872f2087c98
* Add a command-line switch to change the user agent.BUG=757345pkasting@chromium.org2008-09-2410-32/+50
| | | | | | Review URL: http://codereview.chromium.org/4059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2571 0039d316-1c4b-4281-b951-d872f2087c98
* Disable 'suggest' for voila and orange (both use voila) because the result ↵jungshik@google.com2008-09-241-6/+14
| | | | | | | | | | | | | | | comes back in ISO-8859-1. Change the encoding for voila to ISO-8859-1. The front page of Voila.fr is in UTF-8 but the search result pages are in ISO-8859-1 and voila.fr expects a query to be in ISO-8859-1. BUG=2722 TEST=Set your default search engine to voila (in French Chrome) and type a keyword with accented letters. It should come back correctly in the search result page. Review URL: http://codereview.chromium.org/4068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2564 0039d316-1c4b-4281-b951-d872f2087c98
* Flatten the glue and port dependencies to accelerate build on a quad core.maruel@google.com2008-09-241-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Webcore has no custom build step so it can be bypassed. src\chrome>python tools\build\win\sln_deps.py chrome_kjs.sln glue Glue KJSBindings_prebuild KJSConfig localized_strings WebCore src\chrome>python tools\build\win\sln_deps.py chrome_kjs.sln port Port KJSBindings_prebuild KJSConfig WebCore To src\chrome>python tools\build\win\sln_deps.py chrome_kjs.sln glue Glue KJSBindings_prebuild KJSConfig libxml_config libxslt_config localized_strings src\chrome>python tools\build\win\sln_deps.py chrome_kjs.sln port Port KJSBindings_prebuild KJSConfig Review URL: http://codereview.chromium.org/4252 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2563 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disabling 2 SSL UI tests because they are flacky.jcampan@chromium.org2008-09-241-2/+4
| | | | | | | | BUG=2742 TBR=nsylvain Review URL: http://codereview.chromium.org/4256 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2560 0039d316-1c4b-4281-b951-d872f2087c98
* If a RenderWidgetHelper::PaintMsgProxy is deleted without being Run, then thedarin@chromium.org2008-09-242-3/+19
| | | | | | | | | | | | | | | | RenderWidgetHelper gets angry. This change allows the PaintMsgProxy to be deleted without being Run. This change is to support deleting all tasks that have made it into a MessageLoop without being Run. Currently, we leak those tasks, but I'd like to change that to allow us to avoid some hacks that exist to help Purify. R=brettw BUG=2734 Review URL: http://codereview.chromium.org/4251 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2558 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds new UI tests for the SSL UI.jcampan@chromium.org2008-09-2430-110/+940
| | | | | | | | | | | | | | | | | | | | Some more info: SSL UI Tests: Added new tests for redirects and frames. Also improved the mixed-content test to exercise the "block mixed-contents" preference and the show info-bar. Automation: For the new UI tests, added methods to tab_proxy and browser_proxy. The ones of most interest are GetLastNavigatinTime and WaitForNavigation that ensures we wait for a navigation to occur or have occured when taking actions that asynchronously trigger navigations. Resource loading: Added a flag to the response we get when loading a resource that indicates whether that resource was filtered (blocked or altered) by the security peer. We use this flag to notify back the browser when we report a load has been committed. This is so the SSL manager knows a frame has been filtered (in which case we have no cert info but should not consider that as unsafe). BUG=2004 Review URL: http://codereview.chromium.org/3165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2553 0039d316-1c4b-4281-b951-d872f2087c98
* Flatten the glue dependencies to accelerate build on a quad core. Webcore ↵maruel@google.com2008-09-241-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | has no custom build step so it can be bypassed. Glue localized_strings V8Bindings_prebuild V8Config WebCore WebCore libxml_config libxslt_config V8Bindings_prebuild V8Config To Glue libxml_config libxslt_config localized_strings V8Bindings_prebuild V8Config WebCore libxml_config libxslt_config V8Bindings_prebuild V8Config Review URL: http://codereview.chromium.org/4067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2551 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when a frame was inserted into a popup and navigated. I added abrettw@google.com2008-09-242-8/+48
| | | | | | | | | | | | test for this case. I also checked the other navigation cases to see if we were relying on state from the renderer (which might be malicious) and the controller being in sync, and I didn't see any others in this area. I clarified some comments so it should be more clearly correct. BUG=1279570 Review URL: http://codereview.chromium.org/4250 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2549 0039d316-1c4b-4281-b951-d872f2087c98
* Enforce Terminate on Heap Corruption in most of our executable on Windows XP ↵maruel@google.com2008-09-2412-3/+23
| | | | | | | | | | | SP3 or Vista. This won't submit the crash dump but it's still better than nothing. Fix broken alignment on test_shell_main.cc. Review URL: http://codereview.chromium.org/3105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2546 0039d316-1c4b-4281-b951-d872f2087c98
* Personalization pointer tweak.nick@chromium.org2008-09-242-11/+11
| | | | | | Review URL: http://codereview.chromium.org/4238 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2538 0039d316-1c4b-4281-b951-d872f2087c98
* Null out member so that it will be properly reset in StartLogging()jar@google.com2008-09-241-0/+1
| | | | | | | r=petersont Review URL: http://codereview.chromium.org/4242 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2536 0039d316-1c4b-4281-b951-d872f2087c98
* A crasher happens when restoring the focus as a result of switching tab, ↵jcampan@chromium.org2008-09-231-1/+5
| | | | | | | | | | | because the browser window does not have a focus manager. I am not sure how this could happen, this CL just bullet-proofs the code. BUG=1384044 Review URL: http://codereview.chromium.org/4054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2529 0039d316-1c4b-4281-b951-d872f2087c98
* Add an accessor to get the CPAPI main plugin thread's MessageLoop. Use thatmpcomplete@google.com2008-09-233-1/+12
| | | | | | | to fix a crash in renderer/chrome_plugin_host.cc. Review URL: http://codereview.chromium.org/4050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2528 0039d316-1c4b-4281-b951-d872f2087c98
* Try to re-land issue 3200cpu@google.com2008-09-231-7/+13
| | | | | | | | | - it was causing trouble in the distributed tests - now does not try to load the dll in headless configs Review URL: http://codereview.chromium.org/4233 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2520 0039d316-1c4b-4281-b951-d872f2087c98
* Removing the check for creation time on favorites when importing with IE.jcampan@chromium.org2008-09-232-18/+1
| | | | | | | | We were comparing the creation date of the favorite with the profile dir creation date, and ignoring the favorite if they were created around the same time (in an effort to get rid of IE defaults favorites). This was causing problems as some users seem to import their profile and have profile dir and favorites created at the same time. Review URL: http://codereview.chromium.org/4207 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2518 0039d316-1c4b-4281-b951-d872f2087c98
* This CL enables the Page info menu when right-clicking on a page/frame.jcampan@chromium.org2008-09-237-41/+118
| | | | | | | | | | For the frame case, the SSL info had to be added to the show menu message (as the navigation entry contains the top frame SSL info). BUG=2467 TEST=Open a page over HTTPS with multiple frames. Right-click and select shot page info. Review URL: http://codereview.chromium.org/4034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2504 0039d316-1c4b-4281-b951-d872f2087c98
* Update chromium strings.tc@google.com2008-09-235-8/+8
| | | | | | | TBR=mal Review URL: http://codereview.chromium.org/4228 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2503 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bottom right resize corner flicker during size.joshia@google.com2008-09-232-0/+6
| | | | | | | | | | | | | Handle WM_NCPAINT and handle it (do nothing) instead of passing it down to DefWindowProc. B=2577 TEST=resizing window using botom right corner and watch for any odd GUI effects. Review URL: http://codereview.chromium.org/3192 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2501 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for windowed painting regression.jam@chromium.org2008-09-231-3/+3
| | | | | | Review URL: http://codereview.chromium.org/4221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2499 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crasher that occurs when using keyboard to navigate focus andsky@google.com2008-09-231-0/+4
| | | | | | | | | | | enter triggers a focus change. BUG=2554 TEST=see bug Review URL: http://codereview.chromium.org/4014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2487 0039d316-1c4b-4281-b951-d872f2087c98
* Remove io.h from google.patch and fix EOLs. Lack of EOLs is a fatal error ↵deanm@google.com2008-09-233-20/+2
| | | | | | on GCC. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2486 0039d316-1c4b-4281-b951-d872f2087c98
* Build hunspell on Linux.deanm@google.com2008-09-234-11/+22
| | | | | | Patch from Pawel Hajdan Jr. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2483 0039d316-1c4b-4281-b951-d872f2087c98
* Roll the icu38 revision in the DEPS file to change the name ofsgk@google.com2008-09-232-2/+2
| | | | | | | | | our combined-build icuuc.lib to icu.lib. Change solution file references accordingly. Also change libxml patch and Makefile references Review URL: http://codereview.chromium.org/4027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2480 0039d316-1c4b-4281-b951-d872f2087c98
* Bump the version for the next dev cycle.mal@chromium.org2008-09-231-2/+2
| | | | | | | | | | | Since we're already working toward 0.3 as the next Beta update, I bumped the minor to 0.3. R= nsylvain@chromium.org Review URL: http://codereview.chromium.org/4204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2476 0039d316-1c4b-4281-b951-d872f2087c98
* Once again for a mysterious reason all sites are crashing in nsylvain@chromium.org2008-09-231-7/+3
| | | | | | | | | | | | the distributed test at this location: chrome_23e0000!v8::internal::Builtins::Setup+0x2bb Revert this change because it seems to be the culprit. Review URL: http://codereview.chromium.org/4206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2475 0039d316-1c4b-4281-b951-d872f2087c98
* Issue 2509: Duplicate tab should not create a new window.finnur@google.com2008-09-233-29/+34
| | | | | | Review URL: http://codereview.chromium.org/3147 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2474 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land SDCH filter support experimentjar@google.com2008-09-238-0/+183
| | | | | | | | | | | Fix up solution files for webkit and net Add one line keyword change to help linux build r=hunanr,openvcdiff,nsylvain Review URL: http://codereview.chromium.org/4026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2469 0039d316-1c4b-4281-b951-d872f2087c98
* Load RLZ in 20 seconds instead of 100 seconds.cpu@google.com2008-09-231-3/+7
| | | | | | | | | | | | | | | - And have a way to set the initial events even if chrome was shut down before it was able to initialize and thus we have an empty rlz. Apparently a sizeable % of our users have an empty rlz string and it looks like this can be the cause. BUG= 1372961 Review URL: http://codereview.chromium.org/3200 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2467 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r2253 to turn off magic_browzR by default and restore themal@chromium.org2008-09-232-7/+1
| | | | | | | | | --magic_browzR command line switch. R= ben@chromium.org Review URL: http://codereview.chromium.org/4031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2465 0039d316-1c4b-4281-b951-d872f2087c98
* Disable tests while I investigatejam@chromium.org2008-09-231-2/+2
| | | | | | | TBR=nsylvain Review URL: http://codereview.chromium.org/4202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2464 0039d316-1c4b-4281-b951-d872f2087c98
* Desynchronize windowless plugin painting. This greatly improves the paintingjam@chromium.org2008-09-228-325/+260
| | | | | | | | performance when there are multiple plugins, or when scrolling. Review URL: http://codereview.chromium.org/3133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2459 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-08 07:33:02 +0000